From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74F2CC00144 for ; Fri, 29 Jul 2022 14:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DVPABJRUx8/NMR6cGswzQHacpTvY697PrfBDn+oExKM=; b=T1ls6ak496qutE kaRi9wis9tqdU/A46WTrKNBgmODmcC4qojCOQj3mTupn+2o3jDlrSSE5JeL51sZGuSLLLDE0iTJ8C tt/3uzJ0Z0r5EPg6w1DQz4bb2rdfMhIE7qwgDK9dg5qcL7Nmew5nXaVQCP+yMXfauy3ZH2+3nAcpd HOP/S1VPRyjxS6X46c+He4CR2dLrtXRnAPsd/szSQ8EjTktah3j9KBhH+xYsyS9jwdEhJNIHg0UIz /XkgzoP9VD6GdZEjzK3DIsQpUFDTr5QjQzMZ7fmgkMuHP4zgS0wuh0EdeqbKSq9oazpJowHhh7/uh RR3zNpq1/31lLi3sRP3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHQui-005ULi-M7; Fri, 29 Jul 2022 14:24:28 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHQuf-005UK3-F1 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jul 2022 14:24:27 +0000 Received: by mail-wm1-x334.google.com with SMTP id w8-20020a05600c014800b003a32e89bc4eso2568585wmm.5 for ; Fri, 29 Jul 2022 07:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LypYebNOHjfta90jCiEF7l4jJITyPo34Kh+cxFf5b7k=; b=o/VoIs1FYnbSYgcdN1Mey6VbgelHyJu1ATCEWwD53mdKhrXpjQui5rDM7ZZlXtE+fS MUVqTmYxWlsowO+bpTuzy/oVsaembdjMiLzApJgcq5dArVqtptZevLreiKLD8CgRs3kr MvGq1W04Uy8IEEITpzUTp2vB2QhQnKKJbVTNG/vMkIIndei2g1G9H7zRpNz4iiHkULmI aLRqDypMhjfFvunZDaLYNnqjmaQ2WYJwoTKglmL55DegwMx48k5zXYGUUqM2NuAYGUGM qrHPV7ks4LLs2lJBqSSgv7wmY90Cr7frvWqbTwKpyYEZDWXTz9+9QBM7I40bXPwPR1Na 1OBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LypYebNOHjfta90jCiEF7l4jJITyPo34Kh+cxFf5b7k=; b=eL3c1DRaE1P84uGnjkPUmOBzTfzptVRdfBzmgPoWxzosPSYwbSFQLVKWymY9kQk/Lb gEzTOfKvBEZ3rTF5puZ4hYI1tdOYBKLfievCZxdalqGJVNO1+x8at3l3vpXqQaqh1dBU E/hoEdX3smCIiG2u1UMuV8fDNqdeJMgUH5gudt/8iPufdKyk4+WqoW7tnv/sbLRZzzZw +a8yjaZf7JgslyLKz9GTvXx0R89zhkO1ZRKUFYBZWgyQdCFb3ZaJ8aLKgEcdvXviKYE3 YObMehz0cHoYu5UGVZyo/GhKmL2Sog9f+veK/3kCm6C2Wffayti67xaWjHNGqib2IoaW FhIw== X-Gm-Message-State: AJIora+eUDW/wJsCdgGUdxZuv6oQZ8YykxkXsbOQ7rfT3SpYBwEkFwcT zFd1fbiGgCjW6DlHVJGsISajDvJFlpkIPHMyW/ZIBQ== X-Google-Smtp-Source: AGRyM1vcvoixpQIqXoSvh3g/D9PPji8zVRLepMsp2jSLV0A+j/g1kK1tqIHam+9nDFHK6ZhaYv+FN2GWeQvomzERy5c= X-Received: by 2002:a05:600c:19d2:b0:3a3:2cdb:cc02 with SMTP id u18-20020a05600c19d200b003a32cdbcc02mr3018045wmq.182.1659104663337; Fri, 29 Jul 2022 07:24:23 -0700 (PDT) MIME-Version: 1.0 References: <20220729074351.138260-1-irogers@google.com> <20220729074351.138260-6-irogers@google.com> <393770c6-8469-a5b5-5106-a98420bb6e00@huawei.com> In-Reply-To: <393770c6-8469-a5b5-5106-a98420bb6e00@huawei.com> From: Ian Rogers Date: Fri, 29 Jul 2022 07:24:10 -0700 Message-ID: Subject: Re: [PATCH v3 05/17] perf jevents: Remove the type/version variables To: John Garry Cc: Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_072425_525291_84DEA606 X-CRM114-Status: GOOD ( 26.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 29, 2022 at 1:30 AM John Garry wrote: > > On 29/07/2022 08:43, Ian Rogers wrote: > > pmu_events_map has a type variable that is always initialized to "core" > > and a version variable that is never read. Remove these from the API as > > it is straightforward to add them back when necessary. > > > > Signed-off-by: Ian Rogers > > Reviewed-by: John Garry > > Please note the questions, below. > > > --- > > tools/perf/pmu-events/empty-pmu-events.c | 6 ++---- > > tools/perf/pmu-events/jevents.py | 6 ------ > > tools/perf/pmu-events/pmu-events.h | 2 -- > > tools/perf/tests/expand-cgroup.c | 2 -- > > tools/perf/tests/parse-metric.c | 2 -- > > 5 files changed, 2 insertions(+), 16 deletions(-) > > > > diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-events/empty-pmu-events.c > > index 77e655c6f116..4182a986f505 100644 > > --- a/tools/perf/pmu-events/empty-pmu-events.c > > +++ b/tools/perf/pmu-events/empty-pmu-events.c > > @@ -110,15 +110,13 @@ static const struct pmu_event pme_test_soc_cpu[] = { > > > > const struct pmu_events_map pmu_events_map[] = { > > { > > + .arch = "testarch", > > Is this really supposed to be part of this patch? Agreed. Looks like it should have been in the previous. Thanks, Ian > > .cpuid = "testcpu", > > - .version = "v1", > > - .type = "core", > > .table = pme_test_soc_cpu, > > }, > > { > > + .arch = 0, > > Same as above > > > .cpuid = 0, > > - .version = 0, > > - .type = 0, > > .table = 0, > > }, > > }; > > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py > > index e6e6c42c3f8a..98d18d5c3830 100755 > > --- a/tools/perf/pmu-events/jevents.py > > +++ b/tools/perf/pmu-events/jevents.py > > @@ -312,8 +312,6 @@ def print_mapping_table(archs: Sequence[str]) -> None: > > _args.output_file.write("""{ > > \t.arch = "testarch", > > \t.cpuid = "testcpu", > > -\t.version = "v1", > > -\t.type = "core", > > \t.table = pme_test_soc_cpu, > > }, > > """) > > @@ -329,8 +327,6 @@ def print_mapping_table(archs: Sequence[str]) -> None: > > _args.output_file.write(f"""{{ > > \t.arch = "{arch}", > > \t.cpuid = "{cpuid}", > > -\t.version = "{row[1]}", > > -\t.type = "{row[3]}", > > \t.table = {tblname} > > }}, > > """) > > @@ -339,8 +335,6 @@ def print_mapping_table(archs: Sequence[str]) -> None: > > _args.output_file.write("""{ > > \t.arch = 0, > > \t.cpuid = 0, > > -\t.version = 0, > > -\t.type = 0, > > \t.table = 0, > > } > > }; > > diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h > > index 7a360792635f..a491b117c8ac 100644 > > --- a/tools/perf/pmu-events/pmu-events.h > > +++ b/tools/perf/pmu-events/pmu-events.h > > @@ -40,8 +40,6 @@ struct pmu_event { > > struct pmu_events_map { > > const char *arch; > > const char *cpuid; > > - const char *version; > > - const char *type; /* core, uncore etc */ > > const struct pmu_event *table; > > }; > > > > diff --git a/tools/perf/tests/expand-cgroup.c b/tools/perf/tests/expand-cgroup.c > > index dfefe5b60eb2..dc4038f997d7 100644 > > --- a/tools/perf/tests/expand-cgroup.c > > +++ b/tools/perf/tests/expand-cgroup.c > > @@ -197,8 +197,6 @@ static int expand_metric_events(void) > > }; > > const struct pmu_events_map ev_map = { > > .cpuid = "test", > > - .version = "1", > > - .type = "core", > > .table = pme_test, > > }; > > > > diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c > > index 07b6f4ec024f..1b811a26f4ee 100644 > > --- a/tools/perf/tests/parse-metric.c > > +++ b/tools/perf/tests/parse-metric.c > > @@ -81,8 +81,6 @@ static struct pmu_event pme_test[] = { > > > > static const struct pmu_events_map map = { > > .cpuid = "test", > > - .version = "1", > > - .type = "core", > > .table = pme_test, > > }; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel