From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB70FC49ED9 for ; Thu, 12 Sep 2019 09:47:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8017120CC7 for ; Thu, 12 Sep 2019 09:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eJ033u+N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hWMSgmlL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8017120CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ir6VIcQvljhTwmcjCtQ0SBngxlhSQevHEaEV/iB1BIo=; b=eJ033u+NwXb6RL 5vp0H8fPEUgUc3ex77Jb5ojo+Us29LfZuJCkC66B4rkP0Ui5sIpEB79GcVcVCgekCjNzYi4le001U Y9q2ZEiKnpccQ03ffgZ1ELi+RxRp8YVG951jkbN7zGSzui7CEICuxdNl8CqGmmJcUIurgnmnBLd8/ I4Y4SZzxjatpIdzcO1Dm0xaFk8tZm1Efs+Eh2Z0uS0KJQAHa8CZY5bT8AjnvwDw2OA48H4Hv0n79p WeJ6b+3b3jbds+TkyUyJ/gM5bO17uNXHhKHnXvEntrQFniNSENbsCHRJpqMfbfWJqqS7BWZXYoM38 wSmMMUBYkiEICBlrmxww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8LhO-0004jv-5Z; Thu, 12 Sep 2019 09:47:34 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8LhK-0004iW-UE for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2019 09:47:32 +0000 Received: by mail-qk1-x744.google.com with SMTP id f13so23799044qkm.9 for ; Thu, 12 Sep 2019 02:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=njDtF8upkA6+NaauiLZUsAxJubAF9fG83zymry8vAaU=; b=hWMSgmlLtCEWRX/MHXkshsdVSzIZAXdwroHnFWd1J+Pi/zDbGAZcyCfZPRTWouMTs3 HjdnM7SbArudL+LwJw9WXwtNhkxNJ3vPlJTBXwcwK+HnfsDPaTouep35wtRSaBTUpjrI 9emk8DOaWZePVDjguyhCt/ZL5d6Jbv6RqoCnfcdaExjJj3B1O2Clo5CXX+ScgLcmxCOf 9/ugnWmvMifS7Z+DvKaoS9sgQ0er8SxLA0lyfPk5VTk9hpa5RR1ZuoDNDMMCWrBadl7y 3s3xpnuk7FYIRnmUpF5Mf7/DQ3YY1oZ0lqDWccoUZ59bcKSlG6yXZueBxl49+QYWgfcz G4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=njDtF8upkA6+NaauiLZUsAxJubAF9fG83zymry8vAaU=; b=guqP20O8PqO/IfLkvzaWucpknRGvfAlrolh9K0X3D/ly5IW1mmohTex6K+ptgZ+Dve WXMbOHExf7yGSL7lT1YtjxVlfB5FG+RgH7YqjORCttSDSIkbAtLd+whiIvTIsAKDrOa3 tODaDj1wOfsL7l3zbAempCHYTvBClv/JSOokzIwlCb3HPF00DNd9QSnZjb2WSaS4ivp5 F837nnnV0mXJIKL1pJ8R6bF4shpavqTMP/rFm94hl1GlS2+LwKGYBn7fbfbbvfnatk0F GtOXod3empnqq01eAtRTVB6R0TgToqUmwHFYwAQDLRYqfKNS1vYbWxVfoFUGibX7UuDi Ublw== X-Gm-Message-State: APjAAAX5LTum/wMaIUNHnytdBy+AX5pGP3qMSGRkr5f0BmDap92rSD4X kPl8ziTi1+yX2wS02EjyUj0IUItGvwxo+MJ3unqvEVvLU8s= X-Google-Smtp-Source: APXvYqz/1oDNL1ZZfCatdlik6ssSKqxLf+19ecAGHXvhEDBbY9mBKtVG6u/Wq02n39I2GGkc6GmOYewOwwhK8D9OZR8= X-Received: by 2002:a37:6d2:: with SMTP id 201mr39608673qkg.106.1568281649476; Thu, 12 Sep 2019 02:47:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kucheria Date: Thu, 12 Sep 2019 15:17:18 +0530 Message-ID: Subject: Re: [PATCH 0/4] Cleanup arm64 driver dependencies To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_024730_975131_66978590 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Liam Girdwood , Stephen Boyd , Catalin Marinas , Linus Walleij , Linux PM list , linux-clk , "linux-kernel@vger.kernel.org" , linux-pci , Kishon Vijay Abraham I , Bartosz Golaszewski , arm-soc , Mark Brown , "open list:GPIO SUBSYSTEM" , Sebastian Reichel , Will Deacon , Michael Turquette , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Thu, Sep 12, 2019 at 2:59 PM Arnd Bergmann wrote: > > On Thu, Sep 12, 2019 at 12:18 AM Amit Kucheria wrote: > > > > I was using initcall_debugging on a QCOM platform and ran across a bunch of > > driver initcalls that are enabled even if their SoC support is disabled. > > > > Here are some fixups for a subset of them. > > The idea seems reasonable, disabling a platform may just turn off > all the drivers that are not useful elsewhere, but there are mistakes > in a lot of your changes, so I'm certainly not applying these for 5.4. OK, thanks for confirming that you have no objections to such changes, per-se. I'll spend some more time ensuring COMPILE_TEST coverage for these cleanups. I only focused on quickly cleaning up my initcall_debug output for now. > Generally speaking, the way that works best is > > config SUBSYS_DRIVER_FOO > tristate "SUBSYS support for FOO platform" > depends on ARCH_FOO || COMPILE_TEST > depends on SUBSYS > default "m" if ARCH_FOO > > This means it's enabled as a loadable module by default (use > default "y" instead where necessary) as long as the platform > is enabled, but an x86 allmodconfig build also includes it > because of COMPILE_TEST, while any configuration without > ARCH_FOO that is not compile-testing cannot enable it. How would you like to handle defconfigs which list a driver explicitly? Should we add ARCH_FOO to those defconfigs or remove DRIVER_FOO from them? Regards, Amit _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel