From: Amit Kucheria <amit.kucheria@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
soc@kernel.org, arm-soc <arm@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Lists LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: Fix leftover entry-methods for PSCI
Date: Sun, 22 Mar 2020 17:19:42 +0530 [thread overview]
Message-ID: <CAP245DXiU9XUwP-h1CAnORG=a+NAOcZiY7RvkOsgRQSAhSGG4Q@mail.gmail.com> (raw)
In-Reply-To: <20200322112437.18070-1-linus.walleij@linaro.org>
On Sun, Mar 22, 2020 at 4:55 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> These two device trees were either missed or added after
> the commit correcting the "entry-method" from
> "arm,psci" to just "psci" as per the binding.
My patch went in, in 4.18.
The FSL entry went in, in 4.20 and the spreadtrum one in 5.5.
> Fixes: commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation")
So only minor comment is that it isn't really a fix. We've tried
improving the text in the binding too but somehow people still get
confused. Converting the binding to YAML and enforcing it seems to be
the only course of action left now.
Otherwise,
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> Cc: Amit Kucheria <amit.kucheria@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Chunyan Zhang <chunyan.zhang@unisoc.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: if this is fine just apply it to the
> tree where appropriate please.
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> arch/arm64/boot/dts/sprd/sc9863a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 0bf375ec959b..55b71bb4baf8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -53,7 +53,7 @@
> * PSCI node is not added default, U-boot will add missing
> * parts if it determines to use PSCI.
> */
> - entry-method = "arm,psci";
> + entry-method = "psci";
>
> CPU_PW20: cpu-pw20 {
> compatible = "arm,idle-state";
> diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
> index cd80756c888d..2c590ca1d079 100644
> --- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi
> +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
> @@ -108,7 +108,7 @@
> };
>
> idle-states {
> - entry-method = "arm,psci";
> + entry-method = "psci";
> CORE_PD: core-pd {
> compatible = "arm,idle-state";
> entry-latency-us = <4000>;
> --
> 2.21.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-22 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 11:24 [PATCH] arm64: dts: Fix leftover entry-methods for PSCI Linus Walleij
2020-03-22 11:49 ` Amit Kucheria [this message]
2020-03-22 11:56 ` Linus Walleij
2020-03-24 5:55 ` Amit Kucheria
2020-03-27 21:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP245DXiU9XUwP-h1CAnORG=a+NAOcZiY7RvkOsgRQSAhSGG4Q@mail.gmail.com' \
--to=amit.kucheria@linaro.org \
--cc=arm@kernel.org \
--cc=chunyan.zhang@unisoc.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).