From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85600C3A5A4 for ; Fri, 30 Aug 2019 09:56:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 472482173E for ; Fri, 30 Aug 2019 09:56:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vr0ndgLw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EoqZX1Vs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 472482173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FSbcOLum94t1PvBRAUO3on4tyHO/zcMvenoerp18Wb0=; b=Vr0ndgLwsODQhz u2/r7yEAeFl+EvWKOiXs6/BZ333sLqTHpZMz/dmR0QW2H9kmLvLQLe44Zv2SmQFquQLgkCvqEEmdZ p+lQkqnRSmCO+jRibBTgZdV/JQTLaoU9n/wjZnLdr+KXSJNDUDbga+kWvTKEXcUNetV2TZ04ZdBi6 V8ARQE6vA67DmhnRSJOpdkgIUXjrBhadFIN9UfqITjR5Q7Y0n3krfyik6f6JuX6+9gbKmWH7xl75a EOoHTBVc0BcIBKMGxRRw4MRRDwMdnXtsZ6Q1JEYfZr2yUZ1tDSIqpuhaO8dTkXZ/2dpTr93yVv9Oe LTyjE0G6PtqUjvTLP8FA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3ddv-0002YU-GP; Fri, 30 Aug 2019 09:56:31 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3ddr-0002YB-T0 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2019 09:56:29 +0000 Received: by mail-oi1-x242.google.com with SMTP id y8so4888303oih.10 for ; Fri, 30 Aug 2019 02:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=opPJo7Zv4ht/hnWpVSpz0d5Vp3/hOswmpsE3zretzJE=; b=EoqZX1Vsy9Szxp+b2Sg//tUs6kcL4ZoTGUwdLa+NeVeQfQf7IVynklZrNliG7NbW3c BqTTvlkqs6KgPDc2/MsnL7jzP3HCSBgEPj3iAcwf3MaoLg8C9MgHhZhnJloMTNHx7gHf ehsnc475CaxsOCW2n9iAALHDplUCtX23vexks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=opPJo7Zv4ht/hnWpVSpz0d5Vp3/hOswmpsE3zretzJE=; b=cA7JbnsKA2JEGaL5Pgw83eAoXvOJ6IA5P9yDWMpCmwv1GjLreC7YxA+oAFBYhIShPT RRJ9wE7lbAj1DKK8LjruWx/DHcHSlSh/3FHrleCsPBakFtXFuHQkPfFHUkNmsDSjyU4r lzE7lAJPqHHIRexefEjqV8EA3CD6wgUuNOWvpLD64o629/BnTBf11KLdjfU40Bt0XDWe FZzj+7RcfIs5+dffo0fRioH+Dvm0MWTCTN1ELg28RtqgA8NGLHaya+eJCgBXSH7crQQl r5Z6bl9jPZccFK1YDAoo3JSfPCCS/j4EVa+arjMlVjqNbSEOy/2daz8dgogXhEUyHahB cSfw== X-Gm-Message-State: APjAAAWT4WFzqA0cDPOW5RV4QeRWtN8HtJA8g1zVdhhZqD4nFLmO4uzO 0Nr8/IY2rD9/dtud5PjxUK7tgZONj8k= X-Google-Smtp-Source: APXvYqyc06G1MqdxZNGXo7WgeUFe18JrALeT37WtgkrIfCW7bQz51ojKkn6OTytpLkBepisKAidBsg== X-Received: by 2002:aca:6701:: with SMTP id z1mr9057742oix.164.1567158985928; Fri, 30 Aug 2019 02:56:25 -0700 (PDT) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id f197sm1733464oib.20.2019.08.30.02.56.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2019 02:56:25 -0700 (PDT) Received: by mail-ot1-f50.google.com with SMTP id 100so6418435otn.2 for ; Fri, 30 Aug 2019 02:56:25 -0700 (PDT) X-Received: by 2002:a9d:4817:: with SMTP id c23mr10736054otf.97.1567158529318; Fri, 30 Aug 2019 02:48:49 -0700 (PDT) MIME-Version: 1.0 References: <20190822194500.2071-1-jernej.skrabec@siol.net> <20190822194500.2071-3-jernej.skrabec@siol.net> <907f3c43-b994-f1c7-a15b-116566e19003@xs4all.nl> In-Reply-To: <907f3c43-b994-f1c7-a15b-116566e19003@xs4all.nl> From: Alexandre Courbot Date: Fri, 30 Aug 2019 18:48:36 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/8] videodev2.h: add V4L2_DEC_CMD_FLUSH To: Hans Verkuil X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_025627_966174_336E8A8C X-CRM114-Status: GOOD ( 24.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Jernej Skrabec , Linux Media Mailing List , Pawel Osciak , jonas@kwiboo.se, gregkh@linuxfoundation.org, Chen-Yu Tsai , mripard@kernel.org, Tomasz Figa , Paul Kocialkowski , Kyungmin Park , "moderated list:ARM/Mediatek SoC support" , Mauro Carvalho Chehab , Ezequiel Garcia , LKML , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2019 at 6:45 PM Hans Verkuil wrote: > > On 8/30/19 11:38 AM, Alexandre Courbot wrote: > > On Fri, Aug 23, 2019 at 4:45 AM Jernej Skrabec wrote: > >> > >> From: Hans Verkuil > >> > >> Add this new V4L2_DEC_CMD_FLUSH decoder command and document it. > >> > >> Signed-off-by: Hans Verkuil > >> Signed-off-by: Jernej Skrabec > >> --- > >> Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst | 11 ++++++++++- > >> Documentation/media/videodev2.h.rst.exceptions | 1 + > >> include/uapi/linux/videodev2.h | 1 + > >> 3 files changed, 12 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst b/Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst > >> index 57f0066f4cff..0bffef6058f7 100644 > >> --- a/Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst > >> +++ b/Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst > >> @@ -208,7 +208,16 @@ introduced in Linux 3.3. They are, however, mandatory for stateful mem2mem decod > >> been started yet, the driver will return an ``EPERM`` error code. When > >> the decoder is already running, this command does nothing. No > >> flags are defined for this command. > >> - > >> + * - ``V4L2_DEC_CMD_FLUSH`` > >> + - 4 > >> + - Flush any held capture buffers. Only valid for stateless decoders, > >> + and only if ``V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF`` was set. > >> + This command is typically used when the application reached the > >> + end of the stream and the last output buffer had the > >> + ``V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF`` flag set. This would prevent > >> + dequeueing the last capture buffer containing the last decoded frame. > >> + So this command can be used to explicitly flush that last decoded > >> + frame. > > > > Just for safety, can we also specify that it is valid to call this > > command even if no buffer was held (in which case it is a no-op), as > > this can help make user-space code simpler? > > Ah yes, thanks for the reminder. > > Jernej, when you post the next version of this series, can you change the text > above to: > > - Flush any held capture buffers. Only valid for stateless decoders. > This command is typically used when the application reached the > end of the stream and the last output buffer had the > ``V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF`` flag set. This would prevent > dequeueing the capture buffer containing the last decoded frame. > So this command can be used to explicitly flush that final decoded > frame. This command does nothing if there are no held capture buffers. With the above, Reviewed-by: Alexandre Courbot Thanks! > > Regards, > > Hans > > > > >> > >> Return Value > >> ============ > >> diff --git a/Documentation/media/videodev2.h.rst.exceptions b/Documentation/media/videodev2.h.rst.exceptions > >> index adeb6b7a15cb..a79028e4d929 100644 > >> --- a/Documentation/media/videodev2.h.rst.exceptions > >> +++ b/Documentation/media/videodev2.h.rst.exceptions > >> @@ -434,6 +434,7 @@ replace define V4L2_DEC_CMD_START decoder-cmds > >> replace define V4L2_DEC_CMD_STOP decoder-cmds > >> replace define V4L2_DEC_CMD_PAUSE decoder-cmds > >> replace define V4L2_DEC_CMD_RESUME decoder-cmds > >> +replace define V4L2_DEC_CMD_FLUSH decoder-cmds > >> > >> replace define V4L2_DEC_CMD_START_MUTE_AUDIO decoder-cmds > >> replace define V4L2_DEC_CMD_PAUSE_TO_BLACK decoder-cmds > >> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > >> index 4fa9f543742d..91a79e16089c 100644 > >> --- a/include/uapi/linux/videodev2.h > >> +++ b/include/uapi/linux/videodev2.h > >> @@ -1978,6 +1978,7 @@ struct v4l2_encoder_cmd { > >> #define V4L2_DEC_CMD_STOP (1) > >> #define V4L2_DEC_CMD_PAUSE (2) > >> #define V4L2_DEC_CMD_RESUME (3) > >> +#define V4L2_DEC_CMD_FLUSH (4) > >> > >> /* Flags for V4L2_DEC_CMD_START */ > >> #define V4L2_DEC_CMD_START_MUTE_AUDIO (1 << 0) > >> -- > >> 2.22.1 > >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel