From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20D7CA9EB7 for ; Mon, 21 Oct 2019 14:15:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97E4D21783 for ; Mon, 21 Oct 2019 14:15:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pzar1z0t"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pn/BCboT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97E4D21783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FZTpHXi7x4MxMwCje8MysXWbey24o5goM/DOHfUkga4=; b=pzar1z0tmjKfx2 Cr2lxaTaY9p2hofSbNUeEu6gHvGJ6j7wJ+YZm4xTu+lBuY3KlFfTSDH+BBrxOVXVTtYqQ2ECbf/Lk alCmfF34jAcxqnkVvW5TPIo5EW0q9GjbnYHUfVjKOvzw2GZEAYOu46AmJUyT9ptkPy71wXwOXYLfD AkNGY78qj+I7Fnn8pFpiKIuTWsxjhMfgsa/+tQjroMoj5JwXIN5rbA01Cm+LIAwTKX3pBMzVn1l0I IBTi96qLD144Pr1EOZc3bO11K1R8zL2sDsRkekcHzZQy14XOo2DcpC5Z+64xuDd4wLun++1eVnbuh Jtl3q6jbWGHmTQGGFhSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMYSa-0007ib-84; Mon, 21 Oct 2019 14:15:00 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMYSX-0007hx-AU for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 14:14:59 +0000 Received: by mail-vs1-xe44.google.com with SMTP id z14so8918564vsz.13 for ; Mon, 21 Oct 2019 07:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yS8qs3B3YGG+1CaBCs+yd01gHNPGrQOZoSsD0Kk0Jog=; b=Pn/BCboTlYXueWFu2lYYLoFGnsbCRWYun52IGpqPIDYrwc2DK/4wSWIlEIAwadC3Ou dg7eBJiJxRYXrT6Ya9KUrMlTMR6vzqKpazwDroPYbKI7s/J1NEL0Rsc4GYU+P1Md7r7A N0PZnApDTKbbzf9lUyHu+zTbPUaEPLIFUwUG+qiArKuGJgSBDB93WbhnHvQ55Bfly0Bg xR0pyZRVdDcRVZVnGK1lHKMSaKowQU4IO4OApws7zDX3vYlltsiAQXfFTgIxakyKHFIt cyeEQvT12qW/TlJhRySJdqZaFqyCWalutZWBk3pTWyqlu9Q7ejExawnfBfc4+yN2KrGm 52ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yS8qs3B3YGG+1CaBCs+yd01gHNPGrQOZoSsD0Kk0Jog=; b=JqX8cIItiJ6OQHD8A5bbMQ3jbnBlyDL44JqpYhFpdC3qvKsHgfsjSaTThJ6LfjUn1W Px3ZTW0bMYhBJGWAPmP7QF6yOvvUiHms9Qo6aE/V/9eFGPxOAH6dtU29el9xc9azlSM5 JeEy/DmMDPhhrtVtQj9yJOqxlCnQ+L1kvYzBrTAbDMFF5Nz5bwb0nAfbDmvPnMneoBiZ cUQ5W//lHvLTfHkvhSYSPHUFBz8pW2WwjfSaGue3d4dEd7AkYH8s4SXEp00RlXOREyjy 5pVMRBIjXOTG6ipGK9fZDyhYEUQmFt5jc87FQKKRVFHxwC/xwAFr63PWynD80P9rgEsx W7xg== X-Gm-Message-State: APjAAAWzumqBh7t21UVxSw+czSbJoyx9e7LwoGjs0QkwCPm9y72E9cGK Ep+e8nSCSAheRdH9XDNRRx0UmoNxnP7V1tNBtHGm7Q== X-Google-Smtp-Source: APXvYqz9r09sX0s75qmyPEEUmSKArK+VJBphmNsHF6I2eD5KN0VEOGXWfbqgNE20Ygtof4lmLqC1eZzCLfMc1loRLkI= X-Received: by 2002:a05:6102:104d:: with SMTP id h13mr13907823vsq.165.1571667296086; Mon, 21 Oct 2019 07:14:56 -0700 (PDT) MIME-Version: 1.0 References: <1571293310-92563-1-git-send-email-manish.narani@xilinx.com> In-Reply-To: <1571293310-92563-1-git-send-email-manish.narani@xilinx.com> From: Ulf Hansson Date: Mon, 21 Oct 2019 16:14:20 +0200 Message-ID: Subject: Re: [PATCH v3 0/8] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling To: Manish Narani X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_071457_363997_B1747BC7 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , rajan.vaja@xilinx.com, nava.manne@xilinx.com, "linux-mmc@vger.kernel.org" , Adrian Hunter , Michal Simek , Rob Herring , Moritz Fischer , Linux ARM , jolly.shah@xilinx.com, Linux Kernel Mailing List , git@xilinx.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Oct 2019 at 08:22, Manish Narani wrote: > > This patch series does the following: > - Reorganize the Clock Handling in Arasan SD driver > - Adds new sampling clock in Arasan SD driver > - Adds support to set Clock Delays in SD Arasan Driver > - Add SDIO Tap Delay handling in ZynqMP firmware driver > - Add support for ZynqMP Tap Delays setting in Arasan SD driver > > Changes in v2: > - Replaced the deprecated calls to clock framework APIs > - Added support for dev_clk_get() call to work for SD card clock > - Separated the clock data struct > - Fragmented the patch series in smaller patches to make it more > readable > > Changes in v3: > - Reverted "Replaced the deprecated calls to clock framework APIs" > - Removed devm_clk_get() call which was added in v2 > > Manish Narani (8): > mmc: sdhci-of-arasan: Separate out clk related data to another > structure > dt-bindings: mmc: arasan: Update Documentation for the input clock > mmc: sdhci-of-arasan: Add sampling clock for a phy to use > dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI > mmc: sdhci-of-arasan: Add support to set clock phase delays for SD > firmware: xilinx: Add SDIO Tap Delay nodes > dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller > mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup > > .../devicetree/bindings/mmc/arasan,sdhci.txt | 40 +- > drivers/mmc/host/sdhci-of-arasan.c | 477 +++++++++++++++++- > include/linux/firmware/xlnx-zynqmp.h | 13 +- > 3 files changed, 498 insertions(+), 32 deletions(-) > > -- > 2.17.1 > Manish, the series looks good to me. However, I expect you to post a re-spin, to move some of the new DT bindings into common mmc DT bindings, as Rob suggested. So waiting for another version, before I apply it. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel