From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE79C2D0A8 for ; Mon, 28 Sep 2020 11:58:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCF532073A for ; Mon, 28 Sep 2020 11:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2DDTQGiu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pEn/6/8w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCF532073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y1AEGAKAe4WsfOwTXRoUREtcPppKfVGkT/4o41aun2Q=; b=2DDTQGiuKjHDFXNz0u4ttkoe/ 6vsB38NZvVbBippsr8Y3Alpo4iIYLkANJDZqhno9UEkhZ8X9yvWs5xVhC+oPeTrWwhX36ZSrjXrD5 ATjLZANUaGl19x4d8xRz2vHLuHYx9rhib4M1LPEYhioljFiQJeYN2J9nq+J4sMrPApcD7pS4IL6VN HOiyAWcF0bYKeI1+G2dmRdlJTLndXPDLXvM/fOMCt+gMCMjYxZ/MGGNQPeCNSO4dXP2xu1HAEv5Jy e3H++1qUMZeHjtn9uqXwXJo9Cn2U+/B3yCpkqJgLNe2qn7r/gQgfaGrgztEoNJFzOpv62F5g3I1B7 DrlyVu24Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMrmP-0006bh-0p; Mon, 28 Sep 2020 11:57:17 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMrmK-0006a1-VZ for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 11:57:14 +0000 Received: by mail-ua1-x942.google.com with SMTP id q26so2076710uaa.12 for ; Mon, 28 Sep 2020 04:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m6BlvVj0EVBywT2cgsOvKNryF2Rcqd3HsW1lXVo1/GQ=; b=pEn/6/8w3Oy5g1bbm39JWitdVAV22PJrmkH7b+G99ss/wCBD0qrKg18W5H/i5c1rWc y9uKCA8zaRWqRn28zrPEPT659GmhDg5KCB9mbEL4GMFnpc9/9H+rrgIcUkNjvEhd+uBd ryIAmPJ3xMFMyQr6lpwMCgvAMmMnlYl8UBqkq00fWI1N8wzGC/QxFaQRRATkGavKZqK2 blW91iQHF78F47AHuqcbpfmobaffGRoEjozN7WFmmV8yxcG/nGa/F3XuglPgmnKiNCP1 AIA11sjlfh/yWiEdY6Np6R/RGrmPTNdAwIV+CYy7sah+p9EilfEOEV/bvtxG74V++jAi ER0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m6BlvVj0EVBywT2cgsOvKNryF2Rcqd3HsW1lXVo1/GQ=; b=XHW3zL4J25ZSOQkIo5OBRg88NkmNEY73eO5rBnCE7KBraLXoF3UZMHbmEC/zu/i//1 GlmVrpgksGhPaZ1pCbRYTvNFXkcv4XoweA3nWUinerK/0ZTWFP38r7oN49nkkNbp5vjR kbe+MIYv0kODIrX3mWn27+DCPEXTZqyt+h30DMNmMihzMox4YrDIY3HUUwxVWtqBXp21 2FARvzNz3ByD73LnMwQd1mPvUMtLlgm8EW2fRoAX3nveXHs8aS0LjxOjQ7JtkWBRehRV DTTgFhGAGPT6XqIenVWXdD+pWdSVtjfE8iQA61wRew5QsRcuKMyNhaJcVyiJ+jmE70rR CqaQ== X-Gm-Message-State: AOAM531No3OtTNS0JeMwfed8pOG1a67MU1O4hGu871l/qN1QUwyiYe02 fpktX2fZ5JfdNNVnKxy9zTCjgQpviqmQTymuatdzBw== X-Google-Smtp-Source: ABdhPJy2xwpA03LkomFwJX+og3ha8axdK0DMS/pf4Ie0JmuKCaW5PwxmHaD/vPRC+Y16/8q34eWNEpKcCm82OEYTvPo= X-Received: by 2002:ab0:130a:: with SMTP id g10mr375063uae.100.1601294230739; Mon, 28 Sep 2020 04:57:10 -0700 (PDT) MIME-Version: 1.0 References: <20200924110449.329523-1-ulf.hansson@linaro.org> In-Reply-To: <20200924110449.329523-1-ulf.hansson@linaro.org> From: Ulf Hansson Date: Mon, 28 Sep 2020 13:56:34 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] PM / Domains: Add power on/off notifiers for genpd To: "Rafael J . Wysocki" , Kevin Hilman , Linux PM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_075713_282303_2BBFEFB2 X-CRM114-Status: GOOD ( 20.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Vincent Guittot , Stephen Boyd , Daniel Lezcano , Linux Kernel Mailing List , Lina Iyer , Bjorn Andersson , Linux ARM , Sudeep Holla , Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rafael, On Thu, 24 Sep 2020 at 13:06, Ulf Hansson wrote: > > Changes in v2: > - Improved error handling in patch3. > > A device may have specific HW constraints that must be obeyed to, before its > corresponding PM domain (genpd) can be powered off - and vice verse at power > on. These constraints can't be managed through the regular runtime PM based > deployment for a device, because the access pattern for it, isn't always > request based. In other words, using the runtime PM callbacks to deal with the > constraints doesn't work for these cases. > > For these reasons, this series introduces a power on/off notification mechanism > to genpd. To add/remove a notifier for a device, the device must already have > been attached to the genpd, which also means that it needs to be a part of the > PM domain topology. > > The intent is to allow these genpd power on/off notifiers to replace the need > for the existing CPU_CLUSTER_PM_ENTER|EXIT notifiers. For example, those would > otherwise be needed in psci_pd_power_off() in cpuidle-psci-domain.c, when > powering off the CPU cluster. > > Another series that enables drivers/soc/qcom/rpmh-rsc.c to make use of the new > genpd on/off notifiers, are soon to be posted. However, I would appreciate any > feedback on the approach taken, even before that series hits LKML. > > Kind regards > Ulf Hansson > > > Ulf Hansson (3): > PM / Domains: Rename power state enums for genpd > PM / Domains: Allow to abort power off when no ->power_off() callback > PM / Domains: Add support for PM domain on/off notifiers for genpd > > drivers/base/power/domain.c | 187 +++++++++++++++++++++++++++++------- > include/linux/pm_domain.h | 19 +++- > 2 files changed, 171 insertions(+), 35 deletions(-) > > -- > 2.25.1 > I will need to iterate patch 3, potentially even a couple of more times. As I expect patch 1 and patch2 to not get changed, may I suggest that you pick up those so we can move focus to patch3? Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel