From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0899CC433B4 for ; Mon, 17 May 2021 09:28:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FAC7611CC for ; Mon, 17 May 2021 09:28:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FAC7611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=63FjE4WXSYWaIFY5WvDknSwNwSQfihJ3NoV2CrxOc2Y=; b=Lndx7YInHHFBJ0XTiVXTTJroG NKmHZaz99xv4FFbYzpCjBAJ3chvlKXrxz7AAeHT232YnwQ2qUrOLsIs6fQKRPzC9EF/6mF6//veQy M6xOC5+/lx4EX6h5aTCKGEaCYL3A+BuGDS2tkxkfu1Yh83PN5hQFzgRhazQWYcZ4UQLXmXJ3iplxc uj+LGAcAJN7bvBAry1bJakBLjAPC33XLSzpn+kroerFIE5YOIn3jaJLdI10qLpVvVTAv1/OEEuMgi d5cX5+j2Bzzzd4itxI+eAbSrP+Q5noNexxjZut7hMUCo6P77mSydGSZDHy8rMIe0PfvqZfSC+B7d4 J4oADSmAA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liZUt-00EOY9-Pp; Mon, 17 May 2021 09:25:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liZTI-00EOJt-8G for linux-arm-kernel@desiato.infradead.org; Mon, 17 May 2021 09:23:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kzYVzmT+Y8ce2flyvbSSPdmquvI+WpoScVhmf9xFNfc=; b=SigVNoZGUYnWDaoLgU9a4ZDLyJ GRTjxmQ0EPx4r/QCokUjqX5nNq9MUfxplyQB/2ScLpRc7aMhKSgqExX0DyF27J4QuUhYQhxyhUWa0 qLju8W0PrwPUiV6lI4Yb5iFithnZ1Hbk38eUCIF2fSkSJP2tLQqyc9bMa0d6uH83DSsiFugOVwVsj 9gCK+V0ELGOVRoT29K3uZQXU4+2xxGDPdNQiKC6EadgPODlHBccrFGTgQxZas3MpqNDt6ORdRDzHQ GrxlYDhvCbOTCbNFPJrMfTh0YS56li43FV7lGfNRkH9NhLlwR8oHswTAiacGsMnDnSVunmHJyAKt6 +S5pZbZQ==; Received: from mail-vs1-xe2e.google.com ([2607:f8b0:4864:20::e2e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liZTD-00DdKl-67 for linux-arm-kernel@lists.infradead.org; Mon, 17 May 2021 09:23:31 +0000 Received: by mail-vs1-xe2e.google.com with SMTP id u188so2757275vsu.8 for ; Mon, 17 May 2021 02:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kzYVzmT+Y8ce2flyvbSSPdmquvI+WpoScVhmf9xFNfc=; b=wZE8pBAqeARtQbwh+YWftfz+pAOAl52rdskfYBROlX2BYGzyiP8jIhVMX2ZLlI/5TN 2h55vokvcNd9L9wocrsTfFNSZ7mvGTPvyT6ydg0YrjKHLTUBuhbjdOqBt6BcYgzbTu4z CJC7/JcgyYbA8qJyYy52Qlnrl5Ks8rBSWSII4TJUN/iauAg9QqBcUXZ3Uc46G84x0Wqi 7EJaqNos/h447r9ZfuhH/fMb87/SWTIRaTqJufYy20AjL2e6KGye9jf84Rmi4O/7MYAE 1JPV3hD1j6WJmF5EQD0WwU2Wke0Zt5Bbr1TPruhZr+U9SyoLJj18Xh+kzPIbsZqQnpMc 7cvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kzYVzmT+Y8ce2flyvbSSPdmquvI+WpoScVhmf9xFNfc=; b=Yzpl0J0vXD2jemdV8yuMaR93re5fJFfD0WSwtfrPif5DDQcB3MfUgfedL0KFsNbIR6 4t+BOVUTiu745eC65SQ6IAKQR/GjJ4jTnhUIqvJme5gtp3a/7UGdGSP1JW1RrigFAwW0 u/J2TM9LDNRCzcENs5J4VkRu9dKjkPIsSwhjNNfrnZKYzAIIpsBI83LW4j4P8AzNbnDW emlrMya0z4yewrdODEvxFa7rohWE48xdpI0g78Tvt51yWdBaYOtPTCM3zRMSkb97iOMH kZViap/6N5uCJTBFyYuB6Vmqs884ISeY1M5CS9aJCYRlAw6OFhifbgSN5arEodwyW2Mn 67DA== X-Gm-Message-State: AOAM530pYLzdB49hmk11vBrVYJ5zQD27shMdadF/WVqZn/2f/q/oNA8r tssestqEg1AkkwKrhf7pJMjNFkOxJ8OQkF5uM7MnSw== X-Google-Smtp-Source: ABdhPJyXKhN5EScVDwjR162oOK33ajPAKsDnGAYw4sYWr1DOTQym8W+LchIR8j6ixX6JvWzsFngChaUy9M79BpaoBus= X-Received: by 2002:a05:6102:7b4:: with SMTP id x20mr3923640vsg.48.1621243403858; Mon, 17 May 2021 02:23:23 -0700 (PDT) MIME-Version: 1.0 References: <20210513193204.816681-1-davidgow@google.com> <20210513193204.816681-6-davidgow@google.com> In-Reply-To: <20210513193204.816681-6-davidgow@google.com> From: Ulf Hansson Date: Mon, 17 May 2021 11:22:47 +0200 Message-ID: Subject: Re: [PATCH v2 06/10] mmc: sdhci-of-aspeed: Remove some unnecessary casts from KUnit tests To: David Gow Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , Andrew Jeffery , Adrian Hunter , Joel Stanley , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Linux Kernel Mailing List , linux-mmc , linux-aspeed , OpenBMC Maillist , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_022327_254550_6D4B4452 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 13 May 2021 at 21:36, David Gow wrote: > > With KUnit's EXPECT macros no longer typechecking arguments as strictly, > get rid of a number of now unnecessary casts. > > Signed-off-by: David Gow I guess you will funnel this via another tree than the mmc? Acked-by: Ulf Hansson Kind regards Uffe > --- > This should be a no-op functionality wise, and while it depends on the > first couple of patches in this series, it's otherwise independent from > the others. I think this makes the test more readable, but if you > particularly dislike it, I'm happy to drop it. > > drivers/mmc/host/sdhci-of-aspeed-test.c | 34 ++++++++++++------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed-test.c b/drivers/mmc/host/sdhci-of-aspeed-test.c > index bb67d159b7d8..1ed4f86291f2 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed-test.c > +++ b/drivers/mmc/host/sdhci-of-aspeed-test.c > @@ -26,23 +26,23 @@ static void aspeed_sdhci_phase_ddr52(struct kunit *test) > KUNIT_EXPECT_EQ(test, 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 25)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > aspeed_sdhci_phase_to_tap(NULL, rate, 181)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 182)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 183)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > aspeed_sdhci_phase_to_tap(NULL, rate, 184)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > aspeed_sdhci_phase_to_tap(NULL, rate, 203)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 204)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 205)); > } > > @@ -67,21 +67,21 @@ static void aspeed_sdhci_phase_hs200(struct kunit *test) > KUNIT_EXPECT_EQ(test, 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 96)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 186)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 187)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > aspeed_sdhci_phase_to_tap(NULL, rate, 269)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 270)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 271)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 276)); > } > > -- > 2.31.1.751.gd2f1c929bd-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel