From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F63C433DB for ; Tue, 9 Mar 2021 08:17:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A8CD60201 for ; Tue, 9 Mar 2021 08:17:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A8CD60201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XpKL7GMKpx7aN8OZYs56EO7yI8Hl7Iq39a9QqFBG/ns=; b=fTpEzwkOOeBXsdGgk8UOih800 fJPGxrEUPRLP1BuIieBz96fU/1FoTwenIYqN7L/IJB427bd/FQChTYOcRm3av4whMk/4gycBf2vPW B99sspPnI/YUoaS9JgAY6maDAT4Dyzb9WP+uD8RdqA2DBOK6cSaUeXz6IzM/Erq25cRLArpt3bzud 3PMLnOpiHWX5+N4g5O6Simhc0lDSQFJLWGaNehjvLb0iFPHFQpQyvDzrQhzhYrpukacmQUyygaf+x U5hqshLJ1FSU/FGVkEfSJk+C7/dMnUBR+1EgrcRwtGHz228keg/tiJeYpmL2tVSWmlRG9UyB7lrp5 3+wQpBDxw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJXWk-0040r9-1M; Tue, 09 Mar 2021 08:15:38 +0000 Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJXWe-0040qH-6j for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 08:15:34 +0000 Received: by mail-vs1-xe33.google.com with SMTP id w76so6342555vsw.10 for ; Tue, 09 Mar 2021 00:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zt/Qo1WuohJnN8BsEHz9cxnvtJashQ/NC/B5GNdt0Vw=; b=xTMuS7ToMWt37R/E2TwMkIlTyw/OnDiCgFudLcVzRWMSo5w4RdGfYHysaMdM/p1NTM /fqG/hW6BZDUtUgCO1V3seC2X6TEO0zAQWMWvFIatAc2w/rS757Rr+QoLDwCAZudOklN rKGr2+ojXgZPf867xtn+jGgS+l/xekob1NmvS0r1aYibZoE9XIGrR4cHObok+kU5TrAk MprRVuBqMFuG6neSTkuAyQQlG5hEKPh+ZfOZ8ujoA9opxP+AtZh6gqFknJNahGMTgson midmLZwd521PiW899MPbJHiWpD/79d5cW2IU7wdkBmMqCs4Kxhk3I2o16pSfzTtc/tE9 WRXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zt/Qo1WuohJnN8BsEHz9cxnvtJashQ/NC/B5GNdt0Vw=; b=VQyc4E3dSIjwWAXsqjrCUB1naXv0jHArrl+/hcsBL9ZRMhHGQlKV0qdAomQpvJpVNk +JRpvHP/dz4/y8Cc/M/PEM3fmUPraD0EG7jwg+B2mYuRVe4VX3BgG6OTc0Z7a0axHyEf 0vvuQf+OJ7suJJkUkAzL+yi5Y7zYj2CROGyDmy91lcRkOwWdxRgckSVJ5uNaGDwvdNg/ iip1WUrTYGBmifcxGfi7/JwD0UIAIxxbJRKksGA2Pb6ghUeAFvoRfpaMtcySgErP0+x7 /0gxP6IxSKTMGj85NXywBejCEQfxpkn/Baa7k5iduRMTOoFYUHLKFyrdl4RC//7Gi7+8 YLjA== X-Gm-Message-State: AOAM533kQOI5FABPKLq2kNyIFqD0549trezZvKzinH+mm/D89OUVVPPB H5B8FoCmXHkqs3WlDalCdqGTo99w6trkIAnFkwuNqg== X-Google-Smtp-Source: ABdhPJyIREswXY8HIMohbytoDNg1hEAh37OQLrBbhEhyA1hgNSWz8OdncAaF+NnykgRA5ocddH6xzrc2+bGXFLcbPYs= X-Received: by 2002:a05:6102:7b0:: with SMTP id x16mr13806738vsg.34.1615277730169; Tue, 09 Mar 2021 00:15:30 -0800 (PST) MIME-Version: 1.0 References: <20210225095216.28591-1-nsaenzjulienne@suse.de> In-Reply-To: <20210225095216.28591-1-nsaenzjulienne@suse.de> From: Ulf Hansson Date: Tue, 9 Mar 2021 09:14:53 +0100 Message-ID: Subject: Re: [RFC 0/2] sdhci-iproc CMD timeouts To: Nicolas Saenz Julienne Cc: Linux ARM , "linux-mmc@vger.kernel.org" , DTML , BCM Kernel Feedback , "moderated list:BROADCOM BCM2835..." , Florian Fainelli , phil@raspberrypi.com, tim.gover@raspberrypi.com, Adrian Hunter , Scott Branden , Al Cooper , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_081532_413787_E2DCC3D6 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 25 Feb 2021 at 10:53, Nicolas Saenz Julienne wrote: > > I'm seeing a rather odd behavior from sdhci-iproc's integration in BCM2711 > (Raspberry Pi 4's SoC), and would appreciate some opinions. > > The controller will timeout on SDHCI CMDs under the following conditions: > > - No SD card plugged in (the card polling thread is running, CD irq disabled). > - BCM2711's VPU clock[1] configured at 500MHz or more, lower clocks are OK. > > There is no specific command that will time out, it seems random. > > Here's what I found out. The SDHCI controller runs at 100MHz, by bumping the > frequency to 150MHz the issue disapears. Might be pure luck, or maybe I hit the > nail and it's proper interference. Can't say. As you probably know, I don't have the in-depth knowledge about this HW. Although, let me provide a very vague guess. Could be that the controller needs a higher clock rate to stay within some spec, for an OPP/voltage domain for example? In any case, assuming you get some confirmation from the Broadcom folkz that this makes sense, you need to update the DT doc bindings to add the clock-frequency property. In regards to this, please take the opportunity to convert from legacy DT doc format (brcm,sdhci-iproc.txt) into the new yaml format. Kind regards Uffe > > Regards, > Nicolas > > --- > > [1] For those who are not aware, here's the relationship between VPU's clock > and emmc2's: > > osc 54000000 > plld 3000000091 > plld_per 750000023 > emmc2 149882908 > pllc 2999999988 > pllc_core0 999999996 > vpu 499999998 > > Nicolas Saenz Julienne (2): > ARM: dts: Fix-up EMMC2 controller's frequency > mmc: sdhci-iproc: Set clock frequency as per DT > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++++++ > drivers/mmc/host/sdhci-iproc.c | 10 ++++++++++ > 2 files changed, 16 insertions(+) > > -- > 2.30.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel