From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44E19C32772 for ; Mon, 22 Aug 2022 10:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/eRQcQAkcwAjgVyh69vjMTcAaxdrG9oiwMy0SC9z9E0=; b=baw1jk/2QcNAL6 qtUebUjS4xemi5IKdFFtA80DSxralZUvKPZrTwwM+/vCgLwnXPYVf8Bi0TpryEtGrnpiaJbB6x1Co 4M1YGOgkiZExBoi9EnNrfWyp3LD9c9bL5rb6b0XaA+p9R0xtHArJPByfZfZR187oFtvxycmnc5VkI GT6LiFwRTCV+94UexwsNy/RXAP+TMCLoS3K9Fyw91OAAq2CRLQD9BJX+P7YOgJEfA5pzbiv1X86Mf zsRXn8tYxmXubvO/C4ObY8HpqUjRj0hNWqap5jxcRK47hqgtBGVsW4pIJq0qe82qKuLOHGbI+/xUJ ygB3ygcG6h5XUftNN/FA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ54K-007lZJ-7G; Mon, 22 Aug 2022 10:54:08 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ54H-007lVk-2D for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 10:54:06 +0000 Received: by mail-lj1-x236.google.com with SMTP id q18so9193148ljg.12 for ; Mon, 22 Aug 2022 03:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=qUJzeAA0zGAS1ziTyPpIwPEe4uv+VPYIR9XMGD7ii3Q=; b=zS3GUMwVqjObBA9yF5EBFw5i8T4tvqI0WJm3QKWgwuNQskUJA1nQZRNYN7mXVH6eKp BXXJgVnO7b3OxwwmzlUoxkxxprQiYtoLk+sWv1BU/B50dwHNuZ2UkXWKcivTJWATWOuf tPcFq7G74B3Y4yLQOgu4O0FTV8b1WUkxEcIGfN5AXBz8owhYy8BM6cFA9RBJVhjVtm05 BKNxqx0ASZVpEObqTtBm1GsfLmd83YyXYpGusTPRs1Ace2isVx1jfkzK4fVOGr3hdE1A w91cHt3yl/roRhk6IgHsrNwexe+NYBOOBqb6dZfsW2dUZeq0iFyaMLQ7OdYnEUfEQD8Z n5Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=qUJzeAA0zGAS1ziTyPpIwPEe4uv+VPYIR9XMGD7ii3Q=; b=dfj7evji3HrSu7fLaT0/T3IYp+JYX5EPGbDg4LEpPrrBKgfbbHNw/EyGA3NaT3LEbg 22LpDrR3wtf+ZLL9BT9zraes+GOgP4H6zlLqiRYArH14BzEakS/PoCUxGbe9OJ1+u5QJ VsA/uTdyejBi9GoaNQFAkuAR5FqXZp/Xg63R0d38x/XiN3PtZEHTe5yLBK/Vd+XcZGXv tTEi/52r4VA6cb4sc/L4pMmCg20DosIP+thjtpxB6MIBVR3naa2zL5PKa+qKpyy82DXh +u89xk4y9Qb5CnLCBq1YUj6BamjnFQXoDTjTu3ex2fkgeQjjJ/I6/zP/vS8TrIjPQqsp bT3w== X-Gm-Message-State: ACgBeo0rbwY52Hx0JhLzuBSjAPSy6SI1DOIVaafAQcD4zu0SMPlM0tIY rkGkrAIF6lswi273lG67tv0uRmdy86ajQOsSHLZVEA== X-Google-Smtp-Source: AA6agR5TbBnQzeewFLNJT2B20rIJ4J1PMANfqfPlA8kVn7/qRNYu/IMOKiDXsiM+z3emf7Y2A2IYdLt6WrjEEvVIqsQ= X-Received: by 2002:a2e:b746:0:b0:261:cc50:35cf with SMTP id k6-20020a2eb746000000b00261cc5035cfmr1612272ljo.4.1661165639489; Mon, 22 Aug 2022 03:53:59 -0700 (PDT) MIME-Version: 1.0 References: <20220820195750.70861-1-brad@pensando.io> <20220820195750.70861-18-brad@pensando.io> In-Reply-To: <20220820195750.70861-18-brad@pensando.io> From: Ulf Hansson Date: Mon, 22 Aug 2022 12:53:22 +0200 Message-ID: Subject: Re: [PATCH v6 17/17] mmc: sdhci-cadence: Support mmc hardware reset To: Brad Larson Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, will@kernel.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_035405_134604_2DB25849 X-CRM114-Status: GOOD ( 27.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 20 Aug 2022 at 21:58, Brad Larson wrote: > > From: Brad Larson > > Add support for mmc hardware reset with a reset-controller > which would need to be enabled in the device tree with > a supporting driver. The default is disabled for all > existing designs. > > Signed-off-by: Brad Larson > --- > drivers/mmc/host/sdhci-cadence.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c > index c662c63d49fa..35d37b9aba63 100644 > --- a/drivers/mmc/host/sdhci-cadence.c > +++ b/drivers/mmc/host/sdhci-cadence.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > #include "sdhci-pltfm.h" > > @@ -70,6 +71,7 @@ struct sdhci_cdns_priv { > spinlock_t wrlock; /* write lock */ > bool enhanced_strobe; > void (*priv_writel)(struct sdhci_cdns_priv *priv, u32 val, void __iomem *reg); > + struct reset_control *rst_hw; > unsigned int nr_phy_params; > struct sdhci_cdns_phy_param phy_params[]; > }; > @@ -458,6 +460,22 @@ static void sdhci_cdns_hs400_enhanced_strobe(struct mmc_host *mmc, > SDHCI_CDNS_HRS06_MODE_MMC_HS400); > } > > +static void sdhci_mmc_hw_reset(struct mmc_host *mmc) Nitpick: Probably better to be consistent with the prefixes for function names. So, I suggest changing this to "sdhci_cdns_mmc_hw_reset". > +{ > + struct sdhci_host *host = mmc_priv(mmc); > + struct sdhci_cdns_priv *priv = sdhci_cdns_priv(host); > + > + dev_info(mmc_dev(host->mmc), "emmc hardware reset\n"); Maybe it's sufficient with dev_dbg? > + > + reset_control_assert(priv->rst_hw); > + /* For eMMC, minimum is 1us but give it 9us for good measure */ > + udelay(9); > + > + reset_control_deassert(priv->rst_hw); > + /* For eMMC, minimum is 200us but give it 300us for good measure */ > + usleep_range(300, 1000); > +} > + > static int sdhci_cdns_probe(struct platform_device *pdev) > { > struct sdhci_host *host; > @@ -520,6 +538,17 @@ static int sdhci_cdns_probe(struct platform_device *pdev) > if (ret) > goto free; > > + if (host->mmc->caps & MMC_CAP_HW_RESET) { > + priv->rst_hw = devm_reset_control_get_optional_exclusive(dev, "hw"); > + if (IS_ERR(priv->rst_hw)) { > + ret = PTR_ERR(priv->rst_hw); > + if (ret == -ENOENT) > + priv->rst_hw = NULL; > + } else { > + host->mmc_host_ops.card_hw_reset = sdhci_mmc_hw_reset; > + } > + } > + > ret = sdhci_add_host(host); > if (ret) > goto free; > -- Other than the comments above, I wonder about what merging strategy we should use for the series. I believe it looks fine for me to pick up the mmc related patches, thus we can apply patches on a per subsystem basis, right? Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel