From: Ulf Hansson <ulf.hansson@linaro.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Haibo Chen <haibo.chen@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
linux-mmc <linux-mmc@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] mmc: sdhci-esdhc-imx: advertise HS400 mode through MMC caps
Date: Mon, 24 May 2021 16:10:19 +0200 [thread overview]
Message-ID: <CAPDyKFoep9zPwzAU-1yghyMmZF7PVwam0_rN0hgxB0yZbhxDqw@mail.gmail.com> (raw)
In-Reply-To: <20210510190400.105162-2-l.stach@pengutronix.de>
On Mon, 10 May 2021 at 21:04, Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Instead of having an indirection through the SDHCI layer and emulating
> a capability bit, that isn't there in hardware, do the same same thing
> as with HS400_ES and advertise the support for HS400 directly through
> the MMC caps.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index a20459744d21..65a52586db36 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -427,9 +427,6 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
> | FIELD_PREP(SDHCI_RETUNING_MODE_MASK,
> SDHCI_TUNING_MODE_3);
>
> - if (imx_data->socdata->flags & ESDHC_FLAG_HS400)
> - val |= SDHCI_SUPPORT_HS400;
> -
> /*
> * Do not advertise faster UHS modes if there are no
> * pinctrl states for 100MHz/200MHz.
> @@ -1603,7 +1600,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
>
> if (imx_data->socdata->flags & ESDHC_FLAG_HS400)
> - host->quirks2 |= SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400;
> + host->mmc->caps2 |= MMC_CAP2_HS400;
>
> if (imx_data->socdata->flags & ESDHC_FLAG_BROKEN_AUTO_CMD23)
> host->quirks2 |= SDHCI_QUIRK2_ACMD23_BROKEN;
> --
> 2.31.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-24 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:03 [PATCH v2 1/3] dt-bindings: mmc: add no-mmc-hs400 flag Lucas Stach
2021-05-10 19:03 ` [PATCH v2 2/3] mmc: sdhci-esdhc-imx: advertise HS400 mode through MMC caps Lucas Stach
2021-05-11 3:00 ` Bough Chen
2021-05-11 8:18 ` Lucas Stach
2021-05-11 12:40 ` Adrian Hunter
2021-05-12 2:23 ` Bough Chen
2021-05-24 14:10 ` Ulf Hansson [this message]
2021-05-10 19:04 ` [PATCH v2 3/3] mmc: core: add support for disabling HS400 mode via DT Lucas Stach
2021-05-11 11:14 ` Ulf Hansson
2021-05-11 11:54 ` Lucas Stach
2021-05-11 12:19 ` Ulf Hansson
2021-05-24 14:10 ` Ulf Hansson
2021-05-24 14:10 ` [PATCH v2 1/3] dt-bindings: mmc: add no-mmc-hs400 flag Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoep9zPwzAU-1yghyMmZF7PVwam0_rN0hgxB0yZbhxDqw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).