From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B033FC2D0E4 for ; Tue, 17 Nov 2020 17:16:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34A0E238E6 for ; Tue, 17 Nov 2020 17:16:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="y7UWEzNX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T/laoseh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34A0E238E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9e8oNocnVXSLNApRAIgtsAHp9YsXjdmxvGCoLHeb1Ls=; b=y7UWEzNX+2yvYnuD19vks5/TC 5IC12f0GMQQWyTKfV8M6uI026LmhSFuvIVRnTvX7+XFrRHNrvW7LPjMG1s4/E4X1V4+yyUakAku9E OAmddd2cG8/NSsYYPDVvCJraecD9B3NxvQIPbZVye8/BB+X1ZjVUqJxi1za9IjbLBIOJL9Pq39twM q66qg89VKaqJ4nZLgH00PS9W5gDUAHu7zOjBgusY6wT/6Dx9MKQ5RWPubqpPfQseyDTaz4FJ+J6do Mq5tbsGkTegtvGrN5ps/hf8DBh3oFs0ZGxI4oKQmwZ3QgVh3wYvuA5ZoRbPJ3ZObEChE50NnFql+q QW358/X/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf4Zk-0001pV-Lc; Tue, 17 Nov 2020 17:15:28 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf4Zg-0001ow-QX for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 17:15:26 +0000 Received: by mail-ua1-x942.google.com with SMTP id q4so6747385ual.8 for ; Tue, 17 Nov 2020 09:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CYSb0M0fe9VUi0Yz4rN2g/1snkt7mWNkgZy0eLYCtxw=; b=T/laoseh6koUPxSpKTpKUbL/ofH4XlN3e6fbu4/QbEK1o2Xmq7cJt/tP66EXZtFiBa DwUNIkT2bd5fl3g+LgEritIPR3J86JOYC3X4kEs8dawSy9q480jQD63ZgvdANMRNNnuB 7UXrLsOUdIopkr1Z0KYMrHOoWFu+z2a9ic/AsQVnBCJYRTvTzSilQmUAJTUffr7cDhpQ PfLJT4np+Cbyift0EAxQ7IQJuJ0r19pDREoQQiwehj8VZfGv9QUitIfnlPyaWkAoIhNA K9tzDtRXlQSaYLQhsBPAet2WRlN/PWx5yNEU+c+eZ1G3BCQBXaHL8mUr2ZecH7QdeLn+ ASiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CYSb0M0fe9VUi0Yz4rN2g/1snkt7mWNkgZy0eLYCtxw=; b=p1HJYNuRr4FO4039DlngfsBuTFRPC5EIufk5EiEILo2UUPU3yUtUC2cMNsrq7bjUC0 dsbv0/C4OkY2K8bQYtidQY+EyMJmq+pA7bs7wST3h6SAxoMXqq5GvptIy9lRCuS+wfIA tyRRf5VAOd9go9+a7jT56vbIAz0fMemkIx4ynpniuS3RSzPJQ8otsym7sSGFsndFJeiO xPC5HqwX5sU2zcbLXlOd44rPUaOO5VXa+TnaKHHLcUgxi9V0CBe2CfeU9B84evkUSYnQ CinXdd+Jqij3mR5Ep1sE2V5SIqzowETKCYfZcXrKtgfuroqsEH1UhbFIhh6n3ASTqIEc dRXA== X-Gm-Message-State: AOAM533xESPRIIH115fqOVh/SWdV84GJMtM8ydkz/+aqgiuKc3rma3nL rhJoPmvB/yo/zQt8HrmhO7QeLVWNTXHEiBQaLbLTWA== X-Google-Smtp-Source: ABdhPJwmehKHszhtCrvkt107pRksUJsS/ubL0KFY0b6kTiGnGtqW1O2aFcJhTI5DeQaBzbUxtzy41vhjXrzVvPZEfOs= X-Received: by 2002:a9f:2f15:: with SMTP id x21mr593298uaj.104.1605633322970; Tue, 17 Nov 2020 09:15:22 -0800 (PST) MIME-Version: 1.0 References: <20201106120933.7190-1-muhammad.husaini.zulkifli@intel.com> <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com> In-Reply-To: From: Ulf Hansson Date: Tue, 17 Nov 2020 18:14:29 +0100 Message-ID: Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC To: "Zulkifli, Muhammad Husaini" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_121524_891554_73B32E6E X-CRM114-Status: GOOD ( 26.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , "Wan Mohamad, Wan Ahmad Zainie" , "David E. Box" , "Hunter, Adrian" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Nov 2020 at 14:46, Zulkifli, Muhammad Husaini wrote: > > Hi Ulf, > > >-----Original Message----- > >From: Ulf Hansson > >Sent: Tuesday, November 17, 2020 7:27 PM > >To: Zulkifli, Muhammad Husaini > >Cc: linux-mmc@vger.kernel.org; Linux ARM >kernel@lists.infradead.org>; Linux Kernel Mailing List >kernel@vger.kernel.org>; Hunter, Adrian ; Raja > >Subramanian, Lakshmi Bai ; Wan > >Mohamad, Wan Ahmad Zainie > >; David E. Box > > > >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay > >SOC > > > >On Mon, 16 Nov 2020 at 15:22, Zulkifli, Muhammad Husaini > > wrote: > >> > >> Hi Ulf, > >> > >> Thanks for your review comments. I replied inline > >> > >> >-----Original Message----- > >> >From: Ulf Hansson > >> >Sent: Monday, November 16, 2020 7:41 PM > >> >To: Zulkifli, Muhammad Husaini > >> >Cc: linux-mmc@vger.kernel.org; Linux ARM >> >kernel@lists.infradead.org>; Linux Kernel Mailing List >> >kernel@vger.kernel.org>; Hunter, Adrian ; > >> >Raja Subramanian, Lakshmi Bai > >> >; Wan Mohamad, Wan Ahmad > >> >Zainie ; David E. Box > >> > > >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops > >> >for Keem Bay SOC > >> > > >> >On Fri, 6 Nov 2020 at 05:10, wrote: > >> >> > >> >> From: Muhammad Husaini Zulkifli > >> >> > >> >> > >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations > >> >> handling") introduces platform specific SDHCI clock operation. > >> >> > >> >> This patch declares the clock operation for Keem Bay. > >> >> Add clk_ops for SD, EMMC and SDIO operations. > >> > > >> >The above commit message doesn't really tell why or what goes on here. > >> >Can please try to clarify that. > >> > >> We missed out the clock operation handling patch (Commit 16ada730a759) > >> and did not handle the clk_ops for Keem Bay SOC devices. > >> These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) are > >merged at around the same time. > >> We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay > >EVM. > >> That is why I created this patch to handle the clk_ops for Keem Bay devices. > > > >Alright, so the previous changes were simply not sufficient to complete the > >support. > > > >> > >> > > >> >> > >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel > >> >> Keem > >> >> Bay") > >> > > >> >Is $subject patch fixing a bug/regression? > >> > >> This is to fix issue on previous commit. It is a bug fix. > > > >Has it ever worked? > > Yes it is working. Tested with Keem Bay EVM. > SD/EMMC/SDIO devices registered successfully with this fix. I am not asking if $subject patch makes it work, I understand that it does. > > > > >Did the commit you point to with the fixes tag, break some other existing > >functionality? > > It should not break other existing functionality. > This is specific for Keem Bay SOC only. So, you are saying that it has never worked for Keem Bay? But $subject patch makes it work? Can you please re-spin and update the commit message to better reflect what goes on, then I can apply. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel