From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56157C433ED for ; Tue, 11 May 2021 13:21:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A46F261260 for ; Tue, 11 May 2021 13:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A46F261260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a2CMhgBODq1yrGuZiTYJK5zyudL+qBhMp+aK9ZYVKVE=; b=QCFyKujo2vltAqeUe6FJieHO0 TrhJJ2TZqVNjBQAsPESEf9jCV89SLkt7eMk93V3I8Zf57EHt5yS3EB2Gae7HatQQj0Pq9eVQa617T f3osljfBoWypQoSBxm3jlKhQMvuy9w7iTAkt3V1DVYQIGKHFdfyJYqUKWc2L1MkKwe56rcP6Oadyo QmHYTF9zSVx0Fy2wfeRt9pezfNAZ08BWzZLgOC6AwD4U8lhT7xElVZgOS2WRcYMq+DaMgtfzmFl2e ksQnrkIoyBIR9kO9H4gfFZBcMJK0/iOykUZB62wH5u/dm8t7ljeJHw7mbrscqgh6nC+qR5zKDmeFq xc8ldgaEQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgSIu-0003YM-Fh; Tue, 11 May 2021 13:20:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgRN3-00HLax-Ej for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 12:20:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J9p0IV9O/0BHMoRbDshc2d2b/2+hF9lZpmTlcmjAloA=; b=BLDtQ6vfzGti4cP+8CmVFcOWB1 DEdpJcktuIn4OWj9vbDW5HENCXlG5f6xUMCbb5YQE1y3R4c2uHl05UuGl2jLioCp+pCJnBDFg+rHw ZC6uoWPc62NvfHqeuIxmDtuN7VDp/g+y/rpA1cB5nHVBLHs4Ic4WGVFL2xDEy12uNl7SIneeuLKIl WNVohsIQ/g5JODVMl5mWhNFaY9YJz5/s0E+T1VxjoWeCx+7WI8Fr7liaGeVPyTDHSAn1tPJM0vzyo yFHJrLC+4wGhNseGxWr8dch0R9JHWO5ACKBye41W56SnKsgXEX/+molw5mNWUahkF9gxVAo7lwGNc 6FTLGtgA==; Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgRN0-009Ysq-DC for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 12:20:15 +0000 Received: by mail-vk1-xa30.google.com with SMTP id q135so4004680vke.1 for ; Tue, 11 May 2021 05:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J9p0IV9O/0BHMoRbDshc2d2b/2+hF9lZpmTlcmjAloA=; b=RbVZmRNIsScv4qi8gxjWkiSJG43CXZdX+0+a5AkcDFjoJ9J5eGTxj+1afg4LX90EmW k4R/qk6hyDZar8BWrQIHMd/bKTgWKR14kz47HRjhO7tSLL8VnV0qUitEzDXamyivkMLO tTEQlbTn1hHYt7+cwbYDnxrmimrp9f4Gv4Chkv7sTeG5CH/vBG92miOM9cnzK6/xjX55 xoL7WuR3RrBtW7t3pDFPbVI/VCm1cJP7KK3ZCLRqDzJ5NJ6LdFZ7/+Pdac5VaWLpHLTp NFi7KFoj+47/9/VUPlyzAZu0KrDASFcJfMWvfA+bfCiWK9BavfWWSwv18yn+JnboCSVG nBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J9p0IV9O/0BHMoRbDshc2d2b/2+hF9lZpmTlcmjAloA=; b=UpMsjlqK1/jyqrYLgRgViGToxFxS+/eFQz/vEY7QJV3GPEM6vJK9r63IQoGnkvLfEA JHZ+BizYLPeK7IxFDbbCe3ylMmKb3YMIFGsMb0FxNmHO+Et96wsmEeljjTfIZsB0FGAN 28kkOQwKs0l5hxE7aqCyafgCaBUjULC6MULod/YCrUaRiOFzQTE/TeN25O9FurAnGJmM PHMLHXjtYrEo2nMzUD073WeCK7OEBS8AzOmxwWXIpQlyIuLhygetZ2LIbPQOwobd5eo0 3xUH2z3Qx7LVZAIW8UbhPM1gKrVwY/10pGw/8p7HcYRFrZ8B5R1NJvEAm4CaPYHiB/mJ hVhw== X-Gm-Message-State: AOAM5314e9b0OCEHujmbeXof3lHAaImnnYzJTp54YF0Ge8K/mNa7JgGS vxIn2H9MWka/MTbOepPuigITNw/BygJQWkNscAMVEw== X-Google-Smtp-Source: ABdhPJyy0HX6uiYQyMYND+Hu2ICNbRj8Qpd12xxBCQ/P4A91seUGfmc8gvrGzRUb+45J3s5mY3TfTuSa8mgEplFrUfM= X-Received: by 2002:a1f:aecf:: with SMTP id x198mr22224995vke.6.1620735612522; Tue, 11 May 2021 05:20:12 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-3-l.stach@pengutronix.de> <0aa51fabade743fbaac70a149a771f37e7d05165.camel@pengutronix.de> In-Reply-To: <0aa51fabade743fbaac70a149a771f37e7d05165.camel@pengutronix.de> From: Ulf Hansson Date: Tue, 11 May 2021 14:19:36 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] mmc: core: add support for disabling HS400 mode via DT To: Lucas Stach Cc: Chris Ruehl , Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_052014_472407_AE3AE3E6 X-CRM114-Status: GOOD ( 31.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 11 May 2021 at 13:54, Lucas Stach wrote: > > Hi Ulf, > > Am Dienstag, dem 11.05.2021 um 13:14 +0200 schrieb Ulf Hansson: > > + Chris Ruehl > > > > On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > > > > > From: Lucas Stach > > > > > > On some boards the data strobe line isn't wired up, rendering HS400 > > > support broken, even if both the controller and the eMMC claim to > > > support it. Allow to disable HS400 mode via DT. > > > > Before I review the series, I just wanted to highlight that quite > > recently we got a related series posted from Chris [1]. I made some > > comments, but he hasn't replied yet. > > > > In any case, if I understood it correctly, it looks like some > > controllers may support HS400 ES, but not HS200. Could that be the > > case here as well? Or is this a different problem? > > > > > That's not the issue I'm trying to solve here. HS400 modes, whether ES > nor not, require the data strobe line to work. ES mode just defines how > this line is used. I know for a fact that the board I'm dealing with > here, just hasn't wired up this line between the SoC and the eMMC. Thus > HS400 modes fail to work, even though both controller and eMMC support > this mode. > > When HS400 is disabled, like in this series, communication falls back > to HS200 mode and works fine this way. Alright, thanks for clarifying. I will look into the series soon. Kind regards Uffe > > Regards, > Lucas > > > Kind regards > > Uffe > > > > [1] > > https://patchwork.kernel.org/project/linux-mmc/patch/20201208061839.21163-7-chris.ruehl@gtsys.com.hk/ > > > > > > > > Signed-off-by: Lucas Stach > > > --- > > > v2: > > > - move to core > > > - actually disable all HS400 modes > > > --- > > > drivers/mmc/core/host.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > > index 9b89a91b6b47..0e066c5f5243 100644 > > > --- a/drivers/mmc/core/host.c > > > +++ b/drivers/mmc/core/host.c > > > @@ -351,6 +351,9 @@ int mmc_of_parse(struct mmc_host *host) > > > host->caps2 |= MMC_CAP2_NO_SD; > > > if (device_property_read_bool(dev, "no-mmc")) > > > host->caps2 |= MMC_CAP2_NO_MMC; > > > + if (device_property_read_bool(dev, "no-mmc-hs400")) > > > + host->caps2 &= ~(MMC_CAP2_HS400_1_8V | MMC_CAP2_HS400_1_2V | > > > + MMC_CAP2_HS400_ES); > > > > > > /* Must be after "non-removable" check */ > > > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > > > -- > > > 2.31.1 > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel