From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748AEC31E5E for ; Tue, 18 Jun 2019 11:56:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4430D2070B for ; Tue, 18 Jun 2019 11:56:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E17wjHyz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mo7//ZZm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4430D2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y3VLe8GDbxyan/Ad83lbpenV9RD5AMveewsCkdQ+MqU=; b=E17wjHyzP4uCuO TNLXLm9dXxdwS2P87qnNkJ+MiS3G7K8+Llnigy99TTd8GsuHbAQ+OkLdFl/zjYVKSAznkmTZenc38 U5XMisukb3BDMoYXNVQpJhjdpPS1gCQkdIlSWWdcctrXwL/s97imA34XMTWPfBjS0bh/KHQzlxv6R UX2AmWs+yRdjFRlyucF2Drphy+wtHPHQdWypEHKE4TMpVBaAfr2iba+fQCK8XF2BQaPpfCQX0gT2g Cjw1uRv1BrB2PXn6kGb5YNGxDae9TkbQzT46+HnEkCQd3un0xNaDCSKmrPU/ITG/IrGhNUWWA3fDT jCaVviT0DR46vyTuzNdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdCjM-0005wj-TP; Tue, 18 Jun 2019 11:56:52 +0000 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdCjK-0005vz-Jm for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 11:56:52 +0000 Received: by mail-ua1-x943.google.com with SMTP id j8so5625867uan.6 for ; Tue, 18 Jun 2019 04:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=piRTAebFx2FsROFm2zYcU51EDgaGKwKW/nF1spIt1sI=; b=mo7//ZZm5CR0ywBO0NeDMxPL71X9bJ2kFFt6G1IOlFmJ9ImsK53ikh7RHrkrW1cWy9 16iNhl4WpSQJUkAAbTw5KSaMvEgibjhRAeDdK923fBEpZYNAE20PQW/MvuGIVYjvr3Ly PGlsFZh24pJnk4p97S+BlQxGQ5YXakodnK0IFr1Bs6JN3UMFSZC7746dzX1JbDjIEtFl 5D7+lIshQcZUkRwA2eOa9jcmCy7QsLu2FCDfbDU8EzbL7pWXZADfQcDYZH0I6ds16AwR BbQa3geAipWWpwweByap68mRGunqBK9j3PxpS3+GHbGeM8wXH2f7fbKEAVQS0ldqg9eV IXAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=piRTAebFx2FsROFm2zYcU51EDgaGKwKW/nF1spIt1sI=; b=mbOZpKhQVHoc3YGAFbgt072iL90ZgFnnM/mWvPS+yM/sUyKjb9KKdbkyvg7y87204P PX9OrpTa5XhOcmKfxkPc26gBzoPoOEY8bXntlPsCSAIH8QCWD2l936JNakgGa8KdH2n5 kot6zWliCorUZmjyq8yEAKUaKd50Rzla6KejDjfC8mzAvi3VC/UO69KtYcG/b9cCPLal rEA0nv6JfDq7oVbDIwWdhYGx9pQzErW7q69FPI5HGy6lRFp5lX3fM555ITgCp/c3sKxC XA6UDaZwb1E2RwPEZjjz+mJyfmFtpTm0vEnETYHCsD16XMcRFyNKmiVViUiEbTlLJ/ZT F9ig== X-Gm-Message-State: APjAAAWtO8x0SLeCC5fvU3JAcGSCSU6h3veiIUuRLj+sxyd/Mg8EJZ62 GxUqKX95OdM5nr37YmJM2uYFSHPGxMdfyD3hgdo3zA== X-Google-Smtp-Source: APXvYqxWE7NU+QUzDoR4u6I5eIyinKhKJ2E54DPFNLSdMDWyWFZV8l2G2R1evmkcZ1mRW3Z8CNDF2/bizF6JGRucbC8= X-Received: by 2002:a67:3254:: with SMTP id y81mr24197966vsy.34.1560859009184; Tue, 18 Jun 2019 04:56:49 -0700 (PDT) MIME-Version: 1.0 References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190607154210.GJ15577@e107155-lin> <20190607193407.GB24059@builder> <20190610103225.GA26602@e107155-lin> <20190610171557.GA4560@redmoon> In-Reply-To: From: Ulf Hansson Date: Tue, 18 Jun 2019 13:56:13 +0200 Message-ID: Subject: Re: [PATCH 00/18] ARM/ARM64: Support hierarchical CPU arrangement for PSCI To: Lorenzo Pieralisi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_045650_686685_30FF1BF2 X-CRM114-Status: GOOD ( 24.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Linux Kernel Mailing List , Geert Uytterhoeven , "Rafael J. Wysocki" , Stephen Boyd , Viresh Kumar , Linux PM , Daniel Lezcano , "Rafael J . Wysocki" , Kevin Hilman , Amit Kucheria , Bjorn Andersson , Tony Lindgren , linux-arm-msm , Lina Iyer , Sudeep Holla , Niklas Cassel , Souvik Chakravarty , "Raju P . L . S . S . S . N" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 Jun 2019 at 20:57, Ulf Hansson wrote: > > On Mon, 10 Jun 2019 at 19:16, Lorenzo Pieralisi > wrote: > > > > On Mon, Jun 10, 2019 at 05:54:39PM +0200, Ulf Hansson wrote: > > > > [...] > > > > > My summary from the earlier ones, is that because the PSCI spec > > > includes support for OSI, we should also support it in the kernel (and > > > ATF). In a discussion offlist, Lorenzo agreed that it's okay to add, > > > without an apple to apple comparison. Maybe Lorenzo can fill in and > > > state this publicly, to save us all some time? > > > > The comparison should have been made before even requesting PSCI OSI > > mode changes to the specifications, so we have a chip on our shoulders > > anyway. > > > > We will enable PSCI OSI but that's not where the problem lies, enabling > > PSCI OSI from a firmware perspective should take 10 lines of code, > > not: > > Thanks for confirming! > > > > > drivers/firmware/psci/Makefile | 2 +- > > drivers/firmware/psci/psci.c | 219 ++++++++-- > > drivers/firmware/psci/psci.h | 29 ++ > > drivers/firmware/psci/psci_pm_domain.c | 403 ++++++++++++++++++ > > > > I have some concerns about these changes that I will state in the > > relevant patches. > > Most of the above changes isn't for solely for OSI, but to support a > hierarchical topology described in the PSCI DT layout. This is for > example needed when other resources shares the same power rail as the > CPU cluster. > > In other words, the series is orthogonal to whether OSI or PC mode is > used for PSCI, just to make that clear. BTW, this is what you > requested me to change into, a while ago. > > > > > > My final point in regards to the OSI mode support, it's a minor part > > > of the series. I don't see how that should hurt from a maintenance > > > point of view, or perhaps I am wrong? In any case, I offer my help > > > with review/maintenance in any form as you may see need/fit. > > > > I will go through the series but most of this code should move > > to core PM code, it has nothing to do with PSCI. > > I am looking forward to your review - and for sure, I am open to suggestions! > > > > > BTW, apologies for the delay, I was away. Lorenzo, a gentle ping. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel