From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2D5C47083 for ; Wed, 2 Jun 2021 13:19:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82ED26023D for ; Wed, 2 Jun 2021 13:19:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82ED26023D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zqH7cZiyoTFmERkV4VRwukyy32Hm8A70gxN/M0jOA2k=; b=mP0YeVinV9vc9T E2dYMTVUbttGCsaFcGhcLAS2QTYaSA4O1UOYCSHlCx8ZJGTzqFrbz9yyBiUPNNa+INle8sp9vTrBe uNVhk6ftM93yylknGiyzGBd2aEvNF2pqCig689oiIAMt1VizxSpyreHGD+kvlV/Tx1ZjkqaW+NXi3 6n1voys13dm/uiXS/mphRmmrjNY/fVYzGDVm4N8BBSEy2zi6UgK5X4sc6ueaZcr8Hzvh+0q75NN8+ 5SnGYlH9rEk82ex7V0i9caB7pUvk0nDhPtIiqCuQKzuEwTETiSbp9HmmOABROuph+jllOBZ/VJlxl rXsAZc4OGo6QVzcXq2ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loQkz-004KKL-Mk; Wed, 02 Jun 2021 13:18:01 +0000 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loQkt-004KJ2-2E for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 13:17:58 +0000 Received: by mail-ua1-x930.google.com with SMTP id q10so1267885uam.3 for ; Wed, 02 Jun 2021 06:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uH5yxU+BzRF90wWQwBO4VM5milL3akGJBti5j4uOIZE=; b=s6OLJzCVfowSoFK+Kn+Dhlq9dbdZvw299TRcMkIdw5Yuw3QzvKXt83rm00ZYmdAzHh /1dzY+TZZYI7BxQvrF0FDyUZF9EMiKzASt4L13dLl6SCkUavqGGqBrk3O90KyRB0h+lE 5vqtpcRDiNuA4hyi2GEWpaPREnpTT8jFXAL3Ypr8EXcRsTLjM2LEkV+hLkRG4wNmfK+c hawPsG2yo23cDzABvRJQmn8X+GmEu9mJER+1cYC3lQAxQ/foh9xbWloSO7ggqM4k6Djv ehNToKgNW35e/8OEm0Hun2TjV2n0awAldfNx1NCqo7S6PU2Wlxzae8ooaKznyMLri193 rSiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uH5yxU+BzRF90wWQwBO4VM5milL3akGJBti5j4uOIZE=; b=dkGHJh3lrDz+KDdliaMsPr1P/pqdKhsiAWSTuwvVTI+9OPK18CfrCCvM4SBrZb2IXW BefhU/9eFYOH3TJotcMH874ggHLdKeqZ2pDY7Lew7SBMcsN6NKWnwRdGTDHzX+LfMVxm pdBxhGCps4cHoU0/ET4l1y2GgZoVs9idLqukYm86YJ25oSK7+lS47e9TNubLfzSteyrZ eFY5BpmCb1jFF/87piZX+mZDzm51P9AB7FyU3otg6yZWataS3ersNw3ZR7FZFJIH6f2S SaaAq0hyIRKs0OURC/MG3L0uMOslzsrnhkhaCsTowE3hIVR1iAiPFsxperTpts5H59co gzjA== X-Gm-Message-State: AOAM5336bINev5klyvB00ZPrJTfkYm6EFdJF3ihGrW5rQX1P9M23Ei16 ggA5JUzHs2lnqH/eBoAd/U57ketzer7IMCwER0+0mA== X-Google-Smtp-Source: ABdhPJyvipLZfILhu87oS/az2/HBFVuElK4GQ6Srx/B1cgHvOyXaym3QLEigUlS/OUkA08r+m8+miEhdsQUfZ9i5/94= X-Received: by 2002:ab0:100f:: with SMTP id f15mr21456136uab.100.1622639870335; Wed, 02 Jun 2021 06:17:50 -0700 (PDT) MIME-Version: 1.0 References: <20210602112321.2241566-1-anup.patel@wdc.com> <20210602112321.2241566-6-anup.patel@wdc.com> In-Reply-To: <20210602112321.2241566-6-anup.patel@wdc.com> From: Ulf Hansson Date: Wed, 2 Jun 2021 15:17:13 +0200 Message-ID: Subject: Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , Anup Patel , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_061755_176806_72005C9C X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2 Jun 2021 at 13:24, Anup Patel wrote: > > The generic power domain related code in PSCI domain driver is largely > independent of PSCI and can be shared with RISC-V SBI domain driver > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > Signed-off-by: Anup Patel Reviewed-by: Ulf Hansson A small nitpick below. [...] > +EXPORT_SYMBOL_GPL(dt_idle_pd_free); Do we really need to export this symbol? Looks like there are only built-in cpuidle drivers that are going to use it. At least for now. As a matter of fact, the same comment applies to all cases of EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them? [...] Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel