From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC54FC31E49 for ; Wed, 19 Jun 2019 14:41:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A529B21873 for ; Wed, 19 Jun 2019 14:41:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CMDwtAJd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="z50UkcJ9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A529B21873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2z/5+TZLKcLLMJlFYV88Zc8WzhzO+bsAAmSmKjL4yww=; b=CMDwtAJdKE2NOa FMpYiYdzu+rvi6rUUBE3zAyDNx9IumUvDEcazJo7ZreT+ufIq1XAtzw3inQ3hBQ1sMOdMIk/LaK+P ePHbRWq0VJ4jcfASuy3qPS7W3xsHMTLWSkF79XWI8Ci9bkKMUUOa9hfNrdn56bV1A/BQhf3LO2/6N /Q7uhZPiVXJmAqw+Ncuo8E0XgkGSfKFaINdrSMAIGh/Gmcs5E4kqw+WI4UUWbxg92TSe4kAGIJfok wyWI2msLwfd5cEhLN+/8KLdkdCW86dDs3FQBetPB+Cx3bp6zTsaiE8oUkY65kRbU0L4+fDBvYRzn/ U23gZ0UerGqe2wioRMcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdbm2-0007gC-3X; Wed, 19 Jun 2019 14:41:18 +0000 Received: from mail-ua1-x941.google.com ([2607:f8b0:4864:20::941]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdbly-0007et-7B for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 14:41:16 +0000 Received: by mail-ua1-x941.google.com with SMTP id 8so10042935uaz.11 for ; Wed, 19 Jun 2019 07:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OuL65TuVUonkfDYC+yc+qXGA89Xa2MqrM+C9nMr53yk=; b=z50UkcJ9gf1Qmb0DTS3m0F60LXoKl9Uj4ZE8Y69bTITcVx9kxGwD+yUakZDgenUpMM MiLeZcvrSH41/V/cUogSecHNER0CvlIhvkiHNy5EJfw26PP0BzvukiV/lUlbZwUKN1In ueCcx0vPNC99LiCjH2KzgxVVXbor3azuonwTyx42gSTn7BQS+ALSzjZln+iIwctYArf4 3PRJSa5Dp8WSlmBfV833+QccgrJMI9y5SZ8VmxWswoUCIlYbonz8KYJeQkUn6dxgz9Fl CYuWXwN2IGOrGGpCkJQIqsLEV/9T5TYERWJuRM5ICOL/hkav+FCiKs++ovFs8Mxev8Qs /U0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OuL65TuVUonkfDYC+yc+qXGA89Xa2MqrM+C9nMr53yk=; b=PqnKvAwzak8gea1x+5TekB0m8nHrTqwsd8TPnakl9QJWPq+KIuBpF/C3m5Y//PtLS4 MjWmLW3znTaueEVr1zK/vhQ+SS+vIipHDTwylqoWLWAjqIce//4jmqYjf/iIeDpbDz6Q ezVYkMwv9BwDGCeeBro7CxAm7j0gEaN5e3tHjfadZM+I4tnvbscYdnUizibmAmBF2YBT UZBJ/RNzSmc4h7XSRqVt0EmEDPYZ+N/1D0yeV+oFR4OMoPOOTUsE/ekok8EjrjGhAbiU JfQL+TVsT7bW1Q0cQyIjavya/FaYn6JuNN8JFgdnkeJFUTAASU7JVJ5Dz973OYGUmQh1 u67A== X-Gm-Message-State: APjAAAX+42ClYfK2Sp2K4+0d5y7NGN+2pHewkibylm/5fpSGEyC4SMgp HquzOgKp7BheVwvjHZC3MlTQpomY26hi+AUD4LlMkw== X-Google-Smtp-Source: APXvYqxiOhYGOm5J4KhiAdkkQECEzQdtrbEE+lhxjuEjI6r6F96s8L3Sc7YMCWr6KJmrx0p+YMydPuX3sCUGg9bvjMI= X-Received: by 2002:a9f:31a2:: with SMTP id v31mr14379202uad.15.1560955272797; Wed, 19 Jun 2019 07:41:12 -0700 (PDT) MIME-Version: 1.0 References: <1560247011-26369-1-git-send-email-manish.narani@xilinx.com> <1560247011-26369-4-git-send-email-manish.narani@xilinx.com> <5feac3fb-bef3-b7d1-57d6-81e115e1f555@xilinx.com> <948514a0-e310-75fd-e8a8-6ef8bb14e41f@xilinx.com> In-Reply-To: From: Ulf Hansson Date: Wed, 19 Jun 2019 16:40:36 +0200 Message-ID: Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup To: Manish Narani X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_074114_259051_8CB1E891 X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Nava kishore Manne , "linux-mmc@vger.kernel.org" , Adrian Hunter , Linux Kernel Mailing List , Jolly Shah , Rajan Vaja , Rob Herring , Michal Simek , Olof Johansson , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jun 2019 at 06:59, Manish Narani wrote: > > Hi Uffe, > > Thanks for the review. Please find my comments below. > > > -----Original Message----- > > From: Ulf Hansson > > Sent: Monday, June 17, 2019 8:29 PM > > To: Michal Simek > > Cc: Manish Narani ; Rob Herring > > ; Mark Rutland ; Adrian > > Hunter ; Rajan Vaja ; Jolly > > Shah ; Nava kishore Manne ; Olof > > Johansson ; linux-mmc@vger.kernel.org; DTML > > ; Linux Kernel Mailing List > kernel@vger.kernel.org>; Linux ARM > > Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP > > Platform Tap Delays Setup > > > > [...] > > > > > >> > > > >> > > > >>> In regards to the mmc data part, I suggest to drop the > > > >>> ->set_tap_delay() callback, but rather use a boolean flag to indicate > > > >>> whether clock phases needs to be changed for the variant. Potentially > > > >>> that could even be skipped and instead call clk_set_phase() > > > >>> unconditionally, as the clock core deals fine with clock providers > > > >>> that doesn't support the ->set_phase() callback. > > In the current implementation, I am taking care of both the input and > output clock delays with the single clock (which is output clock) registration > and differentiating these tap delays based on their values > (<256 then input delay and >= 256 then output delay), because that is > zynqmp specific. If we want to make this generic, we may need to > register 'another' clock which will be there as an input (sampling) clock > and then we can make this 'clk_set_phase()' be called unconditionally > each for both the clocks and let the platforms handle their clock part. > What's your take on this? Not sure exactly what you are suggesting, but my gut feeling says it sounds good. How is tap delays managed for both the input clock and the output clock? Is some managed by the clock provider (which is probably firmware in your case) and some managed by the MMC controller? [...] Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel