From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E64C32771 for ; Mon, 27 Jan 2020 07:55:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB0D82071E for ; Mon, 27 Jan 2020 07:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="APqVD2Xg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kSO/uE+4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB0D82071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ATeGZmY5qLXTYDXsHJb3XS8Hxpql7gAHrn0e/e8flME=; b=APqVD2Xg34SciD FFZeU+F87ttvkNMeLtZq//wXXs4IuqCELY0IK3yB5m36AfY7PSupGABXdaqVZ/Bqdf3+2T5AEPngi rxnU46wx/4vMBVrmeq6pExnf6Uqaslbp1O4Tj2ZXh+V6NjbvQ4xZ0FGpbcVsjGZyM3OvULb/8Yl/w 7iaY9QHqAFRz8yjONde/5utc7ZR2+U9OKNEdGkV61UyvMOjeDLzwvU7akjVUT/py430rUMNAM/SGr An6+eBQ+alp+JZjSuIZYdc4Sw2sbXIo8Yx3FLpGGLejk11yu3HtLRqb2p4bS9awVO4F4mheBquf19 +9vvhOfksCt1hK+h2d3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ivzFO-00022H-B8; Mon, 27 Jan 2020 07:55:50 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ivzFM-00021e-5Z for linux-arm-kernel@lists.infradead.org; Mon, 27 Jan 2020 07:55:49 +0000 Received: by mail-vs1-xe44.google.com with SMTP id p6so5024376vsj.11 for ; Sun, 26 Jan 2020 23:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JisW5FdHqDfpueRuACrKxki3mS2+DqkIGJ6tqvYKBYg=; b=kSO/uE+41usEvH7ebSjUhk6e1/GR1kdSgxZbiRxsCAhlZoPKgznwup/h/2aiurqXba seFxgj3oUfrgEWcKa+G614+LeCAaTNBjCdbjJPXw0HZTQ7jIJIx56MVRyj5idy2Njihw 1lvg7u/sCsRI9lQAUgiE+1pj3eYt3mM8RKqpvOqGY4GoQ8WpnDC8loBTB3RIAdXpJd1t uvhGn77x1mkhssxugQBP4QZX/BGJNtXHXbfds528PcECqhauXzE+uRrC+XgHw3VmoWxm cfiAWEvIJOhatU7LA2qPT3/WwEw8MlcDjWSC/qZE6TC9IgUl8qSgQSK+hpv1LKGzU+vi 04YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JisW5FdHqDfpueRuACrKxki3mS2+DqkIGJ6tqvYKBYg=; b=h0XwAZXU6+EgX/4vdn1wP7UgpcUtmlrCe09hj8kgyTbMeszg1EuHhfrdrya3o9gTqG 49I5+ZY6dn7wPkG5wptUAfpWX81DJytqERrbka+HU53aCzZbXFhkODwmCyELfTQO7P6Z j7ZNepeBEsZ0od33GONbIIVQ24UCgwf33jdqKqjickGdq0yg4YYRtaAuk2mF7fSACQmI 638+6I6EWb9UIhNTLosqFKwXI6a4ZNIG5UvIv5gZT7aXN/JmuvM4o8PQM0bOYBmevqLc 9XFBycruzmC6RZCThFb2stgrHJFsi9nnu/L9C21MRyyA1xlEtqIUmXkoi6NXXBRt1VyW a6/Q== X-Gm-Message-State: APjAAAX6EmgiOkbwXJkxSaxSrgf0B6U4AFADIjnXCznbKI4Frb6x/orI WCJEpt/kCi+dW9MxrTEdWGc0GXSWHtHfFr2kENgVYg== X-Google-Smtp-Source: APXvYqyL1TCg49AaeGX4CVUErd9kezem7knF5p9I+JWV1m4AIpmUm9yBXdiHxcp8rC0t9W4QBLYziKJLuXWuYii+iQs= X-Received: by 2002:a67:ee02:: with SMTP id f2mr584267vsp.165.1580111746386; Sun, 26 Jan 2020 23:55:46 -0800 (PST) MIME-Version: 1.0 References: <20200108052337.65916-1-drinkcat@chromium.org> <20200108052337.65916-6-drinkcat@chromium.org> In-Reply-To: From: Ulf Hansson Date: Mon, 27 Jan 2020 08:55:10 +0100 Message-ID: Subject: Re: [PATCH v2 5/7] drm/panfrost: Add support for multiple power domain support To: Nicolas Boichat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200126_235548_206184_F5CD4EF6 X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , Tomeu Vizoso , Liam Girdwood , David Airlie , Mark Brown , lkml , dri-devel , Steven Price , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 10 Jan 2020 at 02:53, Nicolas Boichat wrote: > > +Ulf to keep me honest on the power domains > > On Thu, Jan 9, 2020 at 10:08 PM Steven Price wrote: > > > > On 08/01/2020 05:23, Nicolas Boichat wrote: > > > When there is a single power domain per device, the core will > > > ensure the power domains are all switched on. > > > > > > However, when there are multiple ones, as in MT8183 Bifrost GPU, > > > we need to handle them in driver code. > > > > > > > > > Signed-off-by: Nicolas Boichat > > > --- > > > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > > additional devices in device tree to accomodate for this [1], but > > > I believe this solution is cleaner. > > > > I'm not sure what is best, but it seems odd to encode this into the Panfrost driver itself - it doesn't have any knowledge of what to do with these power domains. The naming of the domains looks suspiciously like someone thought that e.g. only half of the cores could be powered, but it doesn't look like that was implemented in the chromeos driver linked and anyway that is *meant* to be automatic in the hardware! (I.e. if you only power up one cores in one core stack then the PDC should only enable the power domain for that set of cores). > > This is actually implemented in the Chrome OS driver [1]. IMHO power > domains are a bit confusing [2]: > i. If there's only 1 power domain in the device, then the core takes > care of power on the domain (based on pm_runtime) > ii. If there's more than 1 power domain, then the device needs to > link the domains manually. > > So the Chrome OS [1] driver takes approach (i), by creating 3 devices, > each with 1 power domain that is switched on/off automatically using > pm_runtime. > > This patch takes approach (ii) with device links to handle the extra domains. > > I believe the latter is more upstream-friendly, but, as always, > suggestions welcome. Apologies for the late reply. A few comments below. If the device is partitioned across multiple PM domains (it may need several power rails), then that should be described with the "multi PM domain" approach in the DTS. As in (ii). Using "device links" is however optional, as it may depend on the use case. If all multiple PM domains needs to be powered on/off together, then it's certainly recommended to use device links. However, if the PM domains can be powered on/off independently (one can be on while another is off), then it's probably easier to operate directly with runtime PM, on the returned struct *device from dev_pm_domain_attach_by_id(). Also note, there is dev_pm_domain_attach_by_name(), which allows us to specify a name for the PM domain in the DTS, rather than using an index. This may be more future proof to use. [...] Hope this helps. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel