Re: [PATCH 0/9] drivers: mmc: Update trivial tasklet_init() callers

From: Ulf Hansson <ulf.hansson@linaro.org>
To: Emil Renner Berthing <kernel@esmil.dk>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Alex Dubov <oakad@yahoo.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Bruce Chang <brucechang@via.com.tw>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Ben Dooks <ben-linux@fluff.org>,
	Manuel Lauss <manuel.lauss@gmail.com>,
	Pierre Ossman <pierre@ossman.eu>,
	linux-omap <linux-omap@vger.kernel.org>,
	Harald Welte <HaraldWelte@viatech.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/9] drivers: mmc: Update trivial tasklet_init() callers
Date: Mon, 8 Feb 2021 13:07:00 +0100	[thread overview]
Message-ID: <CAPDyKFrFPWu-mb+krWBYAC=DPpWDqYDseACRRFHyscKbG7yHaA@mail.gmail.com> (raw)
In-Reply-To: <20210204151847.91353-1-kernel@esmil.dk>

On Thu, 4 Feb 2021 at 16:19, Emil Renner Berthing <kernel@esmil.dk> wrote:
>
> This updates callers of tasklet_init() in drivers/mmc to the new API
> in commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
>
> All changes are made by coccinelle using the following semantic patch:
>
> @ match @
> type T;
> T *container;
> identifier tasklet;
> identifier callback;
> @@
>         tasklet_init(&container->tasklet, callback, (unsigned long)container);
>
> @ patch1 depends on match @
> type match.T;
> identifier match.tasklet;
> identifier match.callback;
> identifier data;
> identifier container;
> @@
> -void callback(unsigned long data)
> +void callback(struct tasklet_struct *t)
> {
>         ...
> -       T *container = \( (T *)data \| (void *)data \);
> +       T *container = from_tasklet(container, t, tasklet);
>         ...
> }
>
> @ patch2 depends on match @
> type match.T;
> identifier match.tasklet;
> identifier match.callback;
> identifier data;
> identifier container;
> @@
> -void callback(unsigned long data)
> +void callback(struct tasklet_struct *t)
> {
>         ...
> -       T *container;
> +       T *container = from_tasklet(container, t, tasklet);
>         ...
> -       container = \( (T *)data \| (void *)data \);
>         ...
> }
>
> @ depends on (patch1 || patch2) @
> match.T *container;
> identifier match.tasklet;
> identifier match.callback;
> @@
> -       tasklet_init(&container->tasklet, callback, (unsigned long)container);
> +       tasklet_setup(&container->tasklet, callback);
>
>
> Emil Renner Berthing (9):
>   mmc: atmel-mci: Use new tasklet API
>   mmc: au1xmmc: Use new tasklet API
>   mmc: dw_mmc: Use new tasklet API
>   mmc: omap: Use new tasklet API
>   mmc: s3cmci: Use new tasklet API
>   mmc: tifm_sd: Use new tasklet API
>   mmc: uniphier-sd: Use new tasklet API
>   mmc: via-sdmmc: Use new tasklet API
>   mmc: wbsd: Use new tasklet API
>
>  drivers/mmc/host/atmel-mci.c   |  6 +++---
>  drivers/mmc/host/au1xmmc.c     | 14 ++++++--------
>  drivers/mmc/host/dw_mmc.c      |  6 +++---
>  drivers/mmc/host/omap.c        |  7 +++----
>  drivers/mmc/host/s3cmci.c      |  6 +++---
>  drivers/mmc/host/tifm_sd.c     |  7 +++----
>  drivers/mmc/host/uniphier-sd.c | 14 ++++++--------
>  drivers/mmc/host/via-sdmmc.c   |  9 +++------
>  drivers/mmc/host/wbsd.c        | 35 +++++++++++++++-------------------
>  9 files changed, 45 insertions(+), 59 deletions(-)
>

Applied for next, thanks!

Kind regards
Uffe

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel