From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA995C54EE9 for ; Tue, 27 Sep 2022 12:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EIvx1/LNOfCoNz1lTFVa8x5Ky+CVTZjRDfn/YSTNQWY=; b=eagXjyd0RWTOjP Nqdaxp7eVX2BkXf2H1nglLS4a+iHcu017o9yXCgDt++mpRnXt2S9Z5SKm5e21bF73Zs7+IlJOCNys ItCFPnnxzDo32GpA4aLR8zCo+F7BXkxSsAQG5FzBLu5svYRUJXpq+wS30ioQaMZe9UDbnV49gzro/ 52Vc/QgIMOtjtoZt2PB+wFHfdqvhaShdYXZlI9vef+XOOw9QPoqNtqNSYEph54yicDU7ZglXY1Mpw 2W0PR1RaGcIscc196Jl+BCh68dkyJ0oqgGwbkBqN1UR6X40w8Vkb67neKM4av95Gh/haf1MOs3t5e /VFNpJp9EGyTDyUzuhSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1od9U2-00AQzb-92; Tue, 27 Sep 2022 12:14:42 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1od9Tz-00AQtg-7o for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 12:14:40 +0000 Received: by mail-wm1-x32f.google.com with SMTP id n35-20020a05600c502300b003b4924c6868so727334wmr.1 for ; Tue, 27 Sep 2022 05:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=VNMJ8dAUFpnWH5my97l4aBgOKeowx7PWc9A+8a4PR10=; b=Opaisrf0YyM9ixDUEygxXwqhLUcxRIYHwPrAdD1EsngI+gSnI/P5zTxmU4bHQwEbZ8 mLS0ZeKunZyelGY7r82jc+c5L3r/JpLt8UQpXsMKRmpz5Pz2xtF+J8jjul5+9LnuS92y 9cO+ajXsttOxz6Qyg3KHTsGYzFnpF84e9Jgo3zX63DixeXqh8pwgY67PmOvHafSrJixr D+mGcn1nE1vTyE4IQ0J8ipqVDJDMOsusEDI+X83E2+//Hnt8lp5exKgzO+Fwqki9Obev NMj8LPhCmysizM4Y+L3j8Zh1R462w6ohWMR5FQU626vJckfUGFcOznxcydQY/ogLDdnF akAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=VNMJ8dAUFpnWH5my97l4aBgOKeowx7PWc9A+8a4PR10=; b=mp2EiewZD9Gg8p/QmTuIa/NLAnREgEJvgIZnyJblGZCCefRbjbGpUktYhOGN54IOIb UGjsiDLReEUYpFe8GWJK/NuUg/XcAxbQqzyibP+1x9aNIxS8JEfOO34XX0UcXTf3Bnyk THGeO2b/zTF+qPDYAg5culxFoAf47IpjFj8w4xp2tY544erQKF64kd4KZWWTt5QaZw5X x/z6n2XKhmub0+wWjBkGaWqcsdr9ZSHMgeVFtykleN42TfALo0AKmtwxd1Z91zztNvm6 WtOhpTt2DcazHZTrIQB6fVMrA9Jlu/I+OB3+JElPO1KmIdp6oZgy+D+Nb+bQqFlx/vIN firQ== X-Gm-Message-State: ACrzQf3UUbDyuHBV7IJ51Y7DJDRuqSgTtGBYPJeUo7q61BAPdFgBlFJr pO98txr7wc8hUVcQsDoFdKX6H0OnJH3taQh3ZwGwqg== X-Google-Smtp-Source: AMsMyM5xwt8GtZ5GqRGo+ZWthPbEfmJgCcSjohJZ+6LcAxXTNx9DpuzY2FpP0asC0lryGBBctHMQcUWoC+0O6+WUrgk= X-Received: by 2002:a05:600c:4f8d:b0:3b4:9f2f:4311 with SMTP id n13-20020a05600c4f8d00b003b49f2f4311mr2366068wmq.17.1664280855969; Tue, 27 Sep 2022 05:14:15 -0700 (PDT) MIME-Version: 1.0 References: <53fc6ffa5d1c428fefeae7d313cf4a669c3a1e98.1663873255.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <53fc6ffa5d1c428fefeae7d313cf4a669c3a1e98.1663873255.git.christophe.jaillet@wanadoo.fr> From: Ulf Hansson Date: Tue, 27 Sep 2022 14:13:39 +0200 Message-ID: Subject: Re: [PATCH v2] mmc: wmt-sdmmc: Fix an error handling path in wmt_mci_probe() To: Christophe JAILLET Cc: cjb@laptop.org, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_051439_296038_642F8F3C X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 22 Sept 2022 at 21:06, Christophe JAILLET wrote: > > A dma_free_coherent() call is missing in the error handling path of the > probe, as already done in the remove function. > > Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650") > Signed-off-by: Christophe JAILLET Applied for next, thanks! Kind regards Uffe > --- > Changes since v1: > * Add and use the (ugly named) 'fail5_and_a_half' label [Dan Carpenter ] > > v1: https://lore.kernel.org/all/bf2e2e69226b20d173cce66287f59488fd47474b.1646588375.git.christophe.jaillet@wanadoo.fr/ > --- > drivers/mmc/host/wmt-sdmmc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c > index 163ac9df8cca..9b5c503e3a3f 100644 > --- a/drivers/mmc/host/wmt-sdmmc.c > +++ b/drivers/mmc/host/wmt-sdmmc.c > @@ -846,7 +846,7 @@ static int wmt_mci_probe(struct platform_device *pdev) > if (IS_ERR(priv->clk_sdmmc)) { > dev_err(&pdev->dev, "Error getting clock\n"); > ret = PTR_ERR(priv->clk_sdmmc); > - goto fail5; > + goto fail5_and_a_half; > } > > ret = clk_prepare_enable(priv->clk_sdmmc); > @@ -863,6 +863,9 @@ static int wmt_mci_probe(struct platform_device *pdev) > return 0; > fail6: > clk_put(priv->clk_sdmmc); > +fail5_and_a_half: > + dma_free_coherent(&pdev->dev, mmc->max_blk_count * 16, > + priv->dma_desc_buffer, priv->dma_desc_device_addr); > fail5: > free_irq(dma_irq, priv); > fail4: > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel