From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 284AEC8B4E3 for ; Mon, 16 Nov 2020 12:41:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C65CC20855 for ; Mon, 16 Nov 2020 12:41:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Txw3SWY/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jVRee76x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C65CC20855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=al8upW25ZECfiNHX08YDNNCbWSk/mlkVUPw0H1E7MOI=; b=Txw3SWY/uIt3wmuFIgPh0p2b2 UBi0F7WY/jCk0XI+GIHhbX4Npb2QN9/bIO5CIGC4PDVw+AtrUxz2DNgX7MogFI5BekAGq/HwB52w3 3GlVp2BRqmvXGPZXTuRPrPKj5iurnwmuw5E/gDYC+Efl8rDGRVO1XVbW7PYSyqanyEN+dcOKIqp7C GqPGN+WVVkh1Dqo2BVJcDUnQBjK2E2l7dwizDPMRET1igufFHMh2IOdZ8MQczns08o3Wob1tDrll3 gBXGXUwjYx9LUJxq9+WrbbBoqItnAVecN/9XGdTHInNFNitEPmnq4DjBP4VNc/wt1lsJk520LO5ZE XiZI/XkDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kectO-0001nH-0K; Mon, 16 Nov 2020 11:41:54 +0000 Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kectK-0001mQ-Sr for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 11:41:52 +0000 Received: by mail-vk1-xa43.google.com with SMTP id e8so3637692vkk.8 for ; Mon, 16 Nov 2020 03:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2lOdbwlpCkQ/U9b3AI8byk39FYQ+zSfYd4xMBl2NASE=; b=jVRee76xd/vj7nXCbI+BMQETz21ek9rOn5KYwlEgY8rR7BwA15GOWS/WjjTQdHOr/L jUFPM9gMGsb2ja5/vP0MD6Cu1HL8aBPFeE7/sEEB1TBN94P7zs6yMRe8yAz5WYI32eT/ mxfxhgJHsKXS37zoW9tG03L2y8KDDQYANGkj4ipDQhWvU1IPXyPK2rwBrgc15JQFTYZm yEdQYbWcEdXbTVZ0upCd/wRj1ZmWWlPZcBLfx1Pt6kfV+iwitXgSftXc4VS8TwUV/yNf AEUNT12cbenYntn9bjKSjVCVwFHH7wS6NVXt0cx+djYtAjiu4PPC3oc1TAWMOzcVOGCe gjbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2lOdbwlpCkQ/U9b3AI8byk39FYQ+zSfYd4xMBl2NASE=; b=mRT2uXi26AXt6ooWJt3KnSIIykFm/e5EFz5VgDpm+1VxsgUuaLgvt66ImlpcIB9joO YUuhlXWmvmPMJg3mDMUe9mMR99hstJ0S6T8qt4Mv1g1411C4tTz+ow9dmWB/Kz+2ul8e 0D6R7nHs0AQYnGO0X/VeaMWGDJBYG4F77NModJnPXl0nOPmvho04X9UwfzboMon8/gnk T6x7p1QoYIkgury4ydy3l9ydMnx0B/YIT0+MOWFqKJ1GBNouO3h3L84CfrEOHlCi0HDw GyudVG5D1Y+PY4xpt2TtKkfpeMXFUdqIpTyXkwu7sr55hgeENhd8T1C7cvoPYl0K8lGA Ue9A== X-Gm-Message-State: AOAM532T+CPn5L3qFKPUR76aBhPerWxGrLgGV50vIkQ+t225nLE7azYX wHGmb2C9TRiXHbJR1L97ZLcUXCzxAuGAcV9lD7JBFg== X-Google-Smtp-Source: ABdhPJyF+H/3JuvG1rFtW0kdG+BQsvxK9WRDn/noF2Wj5TJ7U/U1fEbxZ4IGsVFZ+argIC1nTyuv7vbjE+bp1pyH1+Q= X-Received: by 2002:a1f:41cc:: with SMTP id o195mr6992899vka.15.1605526904953; Mon, 16 Nov 2020 03:41:44 -0800 (PST) MIME-Version: 1.0 References: <20201106120933.7190-1-muhammad.husaini.zulkifli@intel.com> <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com> In-Reply-To: <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com> From: Ulf Hansson Date: Mon, 16 Nov 2020 12:41:08 +0100 Message-ID: Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC To: "Zulkifli, Muhammad Husaini" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_064151_227314_4782801D X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Wan Ahmad Zainie , "David E. Box" , Adrian Hunter , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 6 Nov 2020 at 05:10, wrote: > > From: Muhammad Husaini Zulkifli > > Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") > introduces platform specific SDHCI clock operation. > > This patch declares the clock operation for Keem Bay. > Add clk_ops for SD, EMMC and SDIO operations. The above commit message doesn't really tell why or what goes on here. Can please try to clarify that. > > Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay") Is $subject patch fixing a bug/regression? Kind regards Uffe > > Signed-off-by: Muhammad Husaini Zulkifli > Reviewed-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-of-arasan.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 829ccef87426..012d52e1abee 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data sdhci_arasan_versal_data = { > static struct sdhci_arasan_of_data intel_keembay_emmc_data = { > .soc_ctl_map = &intel_keembay_soc_ctl_map, > .pdata = &sdhci_keembay_emmc_pdata, > + .clk_ops = &arasan_clk_ops, > }; > > static struct sdhci_arasan_of_data intel_keembay_sd_data = { > .soc_ctl_map = &intel_keembay_soc_ctl_map, > .pdata = &sdhci_keembay_sd_pdata, > + .clk_ops = &arasan_clk_ops, > }; > > static struct sdhci_arasan_of_data intel_keembay_sdio_data = { > .soc_ctl_map = &intel_keembay_soc_ctl_map, > .pdata = &sdhci_keembay_sdio_pdata, > + .clk_ops = &arasan_clk_ops, > }; > > static const struct of_device_id sdhci_arasan_of_match[] = { > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel