From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E6DC11F68 for ; Tue, 29 Jun 2021 15:11:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E324D61DAD for ; Tue, 29 Jun 2021 15:11:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E324D61DAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wU2aC/qWyjpqP4y4yN7GXZIs6MFbXmtYSkHBlSjWosQ=; b=zG0DB1H6Vf5g7B qhjJnz7IxM7q0sL84kje4C0t8gT86UofLoKxP3KQtAtD5+ggcL6emn+QizhEVdwOtlXwyEwuMQYY/ g/K+8Qy/g3u9u7s/QkKop6xh5S7JkCAGsYZZFqIfFTIqOdQ/Qw2Z0ucI56W6xy7NZTwbx9C3MpuwQ U3NxXEmDj9zG4KErQl5uGh0x44Ijif9FCpVYYScD97e9fIqnVh1YYchAMmaFVg2PcPPcnB9TaeZvd wCmXIbPQ61gtSTaitKwW3zuInNPOsxuFfR5jREySiap41yYCbtLRfXgvAaFZvdf28Get73NR1NdXX yDFQ1VNjoK33Kekm/7vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyFMx-00BPlQ-0A; Tue, 29 Jun 2021 15:09:47 +0000 Received: from mail-ua1-x929.google.com ([2607:f8b0:4864:20::929]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyFMr-00BPjL-SP for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 15:09:43 +0000 Received: by mail-ua1-x929.google.com with SMTP id x37so4037956uac.13 for ; Tue, 29 Jun 2021 08:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LuyBMZGhtBgcRJwd1A74SaR7qMVubxg4OKYSD7bf0Rg=; b=TGHWWV8kcyBivyZX88cWdYDh6ISxpSSnB+a3I2IZObT877GfF5myGHJDavSsywsD/+ HRNudBk1MUSh5BxtRJ1ScnfRqOaOuhXBHdXG62OzrMB44GRE6P1JiknjAtVrJ4pZdj/i U5pXLro/rLS+ZY7yTlGCYle3qxXqCC9tPc4MXrPuipukj2QsFk68V37sCwZSf2hn+0J1 aKCbqF+sjF004LTaqivSO4eR3lo+h9VcydpASTFhp0b+bOVi84Wsx33m1aSAIudIK1xx 2rBMCcA0SsSfBjmlNB2BC67QUKQpheGAtnghLDKEJdOOrsg/Qq9BeURftGLO1HzvYeTT eBJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LuyBMZGhtBgcRJwd1A74SaR7qMVubxg4OKYSD7bf0Rg=; b=C9BTk8jcHRuscjcyGVnNahqjhaBtSB3ZLhPSKlQ7pj7h38tcS+5A30wshh8YUAR8X8 WTfQy6cwOwxkUO2XlxGBuriJbcYjXF1X0sX81Fwnl634IUK6vE4ruN9FhrMK4Pf1NCK1 3fuMIhcGKo1lG0FAM2mv2vh8JzmwpbIbh8lvzSQ+7wv3aPNK5h8lTWEq76JmW7KL4HTN KESUVA2hPWq25iHDaDlBtde//T5XDBYJhJYn1DNxZXUCCjaqPXHHyBgOeF3P2BCeIgIe TtEa6er1UGnVUNK1PxdzQmpkVTspyIsAPtTDjNdsdHhDW7jlhhtOHkz/QoKz1KrElXU7 kLJA== X-Gm-Message-State: AOAM533wzZXEvfApm/lxmFkw/b9gliiZm2u3msfA0nELnk9gIGtTo+Uz NG7vVoV5NaBgm17/mgS1/d2AGDHJmWaf2qNEaEM1Qw== X-Google-Smtp-Source: ABdhPJzVIVyqLzXURZxn0TF1D1Ma0QIbM2IQTwNlaEsIhbBauCsjME4JZOq/bDRZJCt6zyyzOdYNbQVJX7NZ4PfyH7M= X-Received: by 2002:ab0:484b:: with SMTP id c11mr27684290uad.100.1624979377958; Tue, 29 Jun 2021 08:09:37 -0700 (PDT) MIME-Version: 1.0 References: <1623726033-16073-1-git-send-email-wenbin.mei@mediatek.com> <1623726033-16073-2-git-send-email-wenbin.mei@mediatek.com> In-Reply-To: <1623726033-16073-2-git-send-email-wenbin.mei@mediatek.com> From: Ulf Hansson Date: Tue, 29 Jun 2021 17:09:01 +0200 Message-ID: Subject: Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP To: Wenbin Mei Cc: Rob Herring , Matthias Brugger , Chaotian Jing , Seiya Wang , linux-mmc , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , srv_heupstream X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210629_080941_963490_EDADFDE8 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Jun 2021 at 05:01, Wenbin Mei wrote: > > MT8195 mmc host IP is compatible with MT8183, and currently it shows: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which means the compatible string in the device tree would be: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc", > "mediatek,mt8183-mmc"; > The bindings is wrong and that isn't the result we want. > instead we want: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8183-mmc > - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which would give us: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; > and > compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc"; > > Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195) > Signed-off-by: Wenbin Mei Applied for fixes, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index 8648d48..adaba90 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -31,6 +31,8 @@ properties: > - const: mediatek,mt2701-mmc > - items: > - const: mediatek,mt8192-mmc > + - const: mediatek,mt8183-mmc > + - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > > -- > 1.9.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel