From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F172CC4338F for ; Tue, 10 Aug 2021 17:49:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7C7D6023E for ; Tue, 10 Aug 2021 17:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B7C7D6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B4StqfeZtRZZsw0OK8dCbYbvi/x8+PmJd9r6DhgDH4M=; b=mhmkZLG3S61Xs6 k66bpA3Ej+WE09Ja0padUR+d36ztLVd7hDru46V9qarSZfwWg3WiaB72Imjjs+IBkhvr8T5lEWge9 mZW7UStJbTLc3v2rrsJaS4N775uPUFcsJjxxwo8GGL9zz8rHmbX751I4OeIKLoa3IKkufQ1Aza2lB 6SQH5An32rSKRAYF2FlR2I3pQxLkMIrRV7rzmQfJQe2h57693lb7zXGGeJY+kqsoZW3U+bS4M1/ne O+sqRcCfDkhp9lXXfy9k/N1G+M0092JB2SAh8vLFTO4K2EeNePoAwR+62RFisaAozqcH3l3Sv1cP6 Aryv/TtBDmO2U3lk3WBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDVpr-004bOa-W7; Tue, 10 Aug 2021 17:46:44 +0000 Received: from mail-ua1-x935.google.com ([2607:f8b0:4864:20::935]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDVpl-004bMo-Eb for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 17:46:41 +0000 Received: by mail-ua1-x935.google.com with SMTP id x21so4960926uau.0 for ; Tue, 10 Aug 2021 10:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbcNgFPSz0OzHBe1xln1Cx0UEPJ7cJriNsAq1wTtQnw=; b=H+Vekug80X5FhOkWXXkYEuojkXWHJEiRBaYn563zxuzN1Johl2t/TYuXssgRh8OrKA 6mSCIsk+XTzfXs9+bKm3dJ9a+u3dhAWIYTd8voSBKku4TDM2TXLgnWnUn96JWaOMlRQm QNwtrbA9dTDZzhnyndKrrKn1k5J6J/tXo35xkNkRWF1wUpYp8IAbqIG63yDi6zWtKtXf m3/RGFU11f+6QV1/RFuLUWMeLuAxr/lGyU8zHS3llu5GRSovcF/CiipfG0E0i2vj0nuE Z2FFcicxjAdG9Zqa27m2ouBgP6tPulIf1L9JuBTJXjYjV3AKkhTLyuoAZc9reO+U6OC1 XFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbcNgFPSz0OzHBe1xln1Cx0UEPJ7cJriNsAq1wTtQnw=; b=pCOFMo+RSx/KRiLfhWOUGZFe4oDuD9MFDvoxUTlI2KLfYr3mXOqjyrjsmifdmbCz8D PncYDFoJWEWxxxJ8xRPnCGIsuXXYqF83OAbaqRKRS+QYmhPdik1fIoBECIDh65TYoicx CH9Ut8bPs0lA1VUyUG3GUx13DS6yOVpv0C0E8TBbkpiWmLUTE/sd4BS/mLgvgK5Jvdmi Ock+8TYPXcNmkW3PtPy/MfJ7aD0xfLLVQfr0FYPEcxVG0bWrehCv/ifUM4/5sYwV9Ir1 nEEgqyBUbiwuVoQwoyQGffCdvL5mtIRrRWigBtij4u0FyUNrUrMpXYYC0bwVDQ1jZ2EI 9aZQ== X-Gm-Message-State: AOAM533CjPg1WAcQK5OnNeltyebM6s06dBZcZlADKuprQuop/LOpI/S0 dMMJHxVfEB9mM3SMcta1lG7pahXFY3wxRhymf+OTUw== X-Google-Smtp-Source: ABdhPJwrntD4ZxsH49yI3TNZvnHaWoX7fDRJkA8qmkk+sGGy7WRMINFZ6iBBiTt80dVk9SmeEN7vvmqPVvEMxcbPBD0= X-Received: by 2002:ab0:6392:: with SMTP id y18mr22388136uao.139.1628617596264; Tue, 10 Aug 2021 10:46:36 -0700 (PDT) MIME-Version: 1.0 References: <20210810093145.26153-1-krzysztof.kozlowski@canonical.com> <20210810093145.26153-7-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210810093145.26153-7-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 10 Aug 2021 20:46:24 +0300 Message-ID: Subject: Re: [PATCH v2 6/8] dt-bindings: clock: samsung: convert Exynos AudSS to dtschema To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , linux-clk , devicetree , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_104637_668600_316D3CD0 X-CRM114-Status: GOOD ( 30.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 10 Aug 2021 at 12:32, Krzysztof Kozlowski wrote: > > Convert Samsung Exynos Audio SubSystem clock controller bindings to DT > schema format using json-schema. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/clock/clk-exynos-audss.txt | 103 ------------------ > .../clock/samsung,exynos-audss-clock.yaml | 79 ++++++++++++++ > 2 files changed, 79 insertions(+), 103 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/clk-exynos-audss.txt > create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynos-audss-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt b/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt > deleted file mode 100644 > index 6030afb10b5c..000000000000 > --- a/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt > +++ /dev/null > @@ -1,103 +0,0 @@ > -* Samsung Audio Subsystem Clock Controller > - > -The Samsung Audio Subsystem clock controller generates and supplies clocks > -to Audio Subsystem block available in the S5PV210 and Exynos SoCs. The clock > -binding described here is applicable to all SoCs in Exynos family. > - > -Required Properties: > - > -- compatible: should be one of the following: > - - "samsung,exynos4210-audss-clock" - controller compatible with all Exynos4 SoCs. > - - "samsung,exynos5250-audss-clock" - controller compatible with Exynos5250 > - SoCs. > - - "samsung,exynos5410-audss-clock" - controller compatible with Exynos5410 > - SoCs. > - - "samsung,exynos5420-audss-clock" - controller compatible with Exynos5420 > - SoCs. > -- reg: physical base address and length of the controller's register set. > - > -- #clock-cells: should be 1. > - > -- clocks: > - - pll_ref: Fixed rate PLL reference clock, parent of mout_audss. "fin_pll" > - is used if not specified. > - - pll_in: Input PLL to the AudioSS block, parent of mout_audss. "fout_epll" > - is used if not specified. > - - cdclk: External i2s clock, parent of mout_i2s. "cdclk0" is used if not > - specified. > - - sclk_audio: Audio bus clock, parent of mout_i2s. "sclk_audio0" is used if > - not specified. > - - sclk_pcm_in: PCM clock, parent of sclk_pcm. "sclk_pcm0" is used if not > - specified. > - > -- clock-names: Aliases for the above clocks. They should be "pll_ref", > - "pll_in", "cdclk", "sclk_audio", and "sclk_pcm_in" respectively. > - > -Optional Properties: > - > - - power-domains: a phandle to respective power domain node as described by > - generic PM domain bindings (see power/power_domain.txt for more > - information). > - > -The following is the list of clocks generated by the controller. Each clock is > -assigned an identifier and client nodes use this identifier to specify the > -clock which they consume. Some of the clocks are available only on a particular > -Exynos4 SoC and this is specified where applicable. > - > -Provided clocks: > - > -Clock ID SoC (if specific) > ------------------------------------------------ > - > -mout_audss 0 > -mout_i2s 1 > -dout_srp 2 > -dout_aud_bus 3 > -dout_i2s 4 > -srp_clk 5 > -i2s_bus 6 > -sclk_i2s 7 > -pcm_bus 8 > -sclk_pcm 9 > -adma 10 Exynos5420 > - > -Example 1: An example of a clock controller node using the default input > - clock names is listed below. > - > -clock_audss: audss-clock-controller@3810000 { > - compatible = "samsung,exynos5250-audss-clock"; > - reg = <0x03810000 0x0C>; > - #clock-cells = <1>; > -}; > - > -Example 2: An example of a clock controller node with the input clocks > - specified. > - > -clock_audss: audss-clock-controller@3810000 { > - compatible = "samsung,exynos5250-audss-clock"; > - reg = <0x03810000 0x0C>; > - #clock-cells = <1>; > - clocks = <&clock 1>, <&clock 7>, <&clock 138>, <&clock 160>, > - <&ext_i2s_clk>; > - clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in", "cdclk"; > -}; > - > -Example 3: I2S controller node that consumes the clock generated by the clock > - controller. Refer to the standard clock bindings for information > - about 'clocks' and 'clock-names' property. > - > -i2s0: i2s@3830000 { > - compatible = "samsung,i2s-v5"; > - reg = <0x03830000 0x100>; > - dmas = <&pdma0 10 > - &pdma0 9 > - &pdma0 8>; > - dma-names = "tx", "rx", "tx-sec"; > - clocks = <&clock_audss EXYNOS_I2S_BUS>, > - <&clock_audss EXYNOS_I2S_BUS>, > - <&clock_audss EXYNOS_SCLK_I2S>, > - <&clock_audss EXYNOS_MOUT_AUDSS>, > - <&clock_audss EXYNOS_MOUT_I2S>; > - clock-names = "iis", "i2s_opclk0", "i2s_opclk1", > - "mout_audss", "mout_i2s"; > -}; Seems like some examples and "Provided clocks" table were dropped in in yaml binding. Also there is no description for example present in yaml file. Is that some redundant info and was dropped intentionally? I'm just worrying about losing some useful info during the conversion. > diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos-audss-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos-audss-clock.yaml > new file mode 100644 > index 000000000000..d60b29fa22e7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/samsung,exynos-audss-clock.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/samsung,exynos-audss-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos SoC Audio SubSystem clock controller > + > +maintainers: > + - Chanwoo Choi > + - Krzysztof Kozlowski > + - Sylwester Nawrocki > + - Tomasz Figa > + > +description: | > + All available clocks are defined as preprocessor macros in > + include/dt-bindings/clock/exynos-audss-clk.h header. > + > +properties: > + compatible: > + enum: > + - samsung,exynos4210-audss-clock > + - samsung,exynos5250-audss-clock > + - samsung,exynos5410-audss-clock > + - samsung,exynos5420-audss-clock > + > + clocks: > + minItems: 2 > + items: > + - description: > + Fixed rate PLL reference clock, parent of mout_audss. "fin_pll" is > + used if not specified. > + - description: > + Input PLL to the AudioSS block, parent of mout_audss. "fout_epll" is > + used if not specified. > + - description: > + Audio bus clock, parent of mout_i2s. "sclk_audio0" is used if not > + specified. > + - description: > + PCM clock, parent of sclk_pcm. "sclk_pcm0" is used if not specified. > + - description: > + External i2s clock, parent of mout_i2s. "cdclk0" is used if not > + specified. > + > + clock-names: > + minItems: 2 > + items: > + - const: pll_ref > + - const: pll_in > + - const: sclk_audio > + - const: sclk_pcm_in > + - const: cdclk > + > + "#clock-cells": > + const: 1 > + > + power-domains: true > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - clocks > + - clock-names > + - "#clock-cells" > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + clock-controller@3810000 { > + compatible = "samsung,exynos5250-audss-clock"; > + reg = <0x03810000 0x0c>; > + #clock-cells = <1>; > + clocks = <&clock 1>, <&clock 7>, <&clock 138>, <&clock 160>, <&ext_i2s_clk>; > + clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in", "cdclk"; > + }; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel