From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71D7DC433EF for ; Tue, 7 Dec 2021 19:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QnyySi5RI8L4yZgvNHzO6ByG1oXM6sBSW82SpQG3l0k=; b=ZMuefpoDrJDq3c fmaWrelwxxjeVCHybaG2lei/lfIu9Kbyg3XV0st+ME4J4kad+GqKw8RK7ALL+aMbio3DiGpPJtD3m 1eOubvVbYUE67VN+bp53eveK+kmABJfgpxinZgbzBVADOF+X8WmMzo5jpiLgPfIow4N2FjNlxtMgZ cdR+E+hPkMpkkQvvKe6J4ro+nKKftfBSlc4PCPKDxnbHSj4hduIXKdFACbGpxME4rSjk6DDKlntEH HRveYoYsXfbrYDJuk+oYv2nhXEmid+/RDdp7dQv6FEd7vXEmQC+Wq0XimOg12jqr6DVYofDI86z9s JoQl42wwGud1sTgnW3Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mufi1-009rfP-Gm; Tue, 07 Dec 2021 19:01:01 +0000 Received: from mail-ua1-x92e.google.com ([2607:f8b0:4864:20::92e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mufhx-009rev-J0 for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 19:00:58 +0000 Received: by mail-ua1-x92e.google.com with SMTP id i6so299423uae.6 for ; Tue, 07 Dec 2021 11:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XUW31wASrpej0TIE+YgQ7k+2lttAbs6gSJFGK6RBLPs=; b=KotoaVRcY7w9F5qPYhg8uT5YU7vXM9Nap2d+E1Jj1bxEtOYIf9ruXQ2RAO0t2oh1Lx w1kS4gQlcV9cDX0SNOXlr102ieZAo7dWvX6DG4HYvRvBteqXn+BEqg240XGceQWaoTVE DCCPrFe/J/E5/oWvBD53iiUij4SwsK1uBtxB1d6Olh2xg74wAlivLavVKKltnXLE0SHT 1qUkOGdgwae3JKT9EC7iLcVsFbHX7Q3ZeyNwsEfuTFZYHsT6aDnQTw/qeOq7dzDcpSUo dzAscOhwDrMuPGwa/hjXZ2imTvQxdzS7Q4UvbKsiAh2ygvo0cIqjg3oztvLwmNrGuAbe TgDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XUW31wASrpej0TIE+YgQ7k+2lttAbs6gSJFGK6RBLPs=; b=vc3V53tg8krTrQENSClwnY/XSeuVSrd7alWYFDdpvUkKWFHqRii+/PUFABsGBDxi4H ZRrX0GW1JQ1IP9QBLffyRmwFfyfKOQsq31hhnXmjZi2+z4+9KSY25oS1Zu9eUc/E+MfC 8Z0T4rwzgIk/G7AXxhkNHOkoDeLT+VrXb1b1EjBZov3FFgGRoCJh/y8ULjVd1v9Q/9KM M7LQan4BzhE2T1s5Puf4ARkFox6doH9lEG6vLOrI+quAa1gv8cA8R+m6rz1Kimw3jmmH SrsmGSe34tMuY+L2aXfDBYauKVG2Ngt6VqhaOlfnb2FhZop1t5DXPAVMB/lLgAtrIF+k I4qg== X-Gm-Message-State: AOAM530v5+YcPqlSOpHk19gpRBDVzc4RW90ufLgFUYmW9GiHx/JoQ+/K IW7bIrYwyALit9S3IW8AKwYrd8dQoD5BJ3S7I+1TPg== X-Google-Smtp-Source: ABdhPJzv2fTwd3ja4cBNvXF6S3n5jGC34sPus7OnJwNyYndFTy2ncbXaEU8Qldo0qciKxLX0Ic5B597EeLxHxyLu55o= X-Received: by 2002:a67:3382:: with SMTP id z124mr46939269vsz.57.1638903656074; Tue, 07 Dec 2021 11:00:56 -0800 (PST) MIME-Version: 1.0 References: <20211206153124.427102-1-virag.david003@gmail.com> <20211206153124.427102-6-virag.david003@gmail.com> In-Reply-To: <20211206153124.427102-6-virag.david003@gmail.com> From: Sam Protsenko Date: Tue, 7 Dec 2021 21:00:44 +0200 Message-ID: Subject: Re: [PATCH v4 5/7] clk: samsung: clk-pll: Add support for pll1417x To: David Virag Cc: Krzysztof Kozlowski , Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_110057_655076_93DA3BB0 X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 6 Dec 2021 at 17:32, David Virag wrote: > > pll1417x is used in Exynos7885 SoC for top-level integer PLLs. > It is similar enough to pll0822x that practically the same code can > handle both. The difference that's to be noted is that when defining a > pl1417x PLL, the "con" parameter of the PLL macro should be set to the > CON1 register instead of CON3, like this: > > PLL(pll_1417x, CLK_FOUT_SHARED0_PLL, "fout_shared0_pll", "oscclk", > PLL_LOCKTIME_PLL_SHARED0, PLL_CON0_PLL_SHARED0, > NULL), > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: David Virag > --- > Changes in v2: > - Nothing > > Changes in v3: > - Nothing > > Changes in v4: > - Added R-b tag by Krzysztof Kozlowski > > drivers/clk/samsung/clk-pll.c | 1 + > drivers/clk/samsung/clk-pll.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c > index 83d1b03647db..70cdc87f714e 100644 > --- a/drivers/clk/samsung/clk-pll.c > +++ b/drivers/clk/samsung/clk-pll.c > @@ -1476,6 +1476,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx, > else > init.ops = &samsung_pll35xx_clk_ops; > break; > + case pll_1417x: I wonder why this switch have a bunch of fall through cases, but none marked with "fallthrough;" line, and both checkpatch and "make" turn blind eye on that? Anyway, I guess it's ok as is, just an observation. Reviewed-by: Sam Protsenko > case pll_0822x: > pll->enable_offs = PLL0822X_ENABLE_SHIFT; > pll->lock_offs = PLL0822X_LOCK_STAT_SHIFT; > diff --git a/drivers/clk/samsung/clk-pll.h b/drivers/clk/samsung/clk-pll.h > index a739f2b7ae80..c83a20195f6d 100644 > --- a/drivers/clk/samsung/clk-pll.h > +++ b/drivers/clk/samsung/clk-pll.h > @@ -32,6 +32,7 @@ enum samsung_pll_type { > pll_2550xx, > pll_2650x, > pll_2650xx, > + pll_1417x, > pll_1450x, > pll_1451x, > pll_1452x, > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel