From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89E9FC433F5 for ; Fri, 3 Dec 2021 18:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DDwpizEobrHPErH7FDWeX906MenxAqU9VSYSv+1mxts=; b=ypkH9CTVqfwuKA fWUpGzDTnOCceHxVgY+oFw4comop27YPOEviNJTRBT+MwOUY2KcDOsz08NILZV++U3owSvCWISzWU 2F06a6NOytaQ8d0KLRjmqvVtY1rWZVhuCh0oST8KDG4BZHiJOjQyiC6CS8VEK9MzJJTj+GnS9zZzU jO8AlQ7HOCPN2LQn08xZLP15ZmrVVxOp+3CHy5f5XXa0A3M/tFtbVrh/c9sMyxmZtsZ7IdA19zAKG gBtpit9GorOY6CCZGp6OBUGRN75StUPaI7kvbspn3xHauTqMKh5mLewV6c1kXGAvLRxfULhSDCRD0 Pn9KbB/oKRI4TJ3lB0aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtDTY-00Gmi6-95; Fri, 03 Dec 2021 18:40:04 +0000 Received: from mail-ua1-x933.google.com ([2607:f8b0:4864:20::933]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtDTT-00GmhT-09 for linux-arm-kernel@lists.infradead.org; Fri, 03 Dec 2021 18:40:00 +0000 Received: by mail-ua1-x933.google.com with SMTP id o1so7205484uap.4 for ; Fri, 03 Dec 2021 10:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b5p3ztxRNGHTryECHF1HMG/gYrhBfwJYEjUwDGuarzA=; b=F9+NXkfAn7qWTyNBpgH+F8s1jl70XfqRKv24CTx6q8kWm9ziIds9qi9GpCvPCRbEla P+oYUrVaWbQo0Um8iugAtOoiHU2lg2T17KCHt/tDMIlWbvExmWAyDl4Ilkr4hnfO5Cs/ T7+puOuC0ieEp+xllRPUwcQphG+2lYnQ43XjTtwOK1E6ie2WRXrWY2+pksimxZBW5x85 qFcLmzPR7v1Q3ffkcp7ycqRfWEJGMcrJDG0+d4ZOAFDnar26/IthG8pHajcR+FQGto2l Qho1y5EAVBnR5Kf5wbfgdoitWwB96YA2BViX+48hTCeBtE7K5GFgvzk3gMycOpagDPpx S1KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b5p3ztxRNGHTryECHF1HMG/gYrhBfwJYEjUwDGuarzA=; b=U+jGMBIA6y6kJLEKmzY8Bi27DdhNz7VkN5gFLHkl1gd4JBGL3pJrF5WifZhmwjWP9i Pml8WX2aTxi8N55wqB8g/Tsuph84e3Wg2J48zIaJnE7Jy1JP6xdOfeUSpvm/0Md5pna2 i/KKYPV04nUomHegESERUBzu+Cx8nLtClu8A7MWMgH9tzgaaRlrIgt4y8Gh/l+w5YxrY Uw7r7McVV8/eqj5E3ULNFYyrcIsrTQN2MTj8hwUYNLxAQgDGyq6FNiLKp9326E3biVVd gO6qTIyRG2m1Uw16qzlr5VJv4ySKE/OE8U3Rkp2w81nDNDVrY6F7qhD+AQlGMJ66pvUQ yyfA== X-Gm-Message-State: AOAM530c1LE1kmYCcc0VlyLPXmu08hxqbsfd5r9f1dZ7Fz7KlTVyan0n YQR81tA9Q7THKd6Y4K96UowLK8IGq5zyPcQXFCgtJg== X-Google-Smtp-Source: ABdhPJxoN0d+Ha4ydEmot87mUT0b4uygWp+/4MhofvqZsJysvO/S1XvMIB/hIYACy+ZMw6KdNYPl1P9orZjjE+00clM= X-Received: by 2002:a9f:2431:: with SMTP id 46mr23233053uaq.114.1638556797916; Fri, 03 Dec 2021 10:39:57 -0800 (PST) MIME-Version: 1.0 References: <20211130111325.29328-1-semen.protsenko@linaro.org> <20211130111325.29328-2-semen.protsenko@linaro.org> <1638294184.179325.2713642.nullmailer@robh.at.kernel.org> <4b5bebb0-ed74-8132-1e6b-cb7cbc21439c@canonical.com> In-Reply-To: From: Sam Protsenko Date: Fri, 3 Dec 2021 20:39:46 +0200 Message-ID: Subject: Re: [PATCH v2 RESEND 1/5] dt-bindings: soc: samsung: Add Exynos USI bindings To: Rob Herring Cc: Krzysztof Kozlowski , Jiri Slaby , linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman , Chanho Park , linux-serial@vger.kernel.org, Youngmin Nam , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, David Virag , Jaewon Kim , linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_103959_099078_9181D39A X-CRM114-Status: GOOD ( 37.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2 Dec 2021 at 22:44, Rob Herring wrote: > > On Thu, Dec 2, 2021 at 5:01 AM Sam Protsenko wrote: > > > > On Wed, 1 Dec 2021 at 18:20, Rob Herring wrote: > > > > > > On Tue, Nov 30, 2021 at 2:04 PM Krzysztof Kozlowski > > > wrote: > > > > > > > > On 30/11/2021 18:43, Rob Herring wrote: > > > > > On Tue, 30 Nov 2021 13:13:21 +0200, Sam Protsenko wrote: > > > > >> Add constants for choosing USIv2 configuration mode in device tree. > > > > >> Those are further used in USI driver to figure out which value to write > > > > >> into SW_CONF register. Also document USIv2 IP-core bindings. > > > > >> > > > > >> Signed-off-by: Sam Protsenko > > > > >> --- > > > > >> Changes in v2: > > > > >> - Combined dt-bindings doc and dt-bindings header patches > > > > >> - Added i2c node to example in bindings doc > > > > >> - Added mentioning of shared internal circuits > > > > >> - Added USI_V2_NONE value to bindings header > > > > >> > > > > >> .../bindings/soc/samsung/exynos-usi.yaml | 135 ++++++++++++++++++ > > > > >> include/dt-bindings/soc/samsung,exynos-usi.h | 17 +++ > > > > >> 2 files changed, 152 insertions(+) > > > > >> create mode 100644 Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > > > > >> create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h > > > > >> > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > > > > > yamllint warnings/errors: > > > > > > > > > > dtschema/dtc warnings/errors: > > > > > Documentation/devicetree/bindings/soc/samsung/exynos-usi.example.dts:35.39-42.15: Warning (unique_unit_address): /example-0/usi@138200c0/serial@13820000: duplicate unit-address (also used in node /example-0/usi@138200c0/i2c@13820000) > > > > > > > > Rob, > > > > > > > > The checker complains about two nodes with same unit-address, even > > > > though the node name is different. Does it mean that our idea of > > > > embedding two children in USI and having enabled only one (used one) is > > > > wrong? > > > > > > IIRC, we allow for this exact scenario, and there was a change in dtc > > > for it. So I'm not sure why this triggered. > > > > > > > It's triggered from WARNING(unique_unit_address, ...), because it > > calls static void check_unique_unit_address_common() function with > > disable_check=false. I guess we should interpret that this way: the > > warning makes sense in regular case, when having the same unit address > > for two nodes is wrong. So the warning is reasonable, it's just not > > relevant in this particular case. What can be done: > > > > 1. We can introduce some specific property to mark nodes with > > duplicated address as intentional. check_unique_unit_address_common() > > can be extended then to omit checking the nodes if that property is > > present. > > 2. We can just ignore that warning in this particular case (and > > similar cases). > > 3. We can add some disambiguation note to that warning message, like > > "if it's intentional -- please ignore this message" > > > > I'm all for option (3), as it's the easiest one, and still reasonable. > > Rob, what do you think? Can we just ignore that warning in further > > versions of this patch series? > > Just change the dtc flags to '-Wno-unique_unit_address > -Wunique_unit_address_if_enabled' for both examples and dtbs. > Thanks. Submitted that separately from this series: [1]. [1] https://lkml.org/lkml/2021/12/3/762 > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel