From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7532C433B4 for ; Thu, 20 May 2021 16:55:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 319376108C for ; Thu, 20 May 2021 16:55:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 319376108C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=86OWtaFjiWZoI35A1spPGHSXYXITa//oH8fQY+8WIPQ=; b=L7yPYTxiPs5pRr9x+Arm2mYZau rWyXG662OxHqYwuaDwFt2ktMl0fQoci01DboO2MjD/MQysW4Kl9F2wZN2CxYyJoPQmbZnSepaHdVW KK6AyEKSLoybeBTViUgiu8QVEsA0HhPby018LTYzACOs3V0AYWdRKU1AgaUhOZnbASSWIyonQMbeY G4VPIhVjWIvEvXnhk4CWFqx/e/O3p1QJQAmKFLNRb4hONvcF81jj95Jst6M2sT5D3FRVjGugU1QtS TfGHY9+dS3Dq1ce1eG9OHskroH1+OeEDF11DtOy+uaSyQcgYsD/QTtudRfMk5Cn2UXo2wLOIm8qBh 5KADByvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljlwC-0020yq-Na; Thu, 20 May 2021 16:54:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljlwA-0020yU-2x for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 16:54:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=o7pBWJzNKsDVSAi0Kda9nVTcz1QRPwNqhV8cq3eyftA=; b=e6nXuX8g/Vqe20kTiXJRg4sVvM 0HZ0zoTlG4J4ZwV9WA0BpXM+dBB9zmilx7SRHlIOk/PyJO8XeAengbDaKP6oDZv62ql/W2D4B6EAN 2dZLbOUxrCtygXelW9fvSF2K+MEJjKki44zvNjcDoeRfA/ZaMPyX46YB+zEsDEz2yy9fAqCI7wvQD N7eFVTEKpN+1J5Bt5aKSOW7Hjg3xXjGLCPk0i6LTe/U6k8BM5BZbdQfmokwVMZK4ZyI5pa9N3vQW7 iT0ZOaaPc+5pWG5rlIHAeRWLfpE5r7edGITYgXiiKo7rBi6ahVez1Gkj5uG6jllB4ZPqKbV4iF6aW 0WDl5Jvw==; Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljlw7-00GWTF-47 for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 16:54:16 +0000 Received: by mail-wr1-x42c.google.com with SMTP id x8so18367695wrq.9 for ; Thu, 20 May 2021 09:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o7pBWJzNKsDVSAi0Kda9nVTcz1QRPwNqhV8cq3eyftA=; b=OJpCCVZ/L/pcOIRGd2BvgxdCB+r8SNq/NM0TjSTdRqq/BRuLbTialPysWVcRztaQzV o1zkqS/OZk0QRTfaMMcdUZr9qBWRpZvpa/GKZ882fkoQbV2J3w5sM/fC1Kg8SjijfaEM bOqLPXxBcRL724S4rgpz7Q2HbqHx/0FKvodUlVfMs3n8bWvGbs/pw9LxrhY7bifK1+8M 9s2hzs3mXjVGtfD2JlUQfexustocAqoOJYAFLPLXQZvceJjeK2sLw/XxYFnGpAA3K4WI kdKJEfFZEx+do6zfnGJiiWvlB9Hy8q+UtDjKDM5whB9ooSiBFrFPq4ShLjTPhSpma6xv TtXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o7pBWJzNKsDVSAi0Kda9nVTcz1QRPwNqhV8cq3eyftA=; b=apqUbyuL9S4Zp6oVJmDNuL/kh2ZhYjA0me4RhJ5u/bTkPo1TbUN2pHCjQ5LauQQaqX fEuP/gGP3r2I3d8PFblxCcP2uPX7iQphJFZ0r2h2zv0ouDdcjfL8nPeNJo5ddZ+gosjd gaxfJLEpwxvMJq4R+lK5A6oNXThN9XrxakUyO1DgA+vyYpqIo1SUoSNi4CccR+Fskcv8 tWefNVsoLDioIYJ3K+s7Mmp+/Lo3L0tUTJXW1zbySG8FN3zABM+Li9S2RmTbBXpSBF/i hzRsCcaEfQ2dEuq2fhScM6TQ38wD8HMNDPjEnOt4NP23tBRRU+y/gHH/FSdFlneNS8hl uXDA== X-Gm-Message-State: AOAM533/cY06dq5OscBMCYzrefGPvosaBSfRcBAUB5s0f+dJLcNmlNhQ UbqnVKttdMH4wN8gX23q8KYLAJJQOMBm/u9ebfg2kQ== X-Google-Smtp-Source: ABdhPJyLmgaoTM51t95U44bzxtlVZkq59RCk4epIylEp1iw8ZiHJkO7dVBh7RRx7zg0Gfa8eC6I9NzZU0pfgj/GrTrs= X-Received: by 2002:a5d:6248:: with SMTP id m8mr5314867wrv.42.1621529652057; Thu, 20 May 2021 09:54:12 -0700 (PDT) MIME-Version: 1.0 References: <20210520150344.273900-1-maxime@cerno.tech> In-Reply-To: <20210520150344.273900-1-maxime@cerno.tech> From: Dave Stevenson Date: Thu, 20 May 2021 17:53:56 +0100 Message-ID: Subject: Re: [PATCH 0/4] drm/vc4: Add support for the BCM2711 VEC To: Maxime Ripard Cc: DRI Development , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , devicetree@vger.kernel.org, Florian Fainelli , Scott Branden , Ray Jui , LKML , Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_095415_270203_E5BA8526 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime On Thu, 20 May 2021 at 16:03, Maxime Ripard wrote: > > Hi, > > The composite output in the BCM2711 is dealt using the VEC. While the earlier > SoCs were properly supported, it wasn't functional on the BCM2711. Add the > needed support from the RPi downstream kernel. Thanks for upstreaming these. As far as I'm concerned they're all good, but DT bindings aren't an area of expertise for me. Patches 1&3: Reviewed-by: Dave Stevenson Patches 2&4: Acked-by: Dave Stevenson This is going to need firmware from 23rd March 2021 or later in order to ensure that the VEC can use an integer divider from the PLL. PLLC was rejigged to run at 2592MHz so that /24 gives the VEC the 108MHz clock it requires. (Before that it needed a special config.txt option to set the PLLs appropriately). Dave > Maxime > > Mateusz Kwiatkowski (4): > drm/vc4: Fix clock source for VEC PixelValve on BCM2711 > dt-bindings: display: bcm2835-vec: Add BCM2711 compatible > drm/vc4: Separate VEC compatible variants > ARM: boot: dts: bcm2711: Add BCM2711 VEC compatible > > .../bindings/display/brcm,bcm2835-vec.yaml | 4 ++- > arch/arm/boot/dts/bcm2711.dtsi | 1 + > drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- > drivers/gpu/drm/vc4/vc4_vec.c | 27 +++++++++++++++---- > 4 files changed, 27 insertions(+), 7 deletions(-) > > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel