From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265C1C4708F for ; Tue, 1 Jun 2021 11:05:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDB64613AB for ; Tue, 1 Jun 2021 11:05:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDB64613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=36HqD3IVOkivtTp7wrOgf6F9Dvjm40wAP3vmV9e4kWY=; b=1+klbRKK+BBnsu WBCQ4QvNbU4cJIm1hzEMQCERjXhaHwPMXm+i3gVNXEM2bY8/+Q7M60j2LrbS2fLa4BM5E/AbswTBh VfWlgGfuKO6GM29Bp+YHt9RTLChwIdf8skPHTgz9b80Qvt+yB4wBDrldcDNJNb/d+ceAgjK3pihSJ ZhoUAN2TVYtlqNr71qEuIkWeYOEJDgDtrzBSqhJnZwwuW5Fw/oO/Bawz8oC1BeJH57XVcQyb6sUK2 5csqN0UvW/VCeSfvcbEcc9crqU/GrE2m7hNwD0Yr9eXZgnPT+zwZ5ZLHhZoO8oOjiPdBKJ3pARBaG aBWL20GPkvPhDZLuJSlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo2Bq-00G5xK-42; Tue, 01 Jun 2021 11:04:06 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo2Bm-00G5vs-Kt for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 11:04:03 +0000 Received: by mail-wm1-x32b.google.com with SMTP id b145-20020a1c80970000b029019c8c824054so1279518wmd.5 for ; Tue, 01 Jun 2021 04:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:date:message-id:cc:subject :from:to:references:in-reply-to; bh=UIeev169KsjRHIHSK44fgwRCcjF3oL63Fw85uvXExqs=; b=KvzCCTj/0TGGXpfZKR9UGY0wC/FftejkhUxjOm+geMYWUYljCPae/mROSOWpu+UYrb ShBHZcRmnjjg767XGrE08i5WsakGc4dJrIV1HLAgvLnRcOsYkOm9/f1550HkKqTgub2U ZV6JfcJRs75dXucvlyNBM1aMcIopYauMEB3q1VgzRWfS4oE/9JfbNo27tCyXR4Ujb1MZ n51p12Lg4PJ1jondTA91Ml45ze1QTPqZ9Lvej+jyD5AIYm3o1a4+/pZ/52/UmUDspqBz Len4mSE2cglioc2E8Lko+dUCpKqSO/bb+ZwVKn3za2eiPjyBa+KLE6e13oSbpfYWXh8L dl0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:cc:subject:from:to:references:in-reply-to; bh=UIeev169KsjRHIHSK44fgwRCcjF3oL63Fw85uvXExqs=; b=ZvqzOYRIYxeJeCUMgNSN4Idg2LR/Oxpc+MX52rseb+Q75XDH1eP11Q7jDEHV8P41xq qwrEqPVMWbs/WAQXPsH6zAKdHXDayAnkgdXYkYToV+ybEJnBFpI0ejpKiaRS0wShVmuJ IlSFwdiUnIxgs1ZpfxL/ms9Pz4aR8vr3zdRM9CFm4EsPlbQeI8xDh+wbSDfOFrO5qmKO sQI73Xg0u123VQQNLL5x5xlVEnYROqDyWP8VOKmisHbYjdqQ94BOcRmxGQEWId0WKuB6 2RHrJ3zNtACLjDpf6BVvtWrLmVhp/HWFaULFgAnXe1SKoQmAp3EqCnegz0eUp9LZwujS b3Gg== X-Gm-Message-State: AOAM531YNvpMACDSwthjXQkSaYVDUUlURkux4Mng1F7Te0YlTD+2Vu9r ubgAEf2mP6ugt+M7znk2OLM= X-Google-Smtp-Source: ABdhPJzNJTzJo1iWAFdFFiIgWC2+hfB9CM4LEfJWadWMhzsrL8GS7Czqs8kzSnzTDLb/ygH3MQYjfQ== X-Received: by 2002:a1c:a3c3:: with SMTP id m186mr14625537wme.154.1622545440071; Tue, 01 Jun 2021 04:04:00 -0700 (PDT) Received: from localhost (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id t14sm2755228wra.60.2021.06.01.04.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 04:03:59 -0700 (PDT) Mime-Version: 1.0 Date: Tue, 01 Jun 2021 12:03:59 +0100 Message-Id: Cc: , , , Subject: Re: [PATCH] media: imx: imx7_mipi_csis: convert some switch cases to the default From: "Rui Miguel Silva" To: , , , , , , , , , , References: <20210531174300.2594109-1-trix@redhat.com> In-Reply-To: <20210531174300.2594109-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_040402_698899_F8CAFD1F X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tom, Thanks for the patch. On Mon May 31, 2021 at 6:43 PM WEST, wrote: > From: Tom Rix > > Static analysis reports this false positive > imx7-mipi-csis.c:1027:2: warning: 4th function call argument is > an uninitialized value > > The variable 'align' is falsely reported as uninitialized. > Even though all the cases are covered in the > switch (csis_fmt->width % 8) { > > Because there is no default case, it is reported as uninialized. > > Improve the switch by converting the most numerous set of cases > to the default and silence the false positive. > > Signed-off-by: Tom Rix It solves that, looks good to me. Reviewed-by: Rui Miguel Silva ------ Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index d573f3475d28..330f283030ec 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -1016,10 +1016,8 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd, > case 6: > align = 2; > break; > - case 1: > - case 3: > - case 5: > - case 7: > + default: > + /* 1, 3, 5, 7 */ > align = 3; > break; > } > -- > 2.26.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel