From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD0DC74A51 for ; Thu, 11 Jul 2019 09:09:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91B4521537 for ; Thu, 11 Jul 2019 09:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eZLEr1gO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="zE46ss3v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B4521537 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nHeZiKuc2HQbMPMTq2gfsgVfKNRA/zFniq5qvFV/LFw=; b=eZLEr1gOsIK1RE xFN/Ow/xiuUwdtazJk0ayZvnINHBWw8UJOnAe9XY7Jn/ly1b7+nAxh1thQohPjUCgc5+WNlpn5NpG 6rIQ8Elk0OHZUFtIuho+jd64x2fCreANT/C5FlAdHvUby3rUyQHxCeHI363Sc6yaVmA77AeYynOTy WtU7WxcLgQMGTp0MoHtjpiML/7r0TmTPdUn3ix+Zrdd7nBCqj5lAfd1V9KPWV8Dv/w3zWe1AC6Zjj AMJJ61HF/g0sdX1QnrSC4ML6KnxztlqWYOZUAzzGTmzoFhr5CxNModdzLX7Hzf678CmaJfo0y4WGU A2Kh8UraYeAYKpLsVwpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlV5H-0006Pb-1H; Thu, 11 Jul 2019 09:09:47 +0000 Received: from mail-eopbgr720068.outbound.protection.outlook.com ([40.107.72.68] helo=NAM05-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlV5D-0006Ni-KP for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2019 09:09:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MoaipL9x/yh/ZvSMVmRPEgOp4QouWkODjfXjSkryz4tH0s51R/fjL558x+druvxYkgt0lKV6Ay7iSkdO0Nb4UEX6Jm2jjdFRLkiX/F4Izes0xExCrELX4sHlsftLszhpOyfnfYo6g128G6CTYuKQ62FwQzMS4aZbax1g5PBpNqrBmwJp+4k27dxpB5GQ5yZkvahqyhCN9t6JsYbyyFDgkNW07fGDTLbluMunIT0kJjdCQq1NNH97FXhOObJwQnbKzb9PF7aUQ9G6OR8quLbUYK5vSLXl1VQ8v6pXm5qr1txYpHZX3eqmj1CNT60CVL8IAh+FvOiA/PygkQinQC6Zbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6CGxB9n3CpPDFIk+JXgdmkCMJlSerRHNQsE+rtyc0qA=; b=eDu1LKMO1hCczvLtsJdNH85QVenClxzJMj2Q60A8hhKTeJuTzYga0H15Y6aD5FBuffwE/3mV6XIaPXGphoKdTglO+V//jmGzAGk1JmtPyO6w9oyg5TiuYyMJKm/8mxes5rmeWf0VRb8etaaAW0FJmscaXl0za6n44PT5hsXQ7MipmTyHGzRApAgftwhaHGCJdZRSZxiXv89oY2Cg0ccSYdHJ6Ugecb6UrONvTV3Ay0J2D4N3CwEQXNGhKMnPzpx7G4tgowNxaGyCFvKK/kfHoN9YnXw8v+/ArBCkxd5zY3aB4FkQXFXDNKxuHlONTqHz6NWXR5bESzjbGndXWTp54A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=xilinx.com;dmarc=pass action=none header.from=xilinx.com;dkim=pass header.d=xilinx.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6CGxB9n3CpPDFIk+JXgdmkCMJlSerRHNQsE+rtyc0qA=; b=zE46ss3vP+FMhaFWz/q4QctvZoMF5Jt7OS5YztF+NRS4y4JWTIeh9p+sj1SiG7plAtpx716ZGI/Vn5f5E9MvR+B/6C8LYu7wmS/5KeDUiyGfUvoN6s+Jufaka75YKFajEPMoGo/ykiV4W5sEdoSy/W8rw4T0f3ZEa6ViXKur83I= Received: from CH2PR02MB6088.namprd02.prod.outlook.com (52.132.228.94) by CH2PR02MB6039.namprd02.prod.outlook.com (10.255.156.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Thu, 11 Jul 2019 09:09:33 +0000 Received: from CH2PR02MB6088.namprd02.prod.outlook.com ([fe80::456d:ace7:7c55:8639]) by CH2PR02MB6088.namprd02.prod.outlook.com ([fe80::456d:ace7:7c55:8639%3]) with mapi id 15.20.2052.020; Thu, 11 Jul 2019 09:09:33 +0000 From: Vishal Sagar To: Sakari Ailus Subject: RE: [PATCH v8 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver Thread-Topic: [PATCH v8 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver Thread-Index: AQHVGfMaAKfbOTEUHkuDr9l8JJ/e/6aNBicAgAKUiNCAEf49AIAaFFmg Date: Thu, 11 Jul 2019 09:09:33 +0000 Message-ID: References: <1559555971-193235-1-git-send-email-vishal.sagar@xilinx.com> <1559555971-193235-3-git-send-email-vishal.sagar@xilinx.com> <20190605124851.xr2hmgyoe46q6xud@kekkonen.localdomain> <20190618145922.sq4jovxoz2khs3tq@valkosipuli.retiisi.org.uk> In-Reply-To: <20190618145922.sq4jovxoz2khs3tq@valkosipuli.retiisi.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vsagar@xilinx.com; x-originating-ip: [149.199.50.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e636a22-b177-4af4-81f9-08d705df7d95 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:CH2PR02MB6039; x-ms-traffictypediagnostic: CH2PR02MB6039: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 0095BCF226 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(199004)(189003)(13464003)(66476007)(71190400001)(66066001)(55016002)(76116006)(66556008)(66946007)(6436002)(33656002)(66446008)(14454004)(229853002)(54906003)(7696005)(2906002)(71200400001)(25786009)(53936002)(64756008)(99286004)(6116002)(3846002)(7736002)(74316002)(6246003)(305945005)(81156014)(7416002)(4326008)(81166006)(9686003)(52536014)(5660300002)(14444005)(256004)(76176011)(186003)(6506007)(53546011)(478600001)(26005)(446003)(476003)(486006)(11346002)(316002)(86362001)(6916009)(8936002)(102836004)(68736007)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR02MB6039; H:CH2PR02MB6088.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: xilinx.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +bKkSRatMO+R/F0T2bAt1P4tb6t/d/51GnJqvnewgGptTK9/hpNnl71kXcPJAf/q4VwQ/sV/fFWapQiyH3kw95Fs7HLPGWZNM3u24OO6Q56Nw+0ieYvOj/oCPBWrKK7Mf9TsJ6bgncQ14NepvTwRMcQk0ITyHnJtXpcXBkf+bI69jaCTmt6BWbbbYgT0oGjtNO9Bu1qGyY1ng1LHF0k54AsqM/dnk/pVLlKznzGcbnJVknvJgsY1X7/JxGVF7PKptJYo+nOfbGu2rbDsK93xKNuzT0eBaNGkyzjK5gQSbGydhTqk7TUNz08o8NWgO7xCSVIDjIDy6CInj4GxSP6tHeONj9jFggSdtQXNeiyqAkB1T92I+wA+5vm46+Ujm9jAcarzssjeyYnEkAHqQ4rbFD5QOu9iFJof/r/mJUHmv5Q= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e636a22-b177-4af4-81f9-08d705df7d95 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2019 09:09:33.7161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vsagar@xilinx.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6039 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190711_020943_678748_CD560E96 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Jacopo Mondi , Dinesh Kumar , Hyun Kwon , Sandip Kothari , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , "laurent.pinchart@ideasonboard.com" , Sakari Ailus , Vishal Sagar , Luca Ceresoli , "hans.verkuil@cisco.com" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ailus@iki.fi] > Sent: Tuesday, June 18, 2019 8:29 PM > To: Vishal Sagar > Cc: Sakari Ailus ; Vishal Sagar > ; Hyun Kwon ; > laurent.pinchart@ideasonboard.com; mchehab@kernel.org; > robh+dt@kernel.org; mark.rutland@arm.com; Michal Simek > ; linux-media@vger.kernel.org; > devicetree@vger.kernel.org; hans.verkuil@cisco.com; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Dinesh Kumar > ; Sandip Kothari ; Luca Ceresoli > ; Jacopo Mondi > Subject: Re: [PATCH v8 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx > Subsystem driver > > Hi Vishal, > > On Fri, Jun 07, 2019 at 07:11:47AM +0000, Vishal Sagar wrote: > ... > > > > +/** > > > > + * xcsi2rxss_s_ctrl - This is used to set the Xilinx MIPI CSI-2 V4L2 controls > > > > + * @ctrl: V4L2 control to be set > > > > + * > > > > + * This function is used to set the V4L2 controls for the Xilinx MIPI > > > > + * CSI-2 Rx Subsystem. It is used to set the active lanes in the system. > > > > + * The event counters can be reset. > > > > + * > > > > + * Return: 0 on success, errors otherwise > > > > + */ > > > > +static int xcsi2rxss_s_ctrl(struct v4l2_ctrl *ctrl) > > > > +{ > > > > + struct xcsi2rxss_state *xcsi2rxss = > > > > + container_of(ctrl->handler, struct xcsi2rxss_state, > > > > + ctrl_handler); > > > > + struct xcsi2rxss_core *core = &xcsi2rxss->core; > > > > + int ret = 0; > > > > + > > > > + mutex_lock(&xcsi2rxss->lock); > > > > + > > > > + switch (ctrl->id) { > > > > + case V4L2_CID_XILINX_MIPICSISS_ACT_LANES: > > > > + /* > > > > + * This will be called only when "Enable Active Lanes" parameter > > > > + * is set in design > > > > + */ > > > > > > You generally get the number of lanes from firmware. There's no need to > add > > > a control for it. > > > > > > > I don't understand what firmware means here. There is no other code > running. > > I don't see how to modify the number of lanes apart from using v4l control. > > It's not the user that provides this information. Again, if you want this > feature right from the time the driver is merged to mainline, then rebase > the set on top of Jacopo's frame descriptor set. But it may take a while. > Thanks for reviewing again and sharing this. Since Jacopo's frame descriptor set will take a while, I will remove this control for now from the driver so that the driver can get into upstream. Regards Vishal Sagar > > > > > > + if (core->enable_active_lanes) { > > > > + u32 active_lanes; > > > > + > > > > + xcsi2rxss_clr_and_set(core, XCSI_PCR_OFFSET, > > > > + XCSI_PCR_ACTLANES_MASK, > > > > + ctrl->val - 1); > > > > + /* > > > > + * This delay is to allow the value to reflect as write > > > > + * and read paths are different. > > > > + */ > > > > + udelay(1); > > > > + active_lanes = xcsi2rxss_read(core, XCSI_PCR_OFFSET); > > > > + active_lanes &= XCSI_PCR_ACTLANES_MASK; > > > > + active_lanes++; > > > > + if (active_lanes != ctrl->val) > > > > + dev_info(core->dev, "RxByteClkHS absent\n"); > > > > + dev_dbg(core->dev, "active lanes = %d\n", ctrl->val); > > > > + } else { > > > > + ret = -EINVAL; > > > > + } > > > > + break; > > > > + case V4L2_CID_XILINX_MIPICSISS_RESET_COUNTERS: > > > > + xcsi2rxss_reset_event_counters(xcsi2rxss); > > > > + break; > > > > + default: > > > > + ret = -EINVAL; > > > > + break; > > > > + } > > > > + > > > > + mutex_unlock(&xcsi2rxss->lock); > > > > + > > > > + return ret; > > > > +} > > -- > Regards, > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel