From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3414C28EB3 for ; Thu, 6 Jun 2019 18:22:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE41E20872 for ; Thu, 6 Jun 2019 18:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lYROT57e"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="LpcH017p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE41E20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nZZdy4X8Y3++64zAgoU4J3i5Mv8Qje+EQOeT1Uo8ZU8=; b=lYROT57eiT3J58 0vkqMFhrxPPmC2+01vkA5Jl0L2+OX4Hq6CPysi6aDjpfbVAShLLne0LPL48IwS4i/LsOGc6FShxf4 lDtNCl+/qJ4zDut3yM8TuDWh4/YrRqk1Beo/NGwCi8PHWGJwioAO/DfvXmNUgfcXTjxpTtoOaJFGM 4PO/wZsmv7dLyyjxEiLlkW0F5cYCmpbzLoFlY4UiEdqS7l+RcU5YWXPnfCs5I45CvYCr0vZFx3saX GxJZvdYDeTx7xvgpwZqY0ekvV//OYej59v1EgPPEO/7EfwWDhHRD1Ae8kC5dPxv0Qjj0xMJdK+t2/ r4sm4ucmQzPf0UEzlfIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYx1i-0005aT-8d; Thu, 06 Jun 2019 18:22:14 +0000 Received: from mail-by2nam01on0605.outbound.protection.outlook.com ([2a01:111:f400:fe42::605] helo=NAM01-BY2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYx1f-0005aA-8c for linux-arm-kernel@lists.infradead.org; Thu, 06 Jun 2019 18:22:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sonYqcdLrVVZs4jxWz2LM04hL11uBXmDup0Q2BRmOQQ=; b=LpcH017pBJhBfHTppKchmLvpbJbhyDGDO9Q4PpexaMxtISqrRvdXMCaQVPw1Hrsa22KM4wYDoBfDBTJGa837FNP471u5pO7S5yAUTBQWorRsPJz8SU+EvlwViuqF9R7H7k+U97YAwXj34frhLpzVDBpbcTy5kq5wkLhUU1yw0qk= Received: from CH2PR02MB6359.namprd02.prod.outlook.com (52.132.231.93) by CH2PR02MB6021.namprd02.prod.outlook.com (10.255.156.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Thu, 6 Jun 2019 18:22:08 +0000 Received: from CH2PR02MB6359.namprd02.prod.outlook.com ([fe80::b9dd:11e0:7fca:ba55]) by CH2PR02MB6359.namprd02.prod.outlook.com ([fe80::b9dd:11e0:7fca:ba55%5]) with mapi id 15.20.1943.018; Thu, 6 Jun 2019 18:22:07 +0000 From: Dragan Cvetic To: Greg KH Subject: RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl Thread-Topic: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl Thread-Index: AQHVEu5GErREaULonk+tvtDvF1CkjaaOsacAgABQ8tA= Date: Thu, 6 Jun 2019 18:22:07 +0000 Message-ID: References: <1558784245-108751-1-git-send-email-dragan.cvetic@xilinx.com> <1558784245-108751-5-git-send-email-dragan.cvetic@xilinx.com> <20190606132842.GC7943@kroah.com> In-Reply-To: <20190606132842.GC7943@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=draganc@xilinx.com; x-originating-ip: [149.199.80.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b334be30-de8b-4607-eec9-08d6eaabe27c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:CH2PR02MB6021; x-ms-traffictypediagnostic: CH2PR02MB6021: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(396003)(346002)(376002)(189003)(13464003)(199004)(99286004)(26005)(52536014)(6116002)(3846002)(6436002)(66066001)(74316002)(4326008)(7696005)(14454004)(5660300002)(9686003)(55016002)(25786009)(2906002)(76176011)(478600001)(229853002)(53546011)(6506007)(102836004)(107886003)(8936002)(7736002)(6916009)(76116006)(73956011)(66946007)(486006)(14444005)(446003)(33656002)(256004)(81156014)(71190400001)(316002)(53936002)(71200400001)(66446008)(68736007)(54906003)(476003)(86362001)(6246003)(81166006)(8676002)(66556008)(186003)(305945005)(11346002)(64756008)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR02MB6021; H:CH2PR02MB6359.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: xilinx.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5MzkTd5FzxfzGWuPlrUp6S3DdKpeFq+Um9/YzIEaYsyB8dE22WKTbbpqyocHyEFQ0sH4kHTlGuQnSA/H+9PymvLd/gHPaeEr2TtpwFaQdb5f+gcIpPviltAdVqNYYYigYQG3RNKDay2xXFj+Oh5XGIOE8fglIcgz7lLCBSbz0/oeluhCjyfa1jHUjLrSVQk46T77jvwVccFUrX0ibm6rRhM3/bvKxpApPd/6PoLyToc0IM38yHhRiuhTvUqQDviav2duH5nK29fIk5RTa/pdsGFNcMU+yJ+YcAWK+2JVzf3vX+32H88vr6IFg8dL/8n0oVItNY2Qp1MM6t3nVCQRBhAI+Aoa0KKaPa5j1JHyoHcq3EOzeBDVC0b+gUoEidS0w02wc1iog6zxAl7ba6zZotFuWr8CU0k9jYe9zbxuJ5I= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: b334be30-de8b-4607-eec9-08d6eaabe27c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2019 18:22:07.7990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: draganc@xilinx.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6021 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_112211_309801_C665F28D X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , Derek Kiernan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Thursday 6 June 2019 14:29 > To: Dragan Cvetic > Cc: arnd@arndb.de; Michal Simek ; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org; > mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Derek Kiernan > Subject: Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl > > On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > > +{ > > + return 0; > > +} > > + > > +static int xsdfec_dev_release(struct inode *iptr, struct file *fptr) > > +{ > > + return 0; > > +} > > empty open/close functions are never needed, just drop them. Accepted. Will remove them. > > > + > > +static long xsdfec_dev_ioctl(struct file *fptr, unsigned int cmd, > > + unsigned long data) > > +{ > > + struct xsdfec_dev *xsdfec; > > + void __user *arg = NULL; > > + int rval = -EINVAL; > > + > > + xsdfec = container_of(fptr->private_data, struct xsdfec_dev, miscdev); > > + if (!xsdfec) > > + return rval; > > It is impossible for container_of() to return NULL, unless something > very magical and rare just happened. It's just doing pointer math, you > can never check the return value of it. Accepted. Will remove if statement. > > > + > > + if (_IOC_TYPE(cmd) != XSDFEC_MAGIC) > > + return -ENOTTY; > > How can this happen? Accepted. Will be removed. > > > + > > + /* check if ioctl argument is present and valid */ > > + if (_IOC_DIR(cmd) != _IOC_NONE) { > > + arg = (void __user *)data; > > + if (!arg) > > + return rval; > > + } > > + > > + switch (cmd) { > > + default: > > + /* Should not get here */ > > + dev_warn(xsdfec->dev, "Undefined SDFEC IOCTL"); > > Nice that userspace has a way to fill up the kernel log :( > > Just return the correct error here, don't log it. Accepted. Will remove log. > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel