From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DE5C433DB for ; Fri, 22 Jan 2021 05:59:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30E1622D50 for ; Fri, 22 Jan 2021 05:59:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30E1622D50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cadence.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ywLP7Xdm9VdPMBkSUdDWdl3nzJWnkTxEJ+faNgN8Wb0=; b=V1cB6h8yV0M/oeoXPiEWo7EAS rRgj9hdOkhNKDp58nOjC+c+m8C0nUiU57x5S9W7kzHu34brIKYnzUw0xCeJmyFhMkvrpk/1JzJRS+ VVwE3cILS3dBx3dYHChBMzlJJctDshxN0wPuJHBe0KVIXqw99nINjd0FEZLXTd9eTeZzGZljku0xA b0zrok9C2nvyTpi8yKDRADBGVmcTcYsZkfyti2BPKmH39Rd8N8SBGOJZudIMzyInwNMr6kGtmXBw7 GOz463/M1CquoBSpd18ROK6iK7gVuAzPRiujuKTGIZ/1R54E85luiCQTDzArnt/s8box5W4Fx20SZ YayFPghhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2pSJ-00048v-8t; Fri, 22 Jan 2021 05:57:59 +0000 Received: from mx0a-0014ca01.pphosted.com ([208.84.65.235]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2pSD-00048Q-US for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 05:57:57 +0000 Received: from pps.filterd (m0042385.ppops.net [127.0.0.1]) by mx0a-0014ca01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10M5abBp027086; Thu, 21 Jan 2021 21:57:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=proofpoint; bh=n9evRdPfWF0nxGKWX3+hNAEKZ0NKWPLBcsO7phpGxkc=; b=CwyF4jy9FdVHQ2m7SHlsaqwUqQfo3vpQMD/FphKcFyOxvKnbyjhnTr9GIsetzpV/0SAf 0S7buC9nHDpadZtC2z05ImKHsDjDp1YTZgCeKglIWEC9IcxXhUp1phlNKm7MlVBFQ8Or L4T57xnrIla1cl35etgjDu+iA95WS2n2Fxcs/bU2kgzmaDtD/4yJAlwthRNhJx5wQX6t Y0+Bc4uwi4YSXMN3v9VMISAXqrlc0ujnotOTvat5SUeooBbirS6tTl1DvMjNZj2v71MQ jqzAn90zhmaC+j0v4SadXbpiKCCLexkfXzXj3nzbHS+0SYbX+WH6TP4NbgIiBiQ3J4zq YQ== Received: from nam04-sn1-obe.outbound.protection.outlook.com (mail-sn1nam04lp2058.outbound.protection.outlook.com [104.47.44.58]) by mx0a-0014ca01.pphosted.com with ESMTP id 3668pwh88j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 21:57:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VC+AnN2claaPSzdfw+sBiW7+qYKTLTqDjmuiKGY0GxMfxszbgQ6RGKoeU7k1Emv4JTNEgbgY9SRl5XvIapP6SZ0d5sVytiRJNOHrZl8GazdM54sem/Oi1+S+JMK3LNKcRcXVhndRGhJaz8AizCZr5NOFdD/fCoydM0bGP4QGp/E2NxqXty/7Dc6MMx05l4bqFxkBjh2UcDDgfw0qpRT00FGIqdXbXVXWdzCMMHDNk1F8FsjLknAdAxy2OlagWNnoLMwIHMHHNsNsKcMeLLzxnizsp0XFTGLzwP2N2Zq96lw/VoxoJJaP0Xg1BOe36ux7zkzL95XQns40O59/U6siTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9evRdPfWF0nxGKWX3+hNAEKZ0NKWPLBcsO7phpGxkc=; b=O3t/5ie4g+K94PDHGaKPsl3AfDN6kc9uDwrzI2GQDPbN2J0iLkGhP+iau/CGC+fWA0CTLgZHXgqFW8IPAF4pXuQjJRSiBF8un9N7hXiHC7NGe9bGX37nBe8MDA6G7LO1kx77LC0kISWK6lsiZzURe76V+Z8TbfhOdRx2entPTftl5xhfzTjifH/8hCYFWThdyyhrPp4nlucWlR0NbpiSVa7mC+UXihTvaRWQ6AB6J20l0v7MfV2ED8fJDkWKAPMmyJQGx0fLvNw0sUzR0bu3mkAp8CdTaQQ4B8CnbPJ6PdcXmIrDPuiyjWFXB4v37TOdj7Nw3bIUmg0MOqOnkPJOvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cadence.com; dmarc=pass action=none header.from=cadence.com; dkim=pass header.d=cadence.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9evRdPfWF0nxGKWX3+hNAEKZ0NKWPLBcsO7phpGxkc=; b=ZOsbwsINIuXyVEUX1gv9gdNQb6OM1dPAg/tUE5G7jU+ITTzct5NXcIdkKV1fo8oGm9ODpv4TlhPTVEbChCVB8jUc8Xr0qho0tmd5nj7Fx8K30A8pKbhDMoHnAKiSLj/gfN6cDUHxSeNZAKJHEgK6H0zmctmvKRmM7ur5dDKUmwc= Received: from CO2PR07MB2503.namprd07.prod.outlook.com (2603:10b6:100:1::19) by MWHPR07MB2800.namprd07.prod.outlook.com (2603:10b6:300:1e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12; Fri, 22 Jan 2021 05:57:37 +0000 Received: from CO2PR07MB2503.namprd07.prod.outlook.com ([fe80::d8d9:e81c:18a:33e5]) by CO2PR07MB2503.namprd07.prod.outlook.com ([fe80::d8d9:e81c:18a:33e5%11]) with mapi id 15.20.3784.015; Fri, 22 Jan 2021 05:57:36 +0000 From: Athani Nadeem Ladkhan To: Kishon Vijay Abraham I , Tom Joseph , "lorenzo.pieralisi@arm.com" , "robh@kernel.org" , "bhelgaas@google.com" , "linux-omap@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2 Thread-Topic: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2 Thread-Index: AQHW3qQOEOO3xLnov0GUSEHX9bvYeqojqDeAgA+hOzA= Date: Fri, 22 Jan 2021 05:57:36 +0000 Message-ID: References: <20201230120515.2348-1-nadeem@cadence.com> <15abdca0-d1e1-64b7-4a9a-d7549f035e01@ti.com> In-Reply-To: <15abdca0-d1e1-64b7-4a9a-d7549f035e01@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcbmFkZWVtXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEyOWUzNWJcbXNnc1xtc2ctYjg0YTM4NjgtNWM3Ni0xMWViLWFlOTQtZDQ4MWQ3OWExZmRlXGFtZS10ZXN0XGI4NGEzODZhLTVjNzYtMTFlYi1hZTk0LWQ0ODFkNzlhMWZkZWJvZHkudHh0IiBzej0iMjcwNSIgdD0iMTMyNTU3Njg2NTQyODkzNTI0IiBoPSJ6eXJpZVZqdkJlUlU2UzcyWS9ELzFGSjV2QmM9IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ x-dg-rorf: true authentication-results: ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=none action=none header.from=cadence.com; x-originating-ip: [59.145.174.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c5976bc-36f8-41cc-5284-08d8be9a9eb3 x-ms-traffictypediagnostic: MWHPR07MB2800: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oSUqKHLzTHCmsgMe723jgHA8SDd9GHQJYpYW9WY8lrrfrLHH2RSGd3lmlh3SUVCRHZKqUmV/GI1tFpw8Zs5/nt39jEZpoiVuC1YG1SimXRU4Fwy+VbZndbwPYbN5LJmvH27awmcNqkGyqaSjVgXZTvbdrvrGJ0C5EH4Yr7NZZ9arf68qWX20vfEpwP1XRtcCaweC3hjYPcAp+6dmebpdc3wm5mpqXQLKTd9DAaVT7XkDlMYXn+or0m7zP1neDw3cWYhg8c83BinHDsAM1hXgnVoegqPo79DxWjZg6OMd0WCwJ/r432r+N0Oaw0eS3hqOBeQRWgremRWu9g2tWr/bB1ckfGqANj4Zl/iCzQIXrZlrJBVSBQ29pRzFI98XOisX5YP+J3Fecv5x5jyxZIx3TFPZZDTW9LCIeT/u3LxPaR53obMH/gqVa6sSY8bJdenE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO2PR07MB2503.namprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(36092001)(107886003)(83380400001)(8936002)(478600001)(54906003)(8676002)(5660300002)(66476007)(316002)(186003)(26005)(66446008)(53546011)(2906002)(64756008)(52536014)(6506007)(7696005)(9686003)(76116006)(66556008)(55016002)(33656002)(66946007)(86362001)(71200400001)(4326008)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?c1N5bkpIVHRSMHBsVXdXallNNDNSNUI2amwrTjhqS2s4YVEra2Q5Tm40bjBX?= =?utf-8?B?TGFUYWYxRkljQU1mNVNna1cwNFBlZUJkbWFTdGwwMDMwS05GTlJLKzVleUlV?= =?utf-8?B?V2M4QmpyUWpZTnUvUnhqMEN5bGViQWNFOTl5ZytnK1lTdS8vaFJHcGpVc3lq?= =?utf-8?B?dXE4UkgxTjhCNlBFOW5NSkJxUFQvTnZ2Y1V0VnF1RG5LcHNDdXRZdnRHMkkv?= =?utf-8?B?RjVCOGVvOWQvYmxxOThRY2tubHFBT3ZDcGJvc29ZaWpZaFlLVytQV001OW5F?= =?utf-8?B?MlJOM1Q1Y3RqaWtuL1BxSTlWenBMZGgzMVVkeXVXcGlzZnJMU1pWbFVLSnBw?= =?utf-8?B?Mm41dDR1SktLbFpCaFVoMWZYTk1EWnh0eDF6U3ArRmJxcURUL05kdnFObk5l?= =?utf-8?B?eGpTLzJxaU9yTENCL0Faa0xWMCtLSVpXbHg1UHhPWHREbEd3SGNTblp1RGtV?= =?utf-8?B?aGRSU05qOGlxdFlwUE1yTkhNbVRiUThsbnRXeG9xTHpBTGdiQVZVY05YUEFP?= =?utf-8?B?K1R2Z2VVU1o3L2tBUUhwVTBzRklmZytzZE91czNoMmRXTlZxSWc5N3Zpak94?= =?utf-8?B?NjJRWms2d2huWGFCdkNUa0psZHFxU2JkMWlONy9xdHYwdHdNNndNMlpRWngy?= =?utf-8?B?bEdBYmtWVk90L2RwSmJxdWNFem51N1UrRUJPaVFnVlo4STdITXd2SWRZaWhs?= =?utf-8?B?Ty82eGVFZ0dVNUhOdXhkODdGQzRJTmk0VFREb0pHK1pRT3pIMnZkYUFTL0dj?= =?utf-8?B?MDVsMExDZjFteHh6OWErM2RVTnI1OXdkZE1taXFWeHAwcXNzdDNwblpUejg0?= =?utf-8?B?QXZKdkFKMDlEVytjMkZNNktseU5GRzBDNTlXN21BQWZHVzIxQTZJSWRsc2k0?= =?utf-8?B?aVoycDJpUm1qWTdZbndPY0xWY21VNmJDTm8wYUVqT0lBMTl5bWdiV2w0WWZT?= =?utf-8?B?WWFNN0QxYytPREorTVdnSGxidk03cnkrRlBaSExuc3d3NGtBbjhxd2FRVDFq?= =?utf-8?B?cHp6eGpJMy9JMWNEL0FNcUVMemZQUmsrZVdPZ25hK1J3VURRN21LRG5JaWlT?= =?utf-8?B?VHl3Sit4aGU0MGFyTmxMTVcrN2hQbElVQ1lqQ2hZYy9DYlhaL0VMeUFxODIy?= =?utf-8?B?WDdYcHN3b3ZPVUQ1UW02ejJKL05YZlp1MWoxdHZ6YkMvVnJVNWhrL0pHUEJp?= =?utf-8?B?RUhSRE8wVjVEcjVTUTIwRjkxUEpicGMxSUdubmRwS0R3S1VHRFF0d1p1WjZR?= =?utf-8?B?SVdMdEVJTUxuZUJkM21iekMxUURsT2dtRWFEcGFXVHcyNVJsQWkyMVpJTFN1?= =?utf-8?Q?9cQe2R+k69nDk=3D?= MIME-Version: 1.0 X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO2PR07MB2503.namprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c5976bc-36f8-41cc-5284-08d8be9a9eb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 05:57:36.8748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9MV6poJKEQif0ZWbCXVY5J9nPUL5lMRHUG62wH4i0HA6tp+ZOzLzYpbRoc4F/4YN3T8+bFFqrYubxl4ZOLGyV4iIdpVABXh6BS4i4TSdlEU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB2800 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-22_02:2021-01-21, 2021-01-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 spamscore=0 adultscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101220030 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_005755_046280_A7E43A0E X-CRM114-Status: GOOD ( 24.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Milind Parab , Parshuram Raju Thombare , Swapnil Kashinath Jakhade Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob / Thomas, Requesting to provide your reviews. Thanks & Regards, Nadeem Athani > -----Original Message----- > From: Kishon Vijay Abraham I > Sent: Tuesday, January 12, 2021 12:46 PM > To: Athani Nadeem Ladkhan ; Tom Joseph > ; lorenzo.pieralisi@arm.com; robh@kernel.org; > bhelgaas@google.com; linux-omap@vger.kernel.org; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Cc: Milind Parab ; Swapnil Kashinath Jakhade > ; Parshuram Raju Thombare > > Subject: Re: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2 > > EXTERNAL MAIL > > > > > On 30/12/20 5:35 pm, Nadeem Athani wrote: > > Cadence controller will not initiate autonomous speed change if > > strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed > change. > > Adding a quirk flag for defective IP. In future IP revisions this will > > not be applicable. > > > > Version history: > > Changes in v7: > > - Changing the commit title of patch 1 in this series. > > - Added a return value for function cdns_pcie_retrain(). > > Changes in v6: > > - Move the position of function cdns_pcie_host_wait_for_link to remove > > compilation error. No changes in code. Separate patch for this. > > Changes in v5: > > - Remove the compatible string based setting of quirk flag. > > - Removed additional Link Up Check > > - Removed quirk from pcie-cadence-plat.c and added in pci-j721e.c > > Changes in v4: > > - Added a quirk flag based on a new compatible string. > > - Change of api for link up: cdns_pcie_host_wait_for_link(). > > Changes in v3: > > - To set retrain link bit,checking device capability & link status. > > - 32bit read in place of 8bit. > > - Minor correction in patch comment. > > - Change in variable & macro name. > > Changes in v2: > > - 16bit read in place of 8bit. > > Could get GEN2 card enumerated in GEN2 mode in J7ES EVM. > > Tested-by: Kishon Vijay Abraham I > > Thanks > Kishon > > > > Nadeem Athani (2): > > PCI: cadence: Shifting of a function to support new code. > > PCI: cadence: Retrain Link to work around Gen2 training defect. > > > > drivers/pci/controller/cadence/pci-j721e.c | 3 + > > drivers/pci/controller/cadence/pcie-cadence-host.c | 70 > ++++++++++++++++------ > > drivers/pci/controller/cadence/pcie-cadence.h | 11 +++- > > 3 files changed, 65 insertions(+), 19 deletions(-) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel