From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3CBC433E3 for ; Wed, 1 Jul 2020 09:41:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48508206BE for ; Wed, 1 Jul 2020 09:41:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MRcLa/SF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="rVKHbKSt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48508206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oJHerz4DohaifWVmtJlwVOj62YMH1xhkXgglO/wXmiQ=; b=MRcLa/SF2UGGI85acosoZy6K0 6dAUX6SILNdi3jslSxazhNgV521GgMiEKc8IwtTKmY/9qhQeZaNE2dLMXnYU/gFqZFrmfT1CCHBzR h/qHw2hKmukl0IhmftkyPJuB9xKQSI+hD0ZBNOa7U5Coo2xNmWVk3JD9WvgI/9SsTc50nDxGMQN5V AUjvzv0OtaVTvD2DfCfYCW+Ph1/T5XfKJG0SdoB4+HID0APuBf0jUcp5u2Bh2UQHpSO9wBg8yTAVk IFSJQ79khafHrrEezeCmHNCSoTdmbZWE8wKjirDTNZBTFmQOhzn3/7obA2mgi1RamxbiCTX0o+7CB XtwyLnQ3Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZDv-00026v-7f; Wed, 01 Jul 2020 09:40:11 +0000 Received: from mail-eopbgr70045.outbound.protection.outlook.com ([40.107.7.45] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZDs-00025d-I1 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 09:40:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGO1ej8EtWzGILxkegRAjj4lVK83NCE2b4H7h7z/WLNjn9h/7VHKL2FzdmzDes6by4ppWhnKUkFRN6YwZ5u5UyfG2iaCLYy+aB3Ah279i05DuVq4aKA7I/f/8aO10fUv3VJAdhnmZgdmLgSiAboU0zb5cpivofTqHE/ty20usMJnNGFWwzP4Itx823KG8YP7PgjsAClWxutN5qSO4Ln2JY6aKC+h5t23cwWu3+sBEv7KO/3xC1MHDHpqiUoClfl6DWUimTtIs7ohLw44kJFNT3eG7smi4Wh1qJB915pDYpzNS3vSmlxNm3JWsrmTc4GuhSw0FzJqyMVuTEkWda7kQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6b7c+w6apo+r80Mi741Mb3bP2l8gu8FlchAQlT7grMM=; b=AnQlifwtrrzJnShy/WPt3UIAbGQ1Bii+sOrH2FyrgMp++2xqZuxgQThroFayARPtncPjl8dbNGs4wiw0SySanjfIQMceyRyzLp5JRqcas2Ay5uCGQkdpCHl7c9iesFOcSFi7xKZ8RsMTtzREd1kmEcPqhpwN7JMuVmILsYPN3iM4p5YxpNnP1EN9wcOdfS+wf/22ZeVLUNPRh6aFA7YMiBipQeJkkYCW+r/a0SO3gFXRG3H4IS/MbXdp8Sd81Hj1oGg6k7oB432GmNr3DkoQ+qgFH/8E0CJEIs8r1/1Z5lL+n+PJd0dNvLCM5HtyJajf+3qRcjEKi0pej7HYO3qXfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6b7c+w6apo+r80Mi741Mb3bP2l8gu8FlchAQlT7grMM=; b=rVKHbKStXe/xAYK6wfsrEy35U6QVOw/soSMBOYyOEvsWWgwzFDnRWMbXX0vniDYmwSrSz+Ftj54w/67RDvdyd+ZwycO7zNOIj0xXgPqr/UjWP5feeLJNQfzNykWCFATB0YkO4fB7QEZLKE9FH3R6NlGBHr86vU1ETg3SImLqDMo= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) by DB7PR04MB4762.eurprd04.prod.outlook.com (2603:10a6:10:16::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.24; Wed, 1 Jul 2020 09:40:04 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::1dab:b68c:e028:acb3]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::1dab:b68c:e028:acb3%6]) with mapi id 15.20.3131.030; Wed, 1 Jul 2020 09:40:04 +0000 From: Anson Huang To: Arnd Bergmann Subject: RE: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module Thread-Topic: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module Thread-Index: AQHWTdthV6wfzmMopU6pSRFnxqvg3qjvd4YAgAACQ6CAABqKgIAAAHBggAAdugCAAAKowIAA09MAgAHHMmCAABw9AIAAC3rggAACoRA= Date: Wed, 1 Jul 2020 09:40:04 +0000 Message-ID: References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-5-git-send-email-Anson.Huang@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [183.192.9.232] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b326c8c4-fdf1-495d-4a42-08d81da2bbc1 x-ms-traffictypediagnostic: DB7PR04MB4762: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rG47DL6VqBSX5gqyBvcsVX14lQRtKAMq5Dwlgs+os+B4Ys/5BC4y25ds5OmaiBF7osk/9oSCSHfqRHwHYxCg8xUOZtHQlvjD1Xc6aN8a+zXI8fruSnohPRQi0GQUYHuzBgmyKfJQDBMji/htke7Vj5wwBdpCThhfcx28FMV/VuglIB/YEhsh9HwGmHx9t6K0xAMPg5PfqUcG6HMTV/FmoQZN7Cw7IxRYkhXCoUqgtSCzsDeNcKwLErDXkb6OPdjnyWb0sD+8lxGqzfzy458tmDuqCtkL99FBRpgk/7eEtW7yGivlMUEJZr3zPgd3zfcnphJQhlFwS5FF5yx4ZdIDkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR0402MB3916.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(66556008)(7696005)(64756008)(478600001)(66446008)(52536014)(8936002)(19627235002)(66476007)(33656002)(6506007)(53546011)(4326008)(5660300002)(8676002)(9686003)(6916009)(2940100002)(186003)(55016002)(44832011)(66946007)(71200400001)(26005)(86362001)(316002)(54906003)(76116006)(83380400001)(7416002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zeyBAXk70cVBfTOFI+A8P+/6mJ1hModpLBrL/P1bUdne62WssrRgVys5Uaa3fq3Yof7nkfsLgFEhBo7LQvRTz7hsLoUKn02Pg0DrfTV7bUFQemBtqadjBL/FDCLTJUD76rZ9hkNZEa2bWMx8mZSVC725p4tKSJFaAdQLPX+YunGPnYvMpIZ3oOyLt9JD1rb6++jOuPY61FIQ9uutN2oJ9uT2AnV/EinDAsYQFrscgu5LVk9fRdu4sDcRPbrMnOhKx5UL5MMDyYUMVVvKUgtFnnlfmebqgr4HiU9C9RGkSsNQ/AZKfwJLWrZ0w5Hee1amPBYB3rWwDSz2Xov84kMXTppfET5PajmC6AQbcqmsQpsWd19hQaBo/6V8BKrFnzGkfK4p1h3NsKNe6WnF05az7Nfo3xr9WNakYQaGs+hdxVJihcYysHOVR2/5HWHcsw/1CoRreRFzRts4475yk0g6Uxg5Vza8mYJXAdp5/TknxUQ= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB3PR0402MB3916.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b326c8c4-fdf1-495d-4a42-08d81da2bbc1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 09:40:04.3650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vHhIKHYGE/Y+s3I9JUjxzFXHlX1Am3j8+G49KR6QhUmewPA0kgxFCkgXTiG2icnZiOyM66/ygbK5mvmkq4D1iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4762 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_054008_750215_6140E95E X-CRM114-Status: GOOD ( 26.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Michael Turquette , "oleksandr.suvorov@toradex.com" , Fabio Estevam , linux-clk , Stephen Rothwell , Abel Vesa , YueHaibing , Russell King - ARM Linux , dl-linux-imx , Dong Aisheng , Stefan Agner , Sascha Hauer , Al Viro , Daniel Baluta , Linux ARM , Aisheng Dong , Andy Duan , Stephen Boyd , "linux-kernel@vger.kernel.org" , Sascha Hauer , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: Hi, Arnd > Subject: RE: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as > module > > Hi, Arnd > > > Subject: Re: [PATCH V3 04/10] clk: imx: Support building SCU clock > > driver as module > > > > On Wed, Jul 1, 2020 at 9:19 AM Anson Huang > > wrote: > > > > Subject: Re: [PATCH V3 04/10] clk: imx: Support building SCU clock > > > > driver as module On Tue, Jun 30, 2020 at 5:16 AM Anson Huang > > wrote: > > > > > > > > SCU clock driver is a common driver for all SCU based platforms. > > > > Current i.MX8QXP SCU clock driver will be extended to support all > > > > future SCU based platforms. > > > > So theoretically clk-scu.o and clk-imx8qxp.o can be combined. LPCG > > > > is similar. > > > > Maybe you can give a try as Arnd suggested. > > > > > > > > > > Do we really need to link clk-scu and i.MX8QXP clock driver together > > > just to > > avoid some export? > > > > It was just meant to be easier than exporting a symbol and dealing > > with module dependencies. If it's not easier, then don't. > > > > > I met some build issues if using this method, the i.MX8QXP module > > > build is OK, but other platforms like > > i.MX8MM/i.MX8MN/i.MX8MQ/i.MX8MP > > > clock drivers are just skipped for build, even these i.MX8M clock > > > config are existing in .config, anyone know why? Looks like the > > > change in > > Makefile for i.MX8QXP clock driver introduce this issue. > > > > You have a ":=" instead of "+=" typo, so all earlier "+=" are ignored: > > > > > obj-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o > > > obj-$(CONFIG_CLK_IMX8MN) += clk-imx8mn.o > > > obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o > > > obj-$(CONFIG_CLK_IMX8MQ) += clk-imx8mq.o > > > > > > obj-$(CONFIG_MXC_CLK_SCU) := clk-imx-scu.o clk-imx-lpcg-scu.o > > > > ^^^^^^^^ > > Thanks, I will give another try, I will make the common clk part all linked into > each platform's clock driver, then many exports can be saved. Just tried, it works for i.MX8QXP, andcorrect one thing, other platforms need more complicated change if want to support them in the same way, so I plan to ONLY do this change for i.MX8QXP if it is acceptable. Thanks, Anson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel