From: Anson Huang <anson.huang@nxp.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"heiko@sntech.de" <heiko@sntech.de>,
"maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
Andy Gross <andy.gross@linaro.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"olof@lixom.net" <olof@lixom.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: RE: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding
Date: Sun, 24 Feb 2019 02:53:44 +0000 [thread overview]
Message-ID: <DB3PR0402MB39164677D09DA6CB3A6951B3F5790@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190223213759.GA1472@localhost.localdomain>
Hi, Eduardo
Best Regards!
Anson Huang
> -----Original Message-----
> From: Eduardo Valentin [mailto:edubezval@gmail.com]
> Sent: 2019年2月24日 5:38
> To: Anson Huang <anson.huang@nxp.com>
> Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com;
> daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>;
> ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta
> <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>;
> horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de;
> maxime.ripard@bootlin.com; bjorn.andersson@linaro.org;
> jagan@amarulasolutions.com; enric.balletbo@collabora.com;
> marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding
>
> On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote:
> > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
> > controller, the system controller is in charge of system power, clock
> > and thermal sensors etc. management, Linux kernel has to communicate
> > with system controller via MU (message unit) IPC to get temperature
> > from thermal sensors, this patch adds binding doc for i.MX system
> > controller thermal driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> > Changes since V7:
> > - remove unused property "tsens-num";
> > - improve the compatible description;
> > - update examples according to latest dts file.
> > ---
> > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 19
> +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index 72d481c..d89147e 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -122,6 +122,19 @@ RTC bindings based on SCU Message Protocol
> > Required properties:
> > - compatible: should be "fsl,imx8qxp-sc-rtc";
> >
> > +Thermal bindings based on SCU Message Protocol
> > +------------------------------------------------------------
> > +
> > +Required properties:
> > +- compatible: Should be :
> > + "fsl,imx8qxp-sc-thermal"
> > + followed by "fsl,imx-sc-thermal";
> > +
> > +- #thermal-sensor-cells: See
> Documentation/devicetree/bindings/thermal/thermal.txt
> > + for a description.
> > +
> > +- imx,sensor-resource-id: Property array to specify each thermal zone's
> sensor resource ID.
>
> If this is an array...
>
> > +
> > Example (imx8qxp):
> > -------------
> > lsio_mu1: mailbox@5d1c0000 {
> > @@ -168,6 +181,12 @@ firmware {
> > rtc: rtc {
> > compatible = "fsl,imx8qxp-sc-rtc";
> > };
> > +
> > + tsens: thermal-sensor {
> > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-
> thermal";
> > + #thermal-sensor-cells = <0>;
> > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>;
>
> then this example should have an array, to be better express how this is
> supposed to work. Can you please resend this with an array instead?
On i.MX8QXP, there is ONLY 1 thermal zone available currently, but the thermal driver
is supposed to support multi thermal zones as well for i.MX8QM, in V9 patch set I just
sent, I use the " imx,sensor-resource-id " element count to determine how many thermal
sensors will be supported, so that we can also get rid of searching the thermal-zones' child
node, I improved the description as below, is it OK?
41 +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or
42 + an array of integers to specify each thermal zone's sensor
43 + resource ID.
Thanks,
Anson.
>
> > + };
> > };
> > };
> >
> > --
> > 2.7.4
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-24 2:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 6:38 [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding Anson Huang
2019-02-21 6:38 ` [PATCH V8 2/4] thermal: imx_sc: add i.MX system controller thermal support Anson Huang
2019-02-23 21:38 ` Eduardo Valentin
2019-02-24 2:58 ` Anson Huang
2019-02-21 6:38 ` [PATCH V8 3/4] defconfig: arm64: " Anson Huang
2019-02-21 6:38 ` [PATCH V8 4/4] arm64: dts: imx: add i.MX8QXP " Anson Huang
2019-02-23 21:38 ` [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding Eduardo Valentin
2019-02-23 21:40 ` Eduardo Valentin
2019-02-24 2:53 ` Anson Huang [this message]
2019-02-26 12:00 ` Aisheng Dong
2019-02-27 8:47 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB39164677D09DA6CB3A6951B3F5790@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).