From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8212FC433DF for ; Sun, 12 Jul 2020 01:36:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49C192078B for ; Sun, 12 Jul 2020 01:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gk6d2EqC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="I2Xf1K8S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49C192078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U5S06xR5k6lj10VBDlH1y2nMhQGJgqDjBiUJgnQ6WCo=; b=Gk6d2EqC6DuxKmAz2e2raTZpv Sqdhr6TJZJOi9J20jFcPgAEDBYl0P0x7MX1RY0ckc+E6NXNVbiBA8/eF0W9vbhbcKHtUHiMJm0FEN 7QZIHzFAOlAFA9x67iYklCgT4ImFiFltSW9e3OS78l1HrdvCnNwoYuus9+hMUx1izsg3LyAamrgUX +DwSc9MSOqsu+KYzGb9L/kp2m0iWiD7ureYVkF5un+c9ByS6fnYaAbE14GRHAExnXxYM7f7P/lVgU uxJ5YGu6k/7s55ioA+uMgLjl3+OuVZzcfY2gxKhGMeoIhFFKohjKlb5Nn09ucZ+0bQfATlxxPU4N+ uPk8jDyGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juQt9-0004PK-Cy; Sun, 12 Jul 2020 01:34:43 +0000 Received: from mail-am6eur05on2070.outbound.protection.outlook.com ([40.107.22.70] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juQt3-0004Og-Am for linux-arm-kernel@lists.infradead.org; Sun, 12 Jul 2020 01:34:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MfhrIdVK5fNqLFU6DcCOIByABf+vjWnrjYSPf7RF7L3FzFNoz5+1fZOMh4wCLt5Z61epHQ8oXxZqwdxcMS0vyXRu75RsnDpiyxFMngHWfa8DuQmFkpVVMRMZfrHwG/CUpQqQ8na3SXKEIM4bmlsnVCW64mxAy0q6QIk1bf1xiuX4uzI154A1rmW7FsUMlA54or0dSJ7WQg9ly1UNAtsm40VEB387Vn79fU/qX9GQ3oCLi6tn4Rn3JXXxlqVNsSiL/gYgpgEQjuQwlOyCXvVOCXd1AarvVbG/0XOO666ICNk16o/e/p2Gp6snU9TDrsMnoL+dS2ZUbyAxDRwfn8bvVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FWA5LldR/ITYyYt9suIYI7xvldpdc+5oQ5UqiDSk3qs=; b=SqjeTcvot3azpL+oIQDJXBMpd6OKrDFBFzFVng9Spjqc3F9kr0i7TXC+qbJ6XgVxBpngdUMJdjH0ZIQDV6WJrglqnYbU4E+U6VJfjMZThNUXiNX/Ze9rb38Fju2sdrXgSC7DkM52Wi29fbQyxpOigjRJvKGOt8rRh5X2j4lsDPs3K1lGh001z7NAfMmDOwmsDi7P6VVnLSPhmmERqeDnHMR8YdRY+WzPA/gwNiKlJY8FzdfAxvlXfx+xwk43vbz7Vs85+ZI3ykO31FP0zgmVAttcAp2Yg6Er5KOVRruhpioZ6Evm1qB50ZV73HsZl7lOqMlKbPj0N4zldBjQSjUQ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FWA5LldR/ITYyYt9suIYI7xvldpdc+5oQ5UqiDSk3qs=; b=I2Xf1K8SmaT1g+83OhY+VTBJ0bwokgbN21OkWvG32dZkqsLVrW5qEI3eGBcUZeTsZ7PU6m8L4gR9U6qV4z5Q/L3H3bnPVct4ALcxoTKHt1p0JT4PdA6tBr95JXoyKTjrPeyOxR5BiQMO4triCafUmc0/Kgqs10fbChMJmi/kgRY= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) by DBBPR04MB6027.eurprd04.prod.outlook.com (2603:10a6:10:c7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Sun, 12 Jul 2020 01:34:32 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::1dab:b68c:e028:acb3]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::1dab:b68c:e028:acb3%6]) with mapi id 15.20.3174.025; Sun, 12 Jul 2020 01:34:32 +0000 From: Anson Huang To: Linus Walleij Subject: RE: [PATCH 1/3] gpio: mxc: Support module build Thread-Topic: [PATCH 1/3] gpio: mxc: Support module build Thread-Index: AQHWVLZdNtvAex5vSUmx57p8ya+LG6kC6AIAgABGglA= Date: Sun, 12 Jul 2020 01:34:31 +0000 Message-ID: References: <1594164323-14920-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [183.192.22.69] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: eade3857-2a77-4ac9-7ce0-08d82603ba06 x-ms-traffictypediagnostic: DBBPR04MB6027: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JPzb10yjogyZg+9Z/UPWBI2rsl7G1PTUpMtArog7VuJXNeHz5Pqqx1AJhImnNxOZLKbmR07vK+uUtf9A3QaQq8vZlF8kBUjuTEWATj9WxdrJaf2zUKlQl5ndcLWIQgzB1/WBjC6YwVq1Pivlw1u8uMRoKI9/sj51dktLvTBcGDVE1omm6JXGkNSsz0mBYvdA8UeGtpnLpeB0dlEFWTpG0TZrw4vXqIfzCm4dxDMBomV/Rnxee9AM25iKv8Sz1zbzq5yIn3B6F97Jr8/JZ/Fj1TAonFMWZcyEtW5iohgD7lPVsDyC+5et8F57Lml14lU/yFKr9Q8MwViy2XholE4jew== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR0402MB3916.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(376002)(136003)(39850400004)(346002)(8936002)(478600001)(9686003)(4326008)(55016002)(7416002)(8676002)(86362001)(54906003)(6506007)(66446008)(26005)(66476007)(66556008)(66946007)(33656002)(2906002)(44832011)(52536014)(53546011)(64756008)(5660300002)(6916009)(186003)(316002)(7696005)(71200400001)(76116006)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MoemGWNAiGZI5wGyLxslNLU8z/wbY76oLk/b29ayCgUG5w5XIMiV6+BV0Sz/WHiUGXTV/ICwud1SLjM5LqZKTfzOJaGcdsSgAR2jJq+3F2KCckJizbQtJnzZiIUWA6bzcQEjGQTfy+3st7tKvIFn5/OE2GU3AC/qnmWqv31IHrIMBfA4nMYLRnElQb/X1Ec0aT147vN6gwHAK+UXdJk6p53LZbQo40XgpyPpcKD8faSx3CRTUI8C1y9WVQofoRFNmjQBbqo4cAj/fldLdEk4AC9INbaEg5i+IzPGi9gGmyveQm83WEzr2BmQe1DWQcUxt9dl+6B1I3vAZJY4NfLbQr9/HnG3Thud16uBYbAEAnTRXgcj7Vf5B0PCf5WcXJuGFE6erILjLGWlRRqK/C8qv5k4gi2760l5U4CI7HZzyph2arRTCksI4H9PZo1ZUGSTz1qRv/UTbN/TdIHlfP+DqjmRi3u/DvnhAJlUbIgPwsA= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB3PR0402MB3916.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eade3857-2a77-4ac9-7ce0-08d82603ba06 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2020 01:34:31.9590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gqcltgx23ISL2EmSGGi2BhqEMm6G77AwaqGrZi46tEWG1MC580HnyzERMLsDsNHp/FxObRMWvKpZAbOE76OB4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6027 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200711_213437_592508_15F2F93A X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Will Deacon , "open list:GPIO SUBSYSTEM" , Shawn Guo , Sascha Hauer , Olof Johansson , Russell King , Bjorn Andersson , "oleksandr.suvorov@toradex.com" , Bartosz Golaszewski , Vinod Koul , Andreas Kemnade , dl-linux-imx , Sascha Hauer , Catalin Marinas , Adam Ford , Leo Li , Fabio Estevam , Linux ARM , "hverkuil-cisco@xs4all.nl" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Linus > Subject: Re: [PATCH 1/3] gpio: mxc: Support module build > > On Wed, Jul 8, 2020 at 1:28 AM Anson Huang > wrote: > > > subsys_initcall(gpio_mxc_init); > > + > > +MODULE_AUTHOR("Shawn Guo "); > > +MODULE_DESCRIPTION("i.MX GPIO Driver"); MODULE_LICENSE("GPL"); > > You are making this modualrizable but keeping the subsys_initcall(), which > doesn't make very much sense. It is obviously not necessary to do this probe > at subsys_initcall() time, right? > If building it as module, the subsys_initcall() will be equal to module_init(), I keep it unchanged is because I try to make it identical when built-in, since most of the config will still have it built-in, except the Android GKI support. Does it make sense? > Take this opportunity to convert the driver to use > module_platform_driver() as well. If you think it has to be or it is better to use module_platform_driver(), I will do it in V2. thanks, Anson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel