From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E71C433E2 for ; Mon, 29 Jun 2020 11:41:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95DA223B85 for ; Mon, 29 Jun 2020 11:41:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IB65hZd9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="bfFDTp42" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95DA223B85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2sEgoOtu6O3QLoUXM5NV0WcvMtoe93hbTw5meMxXIS4=; b=IB65hZd9BqBw8kIBDO17XsYJn nDuepe4oCDPm+HAMVrVFxQlxBmbv75iWPbjH7ZTWlONPKXC5S5i2ZD5+Dk2nJCRsANdEa4FGoyXdS kyxCI04kGSHHXw8Iv9fOvm2lKB2iuLg/9Bmw9cSwQovisJVvsVSgo/dtPLotQpUbp3aq5H7RQCgin avB7gJv5CvXW6F0oupV51iGaXMinL+ShK9m9gG5KY9/BR8sMHGADcOVYBcnSym6jc3cQKJidMgFgv Y/LD/3DGRdDT8Gq/8mh+FSbF1FsgCg9ezhwrXJdU2rTWVD0aVLwoHEh2NE4c/NyZ4MWaKC0l1GZqA 8s3APUc3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jps8w-0003PP-9e; Mon, 29 Jun 2020 11:40:10 +0000 Received: from mail-eopbgr80047.outbound.protection.outlook.com ([40.107.8.47] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jps8u-0003Oy-CQ for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 11:40:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YO3o07DDqUJerIu/2ZGDFEtOVFt2UjutMM6KgbRXAessG80s/33l3mii4PwEzVV5lWtJbdRTc59sJhGb0qlgVihMJywsynjuPuXCSGaV/6ysOTaSK/OTwjG4gApf7dmipqqBOcbo4TIqRjMs9NZffs2AB6DEdzrOC5w32D4HBu/PUnSxEvEXMtxuyQmBGg7fC6S7+UEsqpYfQlstHVGmmMM2botUo4bxPpEyAVmFPMlZYiOvbXW17X84Nx5wcMQFyQ86PFHAyTFbRE5oWdzdlp/aZktUGTMNpnAErAfpq12FR6N+dMGHhzzrhxPo2dlLb5Ro3RZrmasUUQOZx5g6zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfXB+EZpSMPFT1/EmN1xK5a5OX3bppp/VU3jsFuoKx0=; b=GMjZallOAAEDVKs+AZz2XWcFpj9hNBSETR07r9zRCnqVVx1eTsE6N5tTDbkLBh/R79VQySdGODeqq6iHYs1X1ednzGRZZXDZhBw1PKSfILFT5emynK52/GoNHBX/4+CkUD7Po1j6o3juoXGICErljFfhlBbHuy634DF/ftZPgLShw/yIG6i1cgoL2BwQA9lYKzBQAH8FfdW0TVXPImZDPq1LmjF53TjsSqxXCOV/jPYCNdQsQaYyXrSkf/VjdaS3xTX/7GQKBJfKgC7UEcGTYIO8FxQrLjACSMuWDjHFWzYdw4fUHgNma6LfqRzZUdipEHnWMOkEykWOeEwTADr5/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfXB+EZpSMPFT1/EmN1xK5a5OX3bppp/VU3jsFuoKx0=; b=bfFDTp42gVCyaw74r+ciq9cuf7fupJC/Kx1qz3WVGuK9Ux4QwSMe+S0PbXWVroyb25D6tAf8DA4toDzxMAuOq0bboVSk3IHQY3KMpMaDwZqwEbNBJy2/u6xsbQsbwAJxz5J3LwUNYhzGpNdi21E2+cuxgOQWjOg0664ZHNMO+1w= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) by DB6PR04MB3014.eurprd04.prod.outlook.com (2603:10a6:6:8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Mon, 29 Jun 2020 11:40:05 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::1dab:b68c:e028:acb3]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::1dab:b68c:e028:acb3%6]) with mapi id 15.20.3131.027; Mon, 29 Jun 2020 11:40:05 +0000 From: Anson Huang To: Arnd Bergmann Subject: RE: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build Thread-Topic: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build Thread-Index: AQHWTdtegku2i+ERdU6EY9a3qfOcyajvdnIAgAABM5A= Date: Mon, 29 Jun 2020 11:40:05 +0000 Message-ID: References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [183.192.13.100] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 06f29aac-bd40-4303-ff1e-08d81c212b51 x-ms-traffictypediagnostic: DB6PR04MB3014: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: du4qRVP0fz3EAYxueQlmgJ2sqFaFNlH7BzsUvqfJDg0Y7K+mkmB6AUkAHKrtZACzHZ8JJ2U/Hc2WSkzSB6Wag0VgQz1ZJNMl1laP09lnLIgdPCMpp2ULNUKIBzJjJS4GuVTOkQgGTh9Oub3UkbDWY5+yLdPhX5+vaeP3p6W9bw0H339qFQ5/3eGMRyQu4CWiUQuOSaSzD+WF6hERcWOO6UHx8qHClbtmCvrkGqjKiVL010jiDB+cf/6wJAbHFERuuOIPGFqo+EoIe1YLHr5DA0rlgNDC+YV3KZBtUX1WBnQ1yqPloKpty/wtCt+a1O9334qZM8ClW4un72dRJxorSw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR0402MB3916.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(316002)(6506007)(8936002)(6916009)(54906003)(26005)(5660300002)(71200400001)(83380400001)(186003)(53546011)(66446008)(76116006)(66946007)(7696005)(66556008)(64756008)(4326008)(66476007)(4744005)(44832011)(7416002)(9686003)(8676002)(55016002)(2906002)(52536014)(86362001)(33656002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Z0LFeI6O0iA0QHbwE5UsaGuEkVQX3tz7NlH1iM/kL5Ch/AvGc7btgUSl64mhDuskOwtQQWxark2qTUcUeq/0OiN7gl61tKP0LZTrmVT5gd13HpoIbKhcEKvpXHYf8TWKLhI11qQLntgh43vY6Rxhfh2qNO5jeUwwvAR5rJdtxaQg84hPotQPMPVWhRaTS4MY42HUxdZg7xQyyvFydvXr13pQc47DfcEFjt5O/4x3+yVRfxjojfa2hLmT8mcm1YuFGNAxQZsaw/dobwXamYGVTP52DpMxIH8EKwwcFfyFDFJ+hA0duwW+vWQTzVp7JqrQWEUTZlgCfiSs/RMuNnWIZmuVH03teOubf9GNYjjrt3VATNvnWoJb5hy1AHbGLLTLIUyHBME5s69/1YQOwO6waF38a463D+HNzq2GAk1FSeOJfwaRUDgjQV/e8ynDD1EN94dYMPpi9Uc72YqoO8RFN4wNZ+Mag7D9hjD2cUZRvcgG8Y93WT03WZ2D2lh4wZh0 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB3PR0402MB3916.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06f29aac-bd40-4303-ff1e-08d81c212b51 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 11:40:05.7678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xnoV0g+stdj5soVP4lvuUu93wjUMS1PBv315Yv9dqchGVatzq3wbwJc5stiSZ9ExcDEUe6gNOSjGaQmWYYQ+iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3014 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Stephen Rothwell , Peng Fan , linux-clk , Andy Duan , Abel Vesa , Stefan Agner , Stephen Boyd , Shawn Guo , Sascha Hauer , YueHaibing , Russell King - ARM Linux , Daniel Baluta , "linux-kernel@vger.kernel.org" , "oleksandr.suvorov@toradex.com" , Al Viro , Sascha Hauer , Fabio Estevam , Michael Turquette , Linux ARM , dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Arnd > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for > module build > > On Mon, Jun 29, 2020 at 8:06 AM Anson Huang > wrote: > > > > Keep __setup_param() to use same parameters for both built in and > > built as module, it can make the drivers which call it easier when the > > drivers can be built in or built as module. > > > > Signed-off-by: Anson Huang > > I wonder if we should instead drop the __setup() and __setup_param() > definitions from the #else block here. This was clearly not used anywhere, and > it sounds like any possible user is broken and should be changed to not use > __setup() anyway. > It makes sense to drop the __setup() and __serup_param() in the #else block, just use one definition for all cases, if no one objects, I will remove them in next patch series. Thanks, Anson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel