RE: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY

From: Anson Huang <anson.huang@nxp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Ronald Tschalär" <ronald@innovation.ch>,
	"Guenter Roeck" <linux@roeck-us.net>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Linux PM" <linux-pm@vger.kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Oleksij Rempel" <linux@rempel-privat.de>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Shawn Guo" <shawnguo@kernel.org>
Subject: RE: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY
Date: Sat, 7 Mar 2020 01:01:19 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916D31AEF0CEA8E4DC42BC3F5E00@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200307005146.GM217608@dtor-ws>

Hi, Dmitry

> Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for
> KEYBOARD_IMX_SC_KEY
> 
> On Sat, Mar 07, 2020 at 12:18:38AM +0000, Anson Huang wrote:
> > Hi, Dmitry
> >
> > > Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support
> > > for KEYBOARD_IMX_SC_KEY
> > >
> > > On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov
> > > <dmitry.torokhov@gmail.com> wrote:
> > > >
> > > > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote:
> > > > > Add COMPILE_TEST support to i.MX SC keyboard driver for better
> > > > > compile testing coverage.
> > > > >
> > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > >
> > > > Applied, thank you.
> > >
> > > Actually, not:
> > >
> > > ERROR: "imx_scu_irq_register_notifier"
> > > [drivers/input/keyboard/imx_sc_key.ko] undefined!
> > > ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko]
> > > undefined!
> > > ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko]
> > > undefined!
> > > ERROR: "imx_scu_irq_unregister_notifier"
> > > [drivers/input/keyboard/imx_sc_key.ko] undefined!
> > > ERROR: "imx_scu_irq_group_enable"
> > > [drivers/input/keyboard/imx_sc_key.ko] undefined!
> > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> > > make: *** [Makefile:1282: modules] Error 2
> > >
> > > If you want to enable compile test coverage you need to provide
> > > stubs for the above functions.
> >
> > These i.MX SCU drivers depends on IMX_SCU, I already add the
> > COMPILE_TEST to IMX_SCU driver as well, that is why I put these patches in
> a patch series.
> 
> Adding "|| COMPILE_TEST" you are removing hard dependency on IMX_SCU,
> which as you can see can result in broken build.
> 
> > Maybe
> > I can add stubs as well to make sure build passed even when IMX_SCU is
> NOT compiled?
> > Will send V2 to add stubs, it makes more sense.
> 
> It is up to you whether you make IMX_SCU buildable with COMPILE_TEST and
> leave the sub-driver as is, or add the stubs and make sub-drivers buildable
> even without IMX_SCU being present.

Thank you, I already added COMPILE_TEST to IMX_SCU driver, and I will also add
stubs for those APIs in V2.

Thanks,
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel