From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECE3C433DF for ; Mon, 27 Jul 2020 06:29:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E53E20714 for ; Mon, 27 Jul 2020 06:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oEjmvGke"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="CtqkSsjU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E53E20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rjfMIuOr6+SYzR9pFp1OuHseUbSQp/FHOx1C9/Iw/9U=; b=oEjmvGkeW+j6apsAR3521eQbe H7069/eKFKIv3J7W6g0XrToNNE4+GCur3aAl8TObcFJMWWHwO/fUHBzC3P5Eh67v8jEL5NFmXmJzq WU3vIJ3iM6gGWFi3k16jAO5NCHoBa2OMDQ1AmvBtyjTEUI+sG2b4fKWeqQRKJ9Z50lLt3QWIot1yk fLlOKUXHDxQoAj+p6Qy4G7uo8ugMYngVaDmGLfEqnlcLE0pXxITlWBOLYPG6EXHjqPTOrI9u9AS+a knJFlnTBr6zP4MRWRNvL9x/moxoFsv9o7sgadb3YEkfXxAu9cyFzWA152QzjdO/XoZ35qvTAR6+eu BC40CUXiw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzwcb-00015D-RG; Mon, 27 Jul 2020 06:28:25 +0000 Received: from mail-eopbgr60045.outbound.protection.outlook.com ([40.107.6.45] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzwcZ-00014U-Q9 for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 06:28:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTZaeKR8g7RbTd9s4r5OFpMBzQgd+u6RmnEuFaLICB1HHFt5GzXw0uIJBJFS2AUy7OajIkdHVSNpyB4zxXnv0Ivq5rO1VjFyQVgUKay0y/8vPLEG1Q8dyVcV4+s1TkgFQocdMVjbvmJmzF1u4z3u8HukCRh3sqFy1Gh2Z0yHgNiQXxYJ9wiyzxnvjLRP0otNSN/rapi1Sm2dZBD5wUM4RMt+LrfKXO5vAiCzXlqWsYA8S1Lvtfmc9u5ncyx7ZkJxoUMyLl/ive9Jt13KR6eLVifRopk2S6BE+1b48J/tkJ69Sc9I4uFPz19jsurRt5Yuz7KwP1uOdEE8RGdtU2oLWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T1bGtu1I81KG2zjmMZaeQOPhN4wOHp+3b0hFNotK1tc=; b=CD67xep2HRq4jJQvyvh3COk4DaWRQ77/g1vMhE1tnjJtowID6lOBjUEBd76HGLl0IF6I2r7/8VbVitqRVCxZsPptS7I9HKRmZcxnXbfeNHgZUOcOOO+hlWUR9r05EOJjZmtyzxX4RMS+0NLIJdT0lXK/bqVOcmA8hq7OZ82d/kJ0oYXvySqpZ4DHT1SW7hekHQ8p/PA2QM4B499+lo6dlvtcId/RdJWieqqN7h44YvLgIgaDHnvpC+ISSYVU5LFUELBpLbcuxmreLWjcBFvNyP4GdHxS0RsJ9z9XxeKrvfytAR2HuuZPZs23VDiwUDsqSFrbe9vMd5hVwIVNqdUDOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T1bGtu1I81KG2zjmMZaeQOPhN4wOHp+3b0hFNotK1tc=; b=CtqkSsjUauYK5GTLg9uKnwr3uGo3IMPqFLFKsoqwRZbbBzA/ILfJyz5vjHv/Y0Y/DK73CBUq0TexEcIoMEuRvSge+cjDPfUTQFQlcRL8gflIfc5Jd7YV07OOFJ7miKqFWBN5s/AcG7CIF3c57fjhDDdAqg+REOQIigvTkxOOxNo= Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5084.eurprd04.prod.outlook.com (2603:10a6:10:1c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Mon, 27 Jul 2020 06:28:20 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::2d36:b569:17c:7701]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::2d36:b569:17c:7701%4]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 06:28:20 +0000 From: Peng Fan To: Oleksij Rempel Subject: RE: [PATCH 03/10] remoteproc: imx: use devm_ioremap Thread-Topic: [PATCH 03/10] remoteproc: imx: use devm_ioremap Thread-Index: AQHWYY4mj2fkhyJv70m2EtieoGp7X6ka+c2AgAAA2pA= Date: Mon, 27 Jul 2020 06:28:20 +0000 Message-ID: References: <20200724080813.24884-1-peng.fan@nxp.com> <20200724080813.24884-4-peng.fan@nxp.com> <20200727062335.v2pxgu6kr6ao2qmh@pengutronix.de> In-Reply-To: <20200727062335.v2pxgu6kr6ao2qmh@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1f19ad30-6690-401a-f985-08d831f6417b x-ms-traffictypediagnostic: DB7PR04MB5084: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dog41px9w5VBTsDXwutOEjclDuKhX7qXb5BR8B5CLphNBmCBBvkmo6jgP4KUl/Lx8FqYBowecclKlR0+P8fX37UdacMHiH4RNo6zZSpy1zac1mGwfMO5cOwdAqKlTSh2ltJzTniS1hq/fuFDvm/z5fHuslUPHk8WVxakxp+xbZ3h0YRHA/MoLMhbdRtFDNSMA1uHE3UEt+XtDqdcPoh92Dn4hPYQCZ/n9/wZYTC37Uywmy2IFpc6GX4xuxH4/HMxgYdCGnAxHA1bFh56eQFsWe/t0GunfaNs4eJCtSGAHa4YUWJaXSqSDTBc1UVyBOnDGEAhdHRPnbtkZIjHcY3zDuoTl1QUq8rAX6YUjI3mr9DnVHvOiEtVl0WVmeGTsG7d2WV5bYwhVTMerVJws3fSOg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(6916009)(6506007)(9686003)(52536014)(8936002)(478600001)(26005)(5660300002)(316002)(4326008)(186003)(33656002)(54906003)(8676002)(66946007)(66476007)(66556008)(66446008)(64756008)(83080400001)(2906002)(76116006)(86362001)(83380400001)(44832011)(7416002)(7696005)(966005)(55016002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: hBl3GAZEAacVU4Asimb++hp6tt5Q5t5db+8ja0E9jyNgIvnbYIeq9sPsr/reeyfPhzsDngElGMc2QdNW0uf2vCHyJrhnnVFbQhJqpXqZIVtGBWq3LMuQri4g8y0XVyQOi1eY9pPcQiqkiOmZzsBmtPJQTKlndc7ISX0XB50cwVACu7TSluGKo+TM/fe4BcAPCsIU/2ZEIiWlkNRYMTLzx8X+sUTqFLkzn7u1b3YEL8C0RcotA3tey4MmaNnxTUIn1+E94ydOU2FalghwgnGAeI968ipHZbr0bagFZPgBR0MNlyOinH67rdCOjFVMyIKt85cRbQ2D546PeFWAsqwhXmxhfDZv5a1o1MvN3tPKm2Dljfn/cuY88KieuuZ/kB0jh5L2CETBgOJZYdg0p7ciqgnW2lfw7lGoagFG7ddKxffGhawE4pmuPMsxgBzgc8xChWbBCBhypC7lmyepSIVomJ4nQ9/yJKAPv/U+AFS3bCY= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f19ad30-6690-401a-f985-08d831f6417b X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 06:28:20.2435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dNL4XnYNHxdpkj8hixsfnxTmlzehJJQaMFC21+CHmdZbBg7VecO0NbmeOG04HDhgpXDYzGk/Aq7BVe3Ohk+OVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5084 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_022823_861991_3588B4D2 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "mathieu.poirier@linaro.org" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bjorn.andersson@linaro.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Oleksij, > Subject: Re: [PATCH 03/10] remoteproc: imx: use devm_ioremap > > On Fri, Jul 24, 2020 at 04:08:06PM +0800, Peng Fan wrote: > > We might need to map an region multiple times, becaue the region might > > be shared between remote processors, such i.MX8QM with dual M4 cores. > > So use devm_ioremap, not devm_ioremap_resource. > > Can you please give an example of this kind of shared resources and how they > should be handled by two separate devices? This is to share vdevbuffer space, there is a vdevbuffer in device tree, it will be shared between M4_0 and M4_1. For the buffer, it is Linux DMA API will handle the space. Thanks, Peng. > > > Reviewed-by: Richard Zhu > > Signed-off-by: Peng Fan > > --- > > drivers/remoteproc/imx_rproc.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index 3b3904ebac75..82594a800a1b > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -296,9 +296,10 @@ static int imx_rproc_addr_init(struct imx_rproc > *priv, > > if (b >= IMX7D_RPROC_MEM_MAX) > > break; > > > > - priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, > &res); > > + /* Not use resource version, because we might share region*/ > > + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, > > +resource_size(&res)); > > if (IS_ERR(priv->mem[b].cpu_addr)) { > > - dev_err(dev, "devm_ioremap_resource failed\n"); > > + dev_err(dev, "devm_ioremap %pR failed\n", &res); > > err = PTR_ERR(priv->mem[b].cpu_addr); > > return err; > > } > > -- > > 2.16.4 > > > > > > -- > Pengutronix e.K. | > | > Steuerwalder Str. 21 | > http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: > +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel