* [PATCH V5 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains
2021-05-21 10:59 [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
@ 2021-05-21 10:59 ` Peng Fan (OSS)
2021-05-21 10:59 ` [PATCH V5 2/4] Documentation: bindings: clk: Add bindings for i.MX BLK_CTL Peng Fan (OSS)
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Peng Fan (OSS) @ 2021-05-21 10:59 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, p.zabel, l.stach, krzk, agx, marex,
andrew.smirnov, devicetree, linux-arm-kernel, linux-kernel,
ping.bai, frieder.schrempf, aford173, abel.vesa, Peng Fan,
Rob Herring
From: Peng Fan <peng.fan@nxp.com>
Adding the defines for i.MX8MM BLK-CTL power domains.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Acked-by: Rob Herring <robh@kernel.org>
---
include/dt-bindings/power/imx8mm-power.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/include/dt-bindings/power/imx8mm-power.h b/include/dt-bindings/power/imx8mm-power.h
index fc9c2e16aadc..982ca2939cdc 100644
--- a/include/dt-bindings/power/imx8mm-power.h
+++ b/include/dt-bindings/power/imx8mm-power.h
@@ -19,4 +19,17 @@
#define IMX8MM_POWER_DOMAIN_DISPMIX 10
#define IMX8MM_POWER_DOMAIN_MIPI 11
+#define IMX8MM_BLK_CTL_PD_VPU_G2 0
+#define IMX8MM_BLK_CTL_PD_VPU_G1 1
+#define IMX8MM_BLK_CTL_PD_VPU_H1 2
+#define IMX8MM_BLK_CTL_PD_VPU_BUS 3
+#define IMX8MM_BLK_CTL_PD_VPU_MAX 4
+
+#define IMX8MM_BLK_CTL_PD_DISPMIX_CSI_BRIDGE 0
+#define IMX8MM_BLK_CTL_PD_DISPMIX_LCDIF 1
+#define IMX8MM_BLK_CTL_PD_DISPMIX_MIPI_DSI 2
+#define IMX8MM_BLK_CTL_PD_DISPMIX_MIPI_CSI 3
+#define IMX8MM_BLK_CTL_PD_DISPMIX_BUS 4
+#define IMX8MM_BLK_CTL_PD_DISPMIX_MAX 5
+
#endif
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH V5 2/4] Documentation: bindings: clk: Add bindings for i.MX BLK_CTL
2021-05-21 10:59 [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
2021-05-21 10:59 ` [PATCH V5 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains Peng Fan (OSS)
@ 2021-05-21 10:59 ` Peng Fan (OSS)
2021-05-21 10:59 ` [PATCH V5 3/4] soc: imx: Add generic blk-ctl driver Peng Fan (OSS)
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Peng Fan (OSS) @ 2021-05-21 10:59 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, p.zabel, l.stach, krzk, agx, marex,
andrew.smirnov, devicetree, linux-arm-kernel, linux-kernel,
ping.bai, frieder.schrempf, aford173, abel.vesa, Peng Fan,
Rob Herring
From: Peng Fan <peng.fan@nxp.com>
Document the i.MX BLK_CTL with its devicetree properties.
Each BLK CTL have different power domain inputs and they have different
names, so we are not able to list all the power domain names for each
BLK CTL here.
For example:
i.MX8MM dispmix BLK CTL, it has
power-domains = <&pgc_dispmix>, <&pgc_mipi>;
power-domain-names = "dispmix", "mipi";
vpumix BLK CTL, it has
power-domains = <&vpumix_pd>, <&vpu_g1_pd>, <&vpu_g2_pd>,
<&vpu_h1_pd>;
power-domain-names = "vpumix", "g1", "g2", "h1";
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
new file mode 100644
index 000000000000..a66f11acc6b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/imx/fsl,imx-blk-ctl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX BLK_CTL
+
+maintainers:
+ - Peng Fan <peng.fan@nxp.com>
+
+description:
+ i.MX BLK_CTL is a conglomerate of different GPRs that are
+ dedicated to a specific subsystem. It usually contains
+ clocks and resets amongst other things. Here we take the clocks
+ and resets as virtual PDs, the reason we could not take it as
+ clock provider is there is A/B lock issue between power domain
+ and clock.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - fsl,imx8mm-dispmix-blk-ctl
+ - fsl,imx8mm-vpumix-blk-ctl
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ "#power-domain-cells":
+ const: 1
+
+ power-domains:
+ minItems: 1
+ maxItems: 32
+
+ power-domain-names:
+ minItems: 1
+ maxItems: 32
+
+ clocks:
+ minItems: 1
+ maxItems: 32
+
+required:
+ - compatible
+ - reg
+ - power-domains
+ - power-domain-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx8mm-clock.h>
+
+ dispmix_blk_ctl: blk-ctl@32e28000 {
+ compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon";
+ reg = <0x32e28000 0x100>;
+ #power-domain-cells = <1>;
+ power-domains = <&pgc_dispmix>, <&pgc_mipi>;
+ power-domain-names = "dispmix", "mipi";
+ clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
+ <&clk IMX8MM_CLK_DISP_APB_ROOT>;
+ };
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH V5 3/4] soc: imx: Add generic blk-ctl driver
2021-05-21 10:59 [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
2021-05-21 10:59 ` [PATCH V5 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains Peng Fan (OSS)
2021-05-21 10:59 ` [PATCH V5 2/4] Documentation: bindings: clk: Add bindings for i.MX BLK_CTL Peng Fan (OSS)
@ 2021-05-21 10:59 ` Peng Fan (OSS)
2021-05-21 10:59 ` [PATCH V5 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Peng Fan (OSS)
2021-05-21 15:37 ` [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Adam Ford
4 siblings, 0 replies; 9+ messages in thread
From: Peng Fan (OSS) @ 2021-05-21 10:59 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, p.zabel, l.stach, krzk, agx, marex,
andrew.smirnov, devicetree, linux-arm-kernel, linux-kernel,
ping.bai, frieder.schrempf, aford173, abel.vesa, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
The i.MX8MM introduces an IP named BLK_CTL and usually is comprised of
some GPRs.
The GPRs has some clock bits and reset bits, but here we take it
as virtual PDs, because of the clock and power domain A/B lock issue
when taking it as a clock controller.
For some bits, it might be good to also make it as a reset controller,
but to i.MX8MM, we not add that support for now.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/soc/imx/Makefile | 2 +-
drivers/soc/imx/blk-ctl.c | 311 ++++++++++++++++++++++++++++++++++++++
drivers/soc/imx/blk-ctl.h | 85 +++++++++++
3 files changed, 397 insertions(+), 1 deletion(-)
create mode 100644 drivers/soc/imx/blk-ctl.c
create mode 100644 drivers/soc/imx/blk-ctl.h
diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile
index 078dc918f4f3..d3d2b49a386c 100644
--- a/drivers/soc/imx/Makefile
+++ b/drivers/soc/imx/Makefile
@@ -4,4 +4,4 @@ obj-$(CONFIG_ARCH_MXC) += soc-imx.o
endif
obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o
obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o
-obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o
+obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o blk-ctl.o
diff --git a/drivers/soc/imx/blk-ctl.c b/drivers/soc/imx/blk-ctl.c
new file mode 100644
index 000000000000..1025415eef42
--- /dev/null
+++ b/drivers/soc/imx/blk-ctl.c
@@ -0,0 +1,311 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2021 NXP.
+ */
+
+#include <linux/clk.h>
+#include <linux/completion.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+#include <linux/string.h>
+#include <linux/types.h>
+#include <linux/pm_domain.h>
+#include <linux/reset-controller.h>
+
+#include "blk-ctl.h"
+
+static inline struct imx_blk_ctl_domain *to_imx_blk_ctl_pd(struct generic_pm_domain *genpd)
+{
+ return container_of(genpd, struct imx_blk_ctl_domain, genpd);
+}
+
+static int imx_blk_ctl_enable_hsk(struct device *dev)
+{
+ struct imx_blk_ctl *blk_ctl = dev_get_drvdata(dev);
+ const struct imx_blk_ctl_hw *hw = blk_ctl->dev_data->hw_hsk;
+ struct regmap *regmap = blk_ctl->regmap;
+ int ret;
+
+ if (hw->flags & IMX_BLK_CTL_PD_RESET) {
+ ret = regmap_update_bits(regmap, hw->rst_offset, hw->rst_mask, hw->rst_mask);
+ if (ret)
+ return ret;
+ }
+
+ ret = regmap_update_bits(regmap, hw->offset, hw->mask, hw->mask);
+
+ /* Wait for handshake */
+ udelay(5);
+
+ return ret;
+}
+
+int imx_blk_ctl_power_on(struct generic_pm_domain *domain)
+{
+ struct imx_blk_ctl_domain *pd = to_imx_blk_ctl_pd(domain);
+ struct imx_blk_ctl *blk_ctl = pd->blk_ctl;
+ struct regmap *regmap = blk_ctl->regmap;
+ const struct imx_blk_ctl_hw *hw = &blk_ctl->dev_data->pds[pd->id];
+ int ret;
+
+ mutex_lock(&blk_ctl->lock);
+
+ ret = clk_bulk_prepare_enable(blk_ctl->num_clks, blk_ctl->clks);
+ if (ret) {
+ mutex_unlock(&blk_ctl->lock);
+ return ret;
+ }
+
+ if (hw->flags & IMX_BLK_CTL_PD_HANDSHAKE) {
+ ret = imx_blk_ctl_enable_hsk(blk_ctl->dev);
+ if (ret)
+ dev_err(blk_ctl->dev, "Hankshake failed when power on\n");
+
+ goto disable_clk;
+ }
+
+ if (hw->flags & IMX_BLK_CTL_PD_RESET) {
+ ret = regmap_clear_bits(regmap, hw->rst_offset, hw->rst_mask);
+ if (ret)
+ goto disable_clk;
+ }
+
+ /* Wait for reset propagate */
+ udelay(5);
+
+ if (hw->flags & IMX_BLK_CTL_PD_RESET) {
+ ret = regmap_update_bits(regmap, hw->rst_offset, hw->rst_mask, hw->rst_mask);
+ if (ret)
+ goto disable_clk;
+ }
+
+ ret = regmap_update_bits(regmap, hw->offset, hw->mask, hw->mask);
+ if (ret)
+ goto disable_clk;
+
+disable_clk:
+ clk_bulk_disable_unprepare(blk_ctl->num_clks, blk_ctl->clks);
+
+ mutex_unlock(&blk_ctl->lock);
+
+ return ret;
+}
+
+int imx_blk_ctl_power_off(struct generic_pm_domain *domain)
+{
+ struct imx_blk_ctl_domain *pd = to_imx_blk_ctl_pd(domain);
+ struct imx_blk_ctl *blk_ctl = pd->blk_ctl;
+ struct regmap *regmap = blk_ctl->regmap;
+ const struct imx_blk_ctl_hw *hw = &blk_ctl->dev_data->pds[pd->id];
+ int ret;
+
+ mutex_lock(&blk_ctl->lock);
+
+ ret = clk_bulk_prepare_enable(blk_ctl->num_clks, blk_ctl->clks);
+ if (ret) {
+ mutex_unlock(&blk_ctl->lock);
+ return ret;
+ }
+
+ if (!(hw->flags & IMX_BLK_CTL_PD_HANDSHAKE)) {
+ ret = regmap_clear_bits(regmap, hw->offset, hw->mask);
+ if (ret)
+ goto hsk_fail;
+
+ if (hw->flags & IMX_BLK_CTL_PD_RESET) {
+ ret = regmap_clear_bits(regmap, hw->rst_offset, hw->rst_mask);
+ if (ret)
+ goto hsk_fail;
+ }
+ }
+
+ if (hw->flags & IMX_BLK_CTL_PD_HANDSHAKE) {
+ ret = imx_blk_ctl_enable_hsk(blk_ctl->dev);
+ if (ret)
+ dev_err(blk_ctl->dev, "Hankshake failed when power off\n");
+ }
+
+hsk_fail:
+ clk_bulk_disable_unprepare(blk_ctl->num_clks, blk_ctl->clks);
+
+ mutex_unlock(&blk_ctl->lock);
+
+ return ret;
+}
+
+static int imx_blk_ctl_probe(struct platform_device *pdev)
+{
+ struct imx_blk_ctl_domain *domain = pdev->dev.platform_data;
+ struct imx_blk_ctl *blk_ctl = domain->blk_ctl;
+ struct generic_pm_domain *parent_genpd;
+ struct device *dev = &pdev->dev;
+ struct device *active_pd;
+ int ret;
+
+ if (domain->hw->active_pd_name) {
+ active_pd = dev_pm_domain_attach_by_name(dev, domain->hw->active_pd_name);
+ if (IS_ERR_OR_NULL(active_pd)) {
+ ret = PTR_ERR(active_pd) ? : -ENODATA;
+ return ret;
+ }
+ domain->active_pd = active_pd;
+ } else {
+ if (!blk_ctl->bus_domain)
+ return -EPROBE_DEFER;
+ }
+
+ if (domain->hw->active_pd_name)
+ parent_genpd = pd_to_genpd(active_pd->pm_domain);
+ else
+ parent_genpd = blk_ctl->bus_domain;
+
+ if (pm_genpd_add_subdomain(parent_genpd, &domain->genpd)) {
+ pr_warn("failed to add subdomain: %s\n", domain->genpd.name);
+ } else {
+ mutex_lock(&blk_ctl->lock);
+ domain->hooked = true;
+ mutex_unlock(&blk_ctl->lock);
+ }
+
+ return 0;
+}
+
+static int imx_blk_ctl_remove(struct platform_device *pdev)
+{
+ return 0;
+}
+
+static const struct platform_device_id imx_blk_ctl_id[] = {
+ { "imx-vpumix-blk-ctl", },
+ { "imx-dispmix-blk-ctl", },
+ { },
+};
+
+static struct platform_driver imx_blk_ctl_driver = {
+ .driver = {
+ .name = "imx-blk-ctl",
+ },
+ .probe = imx_blk_ctl_probe,
+ .remove = imx_blk_ctl_remove,
+ .id_table = imx_blk_ctl_id,
+};
+builtin_platform_driver(imx_blk_ctl_driver)
+
+static struct generic_pm_domain *imx_blk_ctl_genpd_xlate(struct of_phandle_args *genpdspec,
+ void *data)
+{
+ struct genpd_onecell_data *genpd_data = data;
+ unsigned int idx = genpdspec->args[0];
+ struct imx_blk_ctl_domain *domain;
+ struct generic_pm_domain *genpd = ERR_PTR(-EINVAL);
+
+ if (genpdspec->args_count != 1)
+ return ERR_PTR(-EINVAL);
+
+ if (idx >= genpd_data->num_domains) {
+ pr_err("%s: invalid domain index %u\n", __func__, idx);
+ return ERR_PTR(-EINVAL);
+ }
+
+ if (!genpd_data->domains[idx])
+ return ERR_PTR(-ENOENT);
+
+ domain = to_imx_blk_ctl_pd(genpd_data->domains[idx]);
+ mutex_lock(&domain->blk_ctl->lock);
+ if (domain->hooked)
+ genpd = genpd_data->domains[idx];
+ mutex_unlock(&domain->blk_ctl->lock);
+
+ return genpd;
+}
+
+int imx_blk_ctl_register(struct device *dev)
+{
+ struct imx_blk_ctl *blk_ctl = dev_get_drvdata(dev);
+ const struct imx_blk_ctl_dev_data *dev_data = blk_ctl->dev_data;
+ int num = dev_data->pds_num;
+ struct imx_blk_ctl_domain *domain;
+ struct generic_pm_domain *genpd;
+ struct platform_device *pd_pdev;
+ int domain_index;
+ int i, ret;
+
+ blk_ctl->onecell_data.num_domains = num;
+ blk_ctl->onecell_data.xlate = imx_blk_ctl_genpd_xlate;
+ blk_ctl->onecell_data.domains = devm_kcalloc(dev, num, sizeof(struct generic_pm_domain *),
+ GFP_KERNEL);
+ if (!blk_ctl->onecell_data.domains)
+ return -ENOMEM;
+
+ for (i = 0; i < num; i++) {
+ domain_index = dev_data->pds[i].id;
+ if (domain_index >= num) {
+ dev_warn(dev, "Domain index %d is out of bounds\n", domain_index);
+ continue;
+ }
+
+ domain = devm_kzalloc(dev, sizeof(struct imx_blk_ctl_domain), GFP_KERNEL);
+ if (!domain)
+ goto error;
+
+ pd_pdev = platform_device_alloc(dev_data->name, domain_index);
+ if (!pd_pdev) {
+ dev_err(dev, "Failed to allocate platform device\n");
+ goto error;
+ }
+
+ pd_pdev->dev.platform_data = domain;
+
+ domain->blk_ctl = blk_ctl;
+ domain->hw = &dev_data->pds[i];
+ domain->id = domain_index;
+ domain->genpd.name = dev_data->pds[i].name;
+ domain->genpd.power_off = imx_blk_ctl_power_off;
+ domain->genpd.power_on = imx_blk_ctl_power_on;
+ domain->dev = &pd_pdev->dev;
+ domain->hooked = false;
+
+ ret = pm_genpd_init(&domain->genpd, NULL, true);
+ pd_pdev->dev.parent = dev;
+ pd_pdev->dev.of_node = dev->of_node;
+
+ if (domain->hw->flags & IMX_BLK_CTL_PD_HANDSHAKE)
+ blk_ctl->bus_domain = &domain->genpd;
+
+ ret = platform_device_add(pd_pdev);
+ if (ret) {
+ platform_device_put(pd_pdev);
+ goto error;
+ }
+ blk_ctl->onecell_data.domains[i] = &domain->genpd;
+ }
+
+ return of_genpd_add_provider_onecell(dev->of_node, &blk_ctl->onecell_data);
+
+error:
+ for (; i >= 0; i--) {
+ genpd = blk_ctl->onecell_data.domains[i];
+ if (!genpd)
+ continue;
+ domain = to_imx_blk_ctl_pd(genpd);
+ if (domain->dev)
+ platform_device_put(to_platform_device(domain->dev));
+ }
+ return ret;
+}
+EXPORT_SYMBOL_GPL(imx_blk_ctl_register);
+
+const struct dev_pm_ops imx_blk_ctl_pm_ops = {
+ SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+ pm_runtime_force_resume)
+};
+EXPORT_SYMBOL_GPL(imx_blk_ctl_pm_ops);
diff --git a/drivers/soc/imx/blk-ctl.h b/drivers/soc/imx/blk-ctl.h
new file mode 100644
index 000000000000..6780d00ec8c5
--- /dev/null
+++ b/drivers/soc/imx/blk-ctl.h
@@ -0,0 +1,85 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __SOC_IMX_BLK_CTL_H
+#define __SOC_IMX_BLK_CTL_H
+
+enum imx_blk_ctl_pd_type {
+ BLK_CTL_PD,
+};
+
+struct imx_blk_ctl_hw {
+ int type;
+ char *name;
+ char *active_pd_name;
+ u32 offset;
+ u32 mask;
+ u32 flags;
+ u32 id;
+ u32 rst_offset;
+ u32 rst_mask;
+ u32 errata;
+};
+
+struct imx_blk_ctl_domain {
+ struct generic_pm_domain genpd;
+ struct device *active_pd;
+ struct imx_blk_ctl *blk_ctl;
+ struct imx_blk_ctl_hw *hw;
+ struct device *dev;
+ bool hooked;
+ u32 id;
+};
+
+struct imx_blk_ctl_dev_data {
+ struct regmap_config config;
+ struct imx_blk_ctl_hw *pds;
+ struct imx_blk_ctl_hw *hw_hsk;
+ u32 pds_num;
+ u32 max_num;
+ char *name;
+};
+
+struct imx_blk_ctl {
+ struct device *dev;
+ struct regmap *regmap;
+ struct genpd_onecell_data onecell_data;
+ const struct imx_blk_ctl_dev_data *dev_data;
+ struct clk_bulk_data *clks;
+ u32 num_clks;
+ struct generic_pm_domain *bus_domain;
+
+ struct mutex lock;
+};
+
+#define IMX_BLK_CTL(_type, _name, _active_pd, _id, _offset, _mask, _rst_offset, _rst_mask, \
+ _flags, _errata) \
+ { \
+ .type = _type, \
+ .name = _name, \
+ .active_pd_name = _active_pd, \
+ .id = _id, \
+ .offset = _offset, \
+ .mask = _mask, \
+ .flags = _flags, \
+ .rst_offset = _rst_offset, \
+ .rst_mask = _rst_mask, \
+ .errata = _errata, \
+ }
+
+#define IMX_BLK_CTL_PD(_name, _active_pd, _id, _offset, _mask, _rst_offset, _rst_mask, _flags) \
+ IMX_BLK_CTL(BLK_CTL_PD, _name, _active_pd, _id, _offset, _mask, _rst_offset, \
+ _rst_mask, _flags, 0)
+
+#define IMX_BLK_CTL_PD_ERRATA(_name, _active_pd, _id, _offset, _mask, _rst_offset, _rst_mask, \
+ _flags, _errata) \
+ IMX_BLK_CTL(BLK_CTL_PD, _name, _active_pd, _id, _offset, _mask, _rst_offset, \
+ _rst_mask, _flags, _errata)
+
+int imx_blk_ctl_register(struct device *dev);
+
+#define IMX_BLK_CTL_PD_HANDSHAKE BIT(0)
+#define IMX_BLK_CTL_PD_RESET BIT(1)
+#define IMX_BLK_CTL_PD_BUS BIT(2)
+
+const extern struct dev_pm_ops imx_blk_ctl_pm_ops;
+
+#endif
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH V5 4/4] soc: imx: Add blk-ctl driver for i.MX8MM
2021-05-21 10:59 [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
` (2 preceding siblings ...)
2021-05-21 10:59 ` [PATCH V5 3/4] soc: imx: Add generic blk-ctl driver Peng Fan (OSS)
@ 2021-05-21 10:59 ` Peng Fan (OSS)
2021-05-21 15:37 ` [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Adam Ford
4 siblings, 0 replies; 9+ messages in thread
From: Peng Fan (OSS) @ 2021-05-21 10:59 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, p.zabel, l.stach, krzk, agx, marex,
andrew.smirnov, devicetree, linux-arm-kernel, linux-kernel,
ping.bai, frieder.schrempf, aford173, abel.vesa, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
The i.MX8MM SoC has dispmix BLK-CTL and vpumix BLK-CTL, so we add
that support in this driver.
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/soc/imx/Makefile | 2 +-
drivers/soc/imx/blk-ctl-imx8mm.c | 139 +++++++++++++++++++++++++++++++
2 files changed, 140 insertions(+), 1 deletion(-)
create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c
diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile
index d3d2b49a386c..c260b962f495 100644
--- a/drivers/soc/imx/Makefile
+++ b/drivers/soc/imx/Makefile
@@ -4,4 +4,4 @@ obj-$(CONFIG_ARCH_MXC) += soc-imx.o
endif
obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o
obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o
-obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o blk-ctl.o
+obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o blk-ctl.o blk-ctl-imx8mm.o
diff --git a/drivers/soc/imx/blk-ctl-imx8mm.c b/drivers/soc/imx/blk-ctl-imx8mm.c
new file mode 100644
index 000000000000..59443588f892
--- /dev/null
+++ b/drivers/soc/imx/blk-ctl-imx8mm.c
@@ -0,0 +1,139 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2021 NXP
+ */
+
+#include <dt-bindings/clock/imx8mm-clock.h>
+#include <dt-bindings/power/imx8mm-power.h>
+#include <linux/clk.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/of_address.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <linux/types.h>
+#include <linux/pm_domain.h>
+#include <linux/regmap.h>
+
+#include "blk-ctl.h"
+
+#define MEDIA_BLK_BUS_RSTN_BLK_SYNC_SFT_EN BIT(6)
+#define MEDIA_BLK_MIPI_DSI_I_PRESETN_SFT_EN BIT(5)
+#define MEDIA_BLK_MIPI_CSI_I_PRESETN_SFT_EN BIT(4)
+#define MEDIA_BLK_CAMERA_PIXEL_RESET_N_SFT_EN BIT(3)
+#define MEDIA_BLK_CSI_BRIDGE_SFT_EN GENMASK(2, 0)
+
+#define MEDIA_BLK_BUS_PD_MASK BIT(12)
+#define MEDIA_BLK_MIPI_CSI_PD_MASK GENMASK(11, 10)
+#define MEDIA_BLK_MIPI_DSI_PD_MASK GENMASK(9, 8)
+#define MEDIA_BLK_LCDIF_PD_MASK GENMASK(7, 6)
+#define MEDIA_BLK_CSI_BRIDGE_PD_MASK GENMASK(5, 0)
+
+static struct imx_blk_ctl_hw imx8mm_dispmix_blk_ctl_pds[] = {
+ IMX_BLK_CTL_PD("CSI_BRIDGE", NULL, IMX8MM_BLK_CTL_PD_DISPMIX_CSI_BRIDGE, 0x4,
+ MEDIA_BLK_CSI_BRIDGE_PD_MASK, 0, MEDIA_BLK_CSI_BRIDGE_SFT_EN,
+ IMX_BLK_CTL_PD_RESET),
+ IMX_BLK_CTL_PD("LCDIF", NULL, IMX8MM_BLK_CTL_PD_DISPMIX_LCDIF, 0x4,
+ MEDIA_BLK_LCDIF_PD_MASK, -1, -1, 0),
+ IMX_BLK_CTL_PD("MIPI_DSI", "mipi", IMX8MM_BLK_CTL_PD_DISPMIX_MIPI_DSI, 0x4,
+ MEDIA_BLK_MIPI_DSI_PD_MASK, 0, MEDIA_BLK_MIPI_DSI_I_PRESETN_SFT_EN,
+ IMX_BLK_CTL_PD_RESET),
+ IMX_BLK_CTL_PD("MIPI_CSI", "mipi", IMX8MM_BLK_CTL_PD_DISPMIX_MIPI_CSI, 0x4,
+ MEDIA_BLK_MIPI_CSI_PD_MASK, 0,
+ MEDIA_BLK_MIPI_CSI_I_PRESETN_SFT_EN | MEDIA_BLK_CAMERA_PIXEL_RESET_N_SFT_EN,
+ IMX_BLK_CTL_PD_RESET),
+ IMX_BLK_CTL_PD("DISPMIX_BUS", "dispmix", IMX8MM_BLK_CTL_PD_DISPMIX_BUS, 0x4,
+ MEDIA_BLK_BUS_PD_MASK, 0, MEDIA_BLK_BUS_RSTN_BLK_SYNC_SFT_EN,
+ IMX_BLK_CTL_PD_HANDSHAKE | IMX_BLK_CTL_PD_RESET)
+};
+
+static struct imx_blk_ctl_hw imx8mm_vpumix_blk_ctl_pds[] = {
+ IMX_BLK_CTL_PD("VPU_BLK_CTL_G2", "vpu-g2", IMX8MM_BLK_CTL_PD_VPU_G2, 0x4,
+ BIT(0), 0, BIT(0), IMX_BLK_CTL_PD_RESET),
+ IMX_BLK_CTL_PD("VPU_BLK_CTL_G1", "vpu-g1", IMX8MM_BLK_CTL_PD_VPU_G1, 0x4,
+ BIT(1), 0, BIT(1), IMX_BLK_CTL_PD_RESET),
+ IMX_BLK_CTL_PD("VPU_BLK_CTL_H1", "vpu-h1", IMX8MM_BLK_CTL_PD_VPU_H1, 0x4,
+ BIT(2), 0, BIT(2), IMX_BLK_CTL_PD_RESET),
+ IMX_BLK_CTL_PD("VPU_BLK_CTL_BUS", "vpumix", IMX8MM_BLK_CTL_PD_VPU_BUS, 0x4,
+ BIT(2), 0, BIT(2), IMX_BLK_CTL_PD_HANDSHAKE | IMX_BLK_CTL_PD_RESET)
+};
+
+static const struct regmap_config imx8mm_blk_ctl_regmap_config = {
+ .reg_bits = 32,
+ .reg_stride = 4,
+ .val_bits = 32,
+ .max_register = 0x30,
+ .fast_io = true,
+};
+
+static const struct imx_blk_ctl_dev_data imx8mm_vpumix_blk_ctl_dev_data = {
+ .pds = imx8mm_vpumix_blk_ctl_pds,
+ .pds_num = ARRAY_SIZE(imx8mm_vpumix_blk_ctl_pds),
+ .max_num = IMX8MM_BLK_CTL_PD_VPU_MAX,
+ .hw_hsk = &imx8mm_vpumix_blk_ctl_pds[3],
+ .config = imx8mm_blk_ctl_regmap_config,
+ .name = "imx-vpumix-blk-ctl",
+};
+
+static const struct imx_blk_ctl_dev_data imx8mm_dispmix_blk_ctl_dev_data = {
+ .pds = imx8mm_dispmix_blk_ctl_pds,
+ .pds_num = ARRAY_SIZE(imx8mm_dispmix_blk_ctl_pds),
+ .max_num = IMX8MM_BLK_CTL_PD_DISPMIX_MAX,
+ .hw_hsk = &imx8mm_dispmix_blk_ctl_pds[4],
+ .config = imx8mm_blk_ctl_regmap_config,
+ .name = "imx-dispmix-blk-ctl",
+};
+
+static int imx8mm_blk_ctl_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ const struct imx_blk_ctl_dev_data *dev_data = of_device_get_match_data(dev);
+ struct regmap *regmap;
+ struct imx_blk_ctl *ctl;
+ void __iomem *base;
+
+ ctl = devm_kzalloc(dev, sizeof(*ctl), GFP_KERNEL);
+ if (!ctl)
+ return -ENOMEM;
+
+ base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(base))
+ return PTR_ERR(base);
+
+ regmap = devm_regmap_init_mmio(dev, base, &dev_data->config);
+ if (IS_ERR(regmap))
+ return PTR_ERR(regmap);
+
+ ctl->regmap = regmap;
+ ctl->dev = dev;
+ mutex_init(&ctl->lock);
+
+ ctl->num_clks = devm_clk_bulk_get_all(dev, &ctl->clks);
+ if (ctl->num_clks < 0)
+ return ctl->num_clks;
+
+ dev_set_drvdata(dev, ctl);
+ ctl->dev_data = dev_data;
+
+ return imx_blk_ctl_register(dev);
+}
+
+static const struct of_device_id imx_blk_ctl_of_match[] = {
+ { .compatible = "fsl,imx8mm-vpumix-blk-ctl", .data = &imx8mm_vpumix_blk_ctl_dev_data },
+ { .compatible = "fsl,imx8mm-dispmix-blk-ctl", .data = &imx8mm_dispmix_blk_ctl_dev_data },
+ { /* Sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, imx_blk_ctl_of_match);
+
+static struct platform_driver imx_blk_ctl_driver = {
+ .probe = imx8mm_blk_ctl_probe,
+ .driver = {
+ .name = "imx8mm-blk-ctl",
+ .of_match_table = of_match_ptr(imx_blk_ctl_of_match),
+ .pm = &imx_blk_ctl_pm_ops,
+ },
+};
+module_platform_driver(imx_blk_ctl_driver);
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
2021-05-21 10:59 [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
` (3 preceding siblings ...)
2021-05-21 10:59 ` [PATCH V5 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Peng Fan (OSS)
@ 2021-05-21 15:37 ` Adam Ford
2021-05-22 0:54 ` Peng Fan
4 siblings, 1 reply; 9+ messages in thread
From: Adam Ford @ 2021-05-21 15:37 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Philipp Zabel, Lucas Stach,
Krzysztof Kozlowski, Guido Günther, Marek Vasut,
Andrey Smirnov, devicetree, arm-soc, Linux Kernel Mailing List,
Jacky Bai, Schrempf Frieder, Abel Vesa, Peng Fan
On Fri, May 21, 2021 at 5:27 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> V5:
> Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent power
> domain to fix the potential handshake issue.
> I still keep R-b/A-b tag for Patch 1,2,4, since very minor changes
> I only drop R-b tag for Patch 3, since it has big change.
> An example, the pgc_mipi not take pgc_dispmix as parent:
>
> pgc_dispmix: power-domain@10 {
> #power-domain-cells = <0>;
> reg = <IMX8MM_POWER_DOMAIN_DISPMIX>;
> clocks = <&clk IMX8MM_CLK_DISP_ROOT>,
> <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> };
>
> pgc_mipi: power-domain@11 {
> #power-domain-cells = <0>;
> reg = <IMX8MM_POWER_DOMAIN_MIPI>;
> power-domains = <&dispmix_blk_ctl IMX8MM_BLK_CTL_PD_DISPMIX_BUS>;
With this change, I get a bunch of errors on boot. The list of
power-domains appear correct on the surface, but it also has trouble
waking from sleep.
[ 0.695947] imx8mm-blk-ctl imx-dispmix-blk-ctl.0: invalid resource
[ 0.702849] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.0 failed
with error -22
[ 0.711259] imx8mm-blk-ctl imx-dispmix-blk-ctl.1: invalid resource
[ 0.716451] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.1 failed
with error -22
[ 0.724856] imx8mm-blk-ctl imx-dispmix-blk-ctl.2: invalid resource
[ 0.730097] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.2 failed
with error -22
[ 0.738398] imx8mm-blk-ctl imx-dispmix-blk-ctl.3: invalid resource
[ 0.743747] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.3 failed
with error -22
If I have a wrong device tree configuration, can you please post an
updated device tree? I don't think an official patch for original
pgc's were pushed as part of either series. I used this e-mail as the
patch to enable the blk-ctl.
thanks,
adam
> };
>
> dispmix_blk_ctl: clock-controller@32e28000 {
> compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon";
> reg = <0x32e28000 0x100>;
> #power-domain-cells = <1>;
> power-domains = <&pgc_dispmix>, <&pgc_mipi>;
> power-domain-names = "dispmix", "mipi";
> clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> };
>
> V4:
> Add R-b tag
> Typo fix
> Update the power domain macro names Per Abel and Frieder
>
> V3:
> Add explaination for not listing items in patch 2 commit log Per Rob.
> Addressed comments from Lucas and Frieder on patch [3,4].
> A few comments from Jacky was ignored, because following gpcv2
> coding style.
>
> V2:
> Fix yaml check failure.
>
> Previously there is an effort from Abel that take BLK-CTL as clock
> provider, but it turns out that there is A/B lock issue and we are
> not able resolve that.
>
> Per discuss with Lucas and Jacky, we made an agreement that take BLK-CTL
> as a power domain provider and use GPC's domain as parent, the consumer
> node take BLK-CTL as power domain input.
>
> This patchset has been tested on i.MX8MM EVK board, but one hack
> is not included in the patchset is that the DISPMIX BLK-CTL
> MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a MIPI
> DPHY driver, so fine to leave it.
>
> Thanks for Lucas's suggestion, Frieder Schrempf for collecting
> all the patches, Abel's previous BLK-CTL work, Jacky Bai on help
> debug issues.
>
>
> Peng Fan (4):
> dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains
> Documentation: bindings: clk: Add bindings for i.MX BLK_CTL
> soc: imx: Add generic blk-ctl driver
> soc: imx: Add blk-ctl driver for i.MX8MM
>
> .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++
> drivers/soc/imx/Makefile | 2 +-
> drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++
> drivers/soc/imx/blk-ctl.c | 311 ++++++++++++++++++
> drivers/soc/imx/blk-ctl.h | 85 +++++
> include/dt-bindings/power/imx8mm-power.h | 13 +
> 6 files changed, 615 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
> create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c
> create mode 100644 drivers/soc/imx/blk-ctl.c
> create mode 100644 drivers/soc/imx/blk-ctl.h
>
> --
> 2.30.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
2021-05-21 15:37 ` [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support Adam Ford
@ 2021-05-22 0:54 ` Peng Fan
2021-05-22 2:32 ` Adam Ford
0 siblings, 1 reply; 9+ messages in thread
From: Peng Fan @ 2021-05-22 0:54 UTC (permalink / raw)
To: Adam Ford, Peng Fan (OSS)
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
Fabio Estevam, dl-linux-imx, Philipp Zabel, Lucas Stach,
Krzysztof Kozlowski, Guido Günther, Marek Vasut,
Andrey Smirnov, devicetree, arm-soc, Linux Kernel Mailing List,
Jacky Bai, Schrempf Frieder, Abel Vesa
> Subject: Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
>
> On Fri, May 21, 2021 at 5:27 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > V5:
> > Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent power
> > domain to fix the potential handshake issue.
> > I still keep R-b/A-b tag for Patch 1,2,4, since very minor changes I
> > only drop R-b tag for Patch 3, since it has big change.
> > An example, the pgc_mipi not take pgc_dispmix as parent:
> >
> > pgc_dispmix: power-domain@10 {
> > #power-domain-cells = <0>;
> > reg = <IMX8MM_POWER_DOMAIN_DISPMIX>;
> > clocks = <&clk IMX8MM_CLK_DISP_ROOT>,
> > <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> > <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> > };
> >
> > pgc_mipi: power-domain@11 {
> > #power-domain-cells = <0>;
> > reg = <IMX8MM_POWER_DOMAIN_MIPI>;
> > power-domains = <&dispmix_blk_ctl
> > IMX8MM_BLK_CTL_PD_DISPMIX_BUS>;
>
> With this change, I get a bunch of errors on boot. The list of power-domains
> appear correct on the surface, but it also has trouble waking from sleep.
>
> [ 0.695947] imx8mm-blk-ctl imx-dispmix-blk-ctl.0: invalid resource
> [ 0.702849] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.0 failed
> with error -22
> [ 0.711259] imx8mm-blk-ctl imx-dispmix-blk-ctl.1: invalid resource
> [ 0.716451] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.1 failed
> with error -22
> [ 0.724856] imx8mm-blk-ctl imx-dispmix-blk-ctl.2: invalid resource
> [ 0.730097] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.2 failed
> with error -22
> [ 0.738398] imx8mm-blk-ctl imx-dispmix-blk-ctl.3: invalid resource
> [ 0.743747] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.3 failed
> with error -22
It is just the imx8mm-blk-ctl driver matches with the new created
child device, because the child device points the of_node of the parent
device.
But this error will not affect functionality.
I'll resolve this issue and send out v6.
>
> If I have a wrong device tree configuration, can you please post an updated
> device tree? I don't think an official patch for original pgc's were pushed as
> part of either series. I used this e-mail as the patch to enable the blk-ctl.
Do you have an device tree, I could give a look.
Regards,
Peng.
>
> thanks,
>
> adam
>
> > };
> >
> > dispmix_blk_ctl: clock-controller@32e28000 {
> > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon";
> > reg = <0x32e28000 0x100>;
> > #power-domain-cells = <1>;
> > power-domains = <&pgc_dispmix>, <&pgc_mipi>;
> > power-domain-names = "dispmix", "mipi";
> > clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk
> IMX8MM_CLK_DISP_AXI_ROOT>,
> > <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> > };
> >
> > V4:
> > Add R-b tag
> > Typo fix
> > Update the power domain macro names Per Abel and Frieder
> >
> > V3:
> > Add explaination for not listing items in patch 2 commit log Per Rob.
> > Addressed comments from Lucas and Frieder on patch [3,4].
> > A few comments from Jacky was ignored, because following gpcv2
> > coding style.
> >
> > V2:
> > Fix yaml check failure.
> >
> > Previously there is an effort from Abel that take BLK-CTL as clock
> > provider, but it turns out that there is A/B lock issue and we are not
> > able resolve that.
> >
> > Per discuss with Lucas and Jacky, we made an agreement that take
> > BLK-CTL as a power domain provider and use GPC's domain as parent, the
> > consumer node take BLK-CTL as power domain input.
> >
> > This patchset has been tested on i.MX8MM EVK board, but one hack is
> > not included in the patchset is that the DISPMIX BLK-CTL
> > MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a MIPI
> > DPHY driver, so fine to leave it.
> >
> > Thanks for Lucas's suggestion, Frieder Schrempf for collecting all the
> > patches, Abel's previous BLK-CTL work, Jacky Bai on help debug issues.
> >
> >
> > Peng Fan (4):
> > dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains
> > Documentation: bindings: clk: Add bindings for i.MX BLK_CTL
> > soc: imx: Add generic blk-ctl driver
> > soc: imx: Add blk-ctl driver for i.MX8MM
> >
> > .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++
> > drivers/soc/imx/Makefile | 2 +-
> > drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++
> > drivers/soc/imx/blk-ctl.c | 311
> ++++++++++++++++++
> > drivers/soc/imx/blk-ctl.h | 85 +++++
> > include/dt-bindings/power/imx8mm-power.h | 13 +
> > 6 files changed, 615 insertions(+), 1 deletion(-) create mode 100644
> > Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
> > create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c create mode
> > 100644 drivers/soc/imx/blk-ctl.c create mode 100644
> > drivers/soc/imx/blk-ctl.h
> >
> > --
> > 2.30.0
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
2021-05-22 0:54 ` Peng Fan
@ 2021-05-22 2:32 ` Adam Ford
2021-05-22 12:30 ` Peng Fan (OSS)
0 siblings, 1 reply; 9+ messages in thread
From: Adam Ford @ 2021-05-22 2:32 UTC (permalink / raw)
To: Peng Fan
Cc: Peng Fan (OSS),
Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
Fabio Estevam, dl-linux-imx, Philipp Zabel, Lucas Stach,
Krzysztof Kozlowski, Guido Günther, Marek Vasut,
Andrey Smirnov, devicetree, arm-soc, Linux Kernel Mailing List,
Jacky Bai, Schrempf Frieder, Abel Vesa
On Fri, May 21, 2021 at 7:54 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
> >
> > On Fri, May 21, 2021 at 5:27 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > wrote:
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > V5:
> > > Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent power
> > > domain to fix the potential handshake issue.
> > > I still keep R-b/A-b tag for Patch 1,2,4, since very minor changes I
> > > only drop R-b tag for Patch 3, since it has big change.
> > > An example, the pgc_mipi not take pgc_dispmix as parent:
> > >
> > > pgc_dispmix: power-domain@10 {
> > > #power-domain-cells = <0>;
> > > reg = <IMX8MM_POWER_DOMAIN_DISPMIX>;
> > > clocks = <&clk IMX8MM_CLK_DISP_ROOT>,
> > > <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> > > <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> > > };
> > >
> > > pgc_mipi: power-domain@11 {
> > > #power-domain-cells = <0>;
> > > reg = <IMX8MM_POWER_DOMAIN_MIPI>;
> > > power-domains = <&dispmix_blk_ctl
> > > IMX8MM_BLK_CTL_PD_DISPMIX_BUS>;
> >
> > With this change, I get a bunch of errors on boot. The list of power-domains
> > appear correct on the surface, but it also has trouble waking from sleep.
> >
> > [ 0.695947] imx8mm-blk-ctl imx-dispmix-blk-ctl.0: invalid resource
> > [ 0.702849] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.0 failed
> > with error -22
> > [ 0.711259] imx8mm-blk-ctl imx-dispmix-blk-ctl.1: invalid resource
> > [ 0.716451] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.1 failed
> > with error -22
> > [ 0.724856] imx8mm-blk-ctl imx-dispmix-blk-ctl.2: invalid resource
> > [ 0.730097] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.2 failed
> > with error -22
> > [ 0.738398] imx8mm-blk-ctl imx-dispmix-blk-ctl.3: invalid resource
> > [ 0.743747] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.3 failed
> > with error -22
>
> It is just the imx8mm-blk-ctl driver matches with the new created
> child device, because the child device points the of_node of the parent
> device.
> But this error will not affect functionality.
> I'll resolve this issue and send out v6.
> >
> > If I have a wrong device tree configuration, can you please post an updated
> > device tree? I don't think an official patch for original pgc's were pushed as
> > part of either series. I used this e-mail as the patch to enable the blk-ctl.
>
> Do you have an device tree, I could give a look.
I have a git repo where I've been collecting the various power domain
patches. I have updated the imx8mn blk-ctl and device trees as well
in that same repo.
https://github.com/aford173/linux/blob/linux-5.13.y-aford/arch/arm64/boot/dts/freescale/imx8mm.dtsi
thanks for looking at this.
adam
>
> Regards,
> Peng.
>
> >
> > thanks,
> >
> > adam
> >
> > > };
> > >
> > > dispmix_blk_ctl: clock-controller@32e28000 {
> > > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon";
> > > reg = <0x32e28000 0x100>;
> > > #power-domain-cells = <1>;
> > > power-domains = <&pgc_dispmix>, <&pgc_mipi>;
> > > power-domain-names = "dispmix", "mipi";
> > > clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk
> > IMX8MM_CLK_DISP_AXI_ROOT>,
> > > <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> > > };
> > >
> > > V4:
> > > Add R-b tag
> > > Typo fix
> > > Update the power domain macro names Per Abel and Frieder
> > >
> > > V3:
> > > Add explaination for not listing items in patch 2 commit log Per Rob.
> > > Addressed comments from Lucas and Frieder on patch [3,4].
> > > A few comments from Jacky was ignored, because following gpcv2
> > > coding style.
> > >
> > > V2:
> > > Fix yaml check failure.
> > >
> > > Previously there is an effort from Abel that take BLK-CTL as clock
> > > provider, but it turns out that there is A/B lock issue and we are not
> > > able resolve that.
> > >
> > > Per discuss with Lucas and Jacky, we made an agreement that take
> > > BLK-CTL as a power domain provider and use GPC's domain as parent, the
> > > consumer node take BLK-CTL as power domain input.
> > >
> > > This patchset has been tested on i.MX8MM EVK board, but one hack is
> > > not included in the patchset is that the DISPMIX BLK-CTL
> > > MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a MIPI
> > > DPHY driver, so fine to leave it.
> > >
> > > Thanks for Lucas's suggestion, Frieder Schrempf for collecting all the
> > > patches, Abel's previous BLK-CTL work, Jacky Bai on help debug issues.
> > >
> > >
> > > Peng Fan (4):
> > > dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains
> > > Documentation: bindings: clk: Add bindings for i.MX BLK_CTL
> > > soc: imx: Add generic blk-ctl driver
> > > soc: imx: Add blk-ctl driver for i.MX8MM
> > >
> > > .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++
> > > drivers/soc/imx/Makefile | 2 +-
> > > drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++
> > > drivers/soc/imx/blk-ctl.c | 311
> > ++++++++++++++++++
> > > drivers/soc/imx/blk-ctl.h | 85 +++++
> > > include/dt-bindings/power/imx8mm-power.h | 13 +
> > > 6 files changed, 615 insertions(+), 1 deletion(-) create mode 100644
> > > Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
> > > create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c create mode
> > > 100644 drivers/soc/imx/blk-ctl.c create mode 100644
> > > drivers/soc/imx/blk-ctl.h
> > >
> > > --
> > > 2.30.0
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
2021-05-22 2:32 ` Adam Ford
@ 2021-05-22 12:30 ` Peng Fan (OSS)
0 siblings, 0 replies; 9+ messages in thread
From: Peng Fan (OSS) @ 2021-05-22 12:30 UTC (permalink / raw)
To: Adam Ford
Cc: Peng Fan (OSS),
Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
Fabio Estevam, dl-linux-imx, Philipp Zabel, Lucas Stach,
Krzysztof Kozlowski, Guido Günther, Marek Vasut,
Andrey Smirnov, devicetree, arm-soc, Linux Kernel Mailing List,
Jacky Bai, Schrempf Frieder, Abel Vesa
> Subject: Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
>
> On Fri, May 21, 2021 at 7:54 PM Peng Fan <peng.fan@nxp.com> wrote:
> >
> > > Subject: Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support
> > >
> > > On Fri, May 21, 2021 at 5:27 AM Peng Fan (OSS)
> > > <peng.fan@oss.nxp.com>
> > > wrote:
> > > >
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > V5:
> > > > Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent
> > > > power domain to fix the potential handshake issue.
> > > > I still keep R-b/A-b tag for Patch 1,2,4, since very minor
> > > > changes I only drop R-b tag for Patch 3, since it has big change.
> > > > An example, the pgc_mipi not take pgc_dispmix as parent:
> > > >
> > > > pgc_dispmix: power-domain@10 {
> > > > #power-domain-cells = <0>;
> > > > reg = <IMX8MM_POWER_DOMAIN_DISPMIX>;
> > > > clocks = <&clk IMX8MM_CLK_DISP_ROOT>,
> > > > <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> > > > <&clk
> IMX8MM_CLK_DISP_APB_ROOT>;
> > > > };
> > > >
> > > > pgc_mipi: power-domain@11 {
> > > > #power-domain-cells = <0>;
> > > > reg = <IMX8MM_POWER_DOMAIN_MIPI>;
> > > > power-domains = <&dispmix_blk_ctl
> > > > IMX8MM_BLK_CTL_PD_DISPMIX_BUS>;
> > >
> > > With this change, I get a bunch of errors on boot. The list of
> > > power-domains appear correct on the surface, but it also has trouble
> waking from sleep.
> > >
> > > [ 0.695947] imx8mm-blk-ctl imx-dispmix-blk-ctl.0: invalid resource
> > > [ 0.702849] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.0 failed
> > > with error -22
> > > [ 0.711259] imx8mm-blk-ctl imx-dispmix-blk-ctl.1: invalid resource
> > > [ 0.716451] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.1 failed
> > > with error -22
> > > [ 0.724856] imx8mm-blk-ctl imx-dispmix-blk-ctl.2: invalid resource
> > > [ 0.730097] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.2 failed
> > > with error -22
> > > [ 0.738398] imx8mm-blk-ctl imx-dispmix-blk-ctl.3: invalid resource
> > > [ 0.743747] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.3 failed
> > > with error -22
> >
> > It is just the imx8mm-blk-ctl driver matches with the new created
> > child device, because the child device points the of_node of the
> > parent device.
> > But this error will not affect functionality.
> > I'll resolve this issue and send out v6.
> > >
> > > If I have a wrong device tree configuration, can you please post an
> > > updated device tree? I don't think an official patch for original
> > > pgc's were pushed as part of either series. I used this e-mail as the patch
> to enable the blk-ctl.
> >
> > Do you have an device tree, I could give a look.
>
> I have a git repo where I've been collecting the various power domain patches.
> I have updated the imx8mn blk-ctl and device trees as well in that same repo.
I put my dts diff here:
https://gist.github.com/MrVan/d73888d8273c43ea4a3b28fa668ca1d0
Not include vpu, lcdif, mipi, just gpc and blk-ctl.
Your dts has error, the vpu-g1/g2/h1 should use vpu-blk as parent power domain.
And the vpu-blk-ctl power domain changes as below:
power-domain-names = "vpumix", "vpu-g1", "vpu-g2", "vpu-h1";
Regards,
Peng.
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
> com%2Faford173%2Flinux%2Fblob%2Flinux-5.13.y-aford%2Farch%2Farm64%
> 2Fboot%2Fdts%2Ffreescale%2Fimx8mm.dtsi&data=04%7C01%7Cpeng.f
> an%40nxp.com%7Ca5c04b8b13514290944008d91cc9d95f%7C686ea1d3bc2
> b4c6fa92cd99c5c301635%7C0%7C0%7C637572475532314749%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&sdata=NjxeojlrUc5t1tmrpZrhmYL1jaGB
> QNHv8QVh2OcgMpA%3D&reserved=0
>
> thanks for looking at this.
>
> adam
> >
> > Regards,
> > Peng.
> >
> > >
> > > thanks,
> > >
> > > adam
> > >
> > > > };
> > > >
> > > > dispmix_blk_ctl: clock-controller@32e28000 {
> > > > compatible = "fsl,imx8mm-dispmix-blk-ctl",
> "syscon";
> > > > reg = <0x32e28000 0x100>;
> > > > #power-domain-cells = <1>;
> > > > power-domains = <&pgc_dispmix>, <&pgc_mipi>;
> > > > power-domain-names = "dispmix", "mipi";
> > > > clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk
> > > IMX8MM_CLK_DISP_AXI_ROOT>,
> > > > <&clk
> IMX8MM_CLK_DISP_APB_ROOT>;
> > > > };
> > > >
> > > > V4:
> > > > Add R-b tag
> > > > Typo fix
> > > > Update the power domain macro names Per Abel and Frieder
> > > >
> > > > V3:
> > > > Add explaination for not listing items in patch 2 commit log Per Rob.
> > > > Addressed comments from Lucas and Frieder on patch [3,4].
> > > > A few comments from Jacky was ignored, because following gpcv2
> > > > coding style.
> > > >
> > > > V2:
> > > > Fix yaml check failure.
> > > >
> > > > Previously there is an effort from Abel that take BLK-CTL as clock
> > > > provider, but it turns out that there is A/B lock issue and we are
> > > > not able resolve that.
> > > >
> > > > Per discuss with Lucas and Jacky, we made an agreement that take
> > > > BLK-CTL as a power domain provider and use GPC's domain as parent,
> > > > the consumer node take BLK-CTL as power domain input.
> > > >
> > > > This patchset has been tested on i.MX8MM EVK board, but one hack
> > > > is not included in the patchset is that the DISPMIX BLK-CTL
> > > > MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a
> > > > MIPI DPHY driver, so fine to leave it.
> > > >
> > > > Thanks for Lucas's suggestion, Frieder Schrempf for collecting all
> > > > the patches, Abel's previous BLK-CTL work, Jacky Bai on help debug
> issues.
> > > >
> > > >
> > > > Peng Fan (4):
> > > > dt-bindings: power: Add defines for i.MX8MM BLK-CTL power
> domains
> > > > Documentation: bindings: clk: Add bindings for i.MX BLK_CTL
> > > > soc: imx: Add generic blk-ctl driver
> > > > soc: imx: Add blk-ctl driver for i.MX8MM
> > > >
> > > > .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++
> > > > drivers/soc/imx/Makefile | 2 +-
> > > > drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++
> > > > drivers/soc/imx/blk-ctl.c | 311
> > > ++++++++++++++++++
> > > > drivers/soc/imx/blk-ctl.h | 85 +++++
> > > > include/dt-bindings/power/imx8mm-power.h | 13 +
> > > > 6 files changed, 615 insertions(+), 1 deletion(-) create mode
> > > > 100644
> > > > Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
> > > > create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c create
> mode
> > > > 100644 drivers/soc/imx/blk-ctl.c create mode 100644
> > > > drivers/soc/imx/blk-ctl.h
> > > >
> > > > --
> > > > 2.30.0
> > > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread