* RE: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
2021-06-17 12:26 [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe() Jing Xiangfeng
@ 2021-06-17 12:24 ` Aisheng Dong
2021-06-17 22:38 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Aisheng Dong @ 2021-06-17 12:24 UTC (permalink / raw)
To: Jing Xiangfeng, Frank Li, will, mark.rutland, shawnguo, s.hauer,
kernel, festevam, dl-linux-imx
Cc: linux-arm-kernel, linux-kernel
> From: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Sent: Thursday, June 17, 2021 8:26 PM
> Subject: [PATCH] drivers/perf: fix the missed ida_simple_remove() in
> ddr_perf_probe()
>
drivers/perf: imx8_ddr: xxxx
Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
> ddr_perf_probe() misses to call ida_simple_remove() in an error path.
> Jump to cpuhp_state_err to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/perf/fsl_imx8_ddr_perf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> index 2bbb93188064..7b87aaf267d5 100644
> --- a/drivers/perf/fsl_imx8_ddr_perf.c
> +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> @@ -705,8 +705,10 @@ static int ddr_perf_probe(struct platform_device
> *pdev)
>
> name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> DDR_PERF_DEV_NAME "%d",
> num);
> - if (!name)
> - return -ENOMEM;
> + if (!name) {
> + ret = -ENOMEM;
> + goto cpuhp_state_err;
> + }
>
> pmu->devtype_data = of_device_get_match_data(&pdev->dev);
>
> --
> 2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
@ 2021-06-17 12:26 Jing Xiangfeng
2021-06-17 12:24 ` Aisheng Dong
2021-06-17 22:38 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2021-06-17 12:26 UTC (permalink / raw)
To: Frank.li, will, mark.rutland, shawnguo, s.hauer, kernel,
festevam, linux-imx
Cc: linux-arm-kernel, linux-kernel, jingxiangfeng
ddr_perf_probe() misses to call ida_simple_remove() in an error path.
Jump to cpuhp_state_err to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/perf/fsl_imx8_ddr_perf.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
index 2bbb93188064..7b87aaf267d5 100644
--- a/drivers/perf/fsl_imx8_ddr_perf.c
+++ b/drivers/perf/fsl_imx8_ddr_perf.c
@@ -705,8 +705,10 @@ static int ddr_perf_probe(struct platform_device *pdev)
name = devm_kasprintf(&pdev->dev, GFP_KERNEL, DDR_PERF_DEV_NAME "%d",
num);
- if (!name)
- return -ENOMEM;
+ if (!name) {
+ ret = -ENOMEM;
+ goto cpuhp_state_err;
+ }
pmu->devtype_data = of_device_get_match_data(&pdev->dev);
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
2021-06-17 12:26 [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe() Jing Xiangfeng
2021-06-17 12:24 ` Aisheng Dong
@ 2021-06-17 22:38 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2021-06-17 22:38 UTC (permalink / raw)
To: shawnguo, festevam, s.hauer, linux-imx, kernel, mark.rutland,
Jing Xiangfeng, Frank.li
Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel,
linux-arm-kernel
On Thu, 17 Jun 2021 20:26:14 +0800, Jing Xiangfeng wrote:
> ddr_perf_probe() misses to call ida_simple_remove() in an error path.
> Jump to cpuhp_state_err to fix it.
Applied to will (for-next/perf), thanks!
[1/1] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
https://git.kernel.org/will/c/d96b1b8c9f79
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-17 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 12:26 [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe() Jing Xiangfeng
2021-06-17 12:24 ` Aisheng Dong
2021-06-17 22:38 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).