From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171ABC433ED for ; Sat, 8 May 2021 00:47:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61286613C8 for ; Sat, 8 May 2021 00:47:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61286613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GKVFGSVMUEZiuTzirtMl52lSZ5c9M+AIXu3+pLderlA=; b=MHwHikwSGo4Q3BLgG3EQQ4tcG pGmQFzVYoP9+d5hh3bO99GgE/1fz74/SEzFFfBRfnM7/WR9cUx23KR3Qvog0Wngv9gTmSG548PcLV MY7N5Sa5HbszaT8WC1QxAuSpStv86gZKe4W+Xck1EuncMORCKhiieJxMBYb4VSjfCvIqgi6CDcCDi unD9CFowys076aBBxzdaW+CorlC7SFo6D98JlWbeHAW18ZKdWv8utLwo6lCSslsrEgMAN2AFGBKaB pcYCk19sbttIzHIPV25kSK3SRokgIKMclzcUdHbfPbs8m8O68ByBHEe4sBaNRL+pyXgFges32FHGJ jNWeOvHqQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfB6Q-008Pgb-66; Sat, 08 May 2021 00:45:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfB6K-008PfK-PF for linux-arm-kernel@desiato.infradead.org; Sat, 08 May 2021 00:45:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=09PM0zO/daSGIO7YkI+qyleF5g72AObJNef1OKlJkxo=; b=PiIS5K15tY0iY7qUAVgmW82jb3 bjsvgR8kaGj+c7ajvF0hkxCRO/h41NIhq0PkAfT7KoHJcmXaUGh3Y2it4SBLGgqF3kG+VmpzoEj/X YbTIo6EJqInwtIX6goLe5zFQHOpn80iHFhWvcO0EqblpgK6PfLFQ646Qm2uUkUQ3TQKsNoceEuKhU Fhxcwna5BEWDeyMHWWqf281jg6bgMOd6ToFaQvMWQzMwbmoeChsjPqRc+3YBh78MpB754Yah8IgvZ TkA6yTNFjavgaz2yWNUFW6KpmRh7AkTV8VmNQ5XF0nkRv89ARTkBZSUdF/wh5vpXWcTJyLbQgnvp7 oKM869BA==; Received: from mail-eopbgr20056.outbound.protection.outlook.com ([40.107.2.56] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfB6G-007Hjj-Uf for linux-arm-kernel@lists.infradead.org; Sat, 08 May 2021 00:45:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUegWmf9VPmjAdiwlZK5B7P5aDPXKmaP2vMGw32ZsHJ1Cf4d+sdlEVoTkvDpvZ0mKq6nKXraCcnipo3BrWAFMGzGVFQpKvrjkPCMgHTjKXCUmyGtUMR3qPkJn64Vx9webPSMVYi9oe1RXGkQsYm4o3EzFUFjzCZg7qk4sLlw5uOYtLNq6ExfuRs6jyzuq566meVN/3GbEB/Vo638/V+L8frknavkwmQ9WOYn/BmrIUo+QOcDfMeAOazh30Q4QL96rc6PWAOZpMDvNn8vqYg0McKIxgZr0dclUIL47dJqSg5IkT46PmeIQ5TbV8Ek008mY3Mb9PW87qdKtKKtj536Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=09PM0zO/daSGIO7YkI+qyleF5g72AObJNef1OKlJkxo=; b=EWSrU/wRAqYGe3hpkPMqHgSjrY0j7L5gnNWw21V64KbceTLvqbrCbKXYsu85HjNlhwWUT0CrEKdBldIcO8/EzrBcgAKtHXZ/sA0d1ihDo3+E/yrAFT52I8meABWQRfCkeQScbOMRsmKjKfYlLha6UDuK9IzLgnmbMdYuOFmGwKiLXxkJYctS3VDyim1U+bW45+jad9luVWBAc/ZHK7esOLxB7cuXGM3EcKkDhwhIyXpnrWnhXrr7W5ChJb6gunD4Oz95gJhfFV/Yiu22LVxDTfwB5EWH7lc3791+40kHk3Go365iSfS5PTHNOEvlAn+L4EpqIZ/vDv7D22KMCizUtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=09PM0zO/daSGIO7YkI+qyleF5g72AObJNef1OKlJkxo=; b=Z4PwdX72Ja590QSk98YcPunCjrCDEdfCcehZkT/F0PgB2ssIhTOcsAfKDZhDW/2uJcODH8Q9x2vDEF5KFrokDhzqjR81qX3il0sEukT2GDf7/6ifoCutbjMIG5zbT4xUlRF/nhv+Qnuhm1J3WWFXPxeqQ/JkTB7e/iARkMY1Dt4= Received: from DBBPR04MB7930.eurprd04.prod.outlook.com (2603:10a6:10:1ea::12) by DB6PR04MB3128.eurprd04.prod.outlook.com (2603:10a6:6:10::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.24; Sat, 8 May 2021 00:45:36 +0000 Received: from DBBPR04MB7930.eurprd04.prod.outlook.com ([fe80::ddbd:8680:c613:2274]) by DBBPR04MB7930.eurprd04.prod.outlook.com ([fe80::ddbd:8680:c613:2274%5]) with mapi id 15.20.4108.030; Sat, 8 May 2021 00:45:36 +0000 From: Jacky Bai To: Lucas Stach , Shawn Guo CC: Abel Vesa , dl-linux-imx , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "patchwork-lst@pengutronix.de" Subject: RE: [PATCH] clk: imx8mq: prevent sys1_pll_266m gating Thread-Topic: [PATCH] clk: imx8mq: prevent sys1_pll_266m gating Thread-Index: AQHXQ2PjNoBX8XCumUaYwsJMp96f9arYvWkQ Date: Sat, 8 May 2021 00:45:36 +0000 Message-ID: References: <20210507171028.157728-1-l.stach@pengutronix.de> In-Reply-To: <20210507171028.157728-1-l.stach@pengutronix.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c12a38e8-f2f9-4575-5bdd-08d911ba9861 x-ms-traffictypediagnostic: DB6PR04MB3128: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L5uyTxVXRGKyFlA6RRITFi1GRZn1r1I6AixxE4hPnvSO3zMPg2EArTt8g8/SEvzt2+FaoKhtPaKttZysbffHjTq9x25AYZz24UmQCK7KxVx2YTu2qEcZIfpBRoM2DgAupYNO1MLSsn28QnCIJazqdBCh3yKOGbbZdp6pYb7+y7sk3JdQAMoW4Jzl3Kv9QmoLHFK0QU7XoukEUub2C/wy/TBn2sgExFWq5kKYDxpcTsk0M6ozpyPFIXzZFiXP4S/rtMMjRsB9Gu+Ztrqd9mbfp28RCD1bP9+99/xTdNw7MIpUjnT0SmUDmlobixyhr4pNEn5NRMk6XPdFzLLSYD8ILGo3EE6/6wYC0usOM0VkHE74/z8fUSYgnTe5WcMsBYG52b9ZOLzLxOX3qeKGp0WJh9j+WxTN0IDK0qTl/DMwOpz1Y67ITKofOTw6HUUN+VuSFj+428rpLyWrEbMlgWs0dKCFjuYgbNjzk7uCCnQYGEb3Hxm/ArIrjkRbM6ZYJr3VmAUrjwz4a23M1c1Gi133M5fjGs8n/lMPG5smavD7y11soq9muMAqYx3kJnC52Mz+AQ+ZUy1RfB2pWNF2LIi3Use78HW4IIA0DmTBLMO1S7EBSR5mCVaCc/HfYR5LafCMDV7+IIFlHpcpZlCeOG7mOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR04MB7930.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(366004)(346002)(396003)(376002)(76116006)(83380400001)(66446008)(9686003)(6506007)(71200400001)(316002)(478600001)(66476007)(64756008)(26005)(66556008)(186003)(8676002)(4326008)(66946007)(8936002)(86362001)(110136005)(33656002)(7696005)(2906002)(122000001)(55016002)(5660300002)(54906003)(38100700002)(52536014)(32563001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HT6CDStBjUg7J/GyYsMboKx7huMhV28SVr4lyyOcHhb1hpr2wvYKEqgXQciiNWd7S8ptEzPo+NWE/nnmLgdF+8F9Ftl5uCIUV1Qqze2B61Eukf0HBNNhl53hllTbH4IafTYiy5mGhwIWwPhbTXqGv2eOFIKk29cDyHK1tCDr1HFtrDTdjVhyezaVNkoQaxf51ieiUauBJbfFKr9t92k4M9XLEHRTxo2WYj+7ioh1gZWLfOJxVL0isug7FOWQ81huBK8xXtCxjfzuePCsAGRBBC72BP5x+LcNuYL+nzO4dCHzZPQElkSKg5jMC3duJ0l7ZFnoYO+BBbQblGyPGdcoY4VDMrUm4zxGrhq6CsZ612CwSv+Nqz4RRHU0kzUnBgSZy4qLVi0n8c0JkECo2Dc+fqtu2MoWHmkIpHTZortozFcuQAXhE/uYOv8gCd4whT5W6pigkdNSXAMA6P9S7oTfHUK6GWajGE49P9GkNkQ4+OEeyaZoWJiXZNP4FnV4KdzA76crX+0FL7uRQSuCv/yRY0S7qwI0vvAT3BSLQYxX63r96y9rmvWw4vun73S56Isn2g9mGq1iOfzmx7lgq25h5xW7nUgsSZW0pI2w/pl/joYx8BIfdKWqB8L7qigUuvX1HKVSqCP5XXprQPk0yliYPj5REB2z/h8gmXEybhMjhB9oWUAdkRfAG0iRPS9ANR6jnSNgUrBHtyfN0iOeaV5FhCIVLjN71+8ktLBrbqwbyYk= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB7930.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c12a38e8-f2f9-4575-5bdd-08d911ba9861 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2021 00:45:36.6497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eOqQ4gTTVrSLe6hG7zwCsA4bG7JHEcwO3Xo70ILezNBfj7tNMKy8a8hWuBI479qC0r5AhSU5F/CpKPugPBvXEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3128 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_174545_112833_27A105FE X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Subject: [PATCH] clk: imx8mq: prevent sys1_pll_266m gating > > Gating sys1_pll_266m while the usdhc_nand_bus clock is still active (due to > being enabled in to bootloader) leads to spurious failures of the uSDHC > module. > > b04383b6a558 ("clk: imx8mq: Define gates for pll1/2 fixed dividers") > Signed-off-by: Lucas Stach > --- > We probably need some solution to keep parent clocks active on the i.MX8M > clock architecture, as long as any consumers are active, as the reference > manual states that disabling a parent clock may lead to undefined behavior. No such limitation, should be Doc issue. > This needs more work in the clock framework and/or driver. This patch fixes > the obvious regression until we have such a solution. Personally, I prefer to reverted the whole patch b04383b6a558 ("clk: imx8mq: Define gates for pll1/2 fixed dividers"). As instancing those gates increasing the complexity of AMP system clock management, no other obvious benefit. BR Jacky Bai > --- > drivers/clk/imx/clk-imx8mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c > index 4dd4ae9d022b..fce983add1fc 100644 > --- a/drivers/clk/imx/clk-imx8mq.c > +++ b/drivers/clk/imx/clk-imx8mq.c > @@ -372,7 +372,6 @@ static int imx8mq_clocks_probe(struct > platform_device *pdev) > hws[IMX8MQ_SYS1_PLL_133M_CG] = > imx_clk_hw_gate("sys1_pll_133m_cg", "sys1_pll_out", base + 0x30, 15); > hws[IMX8MQ_SYS1_PLL_160M_CG] = > imx_clk_hw_gate("sys1_pll_160m_cg", "sys1_pll_out", base + 0x30, 17); > hws[IMX8MQ_SYS1_PLL_200M_CG] = > imx_clk_hw_gate("sys1_pll_200m_cg", "sys1_pll_out", base + 0x30, 19); > - hws[IMX8MQ_SYS1_PLL_266M_CG] = > imx_clk_hw_gate("sys1_pll_266m_cg", "sys1_pll_out", base + 0x30, 21); > hws[IMX8MQ_SYS1_PLL_400M_CG] = > imx_clk_hw_gate("sys1_pll_400m_cg", "sys1_pll_out", base + 0x30, 23); > hws[IMX8MQ_SYS1_PLL_800M_CG] = > imx_clk_hw_gate("sys1_pll_800m_cg", "sys1_pll_out", base + 0x30, 25); > > @@ -382,7 +381,7 @@ static int imx8mq_clocks_probe(struct > platform_device *pdev) > hws[IMX8MQ_SYS1_PLL_133M] = > imx_clk_hw_fixed_factor("sys1_pll_133m", "sys1_pll_133m_cg", 1, 6); > hws[IMX8MQ_SYS1_PLL_160M] = > imx_clk_hw_fixed_factor("sys1_pll_160m", "sys1_pll_160m_cg", 1, 5); > hws[IMX8MQ_SYS1_PLL_200M] = > imx_clk_hw_fixed_factor("sys1_pll_200m", "sys1_pll_200m_cg", 1, 4); > - hws[IMX8MQ_SYS1_PLL_266M] = > imx_clk_hw_fixed_factor("sys1_pll_266m", "sys1_pll_266m_cg", 1, 3); > + hws[IMX8MQ_SYS1_PLL_266M] = > imx_clk_hw_fixed_factor("sys1_pll_266m", > +"sys1_pll_out", 1, 3); > hws[IMX8MQ_SYS1_PLL_400M] = > imx_clk_hw_fixed_factor("sys1_pll_400m", "sys1_pll_400m_cg", 1, 2); > hws[IMX8MQ_SYS1_PLL_800M] = > imx_clk_hw_fixed_factor("sys1_pll_800m", "sys1_pll_800m_cg", 1, 1); > > -- > 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel