From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34189C28CBC for ; Sat, 9 May 2020 12:31:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDAE221775 for ; Sat, 9 May 2020 12:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JqRjEEQo"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=marvell.com header.i=@marvell.com header.b="ULOWTUvM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="IEISvQqY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDAE221775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6mpXXtxlKB7KS725d24P2K+shec1gL0zyiiqWFYsZ6c=; b=JqRjEEQo350QeM sYvhbCfxnLp0hjR5zqi0ZP9q51g6FwQaccisdHsaTg4WoabYKtTmKN4iDKRWSFSBMqUSv1mDPTHev gfhx/STXqY3MMB2nYDxJ3Jey5hdRpXuc8KOKYzP39dkaoLCyGS0KNnWF7d7umSXyQpj1qJL6H9ccK HNA5yER+TSBGqfIfxlZOEJtaD6rgAlECmNnSo+7gZ3ogew6hlBpaznSze929wKIRZddUKRQLmM7HS s5fv1RL/YuQ12E0y32qGIAjf9w+PGSygd3btnFT7rymRRiAlA9zNtilNUN6dlyAXbA59SIUb7BQyN TNaH7OjE9QDeIaDMq2Zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXOdo-0002oL-Dq; Sat, 09 May 2020 12:31:40 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174] helo=mx0b-0016f401.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXOdl-0002nB-1X for linux-arm-kernel@lists.infradead.org; Sat, 09 May 2020 12:31:38 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 049CQHv1030995; Sat, 9 May 2020 05:31:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=CgzoyqH+mLc4jGjbBtJtUA6q67Q+NNrPXdgkgBJVeNY=; b=ULOWTUvMlRBlgVEENdQvPIIRPk1kjN9ZDzFM3lRzxsrSsEpMpLdBgx8+DgxndZC6l1x3 K2ScAnIwakgKw2R/DuorM4sK95l/IcLO6rYSEFEB1DoSyvytnXKQdP9Ha6REOUyHNqcv mBBoHVvrIw7WFOHZqwWyuU6VskBhRofmIR4yUf0ip9BOZv1UyCaP6sOgamNeFW0i7Smc wx0kaitlFmzsfzo7FJ3I0zLcFTQdwuULcyi3xIKJTmxQvyB8iOdCWEoLM9GbXQ5TeWku jPV99kVtw+L4SFkha24nzoHNYaI2Xwh7mfzdOEdJLBHm9ujKYicUeJrgdvh1f0z1Xk+k aQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30wsvq8dnx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 09 May 2020 05:31:25 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 9 May 2020 05:31:23 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 9 May 2020 05:31:23 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sat, 9 May 2020 05:31:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGf5/E1nEH5DzJMHhc2p1j5ItuqRoWJN9YsVoFZTJu1Dv3Sy10iuQ9ijDVwa0UetoFAgsOfP24RM/PHGHbQygQO296/yoeH9029nIX7VH+y/Kwdvyh6Lg1L/jN1wbh73POJNH+1Fv0yjeD/HoJWtsX+fGTJqu6fAsF97dygLin+9CZgIWMxI/c2+i2zhBnvK8qYioNGDPPHSwT7xX94Suov+5MKwqCH2OLSQqLph83nHfO8DJ2DoGsz/CzmAaMgE7lOlYzHW4rNxFUiH0Dz/Zc12X4HKxdx91b+ToAi7XS2jdPxBvTsfo527tvVLMj9YEOrf1xcC+RfeDzsVIpAKRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgzoyqH+mLc4jGjbBtJtUA6q67Q+NNrPXdgkgBJVeNY=; b=jciW1bIAzLQcdJtv6J2jXeHHMPxjCF07id0HzIOtZ809bPNgZM+linGeX/hbA7R9Kmm0LIX4roacARZKSzz9k/2wpWKMA3B9Fei0Z+vNRPb0Tyt56eCBpeOoPyYmfKk+L5xLPh2qFB1oyb9eoXMovFSyz+83WISCnVzaODKBHV+ZpS8eVgzCupSM3+ynRh8x/0mS1fXAvLLLenDgFueCNqtqbxwojhDNj0PsEmbiGnKF5LdJF1R+Rh5k5DWg69c1nfJ1Jw1pTJCfvU8Llvbe4h79w2mwACPl6JYqA1KJlCS3fXsD0KFRyMcjs0pgRb66K2ZJe0oANtqHZL9Z6TfX8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgzoyqH+mLc4jGjbBtJtUA6q67Q+NNrPXdgkgBJVeNY=; b=IEISvQqYR9KpM6PWmtDB8lWVZg5urTRH4ASSP0xuvYrMSOahFsL1ouU0X4piLvP00VusqmGcKpHO0EWXupIBiRKHpOAVDuYfcY4E0HEH+HR+8XNrup7zjYXKowUfYCZC74pLy+eyhNYYuINguzHBFN8sDMNanY0DBEBUtLFs+n0= Received: from DM5PR18MB1146.namprd18.prod.outlook.com (2603:10b6:3:2c::15) by DM5PR18MB1115.namprd18.prod.outlook.com (2603:10b6:3:31::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Sat, 9 May 2020 12:31:21 +0000 Received: from DM5PR18MB1146.namprd18.prod.outlook.com ([fe80::51c3:5502:21c2:f515]) by DM5PR18MB1146.namprd18.prod.outlook.com ([fe80::51c3:5502:21c2:f515%12]) with mapi id 15.20.2979.033; Sat, 9 May 2020 12:31:21 +0000 From: Stefan Chulski To: Matteo Croce Subject: RE: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Thread-Topic: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Thread-Index: AQHWGZC7cQmjD8WUCU6s0i6IN8JFgKie+g2AgAC4ufCAABFigIAAAbyQ Date: Sat, 9 May 2020 12:31:21 +0000 Message-ID: References: <20190524100554.8606-1-maxime.chevallier@bootlin.com> <20190524100554.8606-4-maxime.chevallier@bootlin.com> <20200423170003.GT25745@shell.armlinux.org.uk> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [80.230.83.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 870e0a22-09a4-408c-22b7-08d7f414e1a2 x-ms-traffictypediagnostic: DM5PR18MB1115: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IracEIVcWtXy1P+MESoN76pcH2DACZZoaHt+PnMNqjbMUiU/DYJGPqFI9xV/YwNancCp8JYL9Hm345rN4D0n3CCHfiQhOSo6rfjwmD6d38b/bFjveYQad7wiA2bCnJMGdJ9HqTvteCE9g7aIw8kyFRpbIs7E3oKX7QbPvrSmjIAELSsguPKRTylvoh13asyUYSukoHVRFTRrZ4024mhOSu6s26TvqqenLEvkcXvGkMbkRRjs1zxK2flva73qKrw84743mJudUBovFvsSuS7tHRZA0+gfJG+zj/IwQOH42ZiFyYBB7oYpM5mn9qQpnjyUCwyOXldxrJmKxBFXT2iIfHaX9YeCgy90GlkpngKStxwsDqsCg7N1Se5R0DF3JelgOEmz9RRxlsu+g50jF/GCIXV+cJbqZp1g/BP7BnLECMWA88gPCMuhRsQjhWEArp1Ro3ME9jzXnDaNkqjhnnd7AC0h2Ziru5q0AmUPj/WZJgSva+o5Rl0gXGr1EP/+oYh5H70g0dAuoYOT3ASxTfwBkg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR18MB1146.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39850400004)(396003)(136003)(346002)(366004)(33430700001)(53546011)(71200400001)(76116006)(2906002)(8936002)(316002)(66556008)(66476007)(7696005)(66946007)(186003)(26005)(33656002)(64756008)(52536014)(66446008)(8676002)(5660300002)(54906003)(6506007)(86362001)(7416002)(6916009)(55016002)(9686003)(478600001)(33440700001)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: UBq5DAfFheGmdi0RaCUhbiubjMUofqBTQphZtxvjgtTMU6w+M505OHHeO6xRjbrK7iJJ6WEAap9cD9IY1xpxFn91gtVxY3dmTLcspM6trrle/dC6PA4FDxeyFhbRA14fsEH5U7UjhMA12/cS0fTrrpcMNAQe5RkUrJGza1Ff2Tdn5BWNSfdDYoDhm+Nf/kjlq4xRnV8kwyH7stIbSf2H/ipdwrPX7yYkw8tIFwvAyZl72wyM2nEBsPcStmX0/iuSkhJaoX74Yy5aNp4cRJ8zin7K8W5zOXAPeMdV9JBn/8/nkDzM18HiOg/YPoJ25JDdsFbM7c/gNhFhMbXU2TWh8kHVs1CA+bwu3+u222Dz3t6NNhGFf9Pq/CwRbWDSzQmb/nPKpPhDyWNDie2+NB3QUVXTuQuFjubeOgIOF/v0eWC+Eff7O0bifRSavyRMxHm5T/XnxU9rEP09ujo35Ouyn0MJlKF2ReUcUhmIH0i/984= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 870e0a22-09a4-408c-22b7-08d7f414e1a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 12:31:21.7297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: us8MPvoj9+Z5kie36QTOQ96km4VWIWcFBuY3N1jS9OHGgkM0yv0s/a8xKUtql1rE/zwob4977W+6oU7x1HwXdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1115 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-09_03:2020-05-08, 2020-05-09 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200509_053137_157934_34C5F20A X-CRM114-Status: GOOD ( 25.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antoine Tenart , netdev , "gregory.clement@bootlin.com" , LKML , Maxime Chevallier , Nadav Haklai , Thomas Petazzoni , "miquel.raynal@bootlin.com" , Russell King - ARM Linux admin , Marcin Wojtas , "David S . Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Matteo Croce > Sent: Saturday, May 9, 2020 3:16 PM > To: Stefan Chulski > Cc: David S . Miller ; Maxime Chevallier > ; netdev ; LKML > ; Antoine Tenart > ; Thomas Petazzoni > ; gregory.clement@bootlin.com; > miquel.raynal@bootlin.com; Nadav Haklai ; Marcin > Wojtas ; Linux ARM kernel@lists.infradead.org>; Russell King - ARM Linux admin > > Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to > handle RSS tables > > On Sat, May 9, 2020 at 1:16 PM Stefan Chulski wrote: > > > Hi, > > > > > > What do you think about temporarily disabling it like this? > > > > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > @@ -5775,7 +5775,8 @@ static int mvpp2_port_probe(struct > > > platform_device *pdev, > > > NETIF_F_HW_VLAN_CTAG_FILTER; > > > > > > if (mvpp22_rss_is_supported()) { > > > - dev->hw_features |= NETIF_F_RXHASH; > > > + if (port->phy_interface != PHY_INTERFACE_MODE_SGMII) > > > + dev->hw_features |= NETIF_F_RXHASH; > > > dev->features |= NETIF_F_NTUPLE; > > > } > > > > > > > > > David, is this "workaround" too bad to get accepted? > > > > Not sure that RSS related to physical interface(SGMII), better just remove > NETIF_F_RXHASH as "workaround". > > > > Stefan. > > Hi, > > The point is that RXHASH works fine on all interfaces, but on the gigabit one > (eth2 usually). > And on the 10 gbit interface is very very effective, the throughput goes 4x when > enabled, so it would be a big drawback to disable it on all interfaces. > > Honestly I don't have any 2.5 gbit hardware to test it on eth3, so I don't know if > rxhash actually only works on the first interface of a unit (so eth0 and eth1), or > if it just doesn't work on the gigabit one. > > If someone could test it on the 2.5 gbit port, this will be helpful. RSS tables is part of Packet Processor IP, not MAC(so it's not related to specific speed). Probably issue exist on specific packet processor ports. Since RSS work fine on first port of the CP, we can do the following: if (port-> id == 0) dev->hw_features |= NETIF_F_RXHASH; Regards. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel