From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C15FA372C for ; Fri, 8 Nov 2019 19:00:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD2CA214DB for ; Fri, 8 Nov 2019 19:00:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DRztkUYG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microsoft.com header.i=@microsoft.com header.b="f3Vb2th8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD2CA214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2y9i/oIQRmgGbRDixJcvnkVym7rM3DZDlKbs1OEYi7o=; b=DRztkUYGn5nH0D b5ni/Ifnwh7ItWRzron6CVLYtIwKRap+FfXVsZ5QHtT2K9zFTdOljn+fO3851UgoyvNihUAPVJ2hw EUfaam60FZ63yD9i5WH6TEj5WApoGQ3UayLGpDYtTDg3cspyuE12GUxfGC5w/4blHZZQI/HIfTAzK Qu7NtuOEibRM/En5ZqJm1PxgHF40L6sCCBDxI9barzeGKjsgtykSw/aPZy313QHR6TxG36s35M6JX nkGsmXUzMsP4KYWRTmC/KBwjHN7StSCfs7OIev4DeB6HCqjiRfDzlVChrneoVJCai92SJA/c2Ehvf n7BrePqdaSGQuBL0Ddsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT9Um-0000RM-5u; Fri, 08 Nov 2019 19:00:32 +0000 Received: from mail-eopbgr680115.outbound.protection.outlook.com ([40.107.68.115] helo=NAM04-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT9Ui-0000Q4-U7 for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 19:00:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H4JTphZsB60UhzJe+UHUig8WdU0yh9d08zBjzgI8tWw0f83DhSetnFcugBJyFtdOdcstbf+Q1z89PtCBKgH5hjQ+H96vzV0dITxzS6NWIaCos+ANJu7oHc+nDJsjPTQU9NFSoKtkcmfRsV2ulLmeVcuavwhx/i4P0/UI8Gv9wKdz+dyguVC/2VrusBBkuM+UPoTlMz853ewiAtFgBod2dHPUYQfqS2wOFrjiwAfGzUHEq+su07AOOlkZWeZttlQj8BF/fDNWmYsP7WMIW4pJ+Z0hZFfo7WOWsCZoe8HQldGnACJ5AdGj340B4OQyJHsxu+KtKuda6++7MVUl/9R+bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VO2S6M1qY9fe2w8cZycs0IX2ND6j/pja58mAe0o9mNs=; b=ldK9AxuOxR30P2r+i4MFijZTah7HPWxbC9rMkD+N+6uFxQtZGdyL8zAoZ3INlIxIk6u1L7ZRxD0844jUM97/bTsiUjIA0PSWvY5f+s4P6cmyQe6c5YvjpMpHW3JclWndTCLM3tahkc0UPhjtciqyuNd97e0xWK0EvgTYjySK4tlVHhP8/h4g3E5GIlJUPmB9SLeqDW2TmRrNj5v89DabcRbTSehqaD99IRsE2NaMRBW3p6j2aSNP+V5Pn8/PsqH9PIHpgkFEQ1Ly8e+hxRspfUCl+iYUt4rF6OOLYnkw+pnkto79BmclnaFol1sdG6xydwM9/yqLzkUmuOjPRZxKPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VO2S6M1qY9fe2w8cZycs0IX2ND6j/pja58mAe0o9mNs=; b=f3Vb2th8iqAyraFJHZ5rg1Lj6MMEf2YKRedo98CqjvqOgNBPZf+s2Jnp9Aec8ARkAdnwxpzI+W1pKijJu/jSRvimqHQEEM7dvHsctS7Z9Rz8h9N6PTLy3yMDsXUWUIYI8EbeKK7v21hEGNIJtIe6W9PFBHxYzgGvOk98SjuG5T8= Received: from DM5PR21MB0137.namprd21.prod.outlook.com (10.173.173.12) by DM5PR21MB0138.namprd21.prod.outlook.com (10.173.173.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.15; Fri, 8 Nov 2019 19:00:24 +0000 Received: from DM5PR21MB0137.namprd21.prod.outlook.com ([fe80::9cc3:f167:bb63:799]) by DM5PR21MB0137.namprd21.prod.outlook.com ([fe80::9cc3:f167:bb63:799%5]) with mapi id 15.20.2451.013; Fri, 8 Nov 2019 19:00:24 +0000 From: Michael Kelley To: Marc Zyngier Subject: RE: [PATCH v5 3/8] arm64: hyperv: Add memory alloc/free functions for Hyper-V size pages Thread-Topic: [PATCH v5 3/8] arm64: hyperv: Add memory alloc/free functions for Hyper-V size pages Thread-Index: AQHVlXZk8k578k16NE+4oE6DGxisXqeBnxIw Date: Fri, 8 Nov 2019 19:00:24 +0000 Message-ID: References: <1570129355-16005-1-git-send-email-mikelley@microsoft.com> <1570129355-16005-4-git-send-email-mikelley@microsoft.com> <43d53ebd2637bd9106137103028a4f0e@www.loen.fr> In-Reply-To: <43d53ebd2637bd9106137103028a4f0e@www.loen.fr> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-11-08T19:00:22.7576236Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=1a82cc3b-5f0f-413f-80da-a4b461a15203; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=mikelley@microsoft.com; x-originating-ip: [24.22.167.197] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b2798357-1728-4501-478c-08d7647de99b x-ms-traffictypediagnostic: DM5PR21MB0138:|DM5PR21MB0138:|DM5PR21MB0138: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0215D7173F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(396003)(39860400002)(136003)(376002)(366004)(189003)(199004)(22452003)(54906003)(8936002)(316002)(6436002)(81156014)(4326008)(81166006)(55016002)(8676002)(446003)(7696005)(186003)(11346002)(25786009)(10290500003)(478600001)(33656002)(6506007)(74316002)(9686003)(486006)(6246003)(476003)(26005)(99286004)(86362001)(76176011)(14454004)(102836004)(3846002)(6116002)(6916009)(66066001)(2906002)(7416002)(10090500001)(305945005)(52536014)(7736002)(66476007)(66946007)(66556008)(64756008)(66446008)(5660300002)(229853002)(256004)(71200400001)(71190400001)(76116006)(8990500004); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR21MB0138; H:DM5PR21MB0137.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wi7mKc93AP6t9t/asy7vx44CfuCem0Nh1XJDYES3n/DtYVDFUza3BJbKkXmvQJ2q4oXzhfIBmP6yqKH+wrYUUu0Y9hpunYYiD/l5AwsUqudxNc9T68aXNuJKNCVY4D4ec8EMDJJtwwzWyVX1mvAJp9aWTZFILw6zHUbXZWPR/2cSHN5HaIbmdqauBpe5Hu/1mENVg2MGNOF6Pk1ipTfHVgLxwrqUlh23Ekl24a8iXLIekyaIDaaCFeXGdL7UIkzP/oh8vRkmCps9CbLj/3VTWIsAdRMt7mfqloqrKOTpKRk6l2RcVtHc+zhRj0VjaQhfEwzpz22YLfApyLgN3BYI7wUrREqu9PCZnCa9XnsEILakR/zE1CI4g6+L8xCUh8fy9JOgGmlj3uqq5sLQbwluALv/OieHi3SgkcwKFuggb8nhyNn2rCUhfbdUhCHPWN61 MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2798357-1728-4501-478c-08d7647de99b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 19:00:24.8442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Czto9UJuOD9dwKru99cZq6G2KmuAPdjqOMRHnbreqRp3fPfJsSdg6hTU+oIMwfrTLzhcpZMtYCDZckvywTrSu3do0+wYCH7jhfrYZffOtsE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0138 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_110029_083000_DAAABB6E X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "linux-hyperv@vger.kernel.org" , "boqun.feng" , "catalin.marinas@arm.com" , "jasowang@redhat.com" , "linux-kernel@vger.kernel.org" , "marcelo.cerri@canonical.com" , "olaf@aepfle.de" , "gregkh@linuxfoundation.org" , "apw@canonical.com" , "devel@linuxdriverproject.org" , vkuznets , KY Srinivasan , "will@kernel.org" , Sunil Muthuswamy , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Marc Zyngier Sent: Thursday, November 7, 2019 6:20 AM > > +/* > > + * Functions for allocating and freeing memory with size and > > + * alignment HV_HYP_PAGE_SIZE. These functions are needed because > > + * the guest page size may not be the same as the Hyper-V page > > + * size. And while kalloc() could allocate the memory, it does not > > + * guarantee the required alignment. So a separate small memory > > + * allocator is needed. The free function is rarely used, so it > > + * does not try to combine freed pages into larger chunks. > > Is this still needed now that kmalloc has alignment guarantees > (see 59bb47985c1d)? > The new kmalloc alignment guarantee is good news, and at least for now would allow these implementations to collapse to just kmalloc/kzalloc/kfree calls. My inclination is to keep the function calls as wrappers, since ISA neutral Hyper-V drivers are starting to use them, and future work on memory encryption in virtual environments may require special handling of pages like these that are shared between the host and guest. But they probably can be moved into the ISA neutral Hyper-V drivers instead of per arch. Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel