From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79808C433C1 for ; Wed, 24 Mar 2021 06:08:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3195619C7 for ; Wed, 24 Mar 2021 06:08:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3195619C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QeDsd01ckjSGjosoWVWvvrwoQIAVQI98fcWF95qlcAc=; b=DIpWiWkKXsC5kLtP64j62VmtZ jqtazHTuWcr4M8nnGu44eNC8zqxU8ONtZSH/pJUOEdDLzMDVX9u2MM0BX0082proCfgxHmno0hQVl ssfeGh2yVUufJlreeE82Xuc/85mJ/y7iWqxrN109SIwoPgYYtwpn7HCMUopJcG0/Z6R3suG0znLc1 nw96ZZfi4K32TaUC/chPmTlikxEM0Cy5u6+8UvBLzjoLAcH1pib9tZa/TFkMVXLngLNoPPOa/CyKq XCY5/Wwo5FozQk28MgSnpew3EGq39WMFZjik+digPeWXWoDWdFAU3CBbMvGaJqLPQfuWIId5vx9bB QKKXcbmwg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOwfS-00GNVV-Ru; Wed, 24 Mar 2021 06:06:58 +0000 Received: from mail-mw2nam10on2056.outbound.protection.outlook.com ([40.107.94.56] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOwfO-00GNUn-NN for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 06:06:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLoRh0Le0SmobaT/NqDfLpSh9iY/HduEdGCB8oz10ZY0pJrJIZ5fxDdf7vC4jnKs0u1J9B+Om3TNbaWX6KUfrbnD3ahx+eFyRgF3MNtEataCRptcii0Tclt1nS1dHi62fk1Yl+B5ul8d2WEDzBtyoQL7trDI/2sQ5ynegoCdhlb2Y+BPOWwa2Ipcq/GB1YT9Se2a5o0twi8+h1ng4RcT88zqd/4YQAG0rJ7MDSViOleGAxWrpT9e017yOwumlXuHPCbWPQtHFBLnS2q/WJ73PRiks7pMnBMziOBKdnLQhifkh0q/D88XpVEE9KIAnPDb738gPYUU3TugruST0YcGUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3tY25yj+JoxKXRb6w+O/dpmPvXJvbERajnF9aW3Q+E=; b=QIRO9t0SaXkSSQmTyYk1St3Xqo3l3wIRTVgHsMaCP85n2+NGIPDKl8kQ+BhKc0Qs9vPHWgJj86GREaPGncT4hg/g4+Fj+WXH3fUSMhZ28saOg5Zo5pziekc/AHbz1uUC6lbSCBEpWI+HAH6s6OfQKWGK3W0e74YIU4h6fWc1kMmq5TTQWuV/IHeYaHB21YbG6bFfwAMfNWdVg99/rUDKJ1lUG1z2GGPrS3e+/pv9U4cSaKXiooQ3KrFGYXrH5sCXqVK3PNOdss5/O74AESHulaDq5si3eG4Y6ScwYEywTynn7/+YmhAbRB7FLsHZ9zk1uPXfLTojNr/a2g9OKAHCBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3tY25yj+JoxKXRb6w+O/dpmPvXJvbERajnF9aW3Q+E=; b=s7e9qi9mRlCiwl6Kmui7R3KlP/cqgwTGhY/nr9DM5GjobhjsLnaTxEDRo1XzY+fLbQxCGheNqJW2bsWyxSy1lV3bRJADiO19poLyEGBjF6QATk3UoWHQaOOPZP7pfI9rf1mLRQc1xMDXaD/ap75xkR+fq2THSZ3affa6/h4YlwU= Received: from DM6PR02MB5386.namprd02.prod.outlook.com (2603:10b6:5:75::25) by DM5PR02MB3813.namprd02.prod.outlook.com (2603:10b6:4:af::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.30; Wed, 24 Mar 2021 06:06:47 +0000 Received: from DM6PR02MB5386.namprd02.prod.outlook.com ([fe80::bdf8:e364:ff76:5a5a]) by DM6PR02MB5386.namprd02.prod.outlook.com ([fe80::bdf8:e364:ff76:5a5a%7]) with mapi id 15.20.3977.024; Wed, 24 Mar 2021 06:06:47 +0000 From: Srinivas Neeli To: Guenter Roeck , Michal Simek , Shubhrajyoti Datta , Srinivas Goud CC: "wim@linux-watchdog.org" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , git , Srinivas Goud Subject: RE: [PATCH 2/9] watchdog: of_xilinx_wdt: Used BIT macro Thread-Topic: [PATCH 2/9] watchdog: of_xilinx_wdt: Used BIT macro Thread-Index: AQHXGYiU4LDFPsvrI0yyhMMRk36T+qqF45mAgAzQ8iA= Date: Wed, 24 Mar 2021 06:06:47 +0000 Message-ID: References: <1615805214-24857-1-git-send-email-srinivas.neeli@xilinx.com> <1615805214-24857-3-git-send-email-srinivas.neeli@xilinx.com> <911ea811-9b9d-f2e1-bd0b-74432e652c04@roeck-us.net> In-Reply-To: <911ea811-9b9d-f2e1-bd0b-74432e652c04@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [103.200.40.46] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e1f953c6-cfe2-4ebd-418d-08d8ee8b0252 x-ms-traffictypediagnostic: DM5PR02MB3813: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:345; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Mb6fzyXTdB2hsLvYC8tPHlStYUx+AvKAiMYr1C5HcKed8e4aqsWYn7hbyaozEl9+y+3ak5Znvksct8c287RVOo6FATQxWEMhIZMys2RBIH57S15fVqxQLPlENGEhGf6loXkNCbG81yfydYoK9oRGZ8smgU3JXVxr5AY9d3TwDyMI3cqQxGB04q1QY+roQk9a2LDNtS9dpVE82vueF81yFyqI8Md8YCXiOtuZAhg7Qfjz2FFceaA/8OQd0tl6eG6SZ502jL0ul3z6EjFXcq3phawSl3aIADS0QOiEuY/HCQVWdkKEpDms7iikIEYg8gY+aMTcMv7PLH8SPZZoMS9IMkhH6anyC5Fwvy6GoPqoQ4jILLGhL8PAmEfvzU5L9udN1Xm4l+C/CP1Wkq9Gecc9uUX9XSXxu9hoUKZXk3EGAiAxrE3m8d2C5f9YCBe9o3qI+ubMwyG+8LXdYc8QtYyI6DQpL+I/ZEEyjq6sQQ6ToTsWiBVd69KCzLT7q47CzS/NTFDeIqvV8GE9ovhYk/Ps/aQvM+SPAJbZ85zpiu+GBsgZLp9H5IZRNx1bgDlRAUIPCcU24ckTtgUA8mtCS5hJOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR02MB5386.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(71200400001)(38100700001)(66476007)(26005)(83380400001)(64756008)(53546011)(66946007)(86362001)(66556008)(4326008)(33656002)(55016002)(2906002)(316002)(8936002)(107886003)(66446008)(5660300002)(6636002)(52536014)(478600001)(110136005)(6506007)(9686003)(76116006)(186003)(54906003)(7696005)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?N0xYQXVjekpIOTYrYml3cFZFK0xBakdGTllrbU9QYktYR1dBZVphekV5dmNi?= =?utf-8?B?UnlTeXY4bFVNVU1oZzd3VVhIZ2hiWVN2c3pnU1hyVXZXWVRUU2JmTk5aemZs?= =?utf-8?B?TWhpS1hkbmtkblpzeGZzRzlRRXNSbHJrNUd2Y1lYd01LYmpmbFJlaUJNNkhh?= =?utf-8?B?NTlsbVJOWVFvMlNaSEtZUHo5Y3lxUXM5K2Fhc3prdXk2WHJpTlkxMVE3d2pG?= =?utf-8?B?Q0pRbkFZQXA0Y1FDRVEvL1BSS095SXh4a1ZLNlFsOUJ3WG9aZ1VYR3dTNEpQ?= =?utf-8?B?bXZEc0dEZlVqWThBQ2tKVjBsdlpDbzg3dGlGSjVRaDJVNFZQaURtL0I1elNC?= =?utf-8?B?UHViM3ZodnpUWURsc01Bc2tTS1dMSXdqM1l4QVRCbUJYQ3dacFAzZXJESWN6?= =?utf-8?B?bWdONkw5ejN4c2xSL2tLSDQ5R2t3WVR6UjQ5eC91MGdWNUpnY293c1Q3YmVn?= =?utf-8?B?Rml2a1pxbzZjZytzWHY3UFlKa3lKVGY4dWhPMVNPV2R2dVVOQUQ0b203ZGNO?= =?utf-8?B?VmErZnRkTzNFeDFyeStkTEVXOTRBQWZVdklvTW9sTWxaTVlLc1FUY3o2YmJi?= =?utf-8?B?dGxEYlZhKzRUdWV3NS9Ud3JnNkpiNUtHSDAxeHBXV0tpRXRIR3BvSXdxMHZ1?= =?utf-8?B?WTBJaFd2dFdHdkpuQWt0a0o2QlFzQWg3VzFobW1ab1BPRWMyT2VnYXdSVEtz?= =?utf-8?B?Z3I1MVhTRG9nN0xqd3ZVdTVsSUg2VVJ0bnB0REppWUZ2SnlwSW9XUTM5c2Fv?= =?utf-8?B?NDdIeVoxVHdHdUEyVjQ1VDFjeVQ4cU1vUml5YXJtN1JwVUpNS1BCRUpIbXpw?= =?utf-8?B?MHArNmNUNFcvdmJOZ1F2cVFGbHBRZ3BSOHZVc044LzhmTHVaREZrbWtlWTI3?= =?utf-8?B?WHFVR0lxM1RPdkg1bmF3UG1mdmg4ZmI0SUtNWEpzNHRrN0xaSGVaZVdLSXYw?= =?utf-8?B?RnVha28vWHBJNkV5RFZweCtuck9NZFNlOW9xaDRzOGpDSFI1THR1d2dzNHRZ?= =?utf-8?B?TUh5QnpoV1hGVFpySWxBVmhSVko3Q2FQRGJQVjkrOGNMUGI3am4vVzBzVU1P?= =?utf-8?B?RWFaS0dKRjhmMjdyQ2tveFJoWnNQYkQralJYczRqQzk5UmJhbHhVUmcxU1dN?= =?utf-8?B?M1UwbG4yejNpRW5sR2dKQlF4OUN1czNTbUpSZDhHR1cwQ0E2eXRMSTd4VlhC?= =?utf-8?B?bCtIV0NpSTlxSDRpNXNVQzVaQjg5YTEzNkFxTUxpOXBxQ0NXMzBXc3l5b3Mr?= =?utf-8?B?YkdVcU5aT3JHbldzTE92azloOGFhN3lucGNFRUppVFNWY095MERMTFFCNFd0?= =?utf-8?B?bFRwcVhyR1g1WVVnVHhNSFV2S0FpZE45cmwxVGV4MURHSkIrSnQ5VFVjbWx3?= =?utf-8?B?bzdOdlJXYkcxdU1WTENaVDBOVlg5ZW1kR1RlbmdXaFJIbW9QQVJQN2EwOWdB?= =?utf-8?B?emN6Wis3c3NEMnphNlZVL3ZpYm8wZ2F5MmE4OUpUVzdqbEtGQ292WkNIdUZ0?= =?utf-8?B?WFZtMEY2Vkd0NVNIZlZYTzlDbzVKVG5QbnkyMXBMWTREQ2dncUxLTWMra3dC?= =?utf-8?B?VjdKcEZMT00xWkZQNitMVVNTR3M5NGkwZEw2VnFFOHFaNmkycG9iVXNxbGMz?= =?utf-8?B?UGkrN2crVk9IaVhGSmNWaFJnT0VuK3k1aCtmNDI4enZ6a29iUVZyclpNNlFK?= =?utf-8?B?OVlZYmpGM1ZkNjZjZmtGYXovK3ZZSHN4cjN6MkFoUFdOQzJ3cTloNXlLdGVl?= =?utf-8?Q?JaKrLUyA9M2JJ3AoLTuUiu+xIPuX50sMpvDz7+h?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR02MB5386.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1f953c6-cfe2-4ebd-418d-08d8ee8b0252 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 06:06:47.9165 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u/1LQFIAMe3qpFuBfSOesAXta77083IbqEYY9+wqwWwJpsh2YYWPeueU3GPlXQrARWemeIHx/qjXUkl4fnZWLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3813 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_060654_928826_D17E644E X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > -----Original Message----- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Tuesday, March 16, 2021 7:53 AM > To: Srinivas Neeli ; Michal Simek ; > Shubhrajyoti Datta ; Srinivas Goud > > Cc: wim@linux-watchdog.org; linux-watchdog@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git > ; Srinivas Goud > Subject: Re: [PATCH 2/9] watchdog: of_xilinx_wdt: Used BIT macro > > On 3/15/21 3:46 AM, Srinivas Neeli wrote: > > From: Srinivas Goud > > > > Used BIT macro instead of mask value. > > > > Signed-off-by: Srinivas Goud > > Signed-off-by: Michal Simek > > Signed-off-by: Srinivas Neeli > > --- > > drivers/watchdog/of_xilinx_wdt.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/watchdog/of_xilinx_wdt.c > > b/drivers/watchdog/of_xilinx_wdt.c > > index 00549164b3d7..0d7df2370db7 100644 > > --- a/drivers/watchdog/of_xilinx_wdt.c > > +++ b/drivers/watchdog/of_xilinx_wdt.c > > @@ -24,12 +24,12 @@ > > #define XWT_TBR_OFFSET 0x8 /* Timebase Register Offset */ > > > > /* Control/Status Register Masks */ > > -#define XWT_CSR0_WRS_MASK 0x00000008 /* Reset status */ > > -#define XWT_CSR0_WDS_MASK 0x00000004 /* Timer state */ > > -#define XWT_CSR0_EWDT1_MASK 0x00000002 /* Enable bit 1 */ > > +#define XWT_CSR0_WRS_MASK BIT(3) /* Reset status */ > > +#define XWT_CSR0_WDS_MASK BIT(2) /* Timer state */ > > +#define XWT_CSR0_EWDT1_MASK BIT(1) /* Enable bit 1 */ > > > > /* Control/Status Register 0/1 bits */ -#define XWT_CSRX_EWDT2_MASK > > 0x00000001 /* Enable bit 2 */ > > +#define XWT_CSRX_EWDT2_MASK BIT(0) /* Enable bit 2 */ > > > > Requires #include Will update in V2 series. > > > /* SelfTest constants */ > > #define XWT_MAX_SELFTEST_LOOP_COUNT 0x00010000 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel