From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C7DC2D0E4 for ; Tue, 17 Nov 2020 13:47:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A5A0221F8 for ; Tue, 17 Nov 2020 13:47:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XUzrLyg7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="xwPFPxvt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A5A0221F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pUmO0DsxEId/mXdHoO4h/bJAdvLvVgbiUiw/BptA6yo=; b=XUzrLyg7rls5XqyKUaUKnKFqZ g4vOx+yun0A9eSr0gBzVoTPptm91g5Oe5b8HxnugJijrtUzr8SCShETDUxpEXOqdzC/ZxDQLzeSPi q0BFGu/t7DHrnwGauk6ZDGGbvLIyRAQCdUJNpfMOUQXxkc47ZFIOPnqcYbE6QQR3+Z+AdXv9JdPEJ J9xRdDgBOStcjhPOR5YwpAA9Eb/y+Xbs9t1R69drPhz3HV58Ap5xmP3550oakq0Ioze/trzyAKfio +kA8YQG416yEO9PW9LORMnlwApv5hh4IzZY0VWt7ZjJW5SipWgDsvJ/QgmVPG7XxG2Ytjks53iItF +U4xkqAkg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf1Jv-00071U-71; Tue, 17 Nov 2020 13:46:55 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf1Js-00070W-A7 for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 13:46:53 +0000 IronPort-SDR: qJlhIHgDdyXqy/Rc7z3n8D1OrexPMgS68jFYaPC4qNt6PhNlXOKocxmHqi0QX4DgMsr/GJQOi6 MMlyHUg+Dybg== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="188981269" X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="188981269" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 05:46:48 -0800 IronPort-SDR: PPgppw46BkNdpfthgF2OHoTVeatOUtzPm1CzRTpm4Cj0sH+sgiR8Oq+9XGyu2FYPHtRWqK37E1 cSvRjRBNFUjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="325159984" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 17 Nov 2020 05:46:48 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 05:46:48 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Nov 2020 05:46:48 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 17 Nov 2020 05:46:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HVO49z+PiRNLDyRn+AAtv4pPAmRL2O0702got/0spkmMZif8Ao2G0RD8L875dT2uZBlnpZ3+8cCxNVLStpnKIsbnme6m9FWsw+mnCTpjuHEIJa2AYS7s7vJFyDgvuexCfJHSQBm0tqCopUfhqh9r+2HJAS72zi5XF/LzlFD4i3hV8iYuCZIPOoWo/edK2YD1/4z3oTVXOCQ5QPUeJjKTyW4JP5GFE6JNH4/YxlfvIBA0wzHUxrmHM8nvgr2UZKdXcpX9qzjfG2Btjnmd0fsRmXKhGSgG/yL5yiihAcVRFohHudRJ5lAc/QDCXQQsL8GDLNUAYzmdFKcCmbiQ3uzOFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CNRnQPnyVR1loYHZEiljYq61WpNgneDSrVQ/iCJDbQw=; b=a2H3RQAEMJxelDymSIwYc5FvbhvcLk7IkFX04QMstC3cxh0v13PT03NxJzwYJ9gOBlCqXNeA6Ebwbb0u35/A88pIccpKKoPlV7mTbeOt9z8gV8fTHgp7ZhLeE3+J3+x9C/Trgq69wU2R5udYmXv4Up+vYIJkNGtQJ1gqCrLU/Ik/h5pvkrt7C97tRrSDqjXWGHkLAOHUPXvBS4gW420uHmXxAV0+aX4c+aluPCcFRB1oRxUbjQ7YxS1uviKPLIB+2Tl75vfNbpZL6gRQsSp/WLbkkw9og5V5IcHXt8uR/TiZRJsGq/FB4b7jgzPEFUiYnyjbmVkm40JcMge0WhC5nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CNRnQPnyVR1loYHZEiljYq61WpNgneDSrVQ/iCJDbQw=; b=xwPFPxvtWAdgeygrvJcQ0nDMJbN84JKgjvAHO5UN9f9e3OajtOwzAIh6Bs3WdiUYfR2kOX8RrqeYWEWsoWk9gv+523dwLic2UaBHzdeWs9QmyCvu0umcb2Wx5RFZA8RWT6YgAbG6IGydwV9q3qWzuvR9zXsCD4h5jFu31UqONQE= Received: from DM6PR11MB2876.namprd11.prod.outlook.com (2603:10b6:5:c1::16) by DM6PR11MB2938.namprd11.prod.outlook.com (2603:10b6:5:64::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.32; Tue, 17 Nov 2020 13:46:42 +0000 Received: from DM6PR11MB2876.namprd11.prod.outlook.com ([fe80::c85a:d98e:fbf3:9f8c]) by DM6PR11MB2876.namprd11.prod.outlook.com ([fe80::c85a:d98e:fbf3:9f8c%5]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 13:46:42 +0000 From: "Zulkifli, Muhammad Husaini" To: Ulf Hansson Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Thread-Topic: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Thread-Index: AQHWs/Kyv+f0bf2SO0CVLGdSxsJGq6nKstkAgAApWoCAAWUIAIAAJgbg Date: Tue, 17 Nov 2020 13:46:42 +0000 Message-ID: References: <20201106120933.7190-1-muhammad.husaini.zulkifli@intel.com> <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [42.189.188.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8cd817b5-12ce-4d25-7339-08d88aff376d x-ms-traffictypediagnostic: DM6PR11MB2938: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ec+HTRoSg9IQ3fHzDcO+twMezeoudnjJR4QCDb5hDctk+r0NwSq6XJl9PadN4Lw+gFRWkR3ML1PtEq1WaZ4E6OoP4sQsNbZhLCcL1QfF4pGFTGgY9e8iC74ZdyFfS7Gr4mZ8smMbb1op6clBCPGdEVqc2dJPEGrXt7C0MFYjIbnwJTrQCWdUm6JRbVqAxhrp+UBZu7WPN615stcMyARy0ooLWcNjsGNryvdUBZ5ert5ex+lTbBH2bl7GaKyKejaFi8kpfH1Z0BmeKJsQhLsluxYKiwPwmhPF5nMFR4DbXrhVHxos73V0fKJz1hbkdgrN7x3kjY0qQtfCJflQek0/iaAJSeoAsl1lfyul8GBWLiLTd6nXO7kZeqf4bX6EG4kr x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2876.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(83380400001)(8936002)(8676002)(52536014)(33656002)(7696005)(478600001)(316002)(5660300002)(55016002)(9686003)(2906002)(76116006)(186003)(6506007)(86362001)(6916009)(66946007)(71200400001)(66476007)(66556008)(26005)(64756008)(66446008)(54906003)(4326008)(142923001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: R9ow3X+cDIPz6hODMHpe3Pp/iECL21zp07DErx4OR90wFRGdTPEK8eB68FlSFjMqNefiREk7Qm8tgPTMM5bJcasXgWKQuwV+H4aXkqptbQd53Nm49F0UpejOH1f4v+QhUHVO0EvJXj3jT+5g/iDADPRqo7uBzeVOAbNq7YzPGpOzm5Ie4Vj9VQj7znpdi3DmO/XFw7sgIUUSKfNFdS4HNzJ3HNCMpRMpdzymEO9Y58dXNFQKH8UNw9ORizfSJahIQ20x2x1/8VVhwQ9cRB1y1v6bei5Jo0Ia9TypNzx6KtDcPDDgZXd/0CStn3lSdZQe+B+R1wh2Qi0cpveKGTVwLlImpyUPNj6HIehpWteqfbG+VYOcGp/3eN1KhVJjugIK84nJf7hE5gbB+FbVxB689jCXPMvvLh7w3fcrH0TOl22cj9zz7QQEwyup/Ly1C9pAZhflNtLLsXm14beuSUl8Ap0QD3yVOZcus3xTbwUHtP9tHaJCEMnDBJEPcpEJZqPYJN1OD7EWA0RAs6mMuOrbX8Ll8jrpRmPCPAKYXiEedbGKhmtYcwhxbnI9sZVlmCORQ8Kk/ve/V6EDeK0AXs2yz2jtia+VR2pQxPsKOc1eeEvbBkOPnJ3vtyN1Bb5zkb2xSiH9A/KVzqLxLLDugwKGmsoKdXwkp++4/UqvQDMRz6TF4Utn1+HdzoWZDLfgqydy80QSencQsgDeQ+4fWzyX9XGKyHpHUfQlUBiWWap1DGPrpca1o7bHsEzhJVNi6iMd12a7J+WdiuZOzKMSVAX+bzp2Ao6Qv5CXyEbuLOdzNT9AiMZybUrYnpePvJCv7JnvPu99br+YmmCTxIAWKGh7hG57/gWC0SbyhbFy1pkJpdq9J9tE1zGCH4i8VmLQj1vPENRCIE0qEQXVzZYgj0ZmUQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2876.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cd817b5-12ce-4d25-7339-08d88aff376d X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 13:46:42.2459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qszRH4RoEiWLMiTLpf9skA+ujWMmaUNnalh0uJLGcSMLUkdWL1U8Zkg9PdaV4gyuSjip6il5GWjazGr9/DPYnwOUwOmk7ZXf6otR27cqC4nl2mHNBAA/FIaDkqM/s46j X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2938 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_084652_620721_62D8C31D X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , "Wan Mohamad, Wan Ahmad Zainie" , "David E. Box" , "Hunter, Adrian" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, >-----Original Message----- >From: Ulf Hansson >Sent: Tuesday, November 17, 2020 7:27 PM >To: Zulkifli, Muhammad Husaini >Cc: linux-mmc@vger.kernel.org; Linux ARM kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; Hunter, Adrian ; Raja >Subramanian, Lakshmi Bai ; Wan >Mohamad, Wan Ahmad Zainie >; David E. Box > >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay >SOC > >On Mon, 16 Nov 2020 at 15:22, Zulkifli, Muhammad Husaini > wrote: >> >> Hi Ulf, >> >> Thanks for your review comments. I replied inline >> >> >-----Original Message----- >> >From: Ulf Hansson >> >Sent: Monday, November 16, 2020 7:41 PM >> >To: Zulkifli, Muhammad Husaini >> >Cc: linux-mmc@vger.kernel.org; Linux ARM > >kernel@lists.infradead.org>; Linux Kernel Mailing List > >kernel@vger.kernel.org>; Hunter, Adrian ; >> >Raja Subramanian, Lakshmi Bai >> >; Wan Mohamad, Wan Ahmad >> >Zainie ; David E. Box >> > >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >for Keem Bay SOC >> > >> >On Fri, 6 Nov 2020 at 05:10, wrote: >> >> >> >> From: Muhammad Husaini Zulkifli >> >> >> >> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations >> >> handling") introduces platform specific SDHCI clock operation. >> >> >> >> This patch declares the clock operation for Keem Bay. >> >> Add clk_ops for SD, EMMC and SDIO operations. >> > >> >The above commit message doesn't really tell why or what goes on here. >> >Can please try to clarify that. >> >> We missed out the clock operation handling patch (Commit 16ada730a759) >> and did not handle the clk_ops for Keem Bay SOC devices. >> These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) are >merged at around the same time. >> We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay >EVM. >> That is why I created this patch to handle the clk_ops for Keem Bay devices. > >Alright, so the previous changes were simply not sufficient to complete the >support. > >> >> > >> >> >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel >> >> Keem >> >> Bay") >> > >> >Is $subject patch fixing a bug/regression? >> >> This is to fix issue on previous commit. It is a bug fix. > >Has it ever worked? Yes it is working. Tested with Keem Bay EVM. SD/EMMC/SDIO devices registered successfully with this fix. > >Did the commit you point to with the fixes tag, break some other existing >functionality? It should not break other existing functionality. This is specific for Keem Bay SOC only. > >[...] > >Kind regards >Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel