From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27382C4742C for ; Mon, 16 Nov 2020 14:24:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B648C2071E for ; Mon, 16 Nov 2020 14:24:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dgamZYF3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="Yqx22wcj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B648C2071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pEhBxZECxQTkt1KnxWYhHFZOd7Nh97zxIV9in65eeaM=; b=dgamZYF3E6dY2CaDNMe+Xj8bV ioQxhUQOagLX7MiuTBWhB5Tt1XVQX2iz266gWa7FhWGmNhsXUdNsEx+5q8u5VlX2QJIe7IJPjFw77 1ZEGVhxJ7i+0Cat09IBGm2bM+lb3sLDmHrsETEuCjTmf79QqyJE4YNCz1TRaWcjZdVU9aa8VRKuDO /Tb7d9EqJtEcB082VlF2tmLZJwtUc4T3Tz67HpychQYbK49U3WPlDotN6aklFntheIUnosYNCFR9g 1tFBfjRyR/b9gUelssDSIZUeVyzJw90eiF/KQDR+x861o7nSCiBnE6IZlr7li6ug7qWQ/D3iJYKIl Vzg/cfl7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kefP5-0007wQ-2l; Mon, 16 Nov 2020 14:22:47 +0000 Received: from mga07.intel.com ([134.134.136.100]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kefP1-0007vI-VY for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 14:22:45 +0000 IronPort-SDR: B4Ry9QBoB+FgNoKJlKxEvpZtsWqoLwu8nKhc6KZQKIeTaGUTeOYyv5tnRAbTcBofhMczRvfREm vubmtvsF6Qkw== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="234904510" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="234904510" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 06:22:37 -0800 IronPort-SDR: CzcwJjpJqBHKmzczGPzB4Bo3dGbXTs0RH5m9Gt66Rwk4Y2tVUzNq/zw9+jOK1suF2o6V6aIUbA 5VML3Y32kD2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="340547328" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 16 Nov 2020 06:22:37 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Nov 2020 06:22:36 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Nov 2020 06:22:36 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 16 Nov 2020 06:22:36 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 16 Nov 2020 06:22:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klwb6d1TMtuljxPJMtOjtEZP6KJgq+gdqtyEynElR3RCfOG3x5WJGzYw558lsw2BKgCuLWajQ+XH5NT6Pxlpp0BPmso3J2F++ozeUPeXCJucV3objj7caLENQ6R5WXKEDas5O2zZJB5muNIxmoLmASJq5oCO+9cZM0DFHl4g76x87ieN9PlzBsDFxb1Ml6q+9wKoMlbUDZEBXt1Lti3ollfrqygqpp1Om7puoF70bKICNrLrsEQkhhbSeYM28Mq4crY5QS8N0Bet5AlXkOKhRGZLXTGyl9oQNEDCYnHCq5vEbBuzl8VHxGa27ziCs/jsI8JSu/FBWipL1sFTxSq6ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gRQraJR8RT5R+CGrYYSxbZuAh2IGbX3g2Ylcu2g4bEs=; b=MWeDR5/fhZIcE5cKVAak5ohvXLza//UYh93gOpEx5JOC/udgJLlQsZBzg4u28IbT5p/PRj//vAKS1ia6ib9ZynUQYZ5tyolok+Yk3hRPNWkKBAg6cA3feXujRkE8T4bvG+3G5RnVMU3pSB9bLzgRyHl2D58J4doZgVtBfa6AoT+MPJFcWcgig9s3TLOp1GDkP72azG5qB2J/AmG+JmVjTrjxtz03b9+9KhXCTZ10ijHm3CjLhVX9OdxawM57UwcvQOBjp9uDCuHbRYagQ5cMzKxeHa5DtM+vJx3wHehhJHHnLXtStvAmEQg+ElSHedBQoMeqzb9ljvhZ2dEQGYX/Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gRQraJR8RT5R+CGrYYSxbZuAh2IGbX3g2Ylcu2g4bEs=; b=Yqx22wcjOvT3kRVm2oEtwN/8kETEarC+mPEtsipar6TPGpIcCWCahIHIsDu3+JjHzed2weCRiaHu5CozlW4EYEAM+EbritKMIhHNvqJ6nr9VNmYWV8ombnheBDk965XKd4X1b08JKgdRkTnr0CHB5y9OofHPkqt++QQPpAQA9UY= Received: from DM6PR11MB2876.namprd11.prod.outlook.com (2603:10b6:5:c1::16) by DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Mon, 16 Nov 2020 14:22:33 +0000 Received: from DM6PR11MB2876.namprd11.prod.outlook.com ([fe80::c85a:d98e:fbf3:9f8c]) by DM6PR11MB2876.namprd11.prod.outlook.com ([fe80::c85a:d98e:fbf3:9f8c%5]) with mapi id 15.20.3564.028; Mon, 16 Nov 2020 14:22:33 +0000 From: "Zulkifli, Muhammad Husaini" To: Ulf Hansson Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Thread-Topic: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Thread-Index: AQHWs/Kyv+f0bf2SO0CVLGdSxsJGq6nKstkAgAApWoA= Date: Mon, 16 Nov 2020 14:22:32 +0000 Message-ID: References: <20201106120933.7190-1-muhammad.husaini.zulkifli@intel.com> <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [42.189.188.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc85f554-778d-4781-b03d-08d88a3b0f5d x-ms-traffictypediagnostic: DM6PR11MB4025: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gKHsCmDpKUxYcj1YZsECH9HZIoN5KaqZfncR404Rqao19AtOFaD0DozRJfux+D6LYk1IR9flERmCv66Fr/aBjL3Jn20MEhhvV6DHt199QZ4jcmyPYkFkSu/e8AvHAb0Gkvt/a7JNsp84ky0Ybkfh88TSa/7ryknH8Yj50IVEU9P41HR0F6yYipgRnu6Va9Zp0Y+pPuZG4XB6XxD56KVle9W2PQAYTloPCo/jbF0fqy0j17PncCHZMGTGZPxMyCPNFLC0/2M7H9j9FIyEiaDMtsfqiq213J4h537Kt0APlXnhkGAgA/RQmaq9xfkaM2T6k2+o7N8UjTuAsecI6BR8gHcwC4HIPmxZga0AvxIOcz5zs4emCiZ3Es6mFyez+Zrh x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2876.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(478600001)(2906002)(83380400001)(6916009)(55016002)(9686003)(186003)(76116006)(5660300002)(26005)(7696005)(316002)(6506007)(54906003)(71200400001)(66446008)(33656002)(8676002)(4326008)(66946007)(66476007)(86362001)(66556008)(64756008)(8936002)(52536014)(142923001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Shiw/CD1aJ1a7uJ32TwXDD9S2d5CbD6HGIgpq6AETbv8J7BCG/VWNx6Czt/t7hYkbL+a5E89AxfTuDMn6W4loaVjnOYmUEL98vS/xlg3QDcVHzfn5q5TFGSsT+7Ffn4iwkZmpNRFKUo00PP2iGdHHn/q01WDq3dZybJN77pIPqI0BD+UN6anK2JjNN99AmVgBRZ940/8v9+HVtZNqWtur8WvR2Oucv2RROg5WG2oE9GmFqk7NBXW7CofqsVPyTEFi080yGtuzDYLeX2sGbxtH4vJ97OH6FofBnyScsEDPGeYvDG9mnSyEoGSBlelW1ht19q/8/ggyoFd01QSwJtlkJfVh4nXBEskWs5y9EJov39Q/NGajnfd+ABGebJlxp837QjprsXvb/Znsdjo4gryubUgT77TweUT37X/BaGnte35QpeyNLHr9MjpYhSbpYyoFtHMnnPiedb6lPlZmiXuDF5aHIMROe3Z5zy34ZE/WU8atHpQUA4RSMyzKDhxTnUTS0eSJIcwZeBLuLwFrLG0aLoathImPxiJnouQ6xiuXTgBjQAI1Sh6k4e4OYZpSDMF5smW/3Yh5x3ENqL+5ulyM5J0EIn0Jk/zLTCTkVPWKsnOB0ebzdhtErCVWT6FutIu72We+OCaJEjS8FmFbpqQ+9ZjaVuTfkTcFQugsY0g7iK62bQkKVG3l+/4sMGlgN73yNX/lF+FFhaU9BPwkIgec8sB33ksoZCpU6Qkckil85TtcO5bIXgHVBHuhlXE8/dNS/W1dRQ77Pas2snXdfByUg7B7HDdRpXx8B+tN5JZjgsQHdI914ITgbsczfaBl0UYtHM3Mr84mZrdnUyFbWye6ohxCPMWnN0xGx+siDt6qk3cjZNgnCKbfYRw0UO36PqFKD/SASm3NO4YZyF2/Rd3Qw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2876.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc85f554-778d-4781-b03d-08d88a3b0f5d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2020 14:22:33.7027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sZrw1MchpGazhY2Ys0z8IkPURN0Jff7iHjCJTLUtohDjzEhtTFeUOV9FygWXbY+ZDiX1GjS8y9bSuzIZfFRiGhedUKp8ThFRuuK/Yt6+4Azxi2AbGR7IcPUo+b6K5V/i X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4025 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_092244_156178_3A07EF03 X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , "Wan Mohamad, Wan Ahmad Zainie" , "David E. Box" , "Hunter, Adrian" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, Thanks for your review comments. I replied inline >-----Original Message----- >From: Ulf Hansson >Sent: Monday, November 16, 2020 7:41 PM >To: Zulkifli, Muhammad Husaini >Cc: linux-mmc@vger.kernel.org; Linux ARM kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; Hunter, Adrian ; Raja >Subramanian, Lakshmi Bai ; Wan >Mohamad, Wan Ahmad Zainie >; David E. Box > >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem >Bay SOC > >On Fri, 6 Nov 2020 at 05:10, wrote: >> >> From: Muhammad Husaini Zulkifli >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations >> handling") introduces platform specific SDHCI clock operation. >> >> This patch declares the clock operation for Keem Bay. >> Add clk_ops for SD, EMMC and SDIO operations. > >The above commit message doesn't really tell why or what goes on here. >Can please try to clarify that. We missed out the clock operation handling patch (Commit 16ada730a759) and did not handle the clk_ops for Keem Bay SOC devices. These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) are merged at around the same time. We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay EVM. That is why I created this patch to handle the clk_ops for Keem Bay devices. > >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem >> Bay") > >Is $subject patch fixing a bug/regression? This is to fix issue on previous commit. It is a bug fix. > >Kind regards >Uffe > >> >> Signed-off-by: Muhammad Husaini Zulkifli >> >> Reviewed-by: Adrian Hunter >> --- >> drivers/mmc/host/sdhci-of-arasan.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-of-arasan.c >> b/drivers/mmc/host/sdhci-of-arasan.c >> index 829ccef87426..012d52e1abee 100644 >> --- a/drivers/mmc/host/sdhci-of-arasan.c >> +++ b/drivers/mmc/host/sdhci-of-arasan.c >> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data >> sdhci_arasan_versal_data = { static struct sdhci_arasan_of_data >intel_keembay_emmc_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_emmc_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sd_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sd_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sdio_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sdio_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static const struct of_device_id sdhci_arasan_of_match[] = { >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel