From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A2AC2D0E4 for ; Wed, 18 Nov 2020 01:05:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 476F62222A for ; Wed, 18 Nov 2020 01:05:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SWprPxbB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="yjwFTv3I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 476F62222A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tTCnAfOiJekpldyIQE86KsanKxoNNfiP5q3m6l13aFg=; b=SWprPxbB/vt/H6V3kYPDeRasP OzwYppDNDqFKokGaGgraxN4iYf9eSkaiGClPv89ZXTe0rey8LxMBvCl6wYxeDd0kOLZiM8Bb/V6mN NUmVoQPdOxyPl9FNIR2KCR+GCootxJhCe7G+weupNLWVpd87OUT7nH22W+TIZZmiHp/2OKAqcByce AMM8jb/3wSfcciHg37C05bLk0UtX78VPrFx/QeHzf3SirfgBcG90uZeEAeGy3lmEPO/mE9NdrpR2E jepykKdx8uY/U4y4/Rzgttr1LB2brI1QaMU+TSmOTnP/U2UvIoqqfojqTsvap5yZAEIZAjqDN0B7U 1yYkiIiQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfBuF-0008JN-JJ; Wed, 18 Nov 2020 01:05:07 +0000 Received: from mga18.intel.com ([134.134.136.126]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfBuD-0008Hq-3h for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 01:05:06 +0000 IronPort-SDR: xoYNIJMFxwQHcLsfacY6nmaJ5qtzEjgNuB/+WZIfDTel6YoOYejyZ9i3pq0/ExMFNgQie4x8NW ZK51j6frkZXA== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158817814" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158817814" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 17:04:58 -0800 IronPort-SDR: Ow6wib94yB60t/jBt5NFI60RRf1cfTExwD1/DIT+R+tb1rl176iDNbYr/eBFP6pgePNQfOUFLG qvnHiLD4zNmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="368284817" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 17 Nov 2020 17:04:58 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 17:04:57 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Nov 2020 17:04:57 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 17 Nov 2020 17:04:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pp12etKToqAkHiimG9h4QMDjy7SfbpSyiKAmoHYDg+hhpS5ycyB93ufdB+bC7Vtt3IiNZ2YbHRO/7np1r0o5MyOJfXDmlgJV4daq7zj/Ybih0wSuKVnOew+pUHv9YxzyIgctmWqQo25vUWT2hYlP1kudsSxenYIZ7UHUc+F6wKhQA65CkbttTjtWmUR/HgWHtZ5H81HUXqgTbPYzLVo1Se439pkgdatHO3byzmxS9YdGNynVscm7NAiALEcAdM29RtmgkCb4OPP8yV2qs4ZHh5cdGg2Iv2ZvbPw1dpdtPht97BkvhJpnzaFyOFX39MNg94pC7/+GPE6k1FGYtmfS2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ng1kYJ9iCg3JOKrhW6p35QwMevsA7DDcTf7aMjBPnT8=; b=NfXh+QgEHQmtOXm6rMUAqxURSyG+0EBvPdWQmAxWiO6L03sNAUnQBB8eY2hIm9N3B6qYqlP13KJ00zJWGsUQnGnZnauyokqiqIp8Guu5MZfq9Ago8BzwLlAhLQf2PEMQdPtLmzmXXuFhydvciEGTjqRwmj0nFwzRqfPvc/nG18Qtl9S4klDasgUL7BhOGOq6xZGqr1kExMscbCc0kFi0ti9PyW+lZlRzFvEE+JFTMr14KjgVY18afaIWoEcVxBPjKc5LeLJhue48JMiR/wdpENQxAaBaVS8qyHCCXByry7B4/lS2v+VY2nEz49zY3RWuifu1jD0oyKd71vFyf/ipUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ng1kYJ9iCg3JOKrhW6p35QwMevsA7DDcTf7aMjBPnT8=; b=yjwFTv3IxyON9zOpNIBFgXPsfDDwwYMWbE0D7lgvV1pXhIAnnp7JNUcdx7/Xqhh3pbnNzg/3TbZmGgn134C02+M0aEzTjihlTNBXzoX+PDHnX6RiIS5OTekCuKb7fYbJYIpPPPO9xhULa5e0bQvijfu0SiGQMkz9ZhMSBvsYEkE= Received: from DM6PR11MB2876.namprd11.prod.outlook.com (2603:10b6:5:c1::16) by DM6PR11MB4610.namprd11.prod.outlook.com (2603:10b6:5:2ab::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Wed, 18 Nov 2020 01:04:52 +0000 Received: from DM6PR11MB2876.namprd11.prod.outlook.com ([fe80::c85a:d98e:fbf3:9f8c]) by DM6PR11MB2876.namprd11.prod.outlook.com ([fe80::c85a:d98e:fbf3:9f8c%5]) with mapi id 15.20.3564.028; Wed, 18 Nov 2020 01:04:52 +0000 From: "Zulkifli, Muhammad Husaini" To: Ulf Hansson Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Thread-Topic: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Thread-Index: AQHWs/Kyv+f0bf2SO0CVLGdSxsJGq6nKstkAgAApWoCAAWUIAIAAJgbggAA7EICAAH+aoA== Date: Wed, 18 Nov 2020 01:04:52 +0000 Message-ID: References: <20201106120933.7190-1-muhammad.husaini.zulkifli@intel.com> <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [42.189.188.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5d2bb5eb-064f-4798-025c-08d88b5df48b x-ms-traffictypediagnostic: DM6PR11MB4610: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vc+ysYuWTCfeI3yYd/EfwdpaZ8vY4d6EYCdgvShZwVJ1mxXYNHN6+oaAFB8ifGdqK8nW1n4hMvSFuXPbhyO9TDHQNK3gZPHOsr0QSauPY+BXBN1Z3ZRRvCGSmqU5AFGpj0ssywNJLi0xlLovL+797pjhJ/rqLQntcEuqiI3ezkFwdGBDE9CuL0vomiM5iDn30+PRYHRvLrlNuRO57XdO/72W4r9cgITZksEEx9WPDavYCAfURN8w3pDXOlI7NjIlZrpsq9ywuzwvx0dAkdJk7oJXexKUmovXpww2+SvKLTPrKrU5j5Ao0VKsN7vABnGucUDNOxmfmTV4601uwFjhxDFroloLM4gPT0vv3HM/D4JGOy8PzSTJOqGnYS3MPuZF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2876.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(33656002)(4326008)(71200400001)(2906002)(66556008)(6916009)(64756008)(66446008)(66946007)(54906003)(52536014)(8936002)(6506007)(66476007)(5660300002)(76116006)(86362001)(7696005)(8676002)(26005)(83380400001)(9686003)(55016002)(186003)(498600001)(142923001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7Umj8nT0yj0YUiGhZMKm35Ut8Lv/TuMH3NhOPqvsJCM8Qd+4RUGIgdm/nlITuJi9/0ZAh43AmSNHss7qGf1eXPrwKhKrskWg86GYRHp2kadSM+IEQVARoe7A2bW1asXork1yhAObPlzlrKx/gAGjCvKczIakVfwO5zzGi80wr6UEJM1Ofa+0bBUSeUl8q9FuIZMt5eVYVDf8TkNF9JENrYD6XggUp1gXe1QGYu9YshoFgThbT+eco8qCz3j2BfL5bz6pvBlAvu/kBXXQaE6NfUhQjJrtRPG6zX/VIQxGshUrNRFcrErb0ud8gsda4Cg20nqvg4O891YsWq3w+pm1akb6jRdJK1wCoRwsHUrzm25Mdh7Ji7ZFJYtjTzVUf8Ra9rwmcPsmnrs1o0CPZaLLMC2Ac1kLdoMMJJ3CFFBlzxGZ6Pk82QJkgsMpK0o+U25kYXLIxbYAJwYPJRVSVZuIdbaYyDaPLuk+Up4G56kCZ1vi3Wm6LWEJP8+Z0ncOvkvcAc6gLWPF4s0IbFi5DTQ4QCZz/z9IB946FCh1PNw6RAFoVNG1r4pRdaZK74J/hQKa5ILeMS2B6RxRoA6iMMs4DjBnlXzwB/v15m2LplrmsNHEgpSrFfvqll+/RI/r3VTylo0eZSbQFOExq6aNVdYh6c0Un94W4onh9EO90hNKu30K/ZtWPITq+qD8UV7u/3R1y2hiw6Y7elb8salHedEvc6DnvfGdaz3PfxcS/sHaHe3m7T7xQgL0REcZilqvEjIbFM+uFG65i5iTh8V25GXiuWOk4iUKN/ft5W1lip+Wje6rK4mugIJDfDironxZDav+3sGRXh0XWTaoNZ2GfRpjEugW77LdaCvyFBiEGAcodAtxMs4ZE0ArK/Fd+xBMUrh3U5BMfKK0ljI8hKa8HCTDNA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2876.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2bb5eb-064f-4798-025c-08d88b5df48b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2020 01:04:52.3245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jRtNgAxDGOMBs+0i1MZiSW3IiU9j7JcfpmdhKrFHhnwjL3UHCalLTHRYuHvo3xfxw8QWw+zhzGpw4KdJ9Okkb5DE35AL0xrEpL+D0t3F/fbBL/MA/UJ4QMhgBmQ4AWN6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4610 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_200505_380805_6A6519E3 X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , "Wan Mohamad, Wan Ahmad Zainie" , "David E. Box" , "Hunter, Adrian" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, >-----Original Message----- >From: Ulf Hansson >Sent: Wednesday, November 18, 2020 1:14 AM >To: Zulkifli, Muhammad Husaini >Cc: linux-mmc@vger.kernel.org; Linux ARM kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; Hunter, Adrian ; Raja >Subramanian, Lakshmi Bai ; Wan >Mohamad, Wan Ahmad Zainie >; David E. Box > >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay >SOC > >On Tue, 17 Nov 2020 at 14:46, Zulkifli, Muhammad Husaini > wrote: >> >> Hi Ulf, >> >> >-----Original Message----- >> >From: Ulf Hansson >> >Sent: Tuesday, November 17, 2020 7:27 PM >> >To: Zulkifli, Muhammad Husaini >> >Cc: linux-mmc@vger.kernel.org; Linux ARM > >kernel@lists.infradead.org>; Linux Kernel Mailing List > >kernel@vger.kernel.org>; Hunter, Adrian ; >> >Raja Subramanian, Lakshmi Bai >> >; Wan Mohamad, Wan Ahmad >> >Zainie ; David E. Box >> > >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >for Keem Bay SOC >> > >> >On Mon, 16 Nov 2020 at 15:22, Zulkifli, Muhammad Husaini >> > wrote: >> >> >> >> Hi Ulf, >> >> >> >> Thanks for your review comments. I replied inline >> >> >> >> >-----Original Message----- >> >> >From: Ulf Hansson >> >> >Sent: Monday, November 16, 2020 7:41 PM >> >> >To: Zulkifli, Muhammad Husaini >> >> > >> >> >Cc: linux-mmc@vger.kernel.org; Linux ARM > >> >kernel@lists.infradead.org>; Linux Kernel Mailing List > >> >kernel@vger.kernel.org>; Hunter, Adrian ; >> >> >Raja Subramanian, Lakshmi Bai >> >> >; Wan Mohamad, Wan >Ahmad >> >> >Zainie ; David E. Box >> >> > >> >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >> >for Keem Bay SOC >> >> > >> >> >On Fri, 6 Nov 2020 at 05:10, >wrote: >> >> >> >> >> >> From: Muhammad Husaini Zulkifli >> >> >> >> >> >> >> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock >> >> >> operations >> >> >> handling") introduces platform specific SDHCI clock operation. >> >> >> >> >> >> This patch declares the clock operation for Keem Bay. >> >> >> Add clk_ops for SD, EMMC and SDIO operations. >> >> > >> >> >The above commit message doesn't really tell why or what goes on here. >> >> >Can please try to clarify that. >> >> >> >> We missed out the clock operation handling patch (Commit >> >> 16ada730a759) and did not handle the clk_ops for Keem Bay SOC devices. >> >> These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) >> >> are >> >merged at around the same time. >> >> We catch the issue later when trying to boot into v5.10-rc1 with >> >> Keem Bay >> >EVM. >> >> That is why I created this patch to handle the clk_ops for Keem Bay >devices. >> > >> >Alright, so the previous changes were simply not sufficient to >> >complete the support. >> > >> >> >> >> > >> >> >> >> >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for >> >> >> Intel Keem >> >> >> Bay") >> >> > >> >> >Is $subject patch fixing a bug/regression? >> >> >> >> This is to fix issue on previous commit. It is a bug fix. >> > >> >Has it ever worked? >> >> Yes it is working. Tested with Keem Bay EVM. >> SD/EMMC/SDIO devices registered successfully with this fix. > >I am not asking if $subject patch makes it work, I understand that it does. > >> >> > >> >Did the commit you point to with the fixes tag, break some other >> >existing functionality? >> >> It should not break other existing functionality. >> This is specific for Keem Bay SOC only. > >So, you are saying that it has never worked for Keem Bay? But $subject patch >makes it work? It is working for Keem Bay before until the Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") came into the picture. Both Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem") are merged about the same time. We did not have "Modify clock operations handling" patch when rebasing and testing during upstreaming process. I noticed of this issue when using latest mainline v5.10-rcx recently. > >Can you please re-spin and update the commit message to better reflect what >goes on, then I can apply. Noted. I will update the commit message and re-send again. Thanks > >Kind regards >Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel