From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A4E2C433F5 for ; Tue, 24 May 2022 12:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vPSWh1CwXL5AsDh/xkJPEkGdmPKv4Oz2ADoLg8yV7ZY=; b=ePpxnojPiesBb0 gtRTWJxKn3dr3EdVmsrvqxfF4T1VAI0z3NqiRyJkigrvTcOvlcTy6CNrcLAPRipGa8VKJFq16ai9d kYPbfM+ne/T21fb627FMq8NTCE1d3kuB/1PdDpjKo2EqjowBscJ38LE9UMF79tcPDwtJ6eW0JWnJP ctzPypDmu3GcSACHIu2PsnKUX4Fmo6E8Qbk7g8IYU5Erd65W7nJ08kD1UIwzkr1NrpEa2TzZPPh/n E6UkTbC2KZ6kr+aIBVYFp9Apr2uQyXyD5LOysXJ7gfgCFl1CB0j7dv6ououYHJJfojTfTmmuZHVEG LT06527rf1pcadcaUU/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntTJi-007v6c-Cc; Tue, 24 May 2022 12:07:14 +0000 Received: from mail-he1eur04on0619.outbound.protection.outlook.com ([2a01:111:f400:fe0d::619] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntTJd-007v4c-Vz for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 12:07:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dNEh+xGxVDsDNTY18tUmJ0epVb1++t9M7DZQs7vemoqaR3i9k+NYy35su0tYyVun5TKU+LtHDc/7hk522mE5ve4DfHmNlAqHqZYzgemJOSYeUgPLYaSphD+/1zy64UCmgPDqn9JpT9ES/ka6IQyJwkdKYvIagBLe0wzVUGcZFQZMd6cH5RMvN4kFcEWhL2p1kxHBvTAMudNrUnHyeut+swZUsSJMl73mW9KS0P2crpyhaW/h2qOUowC08C8e1aZuHQ2z/qp457TlHHpXapsN1tuqy4Tj4hCPxl4R0oSS8uzLHkTAVkE3u9/DOIR0yoBh2WoCdazLBG8/054LIhJ95g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tepz4Pu3Mvwuu2pLAU2BeKaamlJWEZmWIRy57oNLdJU=; b=asJ0+QJaHHaHbEcfJrWXjzyuFTXeLWFPLKflcPwwHsYUZS0LpcO2xPjVYp7U+eo5YS8UiuCmVMjYJGcPHFt4tDUUYRr9l80LddZEnvVwQAQk5Oxx63HCZctnGZpvTiFpr1kfcmkcFOb2VAeRuK4Y4+RrQy4IVhvqSS6vnTaLNsCA2g10Ks0fhwz/D/Ki4mGinSxDpFLGUI0eZr3miPxnz8l+X/RtCt63ZKbxFp6FN13+b+i+oELVHIxG6dS3N4ixdKb4/7qqmkKUcHxF54RFo5IIYi1LxihiX95OTw8MzgUH8z3H7KUNKERZpC5kx13PYFoMhHrJqJFhN6XD0TiCcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tepz4Pu3Mvwuu2pLAU2BeKaamlJWEZmWIRy57oNLdJU=; b=AUh26ZyNYg25kCCnCvbzIP9LhwXMBtt9Uwr+ChieHidOaVOJKiBSLjm37Z8z802xeoVZhDmuuDEgcDgI1Hfbs6knuj8YW/AYsqhz0xiaqFzF4AZYT5CmEusZubQBby0NT0We9WEWmUtA9mQODREkxRfU7jhAVKioEtgp0kKqKoI= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU2PR04MB8821.eurprd04.prod.outlook.com (2603:10a6:10:2e0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 12:07:05 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::a892:e4a9:4769:13a5]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::a892:e4a9:4769:13a5%7]) with mapi id 15.20.5273.020; Tue, 24 May 2022 12:07:05 +0000 From: Peng Fan To: Krzysztof Kozlowski , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "sboyd@kernel.org" , "mturquette@baylibre.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" CC: Aisheng Dong , "l.stach@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 SRC Thread-Topic: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 SRC Thread-Index: AQHYbphE4hPgB8NWEUiwdYEo5yj0ra0tzvwAgAAFlVCAABKegIAACHAA Date: Tue, 24 May 2022 12:07:05 +0000 Message-ID: References: <20220523113029.842753-1-peng.fan@oss.nxp.com> <20220523113029.842753-2-peng.fan@oss.nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 98538b28-1487-4fe1-c90f-08da3d7deb22 x-ms-traffictypediagnostic: DU2PR04MB8821:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SC9VAiFlVHqcQw72aTLWBJ6VtrzSUk+8VShU9wWa35Jv28DToojIZ0/h/VTtNlAMHDWmemc3qSqqEGVK6cczqM/a3aH2iCXYbDeC7Y8iDke1vbV99/3yrnvPrrpQamJpMTAuXzGz++FpdkFbaDOYT6tRHtIWjXCnwbP6fXPcv+V3U2Y775OQOfHZ6TVxW+S9CFPbb8kkpSk57Hoi3RytOdPjINeBW4GK3K20il0JJ8yme04pBUa3gSEmxc348pi6QyPuZd3179IY5zx+FPm9v1tIp3srXRl0gFJzRGzCmGc1efOHHU7VLjzKmmJIxFhT8p42X4iZ29WzGo43scBKuyPdo/kg4C1h5U9A6Y0pMDi+92nfZWdnHQzHQPzPWdRY7k+csPsqSlNGLmXvrabx3M52vJmD9BnaYT936r1dMWnf8r3jfzxLFOxYK2GDA4DQYKMeuuVCTyrbeew+Jma26atS2JsbFVH8mYj8RSzAuxglD3RE1fdnkHpxjCM7yUogqmuClYHqaM49+cP9kt8GByAdc8N3zHCNtQR8lqoFXkEYEbAqU4u7ExYcXyLOFwPEsG8HF6jhPSckL3IW3l/lnDDt0J/teWydFeLU/OYXVYns17L4Ufdfo+Exe1OBb7y8QDcK7G2hiL+7Soe4o4w08Z5vJ0E+UPtAesyVrUW73z+KjpN+zs4D9xWsXHMx4wie/TdV2M+4Tm3+zneDmcIFig== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2906002)(186003)(122000001)(38070700005)(5660300002)(508600001)(7416002)(71200400001)(66476007)(83380400001)(316002)(66946007)(7696005)(66556008)(76116006)(52536014)(4326008)(8676002)(110136005)(66446008)(86362001)(8936002)(33656002)(64756008)(44832011)(26005)(6506007)(9686003)(38100700002)(53546011)(54906003)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dHlCb1pLZFZQMFg1ZUs3bXFXRHhRcSttR2kybFQ0alR1WEVCYU9uV3RyYkM4?= =?utf-8?B?SU56bzNEeFFOaXQveE9rcElMWFlKQ3Y4MVIxRElMNmVHWWVscnl2VyswVk0x?= =?utf-8?B?bEFGZkxESkYzN0ZlZ2hpOEhRVjBzT29OVGtydUoyKzhBVmpnTExVTTQxZCtU?= =?utf-8?B?ZlRreWZITXBSaXA2UUloQkQ4U3B0L3Q1ckduemg4dElJTVRIbENSRzhsSjBk?= =?utf-8?B?UktUK1JadlQ0MGFrTjUzUFg4eG1xYkZNQ3ZBeU11ZzgrUUJzZUFielpDOU1E?= =?utf-8?B?TkpWMFdIdEJSSzhpTkNIQXZCUkxoVXVuRFF6aHZHWVJacFZCVmw2M2ZpME10?= =?utf-8?B?SUtHMnhtTnhScnRHVHRkWkcycmhXVGR2NkJXU1pjcTRiWmVwUitlUVRGc0xT?= =?utf-8?B?WExoRHBDZFlNSzJCUENjNXFTbU41T3VVOUM4SVN0bUE2ZEdlU0hVaWhVNWNG?= =?utf-8?B?cW5DbFNGbmRxVXlMYVhoV2Q5M2ZHUkNLdElCdTE4N2VQakpvZDJrRGh0WlN6?= =?utf-8?B?bU14eWFxbzJiemtFbWZlZGx1N0t3aUlNUCtjdDRTdndvcGs3cFcvNVorSzBt?= =?utf-8?B?eHlyT09TVkttZm1EZGljcGRFY2hENnIwTGpLd0swTC9uMHRnb0duT25zbDZ5?= =?utf-8?B?OWVqS00vaEY1ako0RUpuQndzckphWHh3QWJkMEl1YTE0ZXpaL0JDdTdXOVhn?= =?utf-8?B?WnJyM0J5eVRxTHpLTjZKMFhhU0R5MERXQk9xaWVqZlhYYVBNem13TVpqMkRx?= =?utf-8?B?aHIzR3YwVC9OTDYrSVhJQXk2TXdOVm5HMWtKWm9JUitUWU1LNkViT3gvaVRa?= =?utf-8?B?bno1dk02bWRQOEl4ZFdUN01NWFJTaVVqMnVGMTAxWENHUU15dkp0c1R6d01j?= =?utf-8?B?VzE3eGJnVDg5VUdkVktqTFBpTFA4ZjY2RmZkZ0g3d1VrMVJNY3NZbWZmWmxh?= =?utf-8?B?ckxKVks0NDVudnBmdCt0eVlCZjRsQlRlZGZOb3h0M2hrZFBYVk5zNWVNOXY4?= =?utf-8?B?Q1BwbC9Fek1NVHQxTURWMGhMbkVHUnJhVWRFWDhSMG8reTV2Ri9YdGlzMTFl?= =?utf-8?B?aVhpZ0Vnd0JJRndrV0RpdktOMmxkNGZIbmY5bnlRdzV2dC8zWnpIbytTdXJq?= =?utf-8?B?UFFzRUcrL09VVTB5VWJUaDJmdEpLVS8yUkhjWUtLMzhMelUxL0ltNUZoSCtT?= =?utf-8?B?bzczZlp3dy9nd1BXaUgyWlZaN0E0NUdpWmFXQXJtblhBNTZneldqdHBVM1hU?= =?utf-8?B?VE5oaXJoaGdzMlNwZEU2cUhXS3NoT2RpT01DZ1JFVkpXUlpPWC9YRzllRm1G?= =?utf-8?B?SUxRQlFYVEM2VFM1bFNaQVQ4QWM3ckJqZXNWNXl1czNsR25BRHpUZUtxZDdt?= =?utf-8?B?QXprYW0wN0FNNWhJbm9LQ3BWK0hlRTc5S2tyY3N5V2QvdWZnYlo3Ynd4SmNY?= =?utf-8?B?VXF4NXdUQkxhTFhpS09aQ29rajYyeE1TTUh2bytBckZ1bXF0dmN4NVluRzJ4?= =?utf-8?B?eWJrcVdhdXRUS1ZUQmFoaFJna0UwbFBrU2RCYkFFMnBreW5lODdOOURQRjJQ?= =?utf-8?B?cWFJalNSWGRRRGN5bkVDVkY1eE11U1Y1K2IyMW5uVisxWldDVXZRYzBROGtR?= =?utf-8?B?RmFGSmNRczdzNWhhYk9xN2dTT2RtclE5RmFET2QxdnVRdTJLRWxwY2xucGhM?= =?utf-8?B?RHRDYmRpUFFOYlJwUFpwb1NkL0JWbEMzUUxXRUJkb2QyNlJyQnhkK0JTdENh?= =?utf-8?B?RkRlWTQrRXl6QUtlY0pYNENxL0xFKzdxby9vTHpldTVPYmtRUHdyd0VlU1FR?= =?utf-8?B?M2pjUkdOaTUwOG9DdXdZMS9UOE13MUtITkhMS0VtYjFiRGpLYVhoWHNJWklz?= =?utf-8?B?UkZ0OGVmbS9LTGJFLzhUQlJsdDZaVHpZcEdFN3FBMmx1d1NCU2ZFUGpvYmx0?= =?utf-8?B?MGIzZHJFem9UQXFuL2xpZ3p2Mm5aTnl2U214eUI1eVVJZURyWDhFY3h4UUYw?= =?utf-8?B?SVdGT2pBYVV0R0VCdGNsdndiTUhTU2h1YVE3ckZXTzRxMjhlREpXOHZQMUVM?= =?utf-8?B?dGk5MzR4NFRNWXVjaUt1WnpjUDVMcUVHQ1YwdHg0a0NtSGI0UEtyaHY0T2Jl?= =?utf-8?B?VjVRMklyTVZvZWRia3VzYy8yeVVBYVorMVFGTjNxN08wRmVuWXJtY25na2RB?= =?utf-8?B?UVQ1aDBFK21pRnZzK05paTVtdWJwRXVmRWV6SWZGUERlQ0RsMEJFOXB0YmxW?= =?utf-8?B?dU9FVnZRTi9hNUZEc0JZSmplalVGOGZ2dWFuYVU2dHdoYkpoYVJka2ZzOFBa?= =?utf-8?B?dW03WUdobU8xYmthYTdRSTU3ejF1cDVha2loby8xWnRzTnpObk5jdz09?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98538b28-1487-4fe1-c90f-08da3d7deb22 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 12:07:05.0853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zJo5QYd/iXDl/X2qtRWRXXgbjdeApnJbA3hIBfRg3XnsI7FHgnIxsmNMg8hUTgjc+21vud4YCiRFAd87hvnLhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8821 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_050710_405274_2F435277 X-CRM114-Status: GOOD ( 28.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Subject: Re: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 SRC > > On 24/05/2022 12:37, Peng Fan wrote: > >> Subject: Re: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 > >> SRC > >> > >> On 23/05/2022 13:30, Peng Fan (OSS) wrote: > >>> From: Peng Fan > >>> > >>> Add bindings for i.MX93 System Reset Controller(SRC). SRC supports > >>> resets and power gating for mixes. > >>> > >>> Signed-off-by: Peng Fan > >>> --- > >>> .../bindings/soc/imx/fsl,imx93-src.yaml | 88 > >> +++++++++++++++++++ > >>> include/dt-bindings/power/imx93-power.h | 11 +++ > >>> 2 files changed, 99 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > >> > >> File should be in respective subsystem, so probably power/reset? > > > > ok, will put under power. > > > >> > >>> create mode 100644 include/dt-bindings/power/imx93-power.h > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > >>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > >>> new file mode 100644 > >>> index 000000000000..d45c1458b9c1 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > >>> @@ -0,0 +1,88 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > >>> +--- > >>> +$id: > >>> +> > +title: NXP i.MX9 System Reset Controller > >>> + > >>> +maintainers: > >>> + - Peng Fan > >>> + > >>> +description: | > >>> + The System Reset Controller (SRC) is responsible for the > >>> +generation of > >>> + all the system reset signals and boot argument latching. > >>> + > >>> + Its main functions are as follows, > >>> + - Deals with all global system reset sources from other modules, > >>> + and generates global system reset. > >>> + - Responsible for power gating of MIXs (Slices) and their memory > >>> + low power control. > >>> + > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - const: fsl,imx93-src > >>> + - const: syscon > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + slice: > >> > >> Why do you need this subnode, instead of listing domains here? > > > > I follow > > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > > There are several slices in SRC, just like there are many pgcs in gpcv2. > > Wait, but you have only one slice and you do no allow more of them. Slice is just a group node that could include many child nodes, such as slice { mediamix { }; mlmix { }; } The same > as for gpcv2 - there is only one pgc. What's the point of that node? There are many pgcs, pgc is just a group node there, See arch/arm64/boot/dts/freescale/imx8mp.dtsi. > > > > > > >> > >>> + type: object > >>> + description: list of power domains provided by this controller. > >>> + > >> > >> Hm, what about address/size cells? Is syscon schema bringing these? > > > > The slice submode should have address/size cells, but I not meet > > yaml/dtbs check error. Will add it. > > > > Not sure syscon bringing or not. > > > >> > >>> + patternProperties: > >>> + "power-domain@[0-9]$": > >>> + type: object > >> > >> Missing ref to power-domain.yaml > > > > Ok. > > > >> > >>> + properties: > >>> + > >>> + '#power-domain-cells': > >>> + const: 0 > >>> + > >>> + reg: > >>> + description: | > >>> + Power domain index. Valid values are defined in > >>> + include/dt-bindings/power/imx93-power.h for > fsl,imx93-src > >>> + maxItems: 1 > >>> + > >>> + clocks: > >>> + description: | > >>> + A number of phandles to clocks that need to be enabled > >>> + during domain power-up sequencing to ensure reset > >>> + propagation into devices located inside this power > domain. > >>> + minItems: 1 > >>> + maxItems: 5 > >>> + > >>> + required: > >>> + - '#power-domain-cells' > >>> + - reg > >>> + > >>> +required: > >>> + - compatible > >>> + - reg > >>> + - slice > >>> + > >>> +additionalProperties: false > >>> + > >>> +examples: > >>> + - | > >>> + #include > >>> + #include > >>> + > >>> + src@44460000 { > >> > >> reset-controller > >> or some other generic node name. > > > > It is not a single reset or power domain controller, Currently linux > > driver just use it as a power domain controller. > > Then maybe system-controller. Ok. Thanks, Peng. > > > > > Thanks, > > Peng. > > > >> > >>> + compatible = "fsl,imx93-src", "syscon"; > >>> + reg = <0x44460000 0x10000>; > >>> + > >>> + slice { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + > >>> + mediamix: power-domain@0 { > >> > >> Best regards, > >> Krzysztof > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel