From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D0FBC433EF for ; Wed, 29 Jun 2022 10:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V+xm3bLRoDEXuHg5SFKX/85bUvlcHWEsdyu3aKNf2SA=; b=mPIuw1Cmx7jJBK S36KvoNseE9sOnuKTMtsJ80lOtsKEkdEFNTK+baXt4IpxI7wxHLH7hLMvHUBF73MvUff5mjIYEFxx kghJ0aQ1sSGupbaN+lI1HLkB4G1Tga0qSGTivbWiEpS0k50E7S8D+ZayH9NAly3xlbSX8AtD9jqah CBVt/0n9trcVZE5MjLzCXzxwA33Es3uY2sNBwK4pyTHaFXapH/WGh/Hf7E3d2v46vlMsqP/oaqYNh jKSVsB3ZlJuVoMbX9mXDn4QWAoV2dYVyT+dLVYzkx3/wSuLV3O+gOlJQxQVfbVb/Z2dsDeFCk9Rw9 zZ1MLcx0iiX/HfT6+uUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6UrT-00B02A-IX; Wed, 29 Jun 2022 10:23:55 +0000 Received: from mail-psaapc01on2136.outbound.protection.outlook.com ([40.107.255.136] helo=APC01-PSA-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6UrR-00B01Q-3o for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 10:23:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEqiXc9+khUI2lZei2q7qK+cPvV4qVRdYcsqFw1RfCemm7dvweQovgB1X2BgEdSWHC7HGScUpbdT+iWgPhH8Dh8pjPy8CGLkL0aTeSRTOwZxg5ogJgvLSIv6NIee6jloMJkNBjkr6eS+u2j39Wyc+BIXyu+1lszJyturR+wPQEe58A5+WAaAvMmLMV4oLzz8D8RvedhPsirKPx3+kr8dQtegbCZI/HABIZ3sA3Syst4r6IMt2ofKswPWGrpconhb9Kci+Nqard66j5fHqSYcfRSfGv18PrgtlQAA66Ke9uHt79+GcGmmvlmd2TebJpR5SqTo962X6xaoKSnla1A+yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6uNXtWFHPlo7g9prVJuRiBnzy0WguIkxuQ/PLEK4stE=; b=ef67+XGNxr32EeP4aQo+moRVNzCb74dlKxVvxE6Se8Iwtq9+WGKQns29C+X2hZ8E6qo1Goxbvhs/gyidpAGx32cdDQZVFa+oByJvOPwV5Q60+XXJYhpfzRd/t/3ysJxvu+iEQnhF8YobWwrVIShkb4NfJqzXdvxx8q/HlxO8FdjTRmD0HTGIQXLG8uOXAy78w96Rt6/7Y5twmWcF1hWLwe3ASUBqdIlXC6UEaHTJ7nuArxI8B39Jm3wOAsxKytFcRk0g7jf2/Tj7j3woRqNknak6rU9G5EFQbdADpM15QUPK3S/MclFDRVRbZVTkjhXOytcYMOsmmCukMWc+z4FOTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6uNXtWFHPlo7g9prVJuRiBnzy0WguIkxuQ/PLEK4stE=; b=FZ33FpAtuGmyLoiFNNyaJBhsf9T3Qr/x2p8NrtMjojoU147+Ru6pWPj9Dao2D2sUWduHAv1tP9auL3AKFRCkdvh6o9buA49v+fd/4MfsekAeeJIvAjhZ9a2bcctrbfsR3p3FMEUy9+kCMYPz1QtHpqzGlbM2P2bpI9LZEgAdDfoDVyrQLGOZ/Ks8DnBJv/QyAZjBkwnZ8nC2cwy71iGb9BQodKEkWkrysN4DzyMrt3rA69GcrMY1KcjR29ERN5Uck+Qk9m6X1xrvoUjhupqdCgTTbIToCwCKC54oAY2i84vP0ilhYMkGisC+7AuigUb5ORyjMkf2YitZU18N1jPSOQ== Received: from HK0PR06MB3202.apcprd06.prod.outlook.com (2603:1096:203:87::17) by TY2PR06MB3631.apcprd06.prod.outlook.com (2603:1096:404:f8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Wed, 29 Jun 2022 08:49:51 +0000 Received: from HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::46d:a7a:f047:e9bf]) by HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::46d:a7a:f047:e9bf%5]) with mapi id 15.20.5373.018; Wed, 29 Jun 2022 08:49:51 +0000 From: Neal Liu To: Krzysztof Kozlowski , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Dhananjay Phadke , Johnny Huang CC: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: RE: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Thread-Topic: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Thread-Index: AQHYi2cqlkV0h2M2LEWiJm1FKKQpMa1l43kAgAAgOSCAAAL6gIAAClow Date: Wed, 29 Jun 2022 08:49:51 +0000 Message-ID: References: <20220629032008.1579899-1-neal_liu@aspeedtech.com> <20220629032008.1579899-3-neal_liu@aspeedtech.com> <409af908-5e03-8df7-fcd5-7fab75cdfb34@linaro.org> In-Reply-To: <409af908-5e03-8df7-fcd5-7fab75cdfb34@linaro.org> Accept-Language: en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0594a914-f27e-484b-b069-08da59ac54b3 x-ms-traffictypediagnostic: TY2PR06MB3631:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b16j94rjk8nYGzwtLPmia3NIAKwTEuD4aniBALFOHM3h4vqpzc+TGYn+FIiPTWMGJrn5KoOPADouNyd6VP5Z3qtbiFF29J0fEfccCO5diDM8jhMIBISJCohncimYuRJRMZuyGhIpeCiKW/cp303YnYbAwKLmJdQTi1Rs/TgoajGCtehlNXtYhb5jTv6O8r2ekUD9p+OjKGv9qJv3UPx6CGXmyDMLzbZalobG5GF8pbcOQfBVh4DDghZUt7EtuXYNPyhhndDFglU/W6zKS76HepBAoX9vHKA2os6GaUcUHVDGzaVgBz2bRcjNT77dmxyzGmRe2147Smj5Futf2lfRd1mH0rmU9tR1CPP71JBTQSnwQ/F2zAPYmZS1ic8G/eXy7aoNVbAWmmjrzfZPHjenAC7CwrIAz0bHdYaV3909ZLKdCJDlsIzBeXzJEjOSTKGqMs/PANARdXsIqa/h5/tCvHqlx+v7GNwPolU58s7ggC9wSK7qwegAlqM0YBd/Sq+EPwS2iHLpSfJVGFaseW5RJDGS7iR/8RGJ8kntXjmo59IRHkIrASJp1DtlJyK0PHD4WSFu2uiyRNok9uV667Gy96T6A/G8WLFOofSdW4V4aJwpw1vjdZay9ZEJsiA25KL1z/+zwdgMLO3l1h+IbiQDIywpcYEo0akwJTlSYgRyLI08XbgBpGcge0XcS/dWdiotjtT8nV7HMXwd6XoL1M+iSkMPZyI86fOMREHZt1MNFmEZihArLJ+D60ZWkTTMuJNHxN8VjEkf/4ePn4UjRQR5W85+5w5ywJTvBZ4jqtpujpCzJjE0HV7jYqfUshA4SXk8 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0PR06MB3202.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39840400004)(376002)(396003)(366004)(346002)(107886003)(6506007)(86362001)(921005)(26005)(41300700001)(7696005)(6636002)(122000001)(478600001)(66946007)(316002)(53546011)(8936002)(33656002)(64756008)(4326008)(66446008)(66476007)(66556008)(83380400001)(9686003)(38100700002)(38070700005)(7416002)(76116006)(110136005)(5660300002)(55016003)(2906002)(186003)(71200400001)(52536014)(8676002)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aFJWV2xXMFZkczEzMFc1UkNqeklGamRwNTVXQlNFcjhLNHBEa2FNa2EzbUpM?= =?utf-8?B?U25VZlVqY0dXUTNxOGJjV2wrS3dnVUxFSU5GUGRTM3UzZ0NieUlCcEFmQ2Z0?= =?utf-8?B?M3pISnp4Q2Z3c21GSUtwTkVEdk1ObE9nRW1EM0FBVFZLQTVKT3lEbGlGSVVZ?= =?utf-8?B?UEVzVGIrcEhiZGx2TTJZRUg5WExiSG8yUnh1ZkZEaEN3dXdOTWZvY1Nyb2dU?= =?utf-8?B?d0ptRkI2UjkxdWRROGZycHhabnhhczFkbWt4VHI5YlUzZVVaRUt3bUdrbS9n?= =?utf-8?B?cnNVNHNKYVI2QUZLNUs1cWRiamg3VnBMTVBiTjdyem1sVVprYnV3OCs2VXpY?= =?utf-8?B?SjhPTlN0dStYcitPSHA4SGUzMUtCRnNVbXFRSFNJMjdoQUE4VCs4clhOVWg5?= =?utf-8?B?ZWx1YW9VNllaZmJoWmtkNGxwNXFRb0FLTk10K2NFbVNmLzdIb1ZHZzFJU3hj?= =?utf-8?B?aXkyODFFNmZweFc3ZGpLMEV1Q2tDUjdJNkFhSkpUWklDU0pLb3lqcDZPNnpa?= =?utf-8?B?VU13ditBSmZmRWMvOVY2eU85cGhhcUF5TEdzRmR0OWlhTkZuL2Vjb0piVDBz?= =?utf-8?B?NWFWcWJEdlRQaE5QV3dHdkxJVThLakxma3dhWHBNeTNyK0tqbnVPNER1ekE0?= =?utf-8?B?NE9GYlJFZ2FCV21IbUJEM2pQV1ZPTzNMU2o5RmZVRzhsTE1kV2JPVzZmRFda?= =?utf-8?B?ajVsOFZBcVFXOWFZeGR5WU5MUjBNaXJFTm5CbWgyc3loeXhJQlVzcmlsV2Fs?= =?utf-8?B?L1VvaVd2VXFIRmNnN3l6NFhYT1lJSENtWU1FVE1yb3NhNFlDVlA0WmFvM1VF?= =?utf-8?B?OC85SFB3M0E0czNWOHo3NmtPY0VmVk9aT3FqTWZQdm9HQVFLUTVrQURiSlN4?= =?utf-8?B?elF6TytSMDFoTmxlVXlEblZ6bVduSzQrSW5wT2E1TERPS2lJdmhTM0I5emdR?= =?utf-8?B?QjFCZkJHSDVXN05MNld4dEdoWVZMeW5JTEpYdEw1MWxobzQrUkxSVk1EM2I3?= =?utf-8?B?NFJ6QkxWak5UZkxTVHA0OXZmc3dwa0djLzdHT3NwaXBjZGNEVGNIellEcnRh?= =?utf-8?B?ZEI4cHZVOGFGcHE2WW0zZTJNTy95d1JxelZoWUgwVi9tZ1ZuOVRpTnJHT2RP?= =?utf-8?B?dmRPRHNjZXZWbWxjR0o1K29EZ25OaFpOcUhEdDhVcllhQXNsdXEyZ2JHeS9N?= =?utf-8?B?TVU3amlKNE9xNDV4ZXBaaFdiMmRJVXYvc2x0UVRMaE9ZVUF3MGQ3bGtDTVAr?= =?utf-8?B?RTlncTFxZXlDQisxMDNlZW0weE5VSjNtaThZdDlqZk84U0xLVGZNb2xaNG93?= =?utf-8?B?UGdGUnJ4T25YN1FLS2xIL0dyQ3JuNzZCay8zMjR6aVJyV2lVQ2xtZ1UySFJV?= =?utf-8?B?RUpvZkRCWlpMRUppY1l5eVZaM1B6aUM4akNkWTFTdTdTZG9QQ2llWGg4N3Vo?= =?utf-8?B?YndUVWVBRjlLazloTGxZTXovclBockE3YzlXMlA0YkcvWHJVc0E3Qnh5RUxl?= =?utf-8?B?enlMKzVBR3pKQ1BzMVZRMkVVTjU2TUJyUTRvQTBseWR1SkxzWVMvMDVjRWdv?= =?utf-8?B?akNiZWNMYzFyY2NKQkRQNUJFb3NIR0NVWVNEUEpHNHBZRWxXR0t4dW5GNEN0?= =?utf-8?B?dUVMdEJFUmhlS2V6WFRqT2JScXZPRTJPVC9FeUZUVVhUdzc1NzM4SHgzQ0Qr?= =?utf-8?B?cmZtQnBPU3JaS3hwcG9McTdTNVNsbzY3WVlaMG1PS0hpVFE1NHhpTXU1aVh2?= =?utf-8?B?MVdWSVVhN0F6S1h4OUcxbHFKcENKcTZjRnFGTzJ1bmVTZnVwdFdXSFM4TWln?= =?utf-8?B?b2hDZ0hXU3RTa05uSkhQM2xHaFk0dFA3amZ6WXZPcTNxc0dWVnVzeXB4ZkhY?= =?utf-8?B?a2VmRTdvc0xLR25yK0l2bjdmc2RhMkRRNEVvdDQ1clEwR2F5WndXRVdFTGd3?= =?utf-8?B?OXorOS85ZzI3THRtRnJ2QU1vbGs1UnhMRG9uL01YQ1dKTVp0YXFvd2VGbGNF?= =?utf-8?B?ZHJkWGNhaGpFOS9xUzFnaGZTdHF3R2tJRXBxYWg3VGlLSkp2L0FtbmpRNGlM?= =?utf-8?B?THJKNWlFeUYwbFVxWm5qMGd3UnZ3L2V2V1ZaRFNjNXpwb3NmZ041cXIxSDY5?= =?utf-8?Q?EV67LT5xi/+paLSEKsVJtetiq?= MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0594a914-f27e-484b-b069-08da59ac54b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 08:49:51.6030 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5QNUinfssUwmnxCYgpyer7+DKAKKtDT5WsMLhuOWEPn1//zGBME8xU1WJ1pYFpz7Oz0FtvoyM+XhXB2GsyAQaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB3631 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_032353_213552_444DF8BA X-CRM114-Status: GOOD ( 20.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 29/06/2022 09:59, Neal Liu wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski > >> Sent: Wednesday, June 29, 2022 1:58 PM > >> To: Neal Liu ; Corentin Labbe > >> ; Christophe JAILLET > >> ; Randy Dunlap > >> ; Herbert Xu ; > >> David S . Miller ; Rob Herring > >> ; Krzysztof Kozlowski > >> ; Joel Stanley ; > >> Andrew Jeffery ; Dhananjay Phadke > >> ; Johnny Huang > > >> Cc: linux-aspeed@lists.ozlabs.org; linux-crypto@vger.kernel.org; > >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-kernel@vger.kernel.org; BMC-SW > >> Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 > >> HACE reset definition > >> > >> On 29/06/2022 05:20, Neal Liu wrote: > >>> Add HACE reset bit definition for AST2500/AST2600. > >>> > >>> Signed-off-by: Neal Liu > >>> Signed-off-by: Johnny Huang > >>> Acked-by: Krzysztof Kozlowski > >>> --- > >>> include/dt-bindings/clock/aspeed-clock.h | 3 ++- > >>> include/dt-bindings/clock/ast2600-clock.h | 1 + > >>> 2 files changed, 3 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/include/dt-bindings/clock/aspeed-clock.h > >>> b/include/dt-bindings/clock/aspeed-clock.h > >>> index 9ff4f6e4558c..6e040f7c3426 100644 > >>> --- a/include/dt-bindings/clock/aspeed-clock.h > >>> +++ b/include/dt-bindings/clock/aspeed-clock.h > >>> @@ -46,11 +46,12 @@ > >>> #define ASPEED_RESET_MCTP 1 > >>> #define ASPEED_RESET_ADC 2 > >>> #define ASPEED_RESET_JTAG_MASTER 3 > >>> -#define ASPEED_RESET_MIC 4 > >>> +#define ASPEED_RESET_HACE 4 > >> > >> I did not ack such change. This is a significant change from previous > >> version, invalidating my previous ack. > >> > >> This breaks the ABI, so NAK without proper explanation why ABI break > >> is accepted. > > > > I changed the original define (MIC) into different value (see below diff), and > add a new define for HACE. > > How does that break the ABI? I'll be appreciated if you can explain it more > details. > > And sorry for not remove ack with new change. > > Yes, this breaks ABI. Previously the ASPEED_RESET_MIC define had value of 4, > now it has value of something else. Got your point. I'll re-define HACE without modifying ABI. Thanks for your suggestion. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel