From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA6A9C43334 for ; Wed, 29 Jun 2022 11:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pzlMKEX8QsvkD38+E1kehfs5MaIuH69C9jUyCRTKST0=; b=G6fMPZrkN+QKo1 FkVQnAaUX4ZKRn0zkN1T5NtgaXLFmcxIVaxR1h2vDQTvZXp18wgfFLF7y3z1W84DxMAVtiPjA0qpY 0Dkn/QZ2HY7MVx0pSgPGn3Nnj+bBfnLj5o2Z4sMIXtmetcXZnrx8jzqUzJPkWxCkplsyrUYVJCblc Yh5CJtH+yepXbmlFaW3MlD8m1E4X+ZXsmZY3gUWVrZeSus2J8arv3d/1wmteA6iO2a+GP8fcYbePd w9km1Pfm/JdHIxr/kmXGIcFXTDYxyUDX+sDAklZiA4YXd2QxlIcsP/R1sQm2TjZOY6fwkKAHTvQ/F UEQyZ3X1y/0pIObsrOow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6VOr-00BCwF-Ut; Wed, 29 Jun 2022 10:58:26 +0000 Received: from mail-tyzapc01on2113.outbound.protection.outlook.com ([40.107.117.113] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6V0U-00B3K8-9X for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 10:33:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIoApYUnoSSQAxFJlOU7RGezQCc3z+nu9aWcHIKpw3d/th3lEhRbLmNM7cMvMohMfyfEYlVEQWkEksgj7bEwyvPBX/M7WU3rc73zbaXIE5YNu3sJDNZH1sVgirkk45/3Fcwu8zRsGURiOe7XGsxBSpu+tdGMU3kS3Ud8qEjecDBgOe4DvI0pUoHzjcSD8i0i1LXM+NwceBITxyD/dvOtYEjbxTqRdpENraHLnrtJJ1hdJig5NlpI25NtgFEdfHM/KdDSCVpDrkZ5x2mMTYsLPKFtv5sxFQcSzlplcU/Ltsv5XaE0arIlGoVfw2aHH19wbD2wZChRhXXPJrD3YV82iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RkbCBIEr404ewC5MA1e/VHWgpyTzsrxk9lPmVuP7DGs=; b=ZE2z3DJLoyzVjf9GrPuu6V2NiXc64EVBOpja+9R7s7YWwd2HwrOnyMx4aEIrGs1xF0/veTpfFCu8f3sNve9cy81dUWawqlRrRWx2/rA5eJh3ffDzxpIZ9x0Pc1VsLbZxqOb9k0dqPlaXpQAbLQmmpuFFIwshPG2Tt7HYMSLIXNzHaoHYuybmksS+b879Rqpk7zhOzQMbEX91A7kwhpNy2DWnAmsVi0JPOEbt5ENtukH8C92PMLIzTPzy/49JqFiNPcMqzeTUbowc5MieIZOytzcmfE7sq/uFEAJdvl6NAT3LN+6Hev1eUIgTOX098Q3M12xPwdI8HkVELeyvLCTWvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkbCBIEr404ewC5MA1e/VHWgpyTzsrxk9lPmVuP7DGs=; b=xPPAX4MfBBWENYoFHQp7Viq0L4HJnNNogJk+A8KgmO3dOlUbggwZJ0MY06vS/1RETXW13p2Gk8XuKT840sfpb6iq/5wnoumDp+vY7MetnidtwFBrVqcN3uOQSHJQ0q5Uj6hfNop1FsUHKsuq1lwKtvUq2sRfUiLQzYwpIptUlR/H9e7weu/GgBIF6W7VGqMQS3ewYOAcF8WNqydTxMr53oUXCbLL2PxTHulmk6Ne7pNOQKVGuYCE1UL09LmDQLw31vTqQflXb2bz9jyA+8HQ5HGjh7pGo8DqT3pbWjU6aHOn7jZbn1ogl5gSCDmxhrBi9NPGXZw84uCARB/vxQzNCg== Received: from HK0PR06MB3202.apcprd06.prod.outlook.com (2603:1096:203:87::17) by TY0PR06MB5356.apcprd06.prod.outlook.com (2603:1096:400:216::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Wed, 29 Jun 2022 07:59:16 +0000 Received: from HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::46d:a7a:f047:e9bf]) by HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::46d:a7a:f047:e9bf%5]) with mapi id 15.20.5373.018; Wed, 29 Jun 2022 07:59:15 +0000 From: Neal Liu To: Krzysztof Kozlowski , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Dhananjay Phadke , Johnny Huang CC: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: RE: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Thread-Topic: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Thread-Index: AQHYi2cqlkV0h2M2LEWiJm1FKKQpMa1l43kAgAAgOSA= Date: Wed, 29 Jun 2022 07:59:15 +0000 Message-ID: References: <20220629032008.1579899-1-neal_liu@aspeedtech.com> <20220629032008.1579899-3-neal_liu@aspeedtech.com> In-Reply-To: Accept-Language: en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94a8f68e-3508-4649-a520-08da59a5431b x-ms-traffictypediagnostic: TY0PR06MB5356:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cdePnGreTMMxw8iNlYt15E1ZNny5nmmZO6Q1Z7GAuQqDOiy7AGNciChBwR7PxUSvpSXnGR6mzLpl/MtItHR3a1PtWgdlpux8zJmt8fUbFAnjnBuQ4BDN4W4YEU3d92mtX8BUmXKadGcI/Qggn6WwR557ynDe5rjsykq72skBia9RuLm527Xa9w2djyRPKZVbvmbhQMJqCBC9xDdEJCnzRAEcbPXQCFL6u6UZKp+EZzQYshW8Vs2xA3zY1MWBzTrz+vdlRvA5RrY06Dx+1TU+/JsjXjM8fsPYdKagelXh3AyC4bc4kzaE6cmWZCTBF8SyBLXJIIV6O+sjeRtCUIe22nZf3jGYslo9rsZXHti/Lb5GwOfLFRldYJ1oEJnnM3lRGzCRK4erSZK5IsfwFy+i0hv5fA/wxAH/oMCkmTVjKRk1ea6mK8FhOji5fIQ1ymycDea+UDHLdXqXPDlG1emOC1WuyNnmwWoc/9OHieFAfP8XKdKBS0HVsQtn6SoNtj9692MaNY9xHR80LE6ExKmEilmHjVd07aKPKiK6pyCLsxMS6qJ6nMmHPFN5E7kkccs6k52MI4KygDXMQHx5fTBBqwoao6oi0QfwAI3rJgR5meYWLsZBBrtx2cvXNcUdd8uIEaed4qRVNLct83IzqLaDvxmb01oa3inlPnQImABejDDhlfsw5kYATWtaVuJVRbLTlZMpq3Pj8U0DpR9/r8NhIOoXKsbfBI9Pu4LDPMD3F82CQYYeSSnce2GxV1ZpJs34qy8bqBiG1cIPzXxz5noyNr4PenAp3NWHKXyp4ZjxyGSXygpdp9riMi+d351/0+EN x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0PR06MB3202.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(396003)(346002)(39850400004)(376002)(33656002)(5660300002)(4326008)(6636002)(64756008)(7416002)(52536014)(8936002)(83380400001)(122000001)(38100700002)(478600001)(2906002)(110136005)(66446008)(55016003)(66476007)(71200400001)(316002)(86362001)(8676002)(7696005)(54906003)(66946007)(26005)(186003)(6506007)(107886003)(76116006)(9686003)(53546011)(921005)(66556008)(38070700005)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SnIrVGRiZmdEMGRSc0JjQVZzdFh1enljNWVFcCs5VnAxNVNlbFFOenlpU2ov?= =?utf-8?B?RnllcXhyNVJNV1o1THNLalA3OWR1VWZ3b3hBd21qbEJEYzUvQU5NNkRNQVEr?= =?utf-8?B?dWd6T3Y2cGlNN3N5aXNXcERzWDdRYWVRMHM4b2x1emhKT3ZVQ1RTbFJ1djY4?= =?utf-8?B?Ukdqa2FwSVN4UkovTFJjMzJseU5meVYxSVhxTVJXaEdxdXNyVFdaaVMvakgy?= =?utf-8?B?eTQ0TXRIajRNN1RGUmR6ZmErd2RWZUF3NjJDL1JEc2RzZnNjdmxzdU5yTUx4?= =?utf-8?B?RHJaOWl0K3M5U2t0ZnNGZm9BZFhsSHNJNWdZaE1yQmdjMU1ZUFpob0VoRmcx?= =?utf-8?B?STQ0NmRaclhqYnRhbENaSkI0R3RzZzd5REZDM001ZVgya0tmTkw0NGhZczBQ?= =?utf-8?B?L1piQnZUVlJJQStiNVM4bUU4K1QvQm81SllEVFF0aTdBZUttbU9wWnVsWXR1?= =?utf-8?B?cnhWeVlCekJUaVFZWm5sUEhrd053dXpkN2dnbG5SYmJrSXdrRjVacGVMdERy?= =?utf-8?B?Z2ZZN2g0aWNJQ2ZSdGpzSEpaTlFzRGFXVzU3R3FJbCt0UTJnZ0hXVmNydzA1?= =?utf-8?B?aWNzRlV2aWhSTXZ0bjhVVFo2Q01wQ0pIU2NKWmpQYUtMdDFnYWo1ZkpmanQ4?= =?utf-8?B?M1V1YS8rZ1FYb2YzaFNiejlGVXpzeGVweUk5OHhmd0pqeVhPOFNrMTNsS0ky?= =?utf-8?B?M1JXb1RlQU5WMDVyamlvRDBjcmxjSDdxNC9hTGRxVjc4NWtidURweEYxU0xM?= =?utf-8?B?alpZcktMdTRyZkllN20wNjU1QXh3cm5lUUhCQXNaVHRmTzR5Zk5TR3B2TFQr?= =?utf-8?B?RVRxMTBkRWlqTE1LWUhvenp4QTVrMDQvbGhXbE1POFVyL2VKOFZzMVBPVDc4?= =?utf-8?B?M2JDK0hFL1VGRGZaOVVFUzRNVlY2REQrT0dhYVB2YUdMUDliTjNzM3pGWW9o?= =?utf-8?B?YUVjSUlEV2x2OElOU1FpYzVtcTJCQm9mUnJLVzdCQW9DUEdCeDYvR3haeG9q?= =?utf-8?B?MVJTK2djRnFBbzUwZk1maFUwakpkMnRjaDdIVHpQaDhyOTVkVU4wbEJxczlm?= =?utf-8?B?bWVTc1ovT2h4OUExeTBGa3RaSjlqajVRR1ZIVEo3OTV5dGdhZGJOUlMraUhO?= =?utf-8?B?VzVTaTBBU08zdkFDZEw5OW05RWwwbEJzMWRZMjlxeVQ3akF6RFVORHJNOGJC?= =?utf-8?B?Wll6OWIwZTE2UXM0WTV2SGluOXNad0xDcExabGIzQ29qd0NJTm5RbHo4WTdI?= =?utf-8?B?R0FjR0NpemlwYnp5d2Q1UjN0cnZZMndVWVA2QnhOT3NwM0pBYlJINVd1MEdp?= =?utf-8?B?QndqakFEVGZLSG5abXdhQ3NOVUFqUTVvVWdDYmlMZnRIb0JXb3EzWm1Vby82?= =?utf-8?B?Q2hwSFQ5ZlAxOGlpdFRxaUNPTkpsTmhOSTVnbzV2TmJrZmlkbW1iYVlQWTU5?= =?utf-8?B?VnRUT2FDaGVKb2luVTl2T0h2WG1wd0dUVzRrOHRScS9RSXlCVUlIRkZBb0dU?= =?utf-8?B?elowT1JEOVZuVDUrbTFFVC84WUNMR0NUK3g5MFg4N215TlBzS1dFNVA5VWh3?= =?utf-8?B?N21CZ09uUlJlcCtMUDVOY051Y2N2amNFZkNvOUgvY21Zb3M3Tm9kSDhTV0I5?= =?utf-8?B?YUltOFAvMEtreEVTbHBrM2dsYVhiZHFVVWR1MHhFUlJidU40bVdOR2Q4UE04?= =?utf-8?B?bVVqKzVrLzFyR1drV092a2ZNN1BUcHVmNVFZK2MxbEY3YUxaTjlUYTJpMHJN?= =?utf-8?B?ZUovREFuZjMyMXVlU2Z6U3FhRTh4M3ZJc3BSVjQvNXJOdmtwam43b2JPUWJh?= =?utf-8?B?dWNwQ1lwMDM3T3NZNFJqOXBwREp2S2JWWjVWMnlMYWhyR2tZa0pQVUJCNUk0?= =?utf-8?B?bG1QQjFLYkJpMEZzNHlyMENndFlPcVk3NjNLbSt5cmhyUTJqeWhOYTNhVytH?= =?utf-8?B?dW54MHIyZGNhdWtJd0w1YWFNVEk2S2V0UGtYOS9Wbm9PRTFRZzMrYi9KTDNY?= =?utf-8?B?SVR1VHBCU1ZSZHFVcmN6VDFOWURoT1BWYTFjdExTNFJXQkdDOXFkMzdXNkNZ?= =?utf-8?B?b01MSjEwRituMWZGNS80YXhPTmRxUlg5c1p4SE1ud09CQjNaczdLU2dvRDNa?= =?utf-8?Q?0NopqsCNQSxiqWrhRAYPizci7?= MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94a8f68e-3508-4649-a520-08da59a5431b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 07:59:15.6395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tYQWUlOoWXgAvFyjMO0fV8VgeZ5rQRxDsvSfYIvcCs4XoAMr569Q0HT+mgOKI8bnO7ioaMEFoZHEpxMWziNSiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5356 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_033314_405638_1E199E74 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Wednesday, June 29, 2022 1:58 PM > To: Neal Liu ; Corentin Labbe > ; Christophe JAILLET > ; Randy Dunlap ; > Herbert Xu ; David S . Miller > ; Rob Herring ; Krzysztof > Kozlowski ; Joel Stanley ; > Andrew Jeffery ; Dhananjay Phadke > ; Johnny Huang > > Cc: linux-aspeed@lists.ozlabs.org; linux-crypto@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; BMC-SW > Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE > reset definition > > On 29/06/2022 05:20, Neal Liu wrote: > > Add HACE reset bit definition for AST2500/AST2600. > > > > Signed-off-by: Neal Liu > > Signed-off-by: Johnny Huang > > Acked-by: Krzysztof Kozlowski > > --- > > include/dt-bindings/clock/aspeed-clock.h | 3 ++- > > include/dt-bindings/clock/ast2600-clock.h | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/aspeed-clock.h > > b/include/dt-bindings/clock/aspeed-clock.h > > index 9ff4f6e4558c..6e040f7c3426 100644 > > --- a/include/dt-bindings/clock/aspeed-clock.h > > +++ b/include/dt-bindings/clock/aspeed-clock.h > > @@ -46,11 +46,12 @@ > > #define ASPEED_RESET_MCTP 1 > > #define ASPEED_RESET_ADC 2 > > #define ASPEED_RESET_JTAG_MASTER 3 > > -#define ASPEED_RESET_MIC 4 > > +#define ASPEED_RESET_HACE 4 > > I did not ack such change. This is a significant change from previous version, > invalidating my previous ack. > > This breaks the ABI, so NAK without proper explanation why ABI break is > accepted. I changed the original define (MIC) into different value (see below diff), and add a new define for HACE. How does that break the ABI? I'll be appreciated if you can explain it more details. And sorry for not remove ack with new change. > > > #define ASPEED_RESET_PWM 5 > > #define ASPEED_RESET_PECI 6 > > #define ASPEED_RESET_I2C 7 > > #define ASPEED_RESET_AHB 8 > > #define ASPEED_RESET_CRT1 9 > > +#define ASPEED_RESET_MIC 18 > > > > #endif > > diff --git a/include/dt-bindings/clock/ast2600-clock.h > > b/include/dt-bindings/clock/ast2600-clock.h > > index 62b9520a00fd..d8b0db2f7a7d 100644 > > --- a/include/dt-bindings/clock/ast2600-clock.h > > +++ b/include/dt-bindings/clock/ast2600-clock.h > > @@ -111,6 +111,7 @@ > > #define ASPEED_RESET_PCIE_RC_O 19 > > #define ASPEED_RESET_PCIE_RC_OEN 18 > > #define ASPEED_RESET_PCI_DP 5 > > +#define ASPEED_RESET_HACE 4 > > #define ASPEED_RESET_AHB 1 > > #define ASPEED_RESET_SDRAM 0 > > > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel