From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF751C433E7 for ; Wed, 14 Oct 2020 05:41:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 723B42177B for ; Wed, 14 Oct 2020 05:41:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e0h6h4Ow" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 723B42177B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JXAMmAhTU0v0XuIU1K/0qoyuJ0CX01TT+rOXm1XY1cU=; b=e0h6h4OwHMRM1ZPjQP2NzQj5v mF/9DDximFtX2c1RVNzsl+MgIbRDTdbp7+C8Btlqg/Onv5nTrwbliYw/pp6lzO1Fa4O338lZFpGUH X2VpjoQcAlhmsZBKVEVzSz5LmsF8M0JQF74vCMTflCmtRWwvrwaZnJqK0ZBsK8Oiz8jWfKpZCt7BK gcKvWYF/KGN5kn3U1v0sM46jmqpipJoofBUARUTn4DpF9EgXhOFCXkfpRcDAHg5ktr+5H3y3VeBlT BlznmQLQQG1hs078fm3bJ1Jh0jbYR9cJ++xgeavpW5bOPypiRp14uxgiwuHMnFksgb2QLs18+oK07 jio12Nifw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSZVT-0000sE-8A; Wed, 14 Oct 2020 05:39:23 +0000 Received: from mail-eopbgr1320112.outbound.protection.outlook.com ([40.107.132.112] helo=APC01-PU1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSZVQ-0000ra-1U for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 05:39:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HKratqy8P/EbJA19rYhqeVS46HxcO9nK/TEMy57H7OsJjaFoPjO9ZImmz7ss5WlAN4nUs5eRqTZD7f/BTgNPnK5si5pzRj/EItGx4e3tiLYri6xAc/MF/z2fOB9mwvEuoXu1TWilBu4RG6QmTtSbqzF6KTXNC8dfDCs9qy7GqZigMOyFlnQNamiPxgkhgQq0Jbt+Tjj5+1qnvOzvfGt3dcCcuZVZl2Dl5bHV2mUkGmL+R+2jfiQhISXOb2f9YyhIhsY6vYe0ThGKngDz5t/jIVerzE9VZm8omKLK9bpWe2g07dYWhRqP9ZGcQRJA3GkoLbkCsXCgBPf9716xsQHyDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I9U3XdJ6VtGEk1fHBu0bLKR0mRyODxJrAQTLEOegahM=; b=W8nSOZQ4VD4H3YiU2Zd6ZvcERh9KDUigm+sFgiTuMwg7Svq6gm9KVn9htnQ/w1o4TRt8l8znO9fY+x8HTW9exGMhoLlj5R0bM+ktTIh9RVr5l2Yip5GnSGUxmLFvY50OHyUedYub/A6lYQAbDZOLexGkgIAdQGOEkchxep4Do6GCsbfq1mATCQOyG13KoZKKbEHBFwuf4jRduD8GEcPTV+wNWrmkD1vHmVrCJTbivWk/92NG7bBWcvqk2LlUvp32iENURwit/pP55aiaKrxO2GSQPh+eVEbp6nKNTNlzq0fq0Kflf4IUQRSF05cVhtSP99HieSJGSOmSL2+5+cm+/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none Received: from HK0PR06MB3380.apcprd06.prod.outlook.com (2603:1096:203:82::18) by HK0PR06MB3649.apcprd06.prod.outlook.com (2603:1096:203:b4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Wed, 14 Oct 2020 05:39:08 +0000 Received: from HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::6def:b61:3beb:f3d5]) by HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::6def:b61:3beb:f3d5%6]) with mapi id 15.20.3455.030; Wed, 14 Oct 2020 05:39:08 +0000 From: Ryan Chen To: Joel Stanley , Stephen Boyd Subject: RE: [PATCH 1/1] clk: aspeed: modify some default clks are critical Thread-Topic: [PATCH 1/1] clk: aspeed: modify some default clks are critical Thread-Index: AQHWlWUpDwyjj9Eb9EeIGPpnHXDUp6mWfroAgAAsCwCAAAG5YA== Date: Wed, 14 Oct 2020 05:39:08 +0000 Message-ID: References: <20200928070108.14040-1-ryan_chen@aspeedtech.com> <20200928070108.14040-2-ryan_chen@aspeedtech.com> <160264382296.310579.9835482254268204873@swboyd.mtv.corp.google.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: jms.id.au; dkim=none (message not signed) header.d=none;jms.id.au; dmarc=none action=none header.from=aspeedtech.com; x-originating-ip: [211.20.114.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5543554b-012d-4737-aabd-08d8700378af x-ms-traffictypediagnostic: HK0PR06MB3649: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wHCxSE6SpVU0S+DEuZlvdtIUFqTqYI8HH6qyl8KfF4AbQUnVhdS2f0r/bp29J4eaylZjjvLjfrd6UEvbzYWnfs4xUTbNFp6qX07hYHX04es+mPLhHFZelI9eEvZEZRMqO3vMqbvYAwZ0AOIB9d4CKttI+IHumlduECmV2aZsAIFv8E5j5sm+jwXCe8sLGUjAi/7pRcaySuweQYCivT+aIj0xzkRztpRa16/+Fg4B58uGMIJAvNYEpLWXvOqUh3q1COaod68/WcG/TSIkCBTaenMHelGF66nz+5ws/lPi5obXVd3yh0r3DL3h0FYa6S+fviQaYVtY6t+S8iirN1lcrQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3380.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(396003)(39830400003)(136003)(366004)(76116006)(64756008)(66446008)(478600001)(66946007)(2906002)(7696005)(4326008)(86362001)(52536014)(71200400001)(55016002)(26005)(83380400001)(186003)(33656002)(6506007)(53546011)(9686003)(55236004)(110136005)(54906003)(66556008)(8676002)(66476007)(316002)(8936002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: XlB7TMKDFQojIdCW+ja3hjhiFWuKei5OLNMF8YigzHin/MFB7oa7ckFEXwsiY5zjvbyomG3qSJ4yfr9Si8dotlyjWUTz4oPrU30t0cuHHYs1CskkAcevlaVOKuClN0K4KNAiZMsTlGuGmsjKccbm8vLssmEIE3MKy4jBLHvBZd9u2T2TQJN2wYUOuADKe67mOzbZ9JpXiYNYUb70j02kfY9vw9FZpR3+WI+TIEHUuap3iw0KwOUK9VAgT2JCkW+qijQ42tM5gBrkiPRYAZrjXR283/RGEL5cjkH9oG/URCnZ/P1CzjBk9ZF28Mpz9Xt+doDIxI+Kq7q4bfOB+LIvuPqAwUcOVkXsyETE9YUA+oODBOGBHJ5iVobqZTRAGWVFcBogvjoFl8FPsylj4ZSqoWKvGY5OaPdNgifzT2Tzw00VNbtnM+LKBW1VKme37YCfOT/+rSOyktaBTSCp/V1RN+GW1fUM7JvJB29zOgRhGZVJsNE6ftNiXXdlI1WbGHaSkuD8up2DXoUdVV7GnxNqQ2MnHNBbEzdao3N4l6zNEwuADe2uuoVYVm3Qm6l9iJO1IQu/pu6mDkqNcHPh2LtHe2sEtrYEL5Kw8ngWkYHkPwuh1qDH3QrtOTWrejJ2ZqRH51tcQn5lAu5zGUNicE/HEQ== MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3380.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5543554b-012d-4737-aabd-08d8700378af X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 05:39:08.4536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IPinxIFdVlbD49n6CYz8kL9v98AQvk58IGedn5eYLlraRGHGq7IEyjslsuuU2QcJVjhaE3j40SQ2NAIdXyiKmJbcCDVLCWT1Irp1/c7aT3c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3649 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_013920_136781_5E658350 X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW , linux-aspeed , Andrew Jeffery , Michael Turquette , Linux Kernel Mailing List , "linux-clk@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Joel Stanley > Sent: Wednesday, October 14, 2020 1:28 PM > To: Stephen Boyd > Cc: Andrew Jeffery ; Michael Turquette > ; Ryan Chen ; > BMC-SW ; Linux ARM > ; linux-aspeed > ; linux-clk@vger.kernel.org; Linux Kernel > Mailing List > Subject: Re: [PATCH 1/1] clk: aspeed: modify some default clks are critical > > On Wed, 14 Oct 2020 at 02:50, Stephen Boyd wrote: > > > > Quoting Ryan Chen (2020-09-28 00:01:08) > > > In ASPEED SoC LCLK is LPC clock for all SuperIO device, UART1/UART2 > > > are default for Host SuperIO UART device, eSPI clk for Host eSPI bus > > > access eSPI slave channel, those clks can't be disable should keep > > > default, otherwise will affect Host side access SuperIO and SPI slave device. > > > > > > Signed-off-by: Ryan Chen > > > --- > > > > Is there resolution on this thread? > > Not yet. > > We have a system where the BMC (management controller) controls some > clocks, but the peripherals that it's clocking are outside the BMC's control. In > this case, the host processor us using some UARTs and what not independent of > any code running on the BMC. > > Ryan wants to have them marked as critical so the BMC never powers them > down. > > However, there are systems that don't use this part of the soc, so for those > implementations they are not critical and Linux on the BMC can turn them off. > Take an example, conflict thought about ASPEED_CLK_GATE_BCLK is CLK_IS_CRITICAL in clk-ast2600.c In my opinion, the driver should keep the SoC default clk setting. It is original chip feature. > Do you have any thoughts? Has anyone solved a similar problem already? > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel