From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EE1C433DB for ; Wed, 23 Dec 2020 02:55:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 746FE205CA for ; Wed, 23 Dec 2020 02:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 746FE205CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jgJGwAR97lU13M8sqfwJ3wra3k1kbDFBKAp9j4n1Xpw=; b=wiPMLYlHiZh8qzxrXziIH2LJ7 rx6rlxCaBL2RX7mqkLpxUdzAyUQr0hDCkqwTO7gsO+H9Z2emftF13dBw9BmgeR3jDOOcrzPAEEYMZ VEFPIsQDJNV2oUoLjB856TKAmx6vdRdGAeh6lJ2+F9mjw8FoWmGSgTsczuJN4NDmYgpdQuSOIDzaV UKOf2S+9IANYXQ9Lvog5NCbS2wAYJNffkgLvpwIPuDWAytYs6A6D9eW+2D+cRAjkH+1xKEaToZ2Ri Q1Wjb/PQrfUHsPe4vCsryddXsyMNMvtbfGqxkiXdQ+8pCmpo16NwYcfBgBsaCiarv4ha82xJeinj1 Ki48gDYaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kruHZ-0005eE-Jt; Wed, 23 Dec 2020 02:53:45 +0000 Received: from mail-eopbgr1320100.outbound.protection.outlook.com ([40.107.132.100] helo=APC01-PU1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kruHX-0005ci-4y for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 02:53:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WHvLoe42KLDKORJLYEBN5h331MDauaDs0W8NNvodLnQNQTFKw+4/0Vlb6wtlCjxZxPhuKGpek2oROejhXjTp9LqGX9atPSUw2x2hsgLSGClkrgqJ/ZrnODrPDnltjr491Nf05lfd9sNNMI3b0AlUIhX1c4d61rT3EecyFJR9NFYbncRPvAv07cX/JEqPDMWmpcetMz+JxAyU3qhnnTA8f/V4joT62rQLVOOAyvN8fHcIpd6ylSgiN+Ql+H/I+f3JSqFosjJmI0s3k9HSjA3oPYpo6tzoc5+PEJbjxw+fAodJ20+YKJNEiOxVTSCiEXaljScstiwke4MzUuADSiRR3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XUryfeBTbwswIYaPLLPAI61M7IESWWlMnzZa4JArUA=; b=HKBni15tlCM1kXVMPAud3GSv9242I985UuPI5cdJ+jbgJDg2VF9BtluzuPnCnMmyd/apFe4aSseT7GZfBNAwxNLGkRbDt6BwF3Y/Zg8gRwjZHKVUrDF+KGVvUZXW07ZGpj3clJkKo1d1MI04id6KGBnEmqV7R5eeOW7grN8YdR6tPhub2cW/KFtbExbnvmnwfK2bkZ8bNJJOFYRflN2ynGRc1w0kEE1hJqvx6sCUg3E8MbRAt3RiA1XWXy5iptmWXSPH6CXxd7LkZE4vMZCnjAf9jpD/upzvuo4Fe27v1j0nmQ5hdGUsQNdussxizvn0et1qoHH/LcVHIAvaGBaJhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none Received: from HK0PR06MB3380.apcprd06.prod.outlook.com (2603:1096:203:82::18) by HK0PR06MB2916.apcprd06.prod.outlook.com (2603:1096:203:66::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.25; Wed, 23 Dec 2020 02:53:33 +0000 Received: from HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::59b4:743d:1470:306f]) by HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::59b4:743d:1470:306f%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 02:53:33 +0000 From: Ryan Chen To: Joel Stanley , Zev Weiss Subject: RE: [PATCH 2/3] aspeed-video: clear spurious interrupt bits unconditionally Thread-Topic: [PATCH 2/3] aspeed-video: clear spurious interrupt bits unconditionally Thread-Index: AQHW0o5SCt/jQG9HJ0aOoNGkwIAV56oClgeAgADyOICAAGKHAIAAG/Ig Date: Wed, 23 Dec 2020 02:53:33 +0000 Message-ID: References: <20201215024542.18888-1-zev@bewilderbeest.net> <20201215024542.18888-3-zev@bewilderbeest.net> <20201222191433.3dgnfwyrod4tnvaf@hatter.bewilderbeest.net> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: jms.id.au; dkim=none (message not signed) header.d=none;jms.id.au; dmarc=none action=none header.from=aspeedtech.com; x-originating-ip: [211.20.114.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b11aa684-af89-41f1-1433-08d8a6edefcb x-ms-traffictypediagnostic: HK0PR06MB2916: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +rLPD5J85P913GMCRKN2gQ7F15gmPWwlk4FdEwhBzTCxkZ29lDZi7344vztIw4WSJyvhfaExM0IFlP6JgSuU1KDdqksta3Y3LNeatjmwg42fUPwermRrNndgBFhv+gDUvqFiGlSTy5wlO9Bman1RyH32mOEm5gBjpZ5O+NnX5Zh72UpqLb43Hm5Ooehgd3VvxZzCCKnbXHIDM6/z3iywwkVhsdLyjDZwbL7YGP5KKdNOzZAWqbwp9hXBJKEzkvkPEhRsVBb3b0/a3YF9IX3t/Pj1Y83W88EBGHi70mW/TEKKMSvENb/iEr28DxIi4zeVGDl8rH+tJ5lXTKHBm099phCzoq4Q8RXYBaanI2SUWEnIwcH5DeUNApd3CcqHD7K8HZHLSE8ZfTMYWGklnWLMxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3380.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(346002)(366004)(39840400004)(396003)(6506007)(54906003)(76116006)(53546011)(110136005)(9686003)(2906002)(86362001)(316002)(83380400001)(66446008)(66476007)(8936002)(55016002)(66556008)(66946007)(64756008)(7696005)(52536014)(8676002)(33656002)(5660300002)(7416002)(4326008)(55236004)(71200400001)(26005)(186003)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?Vmc0WUE3ZFhoZjFaT1IvRm53czJnY0gxM1pDS1BCMVQ1S1U0VXBweGJwRW5i?= =?utf-8?B?YXJlWkVpbUJ2OXFxRlBLMVRZVnF3Qm44WlVqWm84czJmSm15T2F6Ty82clVT?= =?utf-8?B?QkkvNzlqdDd0UVE0ZVNTdUxoSlVqazhjeitYUkVMZ1plTDBaN2JIc0dnaHcx?= =?utf-8?B?ZnFpRDVBSGRUc1hlZ3NQdmExL3RvMytvWFZTd2VEWXNWTmZhTzB6VURMZHk2?= =?utf-8?B?STJLM3BXV3V1MVEvYTkzTmJPOFBGbm5SYnBnL3RBU3hSbzc4RDVuSUp3eDhC?= =?utf-8?B?OTRJbmZ0RTRaL3NnQ0FlSW1jMG52MlA3eVVmdlk3RDN0NWtoZVE2eXdTRm5T?= =?utf-8?B?M0NCamJoWlErVXN3NVdlUlhhYXl3MEpJcWlMQ1REODc2aUNwU29wdjBROHJ4?= =?utf-8?B?U3lJaGVvbUdhZEhzamd2MkF0L0JGZzVibGIzcDlRbnU0cUh1aDRsQ2t4cUg0?= =?utf-8?B?aUN1SUp3Qno1VER2SXUwbFRpQ1VDc3JCemFEek1ZYXpUWWkxQ3JyTGxydlBq?= =?utf-8?B?RzFLV2xmSmFOcnV6anROekIwdzdubkw0VVFObVJMYkNJNENxWm5UOVV0Ykhj?= =?utf-8?B?V0hZU09nTUVMY1VKaTZ5YjhvTGFTaVlXbDNacGZNZDBGRS9WV3hhWWkrR2xF?= =?utf-8?B?YmR0UW5JSzBDSVhIRFhaSDRCZi9DY282aEJLVkRXQmQ2dld0MlJRbVozNUFI?= =?utf-8?B?UWdIUXdCL3haUmhHUldXdDdmQzg2dEMxTlBNc0Q5TENqVVFDKzQ5WU96cllk?= =?utf-8?B?THlkRVNpMHFJSXZldU5vSzZyQmxsdVlDRU1WdDllT0FPd0lXS3hkc0RBMU0r?= =?utf-8?B?SDd0aDY2UG8vZ3k4UkhkbFRGaHJnSDlnSGVJTW1mb3hLSnZrMlJDcWRuNlhE?= =?utf-8?B?TStWcmdDNjlzYWlKVlQyQzJONUJ6bW12cG4vWGhNK1Z6L3NVVGJHVGhyMzdD?= =?utf-8?B?OU1aQ2QxdHNBZzBUektDdmM3Z25VNXRjK1RrM0dINWtXRGhRNm1iS0xCZmpo?= =?utf-8?B?S0tuT211OEwvcDlKbXU5a0EzcGkyK1RRUnNkV0ZaWkZZeG1IdHJFZWRSVkJW?= =?utf-8?B?TkNvUDkxRmUxSTduSnNidWNzU1NUOHBadEcwY0kycnpZeldvcjRhYkV1Y2Ft?= =?utf-8?B?aDRpTEhUUVpVdVlSNEJNTUVzdlZYWDczUVdxQTUwVHJEZ1FkWFhlQTEvb2Nz?= =?utf-8?B?MkhVdkZjYndaR1F1NitZZ0ZjcXR1cU5pOGFBeVpsMHhUWWFqdU8zUTRVM0lO?= =?utf-8?B?MWwyQlF6VEtrcWorcnAwWjdMUEJGUzBTZFVWUWFva2hyMFRyMDlDV0hncXRM?= =?utf-8?Q?iKUK0lKQUHXPk=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3380.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b11aa684-af89-41f1-1433-08d8a6edefcb X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 02:53:33.2009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0CV9o6qBITE7nZKk1QMG9BLi26KiWKtHieNxFTOTnNqAg39ArYacmrgMGCBTdbKZsDb+07CPQ8cMcaOTHK+DZrylCHlG1rApvVF0TKDahQk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2916 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_215343_215088_34104451 X-CRM114-Status: GOOD ( 27.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jae Hyun Yoo , linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Eddie James , Linux Kernel Mailing List , Mauro Carvalho Chehab , Linux ARM , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Joel Stanley > Sent: Wednesday, December 23, 2020 9:07 AM > To: Zev Weiss ; Ryan Chen > > Cc: Eddie James ; Mauro Carvalho Chehab > ; Andrew Jeffery ; > linux-media@vger.kernel.org; OpenBMC Maillist ; > Linux ARM ; linux-aspeed > ; Linux Kernel Mailing List > ; Jae Hyun Yoo > Subject: Re: [PATCH 2/3] aspeed-video: clear spurious interrupt bits > unconditionally > > On Tue, 22 Dec 2020 at 19:14, Zev Weiss wrote: > > > > On Mon, Dec 21, 2020 at 10:47:37PM CST, Joel Stanley wrote: > > >On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote: > > >> > > >> Instead of testing and conditionally clearing them one by one, we > > >> can instead just unconditionally clear them all at once. > > >> > > >> Signed-off-by: Zev Weiss > > > > > >I had a poke at the assembly and it looks like GCC is clearing the > > >bits unconditionally anyway, so removing the tests provides no change. > > > > > >Combining them is a good further optimization. > > > > > >Reviewed-by: Joel Stanley > > > > > >A question unrelated to this patch: Do you know why the driver > > >doesn't clear the status bits in the interrupt handler? I would > > >expect it to write the value of sts back to the register to ack the > > >pending interrupt. > > > > > > > No, I don't, and I was sort of wondering the same thing actually -- > > I'm not deeply familiar with this hardware or driver though, so I was > > a bit hesitant to start messing with things. (Though maybe doing so > > would address the "stickiness" aspect when it does manifest.) Perhaps > > Eddie or Jae can shed some light here? > > I think you're onto something here - this would be why the status bits seem to > stick until the device is reset. > > Until Aspeed can clarify if this is a hardware or software issue, I suggest we ack > the bits and log a message when we see them, instead of always ignoring them > without taking any action. > > Can you write a patch that changes the interrupt handler to ack status bits as it > handles each of them? > Hello Zev, before the patch, do you met issue with irq handler? [continuous incoming?] In aspeed_video_irq handler should only handle enable interrupt expected. u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); + sts &= aspeed_video_read(video, VE_INTERRUPT_CTRL); Ryan > > > > > > Zev > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel