From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C42AC433DB for ; Fri, 22 Jan 2021 08:17:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2507E23381 for ; Fri, 22 Jan 2021 08:17:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2507E23381 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eJVnricCZ1eQKuYRw38Szm8oBMlRDGd4Q/qj/aMowkw=; b=X43l5aczPW0QJlFRvdueNERWX N5rB9s1B/IjxmD1KZbM5MqHQkO5UielKVjJB+yyqH24JnlIzvQDVoYiPGB4GvK127qWJIZGeh9bWA xTTNICZXj9QlJrz6s65SAtgshuCN+6Ebs23QDWGGTYTuK3iI3efCl2egDcAqwLb/CS3pMQzl/TCuW fw1hN0422FYo+GkA864cBMxDlc+uYCWKaD1lB5OUh6jneYo8EOvLQBpDlKEwXaE0It/HEIWaG88RV gxyEV7N2AS2pL5QFYf6xEoAuMXRTrlcPqXoQxKoYPaEg6Y9qBV8V3Hv/EyoyhLSChgYT7iBCOJREe SU9b/t3mQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2rbi-0005M8-Kz; Fri, 22 Jan 2021 08:15:50 +0000 Received: from mail-eopbgr1300128.outbound.protection.outlook.com ([40.107.130.128] helo=APC01-HK2-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2rbf-0005KY-9X for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 08:15:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GCzfdTTTi6/f8z9KBg27VGMrXb23eRotUhbfSEvJF9x5yluWjgNIOGbEYiHb7tm3rwu4HnAnK2dFhP6m2Eq7LsL9+uyUy5AyzShefV8+jAEbtDGmr3t1wqeG8o4vli2rpmPgME9dyTJWDK8q5S7+X6cnDLDX1xNbcrdr1lye13DwWkAqQqHc+hpyijejcV2D/6aDOhxj2e65k9EU7SoxR9HNDzp6hNRiChWmbj85I37L5oisyNtk6fRU0YR0e55YRwufS6XDT1mnNPrGE4UwRiQCMyOJXwznqtQZuIixcH6dS9kBTeshHcdHMx4VMIzb2iRldZs06KDmKT9Jum2+Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/0HGXR3pNEZEPvrKBfjjakUo8r5mZ9bmbN9FSdQ28hk=; b=RKdhmlTI9QT0dGt6ZvCYo3wV4h94jM/vopKOZ6yjCZv5WBm0nr9vj4/Z/xOJpwEP9EDkgGHo5RUKqbSjiJGqz+HKbYKdZYBOZpx2+6yIZl4m3LNGUD2oHFMDhqe6+mCcR2deT/dqlN9GzuokaAC97pDT2QcMLYf7cSj/Wh497Ujc4bkQ5xxAh5z/RsZP5yckObBpNnxidhBn6+oL8j5TjB4kElJ8gAkl6UZCmxjby9T3arOs/b0iw0DmEMYeat1Zv31mp8hxF1mG8rqN8xrxyIt+7A2PJsbdjyj36terjuKs0IFX1wIps8h5gc8cWUKNXS/dsWWvwVGoSVOUqS8XVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none Received: from HK0PR06MB3380.apcprd06.prod.outlook.com (2603:1096:203:82::18) by HK0PR06MB3684.apcprd06.prod.outlook.com (2603:1096:203:b2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Fri, 22 Jan 2021 08:15:34 +0000 Received: from HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::116:1437:5d9a:16e9]) by HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::116:1437:5d9a:16e9%6]) with mapi id 15.20.3763.016; Fri, 22 Jan 2021 08:15:34 +0000 From: Ryan Chen To: Samuel Holland , Stephen Boyd , Joel Stanley Subject: RE: Re: [PATCH 1/1] clk: aspeed: modify some default clks are critical Thread-Topic: Re: [PATCH 1/1] clk: aspeed: modify some default clks are critical Thread-Index: AQHWlWUpDwyjj9Eb9EeIGPpnHXDUp6mWfroAgAAsCwCAAMXfgIAWmgkAgIX3RlA= Date: Fri, 22 Jan 2021 08:15:34 +0000 Message-ID: References: <20200928070108.14040-1-ryan_chen@aspeedtech.com> <20200928070108.14040-2-ryan_chen@aspeedtech.com> <160264382296.310579.9835482254268204873@swboyd.mtv.corp.google.com> <160269577311.884498.8429245140509326318@swboyd.mtv.corp.google.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: sholland.org; dkim=none (message not signed) header.d=none;sholland.org; dmarc=none action=none header.from=aspeedtech.com; x-originating-ip: [211.20.114.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e38af6f0-7996-45b9-b8b1-08d8beade4bb x-ms-traffictypediagnostic: HK0PR06MB3684: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T3TQ4tYYO5+MYJOd+7CRsHdZFkonRhaw/cSgBSZGMab5skwuwRT/VNqEz4T7QaCBpRqo9MierKyr+I8OYr5BJbugr/kg54wDgeEdaO/F0WahRoDFCh/YcMCfb76YAHQ32i5VaeGeTpGah4CMj7HJ3F0jhb3szQEQlgfau1pBwTw/4qMVUoHjDEC03pDCdqu6i1OlZ2hHK8ecnwBEszDHrrmr4M5OZAk2QRQ8CchcGB14zXZ+YeDZZljH6VCPLJnFTB8E32tIZePOndErPpOAn6gyKKyYaKWFpxTFTb5fmlN4iNZ5qM3u+dKdtxVhzAF9wq/vwYQBy8+PY0YJb49j5M4KUJU4v1dtI+tsCkScDkFMOU8dyRjbRMDDDO/UQPO4Z0Pkwlo5OKENLo0aDclpLy01Hd1H/PHUEcR/wnr4xZxvI7sqtsrbpa4TEcfB3BWBR+OCXXW+Cd7nux9ClHZZgg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3380.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(376002)(366004)(396003)(39840400004)(7696005)(55016002)(26005)(33656002)(9686003)(316002)(52536014)(5660300002)(478600001)(186003)(966005)(4326008)(86362001)(66946007)(66556008)(8676002)(4001150100001)(6506007)(66446008)(110136005)(53546011)(2906002)(8936002)(83380400001)(55236004)(76116006)(71200400001)(64756008)(54906003)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?YS9iUGQ2T05VeGd1d0RFNzBpWlY1akRGaHJSWUNIRTBCdTMyYi9UQnZPdTEy?= =?utf-8?B?dzNWbGN4NG1ZcjVaK1hmR1lSNjYvbEZwRUR3UnpER2prSFl6cjd6anRsemx3?= =?utf-8?B?Q1p3UHRLZHNCbG82Vlp2bDlWOUJSY2tNa2lwYXYrZjV5ek44VUdCYzNzMjQ1?= =?utf-8?B?S0E1ZGpvUUFRdDJ3NG1qZGExbG9wWE5YMjBrQ3NDVE1tc0YzWWQ3SFNGL2tL?= =?utf-8?B?V0QrZDN2VmVhU3ViY2N3ZWFRMGdTMFRXK3J0SC80Tzg4cTZaVDJNbzE2Q1lL?= =?utf-8?B?ZFd2anA1NG9sRXpxN0Z1Z3hwZmEzZnVmMTVjV043NDIvOGc1VmNkRmNySG00?= =?utf-8?B?cGtuVmhpOG12V1pTWVVjMXF2VFlINVdRWmVheTRsZDhSeEtIV1FzcDk1b05M?= =?utf-8?B?RUtNeGVaNEJBMERFeVQ5WHZkOTh0ZGtBODVycG5Kd0dIbWEvWEFlc2tuZXov?= =?utf-8?B?eGI2amdWNmtkN2E1Y2h3c25aY1Bna2lyV3FIOUxFR281Nzl4bUxRQVZ6b2F6?= =?utf-8?B?WDNOczlkdW5XcWNtQ3Zub0hDNHVFMXY0emhZY0VldDd5S0tZTnlDeDhZQjJ1?= =?utf-8?B?SnZPZjhKY0RaeGpxWFlyTGtOSUFZa3NJb1NKcmFFRTBzdlkvZWFiKzhqQVMx?= =?utf-8?B?cjRqR0UvaVdIaUwxUVJsK0g2RDQwZ0p6UkpVTEN5MndsbE5BOUtKb2FlMzVr?= =?utf-8?B?NW5wMkhsZnRZdjVxVy9NM3VYSWE1SjVwTWlCT0c3cS9DeFdyZEhJTnVsNmRC?= =?utf-8?B?V01rWk5FcWdVelhwQkxtRWN0a2hlVjAxRTFaUmViYVZFNkg0NGtZL1Urd3V4?= =?utf-8?B?bzhJK3ZGdENhQlNPVXdpVEpWQzF0Y09BWGoxeUpPckhnaklFMVVxdGFuUWpy?= =?utf-8?B?TVExZXJYZDdBZjFYemZZWXN2SWk4QTFjMVg4eTJaTGNNSXZjeGpPYVBnLzdR?= =?utf-8?B?YU1BQ1FISFI5YmdOaE9CbFZQZFNKU2Q4QWRBZUpZc09VMlJMK3dpQ1I2SmJs?= =?utf-8?B?LzlzM2VjTFpvMkxiMlJIYkZyRVhuTzc1UkV0U1JqTGxjSE1HQTlXbEdNNVpw?= =?utf-8?B?ZDRXNEoxdWRtT1N6QVRBSGJ2MnBOZWNzWXc3Sk1ZNXloTG5ZUmpKWUZsWDlT?= =?utf-8?B?aC95a1pKdDB1OTlZc1RCM0QzbWVLRzBwN0xOc01SMDlnU0tOeFdlMTBITXhN?= =?utf-8?B?OVJRd2JqSTNQcXZjNkpBTlFkditPZW9ENWZWWlVXc2xyQ3VscnVUVm1SazFo?= =?utf-8?B?VnZSelpvejJ2MWRHZ3JCc0V4N0dBYzZHYy9zcExWcW9lTzNCK2JyNUZhVFA4?= =?utf-8?Q?Q+qXFzHlZ0lJo=3D?= MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3380.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e38af6f0-7996-45b9-b8b1-08d8beade4bb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 08:15:34.8598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 99wiz7vvSU/3PZqYeXIIbll8sCdtUiW113V9jomQEhZKISpC3B1Nf4DQ62bxT4CyP6uWAr1YPZnvSAjX1FV0E5nGpIPGSxpMWxbm1YM6Hmg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3684 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_031547_339641_BA4B00A3 X-CRM114-Status: GOOD ( 30.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW , linux-aspeed , Andrew Jeffery , Michael Turquette , Linux Kernel Mailing List , "linux-clk@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, How about this patch progress? It does impact a lot of machine that when BMC boot at u-boot. SUART is work for Host. But after boot into kernel, due to the clk disabled. The SUART is not work for Host anymore. Regards, Ryan > -----Original Message----- > From: Samuel Holland > Sent: Thursday, October 29, 2020 10:25 AM > To: Stephen Boyd ; Joel Stanley > Cc: Andrew Jeffery ; Michael Turquette > ; Ryan Chen ; > BMC-SW ; Linux ARM > ; linux-aspeed > ; linux-clk@vger.kernel.org; Linux Kernel > Mailing List > Subject: Re: Re: [PATCH 1/1] clk: aspeed: modify some default clks are critical > > Stephen, > > On 10/14/20 12:16 PM, Stephen Boyd wrote: > > Quoting Joel Stanley (2020-10-13 22:28:00) > >> On Wed, 14 Oct 2020 at 02:50, Stephen Boyd wrote: > >>> > >>> Quoting Ryan Chen (2020-09-28 00:01:08) > >>>> In ASPEED SoC LCLK is LPC clock for all SuperIO device, UART1/UART2 > >>>> are default for Host SuperIO UART device, eSPI clk for Host eSPI > >>>> bus access eSPI slave channel, those clks can't be disable should > >>>> keep default, otherwise will affect Host side access SuperIO and SPI slave > device. > >>>> > >>>> Signed-off-by: Ryan Chen > >>>> --- > >>> > >>> Is there resolution on this thread? > >> > >> Not yet. > >> > >> We have a system where the BMC (management controller) controls some > >> clocks, but the peripherals that it's clocking are outside the BMC's > >> control. In this case, the host processor us using some UARTs and > >> what not independent of any code running on the BMC. > >> > >> Ryan wants to have them marked as critical so the BMC never powers them > down. > >> > >> However, there are systems that don't use this part of the soc, so > >> for those implementations they are not critical and Linux on the BMC > >> can turn them off. > >> > >> Do you have any thoughts? Has anyone solved a similar problem already? > >> > > > > Is this critical clocks in DT? Where we want to have different DT for > > different device configurations to indicate that some clks should be > > marked critical so they're never turned off and other times they > > aren't so they're turned off? > > > > It also sounds sort of like the protected-clocks binding. Where you > > don't want to touch certain clks depending on the usage configuration > > of the SoC. There is a patch to make that generic that I haven't > > applied because it looks wrong at first glance[1]. Maybe not > > registering those clks to the framework on the configuration that Ryan has is > good enough? > > Could you please be more specific than the patch "looks wrong"? I'm more > than happy to update the patch to address your concerns, but I cannot do that > unless I know what your concerns are. > > Regards, > Samuel > > > [1] > > https://lore.kernel.org/r/20200903040015.5627-2-samuel@sholland.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel