From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6250C433EF for ; Mon, 6 Sep 2021 10:12:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8088C6101C for ; Mon, 6 Sep 2021 10:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8088C6101C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dX9HQH8yqxYYR57MwCsiYLE40cXMhrS5muKk3vVOI3E=; b=yuVtcgmVao/Bhs x48pajZkl4USIha0yaCJyyNipCoO9bc2W8W285gNhloA3/RojB+9ekLOmFrMzGGA5JKJ3UymAgypw b6yF56HfJftx5m0CUyYDvgbbM20CSdZHnknviqSf1tfEQLc2u/TrXc7QRYs7FcOsb7ZNt8MqjRWy/ wpYdMtIOohh3vf2ZTyuqbpgiAOQKiXKyQAZUcez5yVhGs8jFvzP6whg7ae0+hXLcs0KFUutHUle5i 6nDo2eHzVhEIQISL3cikvSveWa3LzWkXvKT2Lku8Hr5fz5rxuheb2RkADUmCmWPc5qYOsJsP7ZdX2 WJFm5noUSoj8jhv6T0ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNBa2-000UTA-Np; Mon, 06 Sep 2021 10:10:23 +0000 Received: from mail-eopbgr1320113.outbound.protection.outlook.com ([40.107.132.113] helo=APC01-PU1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNBZw-000UP9-8C for linux-arm-kernel@lists.infradead.org; Mon, 06 Sep 2021 10:10:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KiCgzdm7MPeESUqVbmQmHVqXelNSjIzBzakkNtK7n6aDm3lQ5i4i8tYno0oUJ15yuwaouZsDpYUREBFGEng+vGOLUd9MufK7ZMmGFBrwEJDQuQ5EPwAn/c5tbW5BEPR4rc6jKYqf3pPk5d1uGXlkY3RL8+deet0urC0qtJib4t0T0RQlZ4Hp03frI7VH4flt1udOKS8M3hjyajcuxvIWVL9Psm0tq8PHRhj1DAPummUDKBE7T1PIQqsant+zFNDzUiBRXKB/yvmCnE+ZdRIvN5Gqj6C+aJ+1eJJGnZ/XD56AH46XjGwl1I746dcEBfrhcCzzMnzFodmCh5d2iNY3/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8+IBMy8YO+bBw5tLNwEdiui2Ek7bRLL5ZIMDSRdi9xY=; b=UT19XHzpJDjSV5V8tRQmk2ShQLZS9FBG9aIwnBRfgdvss07MrQJKDNAiU7O3zYcWpiAENooobkl6ob6ooQoKeFz3tyr3PFvm+jhR0vHzQ7cZSzupHtmiIo6QFi+MixK5Z5pridMJ5vM71suo1RcRFXxqxkylhO/JKUudaObz5dJko3NvqbFpB5H61cxQYjVhn74DZyfvXMF5WL9w7s+qKYVQAD5ftft74fgQPwleZ4DmMqCpPjZ/psM2fmLxm3GimnT0FgM6HMI2F9lIkX8UeabLzE8WBrijBF92XHBdSBTi3kwCPzD3mdSNFaWjKznZAjpOKvMvCg3IN0iozxS2KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8+IBMy8YO+bBw5tLNwEdiui2Ek7bRLL5ZIMDSRdi9xY=; b=YE+OYOrK0RkdqdS/VFyP4iPyZU26X2jOe17CUULqtcczf/T/pR/nX0aNQ4plA17TrXJ0cCnNTQXxazTyuV4M3CZV1ky9qFo+bihAt76kMFnxuhILq2sFzYp8sQU2XnLA6aGpMXUtyhfHaNxXfT+WDtdWeGO4YL4GJU6enmkOrPog/KY1k8fOCWNjKjrsAGoaphOjBQeX6o1gPZ5hyeUDofpEiYUikT4XGwrOb8M5sAGoO+NBFtYiyqAgd6i4B97HPiarxb5uMuOs1Gq3OkZ7kFfCK4RPfGArCH4vapzNXS4D4DgvvCCncRIc4u38fBF0NT0y+6m9fDNQy1Zh0TdrAg== Received: from HK0PR06MB3380.apcprd06.prod.outlook.com (2603:1096:203:82::18) by HK0PR06MB2339.apcprd06.prod.outlook.com (2603:1096:203:4c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 10:10:10 +0000 Received: from HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::df9:c3a4:7589:e812]) by HK0PR06MB3380.apcprd06.prod.outlook.com ([fe80::df9:c3a4:7589:e812%3]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 10:10:10 +0000 From: Ryan Chen To: Eddie James , Zev Weiss CC: Jae Hyun Yoo , "linux-aspeed@lists.ozlabs.org" , Andrew Jeffery , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Mauro Carvalho Chehab , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Subject: RE: [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled Thread-Topic: [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled Thread-Index: AQHXY8SBAvwOoxspLEuYJEQdXCIVq6uPvpoAgAeIgeA= Date: Mon, 6 Sep 2021 10:10:10 +0000 Message-ID: References: <20210617220229.7352-1-zev@bewilderbeest.net> <46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com> In-Reply-To: <46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.ibm.com; dkim=none (message not signed) header.d=none;linux.ibm.com; dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 650eec36-8a5b-4d87-13b8-08d9711e8298 x-ms-traffictypediagnostic: HK0PR06MB2339: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:313; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i1bpud7i8Rx2l3R+IyliUnFA2JDVlKoXAPDXpwmDxqVgQgzm7mJxc+oRm1MIgh5TBCLOJcwLDk7/cvKPNzDhefWWD0Cm1I6dXQcFUE6CprCeVJcO94yxF9lgmHYmcPCh66KQsT5x/00E+Ttz/Hc+eFcctjxtS8nVGWmzWTX0m3eOBgIoLo8tui3jFdkiIl+LL5MifCwSe53hgVTmQ8D5LU2W8OMQjNU8oNTmyVUQTp3s0Wy6fhm1aZnEMFzFcYrQ1oAaNlsQcfvS32bGyYMwwTZN/IKRAv7uH6yt2toGT0ffpJ7k5lGc5ZXoczbhSjvY7HZd5Q2l/RJ2kumdla5wBpvfxwL5lnmcbYaaAPLEST77OEnZPQMr2G2vvv9XtNisioPuRk8z70tBJFItFIY9tVUOd0ea3R34mD1HQuiEPg3vGpPdJGjYdNSiL9Vcml3W9lszgKoUmIIHm5UVJtDS9PCSpvGAmVil+kDJA0/3SoP3nkd9Lg1S69dpHHHx1uAuAuWOpXLisRU/SjR73lddOGbeo9iEVUhJbZox6/Yyz/JBhqr0TSxuSoNoFwk+SeGhLqxFFpg47mlNh3RoQJAvVFuI8PE5UyJJ400K9Rkq2iz09Dec41NlmHH6qDc7X/dyxDhXIW1lyeoE9PBcjyk/4wZ4VZeKEkHJMfDzWIP1M299J9CS7x0kbdMoKe3onInhslspMw/uMo550vXndkA6L7sTMtaaZTSs94Xu6T7fRmdiCGErvyZoIvGVrVjl6px3+jaro492PiWaRrPBUCVBOGfrmbJSzibcdh+KsM37epY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3380.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(136003)(376002)(39840400004)(366004)(122000001)(86362001)(38100700002)(4326008)(76116006)(5660300002)(71200400001)(316002)(66556008)(66476007)(66446008)(64756008)(478600001)(66946007)(2906002)(55016002)(9686003)(966005)(110136005)(54906003)(53546011)(6506007)(33656002)(7696005)(38070700005)(186003)(8936002)(26005)(7416002)(8676002)(83380400001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ckQwc1FZUXdHRkZXNzYrTDFiR2JYL0o4N2dEM09QY0l6cjZNZGNjaVkvOFQ3?= =?utf-8?B?ZjVWNE9LcEQ0NE1kL0dFVnNYTXoyWEU3SUsybUJjekdmSmV0dHZhYlUrZVl1?= =?utf-8?B?WW9XOG45TzNqazdJSHYrY2tBbDNaS3FTdEllblJOWHlGYkxLWElwdkc5YmVZ?= =?utf-8?B?MmpxYnFocEw0Yk9DTEJqbmNLcXlqb2d3MnFVa0ZhUTFzcW16eXIzcW9xQWp3?= =?utf-8?B?OWh1THJhaWp4VDZDUGFENlNYTnhiMTg0Rlo2OWRLM1V3dDFVblh0UThVcjFT?= =?utf-8?B?Qm1CUjJrQjdrbzM5dHhQc1g0Q3pNUmNRZTh5dHR1emFaSTNtSUllUll6Ukhn?= =?utf-8?B?MkRUSStRRlYvL3NQOVZjZk1NN1g3QThCM2Q0d052amJMclZ5YWFKM01QYXNF?= =?utf-8?B?VXBqU0MycHFHUzVGRW5yYnNOcEZ5VVZSV0pwMjJXQ0lTUVZEazJRYW0rTlhU?= =?utf-8?B?UU9JdHNyMjVRRmNnTnlTMTRMS1RWMVY1U3R5N0g4eC8yUDlhOGxQNk9JTVR2?= =?utf-8?B?TGsxdFduaE1FQzdXYmkrWDFMTk5OTlY5Y3A3b0VsYWhkNmxoTzFJcC9UM1pu?= =?utf-8?B?MjZ0aWhGYnhWWlQzMG1NQURQYnpYMXY3UDQwcjZKRE5TRGJjYUNHdWhybk5q?= =?utf-8?B?ckYxWTg0RS9qS1NWemM5VFpZb21IQlFKenlITFk1UHV6cXgrWWVnRXFvU0tN?= =?utf-8?B?aUlETXZSTnN1bFZjNmxFNjVMdXEzei9OWGtXVmszanNwRDRhclZyeVpNKzh0?= =?utf-8?B?ZEZncm01Rk1LVmtvdXVvSTBZa3lCdXNhK3MyMkdWNGZHTEhFR3dWOWFITjBV?= =?utf-8?B?MnNIWWV0Z1JKbEpVaG9YenRUS0ZhT2N4MXozbGNzcTc5UTBENmVrb29QcElk?= =?utf-8?B?akJ4dGJXaUxNc1ZLZXc2Zkw4YVJtZHhaa0FrM0NtQWRBK0tCTlZLNU1xc1A5?= =?utf-8?B?RmZvWW04Zm5lZFFGSTQvbmRsODJZZjczb1ljTG4weHJ1bWg3Z0lKUnorbnBI?= =?utf-8?B?bjhKVGFXRkR4MC9STERIVlFJSTcveElCRlhtc2JhdjVvR1BlRjV6TVFlQU9V?= =?utf-8?B?NWRpb21pNEdJaUFSWWN1bjh6Wkl0OUgvc1JpdExvTklpbXBKRndEYmh5WVZo?= =?utf-8?B?dHprVkZpK1hIWmhsTHY0KzFtcExPYXpnTGltRlZsaCtQaVVxSEpieHRNeGpK?= =?utf-8?B?akFUUDlJc3VVTSs0THVhNVRnODJzR2dKSzA4NXJlQThWSGtJemxmQzhqektz?= =?utf-8?B?V2wwWUtLcDVkeDV1Y0M1dUFLdCtSQjNJQWYzd3BTbUJYbDQ5TmsyTzcwRnJQ?= =?utf-8?B?Z1h5ZEpxUUJYRmdCekR4YU95V1ZRZ1NqTmJXWmhmMHZTVDhDbFZLeVRJT3hP?= =?utf-8?B?MnBLVGJOUHN6ckkwNGJzWURaUjlSblZNY25ZLzZ2bXNJaFF5RnhoQW1OZ1VI?= =?utf-8?B?TnFrK0pvRXFPVWx3eUpTNnNNbDVOaXc4NGJtcUhLUzhJbExwcTg0aFVvSzJL?= =?utf-8?B?SWI3dXRQQ3l2K0UzZzZsMC9kQ0VNM0ZtT2lGRUJ0eStDaC8zaWFoNVF2WVhR?= =?utf-8?B?TG1uaWMzMGJzSWh0aHJCM2tGYzBFZjgzbjZVTW9tTERyQ2hyeUNJMXlndmtG?= =?utf-8?B?MDZTVVNsRi9xOU5sTFF3OVVBUWVSeW5rNkUzQVlOKzVpTmpFY2JPRGlFcENi?= =?utf-8?B?bXYzYU9IekNBczV1cU5sdHg3MitCQ3NPbW1xRlJQRlNCRnYxcjRDdWxtdGl0?= =?utf-8?Q?8+sVit5FFdsB5BOuff6xECGvUgBXpFmd9LoqSm+?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3380.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 650eec36-8a5b-4d87-13b8-08d9711e8298 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 10:10:10.1789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AAvWm6ctjdx25TLhQczlAhSacNlh18ugCuPkmTsLoA2Rjiikb658nt4FhlSP5xeQ3Y1a/C2e8VOYl67APIcMBS0og+9freQD/btgRAqyNhg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2339 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210906_031016_342406_E121F0E8 X-CRM114-Status: GOOD ( 27.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Eddie James > Sent: Wednesday, September 1, 2021 11:07 PM > To: Zev Weiss > Cc: Jae Hyun Yoo ; Ryan Chen > ; linux-aspeed@lists.ozlabs.org; Andrew Jeffery > ; openbmc@lists.ozlabs.org; linux-kernel@vger.kernel.org; > Mauro Carvalho Chehab ; > linux-arm-kernel@lists.infradead.org; linux-media@vger.kernel.org > Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't > enabled > > On Thu, 2021-06-17 at 17:02 -0500, Zev Weiss wrote: > > As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear > > garbage interrupts"), the ASpeed video engine sometimes asserts > > interrupts that the driver hasn't enabled. In addition to the > > CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that > > patch, COMP_READY has also been observed. Instead of playing > > whack-a-mole with each one individually, we can instead just blanket > > ignore everything we haven't explicitly enabled. > > Suspect this will fix an intermittent problem on AST2500 with screensaver. > Change looks good, thanks! > > Reviewed-by: Eddie James > Reviewed-by: Ryan Chen > > > > Signed-off-by: Zev Weiss > > --- > > > > Changes since v2 [1]: > > - minor commit message improvements > > > > Changes since v1 [0]: > > - dropped error message > > - switched to a blanket-ignore approach as suggested by Ryan > > > > [0] > > https://lore.kernel.org/linux-arm-kernel/20201215024542.18888-1-zev@be > > wilderbeest.net/ > > [1] > > > https://lore.kernel.org/openbmc/20210506234048.3214-1-zev@bewilderbees > > t.net/ > > > > drivers/media/platform/aspeed-video.c | 16 ++++++---------- > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/media/platform/aspeed-video.c > > b/drivers/media/platform/aspeed-video.c > > index 7bb6babdcade..77611c296a25 100644 > > --- a/drivers/media/platform/aspeed-video.c > > +++ b/drivers/media/platform/aspeed-video.c > > @@ -563,6 +563,12 @@ static irqreturn_t aspeed_video_irq(int irq, void > > *arg) > > struct aspeed_video *video = arg; > > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > > > > + /* > > + * Hardware sometimes asserts interrupts that we haven't > > actually > > + * enabled; ignore them if so. > > + */ > > + sts &= aspeed_video_read(video, VE_INTERRUPT_CTRL); > > + > > /* > > * Resolution changed or signal was lost; reset the engine and > > * re-initialize > > @@ -629,16 +635,6 @@ static irqreturn_t aspeed_video_irq(int irq, void > > *arg) > > aspeed_video_start_frame(video); > > } > > > > - /* > > - * CAPTURE_COMPLETE and FRAME_COMPLETE interrupts come even > > when these > > - * are disabled in the VE_INTERRUPT_CTRL register so clear them > > to > > - * prevent unnecessary interrupt calls. > > - */ > > - if (sts & VE_INTERRUPT_CAPTURE_COMPLETE) > > - sts &= ~VE_INTERRUPT_CAPTURE_COMPLETE; > > - if (sts & VE_INTERRUPT_FRAME_COMPLETE) > > - sts &= ~VE_INTERRUPT_FRAME_COMPLETE; > > - > > return sts ? IRQ_NONE : IRQ_HANDLED; } > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel